[00:11:03] (03CR) 10jenkins-bot: ve.ui.MWWikitextSurface: Implement textSelection 'replaceSelection', 'encapsulateSelection' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński) [00:16:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Developer-notice, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)): NWE: Provide API supporting majority of calls and integrations Gadgets make with wikitext editor - https://phabricator.wikimedia.org/T185992#3957113 (10Jdforreste... [00:16:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), 10User-Ryasmeen: Implement $.textSelection's replaceSelection and encapsulateSelection in NWE - https://phabricator.wikimedia.org/T185917#3957109 (10Jdforrester-WMF) 05Open>03Res... [00:17:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design, 10Epic: Provide a second version of a beta modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T142523#3957117 (10Jdforrester-WMF) [00:17:13] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Developer-notice, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), 10User-Ryasmeen: NWE: Provide API supporting majority of calls and integrations Gadgets make with wikitext ed... - https://phabricator.wikimedia.org/T185992#3957118 [00:17:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design, 10Epic: Provide a second version of a beta modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T142523#2538094 (10Jdforrester-WMF) [00:19:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When in source mode, point the feedback form to a page about that rather than the VE feedback page - https://phabricator.wikimedia.org/T157953#3957120 (10Jdforrester-WMF) [00:39:13] (03PS1) 10Jforrester: FeedbackTool: Add the ability to vary feedback page for source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409191 (https://phabricator.wikimedia.org/T157953) [00:42:39] (03CR) 10Jforrester: "(Needs patches in mw-config / local over-rides on wikis that want it before deploy.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409191 (https://phabricator.wikimedia.org/T157953) (owner: 10Jforrester) [01:26:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10Front-end-Standards-Group, 10OOUI: Change OOUI WikimediaUI theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki's Vector skin - https://phabricator.wikimedia.org/T97631#3957250 (10Volker_E) [01:55:30] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid, 10Epic, and 3 others: Adding or updating a reference in VisualEditor does not update fake references blocks inside templates - https://phabricator.wikimedia.org/T52769#3957273 (10Liuxinyu970226) [06:50:28] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Beta-Feature, 10MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), 10User-notice: Make historical VisualDiffs a BetaFeature - https://phabricator.wikimedia.org/T185708#3957533 (10Johan) @Quiddity is handling Tech News this particular week, so any... [07:53:10] (03PS1) 10Legoktm: Move classes to includes/ [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 [07:54:43] (03CR) 10jerkins-bot: [V: 04-1] Move classes to includes/ [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 (owner: 10Legoktm) [08:33:31] 08:32:47 1) ResourcesTest::testFileExistence with data set #1364 ('/home/jenkins/workspace/mwext...ata.js', 'jquery.uls.data', 'lib/ve/lib/jquery.uls/src/jqu...ata.js') [08:33:31] 08:32:47 File 'lib/ve/lib/jquery.uls/src/jquery.uls.data.js' referenced by 'jquery.uls.data' must exist. [08:33:31] 08:32:47 Failed asserting that file "/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/VisualEditor/includes/lib/ve/lib/jquery.uls/src/jquery.uls.data.js" exists. [08:33:39] seeing that failure on CodeMirror and Citoid patches [08:33:45] also [08:33:46] 08:32:47 2) ResourcesTest::testFileExistence with data set #1365 ('/home/jenkins/workspace/mwext...ils.js', 'jquery.uls.data', 'lib/ve/lib/jquery.uls/src/jqu...ils.js') [08:33:46] 08:32:47 File 'lib/ve/lib/jquery.uls/src/jquery.uls.data.utils.js' referenced by 'jquery.uls.data' must exist. [08:33:46] 08:32:47 Failed asserting that file "/home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/extensions/VisualEditor/includes/lib/ve/lib/jquery.uls/src/jquery.uls.data.utils.js" exists. [08:42:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/409272 (owner: 10L10n-bot) [08:45:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409279 (owner: 10L10n-bot) [09:22:36] ██╗██████╗ ██████╗ ███████╗██╗ ██╗██████╗ ███████╗██████╗ ███╗ ██╗███████╗████████╗███████╗ ██████╗ ██████╗ ██████╗ [09:22:40] ██║██╔══██╗██╔════╝ ██╔════╝██║ ██║██╔══██╗██╔════╝██╔══██╗████╗ ██║██╔════╝╚══██╔══╝██╔════╝ ██╔═══██╗██╔══██╗██╔════╝ [09:22:44] ██║██████╔╝██║ ███████╗██║ ██║██████╔╝█████╗ ██████╔╝██╔██╗ ██║█████╗ ██║ ███████╗ ██║ ██║██████╔╝██║ ███╗ [09:22:48] ██║██╔══██╗██║ ╚════██║██║ ██║██╔═══╝ ██╔══╝ ██╔══██╗██║╚██╗██║██╔══╝ ██║ ╚════██║ ██║ ██║██╔══██╗██║ ██║ [09:22:52] ██║██║ ██║╚██████╗██╗███████║╚██████╔╝██║ ███████╗██║ ██║██║ ╚████║███████╗ ██║ ███████║██╗╚██████╔╝██║ ██║╚██████╔╝ [09:22:56] ╚═╝╚═╝ ╚═╝ ╚═════╝╚═╝╚══════╝ ╚═════╝ ╚═╝ ╚══════╝╚═╝ ╚═╝╚═╝ ╚═══╝╚══════╝ ╚═╝ ╚══════╝╚═╝ ╚═════╝ ╚═╝ ╚═╝ ╚═════╝ [09:23:12] mvolz matanya NightMonkey AySz88 eddiegp gwicke mooeypoo ryasmeen jaufrecht AlexZ jackmcbarn Isarra lindseyanne jgirault wikibugs JD|cloud SpydarOO7 nuria_ wm-bot wmopbot drewmutt ypnos quiddity ragesoss subbu thedj tomaluca95 Reedy FastLizard4 aude legoktm matt_flaschen Steinsplitter jdlrobson [09:23:56] tab misfire sorry [09:31:16] 10Citoid, 10VisualEditor, 10Wikimedia-Site-requests: Disallow adding Czech language tag (cs-CZ) into citation templates on cswiki - https://phabricator.wikimedia.org/T156548#3957774 (10Mvolz) 05Open>03declined [09:45:48] 10Citoid, 10VisualEditor, 10Wikimedia-Site-requests: Disallow adding Czech language tag (cs-CZ) into citation templates on cswiki - https://phabricator.wikimedia.org/T156548#3957809 (10Mvolz) >>! In T156548#3956855, @Dvorapa wrote: > Well, the community of Czech Wikipedia users has chosen the option two, but... [10:56:42] 10Citoid, 10VisualEditor, 10Wikimedia-Site-requests: Disallow adding Czech language tag (cs-CZ) into citation templates on cswiki - https://phabricator.wikimedia.org/T156548#3957927 (10Dvorapa) @Mvolz Overall this is a really useful feature, not buggy in other ways (like detecting wrong language), so we adap... [11:22:36] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#3957958 (10Pinnerup) I came here just for this after too often accidentally publishing an incomplete or undescribed edit. It'... [11:32:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: Have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#3957975 (10Pinnerup) I second this. I find it vexing that the opportunity to preview and review chan... [12:50:30] 10VisualEditor, 10ContentTranslation: Integrate editing toolbar in the tools column in Content Translation - https://phabricator.wikimedia.org/T176422#3624629 (10Pginer-WMF) [13:55:11] (03CR) 10Hashar: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [13:57:12] (03CR) 10jenkins-bot: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [13:58:31] 10VisualEditor, 10ContentTranslation: Customise the editing toolbar in Content Translation to show the most relevant tools - https://phabricator.wikimedia.org/T186882#3958287 (10Pginer-WMF) p:05Triage>03Normal [13:59:25] 10VisualEditor, 10ContentTranslation, 10Language-2018-Jan-Mar: Customise the editing toolbar in Content Translation to show the most relevant tools - https://phabricator.wikimedia.org/T186882#3958287 (10Pginer-WMF) [14:03:57] (03CR) 10Hashar: "check experimental" [unicodejs] - 10https://gerrit.wikimedia.org/r/153401 (owner: 10Hashar) [14:04:13] (03CR) 10jenkins-bot: Jenkins job validation (DO NOT SUBMIT) [unicodejs] - 10https://gerrit.wikimedia.org/r/153401 (owner: 10Hashar) [14:55:29] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607#3958424 (10MZMcBride) If the use-case is "I want to discuss a particular block of text fro... [14:55:34] 10VisualEditor, 10Wikimedia-log-errors: parseWikitextFragment() expects exactly 3 parameters, 2 given in ApiVisualEditor - https://phabricator.wikimedia.org/T186884#3958426 (10demon) p:05Triage>03Normal [14:56:27] (03CR) 10Hashar: "check experimental" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/55130 (owner: 10Hashar) [14:58:31] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/409347 [14:58:45] (03CR) 10Hashar: "check experimental" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/409347 (owner: 10Hashar) [15:07:12] (03CR) 10jenkins-bot: Jenkins job validation (DO NOT SUBMIT) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/55130 (owner: 10Hashar) [15:26:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/409272 (owner: 10L10n-bot) [16:01:33] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)): Allow to add buttons with undefined icons. - https://phabricator.wikimedia.org/T172500#3958707 (10Liuxinyu970226) [16:02:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 3 others: [NWE + CodeMirror] Syntaxhighlighting and actual text out of sync for some special characters - https://phabricator.wikimedia.org/T170382#3958717 (10Liuxinyu970226) [16:02:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: Possible to select CodeMirror surface under VE NWE using slight gap and end of document - https://phabricator.wikimedia.org/T170170#3958719 (10Liuxinyu970226) [16:02:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: Using delete key above the line for indented text in NWE+CodeMirror leads to bug - https://phabricator.wikimedia.org/T170057#3958723 (10Liuxinyu970226) [16:02:21] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: [NWE + CodeMirror] Long words cause following text to fall out of sync - https://phabricator.wikimedia.org/T169851#3958725 (10Liuxinyu970226) [16:02:25] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, and 2 others: "Uncaught Error: Invalid end offset: X" when undoing an HTML paste in new wikitext editor with syntax editing enabled - https://phabricator.wikimedia.org/T169012#3958727 (10Liuxinyu970226) [16:03:10] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Beta-Cluster-reproducible: CodeMirror breaks NWE on labs: "TypeError: mwConfig is null" - https://phabricator.wikimedia.org/T172632#3958746 (10Liuxinyu970226) [16:03:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: [NWE + CodeMirror] Syntaxhighlighting doesn't work together with the change-directionality-tool - https://phabricator.wikimedia.org/T170040#3958750 (10Liuxinyu970226) [17:14:57] 10VisualEditor, 10Wikidata: ResourcesTest::testFileExistence fails for ULS files in VisualEditor - https://phabricator.wikimedia.org/T186903#3958883 (10Lucas_Werkmeister_WMDE) [17:16:42] (03CR) 10Umherirrender: "Clean up .phpcs.xml? Or there are still wrong class names?" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 (owner: 10Legoktm) [17:29:29] 10VisualEditor, 10Wikimedia-log-errors: parseWikitextFragment() expects exactly 3 parameters, 2 given in ApiVisualEditor - https://phabricator.wikimedia.org/T186884#3958921 (10Esanders) pinging @DLynch [18:11:29] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Wikidata, 10Jenkins: ResourcesTest::testFileExistence fails for ULS files in VisualEditor - https://phabricator.wikimedia.org/T186903#3959008 (10Umherirrender) [18:27:25] (03PS2) 10Jforrester: Move classes to includes/ [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 (owner: 10Legoktm) [18:27:47] (03CR) 10Jforrester: "Failure is a missing-ULS-so-VE-tries-to-provide-the-data-and-fails issue? Very odd." [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 (owner: 10Legoktm) [18:29:36] (03CR) 10jerkins-bot: [V: 04-1] Move classes to includes/ [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 (owner: 10Legoktm) [18:32:47] (03PS1) 10Jforrester: Follow-up fa9438e5f: Fix path to back-up data source for non-ULS installs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409408 (https://phabricator.wikimedia.org/T186903) [18:34:52] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Wikidata, 10Jenkins, 10Patch-For-Review: ResourcesTest::testFileExistence fails for ULS files in VisualEditor - https://phabricator.wikimedia.org/T186903#3959054 (10Jdforrester-WMF) p:05Triage>03Unbreak! a:03Jdforrester-WMF My fault, sorry.... [18:35:23] (03CR) 10Legoktm: [C: 032] Follow-up fa9438e5f: Fix path to back-up data source for non-ULS installs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409408 (https://phabricator.wikimedia.org/T186903) (owner: 10Jforrester) [18:35:55] (03PS3) 10Jforrester: Move classes to includes/ [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 (owner: 10Legoktm) [18:42:04] (03Merged) 10jenkins-bot: Follow-up fa9438e5f: Fix path to back-up data source for non-ULS installs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409408 (https://phabricator.wikimedia.org/T186903) (owner: 10Jforrester) [18:45:16] 10VisualEditor, 10Wikimedia-log-errors: parseWikitextFragment() expects exactly 3 parameters, 2 given in ApiVisualEditor - https://phabricator.wikimedia.org/T186884#3959127 (10demon) [18:46:39] (03CR) 10jenkins-bot: Follow-up fa9438e5f: Fix path to back-up data source for non-ULS installs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409408 (https://phabricator.wikimedia.org/T186903) (owner: 10Jforrester) [18:56:32] (03CR) 10Jforrester: [C: 032] Move classes to includes/ [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 (owner: 10Legoktm) [19:00:20] legoktm: If only we had static dependent registration of RL modules. ;-) [19:00:37] (03Merged) 10jenkins-bot: Move classes to includes/ [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/409238 (owner: 10Legoktm) [19:01:29] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Wikidata, 10Jenkins, and 2 others: ResourcesTest::testFileExistence fails for ULS files in VisualEditor - https://phabricator.wikimedia.org/T186903#3959141 (10Jdforrester-WMF) 05Open>03Resolved [20:39:23] 10VisualEditor, 10Wikimedia-log-errors: parseWikitextFragment() expects exactly 3 parameters, 2 given in ApiVisualEditor - https://phabricator.wikimedia.org/T186884#3959440 (10DLynch) @ESanders: It's duelling patches. Your https://gerrit.wikimedia.org/r/406770 merged at the end of January, but was originally w... [20:41:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-log-errors: parseWikitextFragment() expects exactly 3 parameters, 2 given in ApiVisualEditor - https://phabricator.wikimedia.org/T186884#3959451 (10Jdforrester-WMF) a:03DLynch Sounds good. [20:43:18] (03PS1) 10DLynch: ApiVisualEditor: Update getPreloadContent's parseWikitextFragment call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409439 (https://phabricator.wikimedia.org/T186884) [20:44:22] (03CR) 10Jforrester: [C: 031] ApiVisualEditor: Update getPreloadContent's parseWikitextFragment call [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/409439 (https://phabricator.wikimedia.org/T186884) (owner: 10DLynch) [23:14:22] 10VisualEditor, 10Wikimedia-log-errors: Undefined variable: bodyOnly in ApiVisualEditor - https://phabricator.wikimedia.org/T186934#3959844 (10demon) p:05Triage>03Normal [23:14:35] 10VisualEditor, 10Wikimedia-log-errors: Undefined variable: bodyOnly in ApiVisualEditor - https://phabricator.wikimedia.org/T186934#3959856 (10demon)