[00:02:49] (03CR) 10Esanders: SessionStorage: Return booleans for setters (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413627 (owner: 10Esanders) [00:06:23] 10VisualEditor, 10Parsoid, 10TemplateStyles: VisualEditor does not like TemplateStyles - https://phabricator.wikimedia.org/T188143#3998292 (10Nirmos) Ok, so I'm gonna move all styles I've migrated back to the MediaWiki namespace, until this is sorted out. Even if this turns out to be premature, the key here... [00:08:55] (03CR) 10Jforrester: [C: 032] Make get/removeSession exception safe [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413895 (owner: 10Esanders) [00:11:38] (03Merged) 10jenkins-bot: Make get/removeSession exception safe [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413895 (owner: 10Esanders) [00:14:13] (03CR) 10jenkins-bot: Make get/removeSession exception safe [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413895 (owner: 10Esanders) [00:56:01] (03PS1) 10Jforrester: Update VE core submodule to master (d0fd0c9a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) [01:02:32] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (d0fd0c9a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [01:05:44] 10VisualEditor, 10Parsoid, 10TemplateStyles: VisualEditor does not like TemplateStyles - https://phabricator.wikimedia.org/T188143#3997644 (10ssastry) >>! In T188143#3998163, @Anomie wrote: > Doing a little digging, https://sv.wikipedia.org/api/rest_v1/page/html/Anv%C3%A4ndare%3AAnomie%2FSandbox?redirect=fal... [01:05:59] 10VisualEditor, 10TemplateStyles: VisualEditor does not like TemplateStyles - https://phabricator.wikimedia.org/T188143#3998404 (10ssastry) [01:09:32] 10VisualEditor, 10TemplateStyles: VisualEditor does not like TemplateStyles - https://phabricator.wikimedia.org/T188143#3998405 (10Nirmos) Done. Everything with regard to migration of styles on svwiki is now reverted, so that this task may be investigated in peace without any fear of more wild span tags being... [02:51:46] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [04:43:37] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (d0fd0c9a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [06:21:59] (03PS4) 10Divec: ve.dm.Change: Allow unsafe deserialization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413455 (owner: 10Esanders) [06:24:05] (03PS1) 10Divec: Merge "Use offsetWidth/Height instead of jQuery.width()/height()" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414025 [06:24:07] (03PS1) 10Divec: WIP: Minify the serialized form of Transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414026 (https://phabricator.wikimedia.org/T188020) [06:24:53] (03Abandoned) 10Divec: Merge "Use offsetWidth/Height instead of jQuery.width()/height()" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414025 (owner: 10Divec) [06:25:33] (03PS2) 10Divec: WIP: Minify the serialized form of Transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414026 (https://phabricator.wikimedia.org/T188020) [06:26:20] (03CR) 10Divec: [C: 032] ve.dm.Change: Allow unsafe deserialization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413455 (owner: 10Esanders) [06:28:09] (03CR) 10jerkins-bot: [V: 04-1] WIP: Minify the serialized form of Transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414026 (https://phabricator.wikimedia.org/T188020) (owner: 10Divec) [06:30:40] (03Merged) 10jenkins-bot: ve.dm.Change: Allow unsafe deserialization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413455 (owner: 10Esanders) [06:33:32] (03CR) 10jenkins-bot: ve.dm.Change: Allow unsafe deserialization [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413455 (owner: 10Esanders) [10:35:39] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff bug in the history tab - https://phabricator.wikimedia.org/T187913#3989951 (10Schnark) Note that the `34` is actually present, but for some reason hidden via `display: none`. [10:45:59] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff behaves poorly for changes inside a container - https://phabricator.wikimedia.org/T188170#3998663 (10Schnark) [12:15:42] (03PS9) 10Esanders: Use session storage to auto-save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413273 (https://phabricator.wikimedia.org/T57370) [12:20:05] (03PS1) 10Esanders: MWImageNode: getHashObject -> getHashObjectForRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/414099 [12:22:11] (03CR) 10jerkins-bot: [V: 04-1] Use session storage to auto-save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413273 (https://phabricator.wikimedia.org/T57370) (owner: 10Esanders) [12:28:09] (03PS2) 10Esanders: MWImageNode: getHashObject -> getHashObjectForRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/414099 [12:34:34] (03CR) 10jerkins-bot: [V: 04-1] MWImageNode: getHashObject -> getHashObjectForRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/414099 (owner: 10Esanders) [12:45:07] (03PS3) 10Esanders: MWImageNode: getHashObject -> getHashObjectForRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/414099 [13:25:57] (03PS5) 10Esanders: ve.dm.Change: Serialize empty stores to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413475 [13:32:52] (03CR) 10Tchanders: [C: 032] MWImageNode: getHashObject -> getHashObjectForRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/414099 (owner: 10Esanders) [13:42:16] (03Merged) 10jenkins-bot: MWImageNode: getHashObject -> getHashObjectForRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/414099 (owner: 10Esanders) [13:44:12] (03CR) 10jenkins-bot: MWImageNode: getHashObject -> getHashObjectForRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/414099 (owner: 10Esanders) [14:11:20] (03PS1) 10Esanders: Transactions: Only set insertedDataOffset/Length when meaningful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414104 (https://phabricator.wikimedia.org/T188020) [15:56:01] (03CR) 10Divec: [C: 032] Transactions: Only set insertedDataOffset/Length when meaningful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414104 (https://phabricator.wikimedia.org/T188020) (owner: 10Esanders) [15:58:54] (03Merged) 10jenkins-bot: Transactions: Only set insertedDataOffset/Length when meaningful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414104 (https://phabricator.wikimedia.org/T188020) (owner: 10Esanders) [16:01:05] (03CR) 10jenkins-bot: Transactions: Only set insertedDataOffset/Length when meaningful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414104 (https://phabricator.wikimedia.org/T188020) (owner: 10Esanders) [16:35:30] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Historic visual diff displays change completely unrelated to actual change - https://phabricator.wikimedia.org/T187613#3998944 (10Tchanders) a:03Tchanders [16:43:24] (03PS6) 10Esanders: ve.dm.IndexValueStore: Serialize empty stores to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413475 [16:46:33] (03CR) 10Esanders: "we should do a quick performance check on a minifying a huge transaction (e.g. delete large article) as we want to have a balance between " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414026 (https://phabricator.wikimedia.org/T188020) (owner: 10Divec) [16:54:25] 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Patch-For-Review, 10VisualEditor (Current work): Update gallery dialog to work with Parsoid's native implementation - https://phabricator.wikimedia.org/T150621#3998972 (10Esanders) a:03matmarex [16:55:46] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#3998979 (10Esanders) a:03... [17:06:48] (03CR) 10Divec: [C: 032] ve.dm.IndexValueStore: Serialize empty stores to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413475 (owner: 10Esanders) [17:10:01] (03Merged) 10jenkins-bot: ve.dm.IndexValueStore: Serialize empty stores to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413475 (owner: 10Esanders) [17:12:59] (03CR) 10jenkins-bot: ve.dm.IndexValueStore: Serialize empty stores to null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413475 (owner: 10Esanders) [17:16:00] (03CR) 10Esanders: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [17:23:25] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (d0fd0c9a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [17:25:36] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (d0fd0c9a6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [17:28:42] (03PS1) 10Tchanders: Filter out meaningless properties when comparing elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414110 (https://phabricator.wikimedia.org/T187613) [17:28:44] (03PS1) 10Tchanders: Stop diffing originalHTML for internal items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414111 (https://phabricator.wikimedia.org/T187613) [17:54:55] 10Cite, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable responsive references by default on the Romanian Wikipedia - https://phabricator.wikimedia.org/T187997#3999060 (10Framawiki) p:05Triage>03Normal [17:55:01] 10Cite, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable responsive references by default on the Romanian Wikipedia - https://phabricator.wikimedia.org/T187997#3992745 (10Framawiki) a:03Framawiki [18:00:17] 10VisualEditor, 10VisualEditor-VisualDiffs: Historical diffs show lots of unrelated reference changes - https://phabricator.wikimedia.org/T178499#3999068 (10Tchanders) [18:00:19] (03CR) 10Divec: [C: 032] Filter out meaningless properties when comparing elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414110 (https://phabricator.wikimedia.org/T187613) (owner: 10Tchanders) [18:00:21] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Historic visual diff displays change completely unrelated to actual change - https://phabricator.wikimedia.org/T187613#3999071 (10Tchanders) [18:03:13] (03Merged) 10jenkins-bot: Filter out meaningless properties when comparing elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414110 (https://phabricator.wikimedia.org/T187613) (owner: 10Tchanders) [18:06:09] (03CR) 10jenkins-bot: Filter out meaningless properties when comparing elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414110 (https://phabricator.wikimedia.org/T187613) (owner: 10Tchanders) [18:15:11] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Historic visual diff displays change completely unrelated to actual change - https://phabricator.wikimedia.org/T187613#3999098 (10Tchanders) The fact that it isn't showing the blockquote diff is a separate issue. It seems blockquo... [18:39:19] (03PS1) 10Esanders: Use #cloneWithData in #getInternalListChangedNodeElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414118 [18:46:54] (03CR) 10Esanders: "Fix is https://gerrit.wikimedia.org/r/#/c/414118/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [19:01:14] (03PS2) 10Esanders: Use #cloneWithData in #getInternalListChangedNodeElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414118 [19:04:38] (03CR) 10Tchanders: [C: 032] Use #cloneWithData in #getInternalListChangedNodeElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414118 (owner: 10Esanders) [19:07:36] (03Merged) 10jenkins-bot: Use #cloneWithData in #getInternalListChangedNodeElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414118 (owner: 10Esanders) [19:10:34] (03CR) 10jenkins-bot: Use #cloneWithData in #getInternalListChangedNodeElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414118 (owner: 10Esanders) [19:11:24] (03PS2) 10Esanders: Update VE core submodule to master (d946b72) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [19:16:38] (03CR) 10Esanders: [C: 032] Stop diffing originalHTML for internal items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414111 (https://phabricator.wikimedia.org/T187613) (owner: 10Tchanders) [19:19:25] (03Merged) 10jenkins-bot: Stop diffing originalHTML for internal items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414111 (https://phabricator.wikimedia.org/T187613) (owner: 10Tchanders) [19:20:08] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (d946b72) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [19:22:26] (03CR) 10jenkins-bot: Stop diffing originalHTML for internal items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414111 (https://phabricator.wikimedia.org/T187613) (owner: 10Tchanders) [19:27:11] 10Cite, 10MassMessage: Add a warning when tags are in a message, but no tag. - https://phabricator.wikimedia.org/T156167#3999132 (10Noella94) a:03Noella94 [19:32:49] (03CR) 10Esanders: "Now depends on https://gerrit.wikimedia.org/r/#/c/414119/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/413904 (https://phabricator.wikimedia.org/T187070) (owner: 10Jforrester) [20:35:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor should not display uneditable page content - https://phabricator.wikimedia.org/T188186#3999197 (10Tgr) [20:58:42] 10VisualEditor, 10VisualEditor-VisualDiffs: Historical visual diff sometimes shows extraneous changes for a single-line addition - https://phabricator.wikimedia.org/T187632#3981223 (10Tchanders) Thanks for this, I've seen other examples like it. It's a problem with the nested lists - the diff matches up the w... [21:31:32] (03PS3) 10Divec: WIP: Minify the serialized form of Transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414026 (https://phabricator.wikimedia.org/T188020) [21:32:07] (03PS1) 10Divec: WIP: Minify the serialized form of Changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414127 (https://phabricator.wikimedia.org/T188020) [21:35:09] (03CR) 10jerkins-bot: [V: 04-1] WIP: Minify the serialized form of Transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414026 (https://phabricator.wikimedia.org/T188020) (owner: 10Divec) [21:35:39] (03CR) 10jerkins-bot: [V: 04-1] WIP: Minify the serialized form of Changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/414127 (https://phabricator.wikimedia.org/T188020) (owner: 10Divec) [23:25:42] hey can someone tell me how i can diagnose the issue with my mediawiki visualeditor ? I already went through the https://www.mediawiki.org/wiki/Parsoid/Troubleshooting#Configuration [23:25:52] https://unethical.me/wiki/Main_Page [23:26:27] im using port 8000 for parsoid [23:31:09] after a while it also shows this error in console "RESTBase load failed: error" [23:38:55] 10VisualEditor: Bug in Basque Wikipedia Visual Editor - https://phabricator.wikimedia.org/T187699#3999333 (10Inaki-LL) @Deskana Yes, I am also sorry. The thing is I do not know how to reproduce other than provide diffs, since I am only now coming to grips with Phabricator, but still do not know what you mean wit...