[00:26:05] 10VisualEditor-EditingTools, 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): Gallery with no images (invalid characters as gallery contents) creates an invisible node and can't be... - https://phabricator.wikimedia.org/T75230#4008790 [01:27:28] 10VisualEditor, 10SyntaxHighlight: [Regression pre-wmf.23] Weird wikitext formatting observed while editing with NWE when syntax highlighting is on - https://phabricator.wikimedia.org/T188473#4008893 (10Ryasmeen) [01:29:48] 10VisualEditor, 10SyntaxHighlight: [Regression pre-wmf.23] Weird wikitext formatting observed while editing with NWE when syntax highlighting is on - https://phabricator.wikimedia.org/T188473#4008906 (10Ryasmeen) Same issue occurs for the following cases: 1. Adding text with formatting such as "bold" . 2. In... [01:52:09] i've been doing some refactoring and accidentally discovered and fixed two bugs. should i file tasks so that we can brag about fixing them? ;) [02:04:09] (03PS29) 10Bartosz Dziewoński: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [02:04:11] (03PS1) 10Bartosz Dziewoński: Centralize Parsoid resource name parsing logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415202 [02:04:45] (03CR) 10Bartosz Dziewoński: "PS29 extracts ve.normalizeParsoidResourceName() to a separate changeset (https://gerrit.wikimedia.org/r/415202)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [02:06:50] (03CR) 10Bartosz Dziewoński: "Introducing ve.normalizeParsoidResourceName() was originally a part of https://gerrit.wikimedia.org/r/#/c/322490/ ." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415202 (owner: 10Bartosz Dziewoński) [02:10:14] 10VisualEditor, 10VisualEditor-ContentEditable, 10User-Ryasmeen, 10Verified: Cursor positioned too high (like superscript) when adding new item to numbered list - https://phabricator.wikimedia.org/T86928#4008974 (10Ryasmeen) [02:19:07] 10WikiEditor, 10Accessibility: allow to customize toolbar buttons size - https://phabricator.wikimedia.org/T188470#4008694 (10Volker_E) Also, we've tried to accomplish increased minimum sizing of widgets and toolbar tools to reflect touch inputs following human-computer-interface guide lines and we also have a... [02:42:21] 10VisualEditor, 10Parsing-Team, 10TemplateStyles, 10RfC, and 3 others: RfC: Allow styling in templates - https://phabricator.wikimedia.org/T483#4008995 (10Tgr) 05Open>03Resolved Nevertheless, it can be closed. The RfC was accepted and the feature implemented, reviewed and deployed; nothing actionable l... [02:43:11] 10VisualEditor, 10Parsing-Team, 10TemplateStyles, 10RfC, and 3 others: RfC: Allow styling in templates - https://phabricator.wikimedia.org/T483#4008999 (10Tgr) [04:50:09] 10Cite, 10Parsoid: Cite error messes up reference lists in Parsoid output - https://phabricator.wikimedia.org/T188478#4009128 (10bearND) [07:57:30] 10VisualEditor, 10ContentTranslation, 10Language-2018-Jan-Mar, 10Patch-For-Review: Customise the editing toolbar in Content Translation to show the most relevant tools - https://phabricator.wikimedia.org/T186882#4009326 (10Nikerabbit) Why is this in-progress and not in in-review? [08:57:03] 10Cite: Cite: Provide a way for users to find articles which have the reference list inserted automatically - https://phabricator.wikimedia.org/T69700#4009416 (10Aklapper) @Nunabas: No updates, otherwise they'd be listed here. If you fancy working on related code, see previous patches for pointers and [[ https:/... [09:54:38] 10WikiEditor, 10Accessibility: allow to customize toolbar buttons size - https://phabricator.wikimedia.org/T188470#4009511 (10Aklapper) p:05Triage>03Lowest [10:32:04] 10Editing-team, 10MediaWiki-extensions-DynamicPageList, 10Performance: Address performance needs for Wikimedia from DynamicPageList extension so that it can be deployed to further wikis - https://phabricator.wikimedia.org/T124841#4009566 (10Mrjohncummings) Hi all I'm sorry to see that this extension is bloc... [11:18:13] (03PS4) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [11:21:06] (03CR) 10jerkins-bot: [V: 04-1] WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [11:25:02] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Text on category page is invisible when syntax highlighting is enabled - https://phabricator.wikimedia.org/T188069#3995238 (10Elitre) T185184? [12:41:35] 10VisualEditor-DataModel, 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Provide a way to compact multiple transactions into one - https://phabricator.wikimedia.org/T188026#4009991 (10Esanders) [12:45:22] (03CR) 10Esanders: [C: 04-1] "You correctly observed that the fix is easier in VE because we use display:inline-block, so why not just switch this to use inline-block t" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/414961 (https://phabricator.wikimedia.org/T56310) (owner: 10Amire80) [13:04:32] (03CR) 10Esanders: [C: 04-1] Order right-to-left alphabets from right-to-left in the special character selector (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/414961 (https://phabricator.wikimedia.org/T56310) (owner: 10Amire80) [13:21:55] 10VisualEditor: How to insert non-breaking space in VisualEditor - https://phabricator.wikimedia.org/T188504#4010164 (10Dvorapa) [13:26:21] 10VisualEditor: How to insert non-breaking space in VisualEditor - https://phabricator.wikimedia.org/T188504#4010193 (10Dvorapa) [13:47:34] (03PS1) 10Esanders: SpecialCharacterPage: Allow setting lang/dir via special attributes property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415281 (https://phabricator.wikimedia.org/T56310) [13:50:30] (03PS1) 10Esanders: fetchSpecialCharList: Set directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) [13:55:07] (03PS2) 10Esanders: Use display:inline-block for special character buttons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/414961 (https://phabricator.wikimedia.org/T56310) (owner: 10Amire80) [13:56:24] (03PS3) 10Esanders: Use display:inline-block for special character buttons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/414961 (https://phabricator.wikimedia.org/T56310) (owner: 10Amire80) [13:56:38] (03CR) 10Esanders: [C: 031] Use display:inline-block for special character buttons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/414961 (https://phabricator.wikimedia.org/T56310) (owner: 10Amire80) [14:11:50] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): New wikitext editor should not display uneditable page content - https://phabricator.wikimedia.org/T188186#3999197 (10Esanders) The FOUC is being caused by the temp wikitext editor which is a separate issue, but we need to think more c... [14:14:28] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): New wikitext editor should not display uneditable page content - https://phabricator.wikimedia.org/T188186#4010377 (10Esanders) Also worth noting that most images are on Commons, where VE is only a beta feature, so this is probably low... [14:15:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor should not display uneditable page content - https://phabricator.wikimedia.org/T188186#4010378 (10Esanders) [14:16:05] 10VisualEditor: How to insert non-breaking space in VisualEditor - https://phabricator.wikimedia.org/T188504#4010380 (10Esanders) [14:16:08] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#4010383 (10Esanders) [14:20:40] 10VisualEditor: VisualEditor Hangs if Uploaded Image Manipulated with "Advanced Settings" - https://phabricator.wikimedia.org/T187941#3990788 (10Esanders) I can't reproduce, what exactly did you change in advanced settings? [14:22:26] 10VisualEditor: VisualEditor Hangs if Uploaded Image Manipulated with "Advanced Settings" - https://phabricator.wikimedia.org/T187941#4010397 (10Esanders) [14:26:22] 10VisualEditor: VisualEditor Hangs if Uploaded Image Manipulated with "Advanced Settings" - https://phabricator.wikimedia.org/T187941#4010402 (10bisongde) Any setting there will trigger for us. Toggling text wrap, changing page justification, etc. The media gets uploaded successfully but VE hangs if you click fi... [14:27:36] 10VisualEditor: VisualEditor Hangs if Uploaded Image Manipulated with "Advanced Settings" - https://phabricator.wikimedia.org/T187941#4010404 (10Esanders) Looks like a duplicate of T180521 from the stack trace. [14:27:53] 10VisualEditor: VisualEditor Hangs if Uploaded Image Manipulated with "Advanced Settings" - https://phabricator.wikimedia.org/T187941#4010408 (10Esanders) [14:27:56] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), 10Patch-For-Review, 10User-Ryasmeen: Can't add frameless images unless you insert them as thumbs first - https://phabricator.wikimedia.org/T180521#3760532 (10Esanders) [14:30:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-Translate: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#4010419 (10Esanders) [14:35:22] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607#4010428 (10Trizek-WMF) >>! In T185607#3986710, @thiemowmde wrote: > * The moderation proce... [14:35:37] (03PS2) 10Esanders: fetchSpecialCharList: Set directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) [14:37:25] (03PS1) 10Esanders: Tag TODO comments with bug number [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415296 [14:37:27] (03PS1) 10Esanders: Clarify autosave comment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415297 [14:40:34] (03CR) 10Bartosz Dziewoński: [C: 032] Tag TODO comments with bug number [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415296 (owner: 10Esanders) [14:40:37] (03CR) 10Bartosz Dziewoński: [C: 032] Clarify autosave comment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415297 (owner: 10Esanders) [14:46:29] (03CR) 10jerkins-bot: [V: 04-1] fetchSpecialCharList: Set directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [14:47:07] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [14:48:17] (03Merged) 10jenkins-bot: Tag TODO comments with bug number [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415296 (owner: 10Esanders) [14:50:06] (03CR) 10jenkins-bot: Tag TODO comments with bug number [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415296 (owner: 10Esanders) [14:50:51] 10VisualEditor: VisualEditor Hangs if Uploaded Image Manipulated with "Advanced Settings" - https://phabricator.wikimedia.org/T187941#4010500 (10bisongde) >>! In T187941#4010404, @Esanders wrote: > Looks like a duplicate of T180521 from the stack trace. I notice that you uploaded a patch in early January. Our V... [14:50:53] (03Merged) 10jenkins-bot: Clarify autosave comment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415297 (owner: 10Esanders) [14:52:45] (03CR) 10jenkins-bot: Clarify autosave comment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415297 (owner: 10Esanders) [14:57:30] 10VisualEditor: Duplicate content when saving after joining a line - https://phabricator.wikimedia.org/T187920#3990165 (10Esanders) I can't reproduce this. What keystrokes are you using to get to the end of the line? Is it broken on https://en.wikipedia.beta.wmflabs.org? [14:59:02] (03CR) 10Esanders: [C: 032] Centralize Parsoid resource name parsing logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415202 (owner: 10Bartosz Dziewoński) [15:02:13] (03CR) 10jerkins-bot: [V: 04-1] fetchSpecialCharList: Set directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [15:05:56] (03PS5) 10Esanders: Don't show the Cite tool if the config lacks any required keys [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408344 (https://phabricator.wikimedia.org/T186276) (owner: 10Jforrester) [15:06:12] (03CR) 10Esanders: [C: 031] Don't show the Cite tool if the config lacks any required keys [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408344 (https://phabricator.wikimedia.org/T186276) (owner: 10Jforrester) [15:09:04] 10Editing-team, 10MediaWiki-extensions-DynamicPageList, 10Performance: Address performance needs for Wikimedia from DynamicPageList extension so that it can be deployed to further wikis - https://phabricator.wikimedia.org/T124841#4010614 (10Bawolff) >>! In T124841#4009566, @Mrjohncummings wrote: > Hi all >... [15:09:20] (03Merged) 10jenkins-bot: Centralize Parsoid resource name parsing logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415202 (owner: 10Bartosz Dziewoński) [15:11:08] (03CR) 10jenkins-bot: Centralize Parsoid resource name parsing logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415202 (owner: 10Bartosz Dziewoński) [15:39:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10VisualEditor-MediaWiki-Templates, and 3 others: Ref generating templates show references lists when edited - https://phabricator.wikimedia.org/T101553#4010731 (10He7d3r) [15:42:14] 10VisualEditor, 10VisualEditor-EditingTools, 10User-Ryasmeen: VisualEditor:Cite error for no {{reflist}} template shows up,when references are added after the reflist in the article - https://phabricator.wikimedia.org/T60049#4010747 (10He7d3r) [15:42:17] 10VisualEditor, 10VisualEditor-EditingTools, 10User-Ryasmeen: VisualEditor:Cite error for no {{reflist}} template shows up,when references are added after the reflist in the article - https://phabricator.wikimedia.org/T60049#4010748 (10He7d3r) [15:42:19] 10VisualEditor, 10VisualEditor-EditingTools: Append a references list to bottom of the page when the first reference is added - https://phabricator.wikimedia.org/T56906#636266 (10He7d3r) [16:52:50] (03PS3) 10Esanders: fetchSpecialCharList: Set directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) [17:05:04] 10VisualEditor: Duplicate content when saving after joining a line - https://phabricator.wikimedia.org/T187920#4010988 (10Jhernandez) Here's a gif with the keys I'm pressing in an overlay. {F14106826} Could reproduce in mediawiki.org with Safari. Tried on en.wikipedia.beta.wmflabs.org and could reproduce too (... [17:37:10] (03CR) 10jerkins-bot: [V: 04-1] fetchSpecialCharList: Set directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [17:59:52] 10TemplateData, 10VisualEditor: VisualEditor should not insert empty parameters from the TemplateData dialog - https://phabricator.wikimedia.org/T188330#4003869 (10DLynch) Duplicate of T101075, I think? There's discussion there on some of the gotchas, certainly. [18:06:33] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff: Provide a more detailed description of template changes - https://phabricator.wikimedia.org/T188389#4011204 (10DLynch) a:03DLynch [18:06:57] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Visual diff: Provide a more detailed description of template changes - https://phabricator.wikimedia.org/T188389#4005621 (10DLynch) [18:18:09] 10VisualEditor-CopyPaste, 10VisualEditor (Current work): Cutting and pasting some text on one article emits JS error and doesn't let you save - https://phabricator.wikimedia.org/T187690#3982573 (10Alsee) I tried testing the bug mentioned just above, at [[ https://en.wikipedia.org/w/index.php?title=Sonic_X-trem... [18:34:46] (03CR) 10Esanders: [C: 032] Remove autoGenerated hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/403751 (owner: 10Arlolra) [18:41:30] (03Merged) 10jenkins-bot: Remove autoGenerated hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/403751 (owner: 10Arlolra) [18:45:18] (03CR) 10jenkins-bot: Remove autoGenerated hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/403751 (owner: 10Arlolra) [19:22:26] (03PS1) 10Esanders: Make edit notices popup wider (320 -> 450) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415364 (https://phabricator.wikimedia.org/T184379) [19:24:56] (03CR) 10Jforrester: [C: 031] Don't show the Cite tool if the config lacks any required keys [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408344 (https://phabricator.wikimedia.org/T186276) (owner: 10Jforrester) [19:25:16] (03CR) 10Jforrester: [C: 032] SpecialCharacterPage: Allow setting lang/dir via special attributes property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415281 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [19:27:56] (03Merged) 10jenkins-bot: SpecialCharacterPage: Allow setting lang/dir via special attributes property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415281 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [19:30:32] (03CR) 10jenkins-bot: SpecialCharacterPage: Allow setting lang/dir via special attributes property [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415281 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [19:37:49] (03PS30) 10Bartosz Dziewoński: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [19:38:33] edsanders: does checking for a 'data-parsoid' attribute in a matchFunction sound like a good idea? https://gerrit.wikimedia.org/r/#/c/322490/29..30 [19:39:33] for backwards compatibility? [19:40:16] edsanders: so that a
  • in wikitext doesn't turn into a MWGalleryImageNode [19:40:48] oh [19:40:54] hmm [19:41:02] if that sounds like a bad idea, we can make MWGalleryImageNode matchFunction match nothing, but then gallery has to handle its image/caption children, which is not a big deal, but a bit inelegant [19:41:41] can we check element.parentNode? [19:42:13] edsanders: hmm, i suppose we can. if it sounds like a better idea to you :D [19:42:44] I mean - that way it's relying on DOM structure [19:43:06] edsanders: (i actually expected Converter to check .static.parentNodeTypes at first, and alienate the node or something, but it doesn't. and it turns out lists with alienated children blow up) [19:43:20] edsanders: yeah, that's actually probably a better idea. thanks [19:51:18] 10VisualEditor, 10Patch-For-Review: VisualEditor/NWE should show larger dialogs for edit notices and AbuseFilter messages - https://phabricator.wikimedia.org/T184379#3881476 (10Esanders) WP:AN with 450 width: {F14113775} [19:53:14] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [19:54:09] (03PS31) 10Bartosz Dziewoński: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [19:54:44] (03CR) 10Bartosz Dziewoński: "PS30-31: MWGalleryNode doesn't have to handle own children." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [20:02:17] (03PS4) 10Jforrester: fetchSpecialCharList: Set directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [20:02:19] (03PS1) 10Jforrester: Update VE core submodule to master (bdb1a680a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415374 (https://phabricator.wikimedia.org/T56310) [20:12:16] (03CR) 10Esanders: [C: 032] "1+1=2" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408344 (https://phabricator.wikimedia.org/T186276) (owner: 10Jforrester) [20:16:48] (03CR) 10jerkins-bot: [V: 04-1] WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [20:18:16] (03Merged) 10jenkins-bot: Don't show the Cite tool if the config lacks any required keys [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/408344 (https://phabricator.wikimedia.org/T186276) (owner: 10Jforrester) [20:21:58] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Templates: Copy-pasting a relative transclusion to a different page keeps it relative, which breaks - https://phabricator.wikimedia.org/T188543#4011704 (10Niharika) [20:30:45] 10Citoid, 10VisualEditor, 10Patch-For-Review: Prevent citoid from being enabled unless all required keys are present in MediaWiki:Citoid-template-type-map.json - https://phabricator.wikimedia.org/T186276#4011723 (10Jdforrester-WMF) I added a note about this to https://meta.wikimedia.org/wiki/Tech/News/2018/10 [20:40:37] (03CR) 10Jforrester: [C: 031] fetchSpecialCharList: Set directionality (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415286 (https://phabricator.wikimedia.org/T56310) (owner: 10Esanders) [20:40:54] (03CR) 10Jforrester: "I1c7e28d3d2 adds this to the 2017 wikitext editor and the visual editor." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/414961 (https://phabricator.wikimedia.org/T56310) (owner: 10Amire80) [20:53:39] 10VisualEditor-MediaWiki, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Patch-For-Review, 10VisualEditor (Current work): [Regression pre-wmf.23] Weird wikitext formatting observed while editing with NWE when syntax highlighting is on - https://phabricator.wikimedia.org/T188473#4011806 (10Jdforres... [21:25:40] 10VisualEditor, 10Patch-For-Review: VisualEditor/NWE should show larger dialogs for edit notices and AbuseFilter messages - https://phabricator.wikimedia.org/T184379#4011935 (10Tacsipacsi) Better, but still not great. I think a full-page popup with a short summary would still be better. [21:31:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415442 (owner: 10L10n-bot) [21:33:06] 10Cite, 10VisualEditor-MediaWiki-References, 10MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), and 2 others: VisualDiffs: Add custom messages for reference changes - https://phabricator.wikimedia.org/T160589#4011944 (10Tchanders... [21:39:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs: Provide diffs on mobile VE/2017WTE, including visual diffs - https://phabricator.wikimedia.org/T188554#4011972 (10Jdforrester-WMF) [21:41:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: Redesign submit dialog / diff view to show changes alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451#4011986 (10Jdforrester-WMF) [21:44:19] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance, 10Epic, 10VisualEditor (Current work): Switching tabs in memory-limited browsers (esp. mobile ones) often causes page to refresh, causing data loss of session changes - https://phabricator.wikimedia.org/T70017#4011987 (10Jdforrester-WMF) a:03Esa... [22:09:37] 10Cite: Automatic references list after page-terminal ordered or bullet list generates unbalanced HTML - https://phabricator.wikimedia.org/T148701#2730421 (10Cchunn) I overcame this issue on our Wikis buy adding a line break before the reference is inserted: ``` diff --git a/extensions/Cite/includes/Cite.php b... [22:10:05] 10Cite, 10VisualEditor-MediaWiki-References, 10MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), and 2 others: VisualDiffs: Add custom messages for reference changes - https://phabricator.wikimedia.org/T160589#4012058 (10Ryasmeen)... [22:12:43] 10Cite: Automatic references list after page-terminal ordered or bullet list generates unbalanced HTML - https://phabricator.wikimedia.org/T148701#2730421 (10Alexia) Terraria Wiki was running into the same issue. My coworker put this fix in to prevent it from happening. ``` diff --git a/extensions/Cite/includ... [22:39:46] 10Cite: Automatic references list after page-terminal ordered or bullet list generates unbalanced HTML - https://phabricator.wikimedia.org/T148701#4012131 (10Ciencia_Al_Poder) It looks like a sane fix for this. The previous part of the "if" clause already adds a \n at the end of $text before adding the cite cont... [22:47:22] 10VisualEditor, 10Patch-For-Review: VisualEditor/NWE should show larger dialogs for edit notices and AbuseFilter messages - https://phabricator.wikimedia.org/T184379#4012157 (10MusikAnimal) I like the short summary idea, though I doubt it would get used that often. 450px certainly looks better. Does that also... [23:47:31] (03PS32) 10Bartosz Dziewoński: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [23:48:49] (03CR) 10Bartosz Dziewoński: "PS32:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [23:51:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Font size changes, and then the editor crashes - https://phabricator.wikimedia.org/T171616#4012399 (10XanonymusX) I hoped that resolving T185184 would fix this as well. But I can still reproduce the invisible wikitext parts at the beginning of any ar... [23:54:20] (03CR) 10jerkins-bot: [V: 04-1] WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders)