[00:01:19] 10VisualEditor-MediaWiki, 10WikiEditor, 10I18n, 10RTL, 10VisualEditor (Current work): RTL language characters are displayed in LTR order in LTR languages (and vice versa) - https://phabricator.wikimedia.org/T56310#4016135 (10Jdforrester-WMF) a:03Esanders [00:18:55] James_F: https://gerrit.wikimedia.org/r/415781 Don't store a cookie for mobileEditors any more [00:19:01] just noticed this super old bit of code [00:21:21] jdlrobson: Ha! Nice find. [00:43:28] (03CR) 10Jforrester: docs: Replace fake ellipses with real ones (or in one case, a vertical one) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415073 (owner: 10Jforrester) [00:53:49] (03PS35) 10Bartosz Dziewoński: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [00:53:51] (03PS1) 10Bartosz Dziewoński: ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415785 [00:56:29] (03CR) 10Bartosz Dziewoński: "PS35: Fixing some more TODOs." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [00:57:58] (03CR) 10Bartosz Dziewoński: "I am pretty happy with this commit right now, I think it's only missing support for gallery modes other than "traditional", and needs fixe" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [01:06:19] (03CR) 10Jforrester: WIP Make gallery dialog work with native gallery implementation (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [02:41:22] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests: Convert reference lists over to `responsive` on The Amusement Parkives wiki - https://phabricator.wikimedia.org/T188694#4016430 (10Hmich176) [02:54:23] 10VisualEditor, 10ContentTranslation, 10Language-2018-Jan-Mar: Customise the editing toolbar in Content Translation to show the most relevant tools - https://phabricator.wikimedia.org/T186882#3958287 (10Etonkovidova) @Pginer-WMF please review the following. It might be just one of iteration before finalizin... [03:10:44] 10Cite, 10VisualEditor, 10Wikimedia-Site-requests: Convert reference lists over to `responsive` on The Amusement Parkives wiki - https://phabricator.wikimedia.org/T188694#4016482 (10Izno) 05Open>03declined Phabricator is for changes either to the MediaWiki software or configuration changes for the Wikime... [03:10:47] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons, 10Wikimedia-Site-requests: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#4016484 (10Izno) [03:45:00] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), 10VisualEditor (Current work): Invisible text in new wikitext editor on image pages - https://phabricator.wikimedia.org/T188215#3999880 (10Anon126) I'm still experiencing this problem with the new te... [03:53:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Text on category page is invisible when syntax highlighting is enabled - https://phabricator.wikimedia.org/T188069#4016504 (10Anon126) Here's something interesting: The "refresh the page" workaround works if I have only one edit tab, but not when I h... [04:18:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: Have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#4016509 (10Alsee) Adding [[ https://www.mediawiki.org/wiki/Topic:U8j21ma3ihrdjhk8 | another complain... [06:02:33] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-Performance, 10MediaWiki-extensions-CodeMirror: Problems with editing huge pages - https://phabricator.wikimedia.org/T184857#4016603 (10Niharika) [06:51:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-CodeMirror: CodeMirror on NWE: pasting problems from one surface to another - line size? - https://phabricator.wikimedia.org/T175961#4016639 (10Niharika) [07:46:35] (03PS5) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [07:48:38] (03CR) 10jerkins-bot: [V: 04-1] WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [07:52:57] 10VisualEditor, 10VisualEditor-VisualDiffs: Repeated, but unchanged headlines not grayed out in visual diff - https://phabricator.wikimedia.org/T188702#4016722 (10Schnark) [10:18:22] 10VisualEditor, 10VisualEditor-VisualDiffs: Repeated, but unchanged headlines not grayed out in visual diff - https://phabricator.wikimedia.org/T188702#4016964 (10Schnark) [10:21:28] (03PS6) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [10:23:36] (03CR) 10jerkins-bot: [V: 04-1] WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [10:41:41] 10VisualEditor, 10VisualEditor-DataModel: Annotation ordering is hazily defined - https://phabricator.wikimedia.org/T188709#4016992 (10dchan) [10:43:45] 10VisualEditor, 10VisualEditor-DataModel: Annotation ordering is hazily defined - https://phabricator.wikimedia.org/T188709#4017012 (10dchan) @Esanders suggests we could change our annotation transactions to define the whole annotation array before and after. So the unbold transaction in the above example woul... [10:49:12] 10VisualEditor, 10VisualEditor-DataModel: Annotation ordering is hazily defined - https://phabricator.wikimedia.org/T188709#4017059 (10dchan) [11:07:14] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): CTRL+D (forwards delete) on OSX at end of line causes model/view de-sync - https://phabricator.wikimedia.org/T187920#4017123 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [11:09:29] 10VisualEditor: External link icon appearing twice - https://phabricator.wikimedia.org/T188656#4017131 (10Deskana) 05Open>03stalled p:05Triage>03Normal I can't reproduce this in my sandbox on the English Wikipedia. How are you inserting the link, and what does it look like before and after you save? [11:34:59] 10Editing-team, 10VisualEditor, 10WikiEditor, 10Contributors-Team, and 2 others: Edit conflict not shown/detected - https://phabricator.wikimedia.org/T188713#4017203 (10jcrespo) [11:37:56] 10Editing-team, 10VisualEditor, 10WikiEditor, 10Contributors-Team, and 3 others: Edit conflict not shown/detected - https://phabricator.wikimedia.org/T188713#4017230 (10jcrespo) Other conflicts not detected: T100912 T119985 [11:40:41] 10VisualEditor, 10ContentTranslation, 10Language-2018-Jan-Mar: Integrate editing toolbar in the tools column in Content Translation - https://phabricator.wikimedia.org/T176422#3624629 (10Petar.petkovic) After [[https://gerrit.wikimedia.org/r/#/c/413702/|this patch]], editing toolbar is integrated into tools... [12:07:53] 10VisualEditor, 10ContentTranslation, 10Language-2018-Jan-Mar, 10User-Ryasmeen: Integrate editing toolbar in the tools column in Content Translation - https://phabricator.wikimedia.org/T176422#4017320 (10Pginer-WMF) 05stalled>03Resolved a:03Pginer-WMF >>! In T176422#4017243, @Petar.petkovic wrote: >... [12:34:09] 10VisualEditor, 10MediaWiki-Interface: Edit summary box should be a multiline input - https://phabricator.wikimedia.org/T99944#4017392 (10Anomie) [12:56:19] 10VisualEditor: Modifications to gallery properties are not retained upon reloading the editor - https://phabricator.wikimedia.org/T188655#4015213 (10Esanders) Probably fixed by https://gerrit.wikimedia.org/r/#/q/f5c88eb30 [12:56:32] 10VisualEditor: Reloading the editor does not retain the changes related with maps/hiero/musical notation - https://phabricator.wikimedia.org/T188654#4015194 (10Esanders) Probably fixed by https://gerrit.wikimedia.org/r/#/q/f5c88eb30 [12:59:10] 10VisualEditor: Refreshing the editor does not retain the changes related with any template, shows error "Change recovery failed" - https://phabricator.wikimedia.org/T188653#4015183 (10Esanders) Probably fixed by https://gerrit.wikimedia.org/r/#/q/f5c88eb30 [12:59:26] 10VisualEditor: Reloading the editor does not retain the changes related with maps/hiero/musical notation - https://phabricator.wikimedia.org/T188654#4017436 (10Esanders) [12:59:28] 10VisualEditor: Refreshing the editor does not retain the changes related with any template, shows error "Change recovery failed" - https://phabricator.wikimedia.org/T188653#4017438 (10Esanders) [12:59:37] 10VisualEditor: Modifications to gallery properties are not retained upon reloading the editor - https://phabricator.wikimedia.org/T188655#4017440 (10Esanders) [12:59:39] 10VisualEditor: Refreshing the editor does not retain the changes related with any template, shows error "Change recovery failed" - https://phabricator.wikimedia.org/T188653#4015183 (10Esanders) [13:05:55] (03CR) 10Esanders: [C: 032] ve.ce.MWBlockImageNode: Fix handling of borders [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415486 (owner: 10Bartosz Dziewoński) [13:09:42] 10VisualEditor, 10Patch-For-Review: VisualEditor/NWE should show larger dialogs for edit notices and AbuseFilter messages - https://phabricator.wikimedia.org/T184379#3881476 (10Deskana) I'm willing to increase the size slightly to help alleviate the problem. I'm not saying that that'll be the end of the change... [13:12:56] 10VisualEditor, 10Patch-For-Review: VisualEditor/NWE should show larger dialogs for edit notices and AbuseFilter messages - https://phabricator.wikimedia.org/T184379#4017466 (10Deskana) That said, I think that 450px, a ~40% increase, is way too much for a small, iterative change. {F14287575} {F14287425} [13:15:50] (03Merged) 10jenkins-bot: ve.ce.MWBlockImageNode: Fix handling of borders [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415486 (owner: 10Bartosz Dziewoński) [13:18:11] (03CR) 10jenkins-bot: ve.ce.MWBlockImageNode: Fix handling of borders [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415486 (owner: 10Bartosz Dziewoński) [13:19:27] (03CR) 10Deskana: [C: 04-1] "This patch accidentally removes the little "n notices" and the button to close the window at the top of the edit notice popup." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415364 (https://phabricator.wikimedia.org/T184379) (owner: 10Esanders) [13:22:56] 10VisualEditor, 10VisualEditor-DataModel: Annotation ordering is hazily defined in Transactions - https://phabricator.wikimedia.org/T188709#4017500 (10dchan) [13:23:57] 10VisualEditor, 10VisualEditor-VisualDiffs: Message about references defined in templates not being editable is sub-optimal in historical visual diffs. - https://phabricator.wikimedia.org/T188682#4017511 (10Deskana) [13:24:05] 10VisualEditor, 10VisualEditor-VisualDiffs: Message about references defined in templates not being editable is sub-optimal in historical visual diffs. - https://phabricator.wikimedia.org/T188682#4016071 (10Deskana) p:05Triage>03Normal Screenshot from the above diff, showing the issue: {F14288666} [13:24:57] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Message about references defined in templates not being editable is sub-optimal in historical visual diffs. - https://phabricator.wikimedia.org/T188682#4017515 (10Deskana) [13:30:02] (03PS2) 10Esanders: Make edit notices popup wider (320 -> 450) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415364 (https://phabricator.wikimedia.org/T184379) [14:04:04] 10VisualEditor, 10VisualEditor-DataModel: Annotation ordering is hazily defined in Transactions - https://phabricator.wikimedia.org/T188709#4017691 (10dchan) [15:18:23] (03PS1) 10Esanders: Handle errors in storeDocState better [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415864 [15:25:30] (03PS1) 10Esanders: Replace node instanceof ve.dm.TextNode with node.type === 'text' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415867 [15:42:54] (03PS1) 10Esanders: Only run checkLinearOffset in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415871 [16:24:53] (03CR) 10Divec: [C: 032] Only run checkLinearOffset in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415871 (owner: 10Esanders) [16:27:38] (03Merged) 10jenkins-bot: Only run checkLinearOffset in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415871 (owner: 10Esanders) [16:30:42] (03CR) 10jenkins-bot: Only run checkLinearOffset in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415871 (owner: 10Esanders) [16:30:53] (03CR) 10Divec: [C: 032] Replace node instanceof ve.dm.TextNode with node.type === 'text' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415867 (owner: 10Esanders) [16:33:42] (03Merged) 10jenkins-bot: Replace node instanceof ve.dm.TextNode with node.type === 'text' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415867 (owner: 10Esanders) [16:35:15] 10Editing-team, 10VisualEditor, 10WikiEditor, 10Contributors-Team, 10MediaWiki-Page-editing: Edit conflict not shown/detected - https://phabricator.wikimedia.org/T188713#4018271 (10MichaelSchoenitzer_WMDE) Could maybe this T186152 be connected? [16:35:19] 10Editing-team, 10VisualEditor, 10WikiEditor, 10Contributors-Team, 10MediaWiki-Page-editing: Edit conflict not shown/detected - https://phabricator.wikimedia.org/T188713#4018274 (10Lea_WMDE) So we looked into the first report (the one by Uwe Rohledder) and could not reproduce the issue :/ He also now [[... [16:35:45] (03CR) 10jenkins-bot: Replace node instanceof ve.dm.TextNode with node.type === 'text' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415867 (owner: 10Esanders) [16:40:39] 10VisualEditor, 10VisualEditor-DataModel: Annotation ordering is hazily defined in Transactions - https://phabricator.wikimedia.org/T188709#4018300 (10dchan) OTOH the theoretical logic perspective is that treating all annotations as ordered, and losing some clarity of intent in the transactions in order to pre... [16:48:13] (03PS4) 10Jforrester: docs: Convert multi-line comments to /**/ syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415072 [16:48:18] (03PS3) 10Jforrester: docs: Replace fake ellipses with real ones (or in one case, a vertical one) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415073 [17:36:58] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: Syntax highlighting with old editor breaks Firefox's spell checker - https://phabricator.wikimedia.org/T188757#4018542 (10Bencemac) [17:43:13] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: Syntax highlighting with old editor breaks Firefox's spell checker - https://phabricator.wikimedia.org/T188757#4018542 (10MusikAnimal) I believe spell checking on Firefox / non-Mac was disabled with https://gerrit... [17:59:28] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: Syntax highlighting with old editor breaks Firefox's spell checker - https://phabricator.wikimedia.org/T188757#4018644 (10Bencemac) @MusikAnimal Thanks, you are right! Then we have to wait till they fix it. [18:15:39] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: Syntax highlighting with old editor breaks Firefox's spell checker - https://phabricator.wikimedia.org/T188757#4018720 (10Aklapper) Is this the same as T177509? If so, could you mark T177509 as a duplicate (via {... [18:16:24] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: Syntax highlighting with old editor breaks Firefox's spell checker - https://phabricator.wikimedia.org/T188757#4018542 (10Niharika) I believe this will be fixed if we fix {T184467} or more specifically, T184467#39... [18:16:45] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: Syntax highlighting with old editor breaks Firefox's spell checker - https://phabricator.wikimedia.org/T188757#4018733 (10Niharika) [18:33:19] (03CR) 10Esanders: [C: 04-1] ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415487 (owner: 10Bartosz Dziewoński) [18:34:22] (03CR) 10Jforrester: [C: 032] ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415785 (owner: 10Bartosz Dziewoński) [18:39:42] (03PS1) 10Jforrester: Update VE core submodule to master (17721d5f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415911 [18:42:32] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (17721d5f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415911 (owner: 10Jforrester) [18:52:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (17721d5f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415911 (owner: 10Jforrester) [18:54:32] (03CR) 10jenkins-bot: Update VE core submodule to master (17721d5f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415911 (owner: 10Jforrester) [21:12:38] 10Editing-team, 10VisualEditor, 10WikiEditor, 10Contributors-Team, 10MediaWiki-Page-editing: Edit conflict not shown/detected - https://phabricator.wikimedia.org/T188713#4019184 (10Cirdan) [21:35:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415978 (owner: 10L10n-bot) [22:40:09] 10VisualEditor: Modifications to gallery properties are not retained upon reloading the editor - https://phabricator.wikimedia.org/T188655#4019476 (10Ryasmeen) Fixed now. [22:40:29] 10VisualEditor, 10Verified: Modifications to gallery properties are not retained upon reloading the editor - https://phabricator.wikimedia.org/T188655#4019477 (10Ryasmeen) [22:44:26] 10VisualEditor, 10Verified: Reloading the editor does not retain the changes related with maps/hiero/musical notation - https://phabricator.wikimedia.org/T188654#4019490 (10Ryasmeen) [22:49:20] 10VisualEditor: External link icon appearing twice - https://phabricator.wikimedia.org/T188656#4019495 (10Ryasmeen) Here are the screenshots: Before saving: {F14325665} After saving: {F14325683} [22:49:36] 10VisualEditor: External link icon appearing twice - https://phabricator.wikimedia.org/T188656#4019496 (10Ryasmeen) 05stalled>03Open [23:38:23] 10VisualEditor: [Regression pre-wmf.24] Labels for "Minor edit" and "Watch page" checkboxes are missing after reloading the editor with unsaved changes - https://phabricator.wikimedia.org/T188796#4019769 (10Ryasmeen) [23:40:40] (03PS1) 10Legoktm: Use SPDX 3.0 license identifier [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/416128 (https://phabricator.wikimedia.org/T183858) [23:41:29] (03CR) 10Legoktm: "@Krinkle: Is this supposed to be GPL-2.0-only or -or-later?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/416128 (https://phabricator.wikimedia.org/T183858) (owner: 10Legoktm) [23:43:21] 10VisualEditor-EditingTools, 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), 10User-Ryasmeen, 10Verified, and 3 others: Gallery with no images (invalid characters as gallery contents) creates an invisible node and can't be edited - https://phabricator.wikimedia.org/T75230#4019819 (10Ryasmee... [23:53:26] (03PS1) 10Legoktm: Use SPDX 3.0 license identifier [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/416168 (https://phabricator.wikimedia.org/T183858) [23:59:28] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), 10Verified, 10Verified-in-Phase0, and 2 others: tempWikitextEditor doesn't work well when adding new section - https://phabricator.wikimedia.org/T185633#4019943 (10Ryasmeen)