[01:16:25] how do i load my script before visualeditor finished loading, ideally as quickly as the user clicks 'edit'? i'd like to modify appearance of the progress bar in my user script [01:16:46] "mw.loader.using( 'ext.visualEditor.desktopArticleTarget.init', function () {" seems to be too late [01:17:13] 10VisualEditor-MediaWiki-Templates, 10VisualEditor (Current work): Invisible templates are unexpectedly large - https://phabricator.wikimedia.org/T189267#4037276 (10DLynch) a:03DLynch Let's see... bisect says introduced in 55a30052a89e2a662568f90acaf40d9e8763b0b5, which was an update-submodule commit, and lo... [01:17:34] as a test, i put `$('.ve-init-mw-desktopArticleTarget-loading-overlay').hide();` into my script to remove the progress bar completely, so it looks ike this: http://dpaste.com/3K59GBW.txt but the progress bar is still shown [01:19:57] please help :-) i'm not sure how to find this information myself [01:30:26] (03PS1) 10DLynch: ce.MWTransclusionNode: increase invisible selector specificity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417479 (https://phabricator.wikimedia.org/T189267) [01:38:55] Sveta: I'd suspect you're in there slightly too soon going off of .init like that -- the progress bar won't actually exist at the moment you run it. Try `ext.visualEditor.targetLoader` instead? [01:40:13] There's not a good hook in there for specifically this case, but that should approximate it. [01:45:45] hi Kemayo :-) i'm testing it out, i don't think it fires on time. i've made it hide #content so that i can assess the timing visually easier, the content gets hidden only after the progress bar disappears. [01:45:50] current version, http://dpaste.com/1GCG79J.txt [01:47:05] i'm using timeless skin, so having the progress bar show in the search bar -- without obscuring the page -- would be easier for me. but i would need to get the timing right. (as a workaround i'm considering listening for clicks on the 'edit' tab, that might work 'better' in some ways.) [01:47:54] but then i'd like to listen for its width changes, i've found https://stackoverflow.com/questions/9628450/jquery-how-to-determine-if-a-div-changes-its-height-or-any-css-attribute but it is a bit ugly, i was hoping resize() would already pick it up https://jsfiddle.net/ca6111s8/3/ [01:48:13] perhaps you know of a good hook to the progress bar changes Kemayo? [01:49:28] brb [01:55:44] Sveta: There's always the delightful approach of using a MutationObserver on the `html` node, watching for the `ve-loading` class being added to it. [02:02:24] https://www.irccloud.com/pastebin/Gps1l15o/ [02:02:32] Not that I've *tested* this. :D [02:05:42] Okay, having actually tested it, it does seem to do approximately the right thing. It's a horrible hack, of course, but I think it'd work. [02:10:46] Conveniently, about two weeks ago we dropped IE10 support, so I can make this suggestion without technically having it not work on all supported browsers. [02:16:41] Same technique could be exploited to observe the loading progress changes, since that's technically just a change to the `style` attribute on the bar... [02:52:17] (03CR) 10jenkins-bot: build: Updating jakub-onderka/php-parallel-lint to 1.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417484 (owner: 10Libraryupgrader) [04:09:01] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4037387 (10Liuxinyu970226) [04:21:03] Kemayo: thank you :-) for ve-loading class it works, for ve-init-mw-desktopArticleTarget-progress-bar class for some reason it does not (the only change in your code, changing the class name) [04:25:08] actually i think i get it. it's a class for the html tag. it doesn't listen for classes of its children or children's children. [05:07:53] Sveta: Yeah, you have to pass the specific node you're listening to into the `observer.observe` call. [05:17:18] yes i got it working now :-) thank you :-) [05:17:23] playing with some css now :-) [05:17:35] what timezone are you in if i may ask? i'm in utc+11 or so (.au/sydney) [05:33:06] UTC-5, so you sort of lucked out with me working in my evening here. [05:37:19] ok :-) [05:53:40] i added https://www.mediawiki.org/wiki/Topic:U90fahk0d74jp9rh Remove jumpiness in the layout when activating and deactivating Visual Editor [08:53:39] (03CR) 10TheDJ: Use sessionStorage to auto-save (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413249 (https://phabricator.wikimedia.org/T57370) (owner: 10Esanders) [09:00:46] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#1531170 (10TheDJ) I have 4... [09:08:38] (03PS1) 10Zfilipin: build: Use new version of commons_upload Ruby gem for language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) [09:15:05] (03CR) 10Esanders: [C: 032] ce.MWTransclusionNode: increase invisible selector specificity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417479 (https://phabricator.wikimedia.org/T189267) (owner: 10DLynch) [09:16:37] (03CR) 10jerkins-bot: [V: 04-1] build: Use new version of commons_upload Ruby gem for language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) (owner: 10Zfilipin) [09:24:13] (03Merged) 10jenkins-bot: ce.MWTransclusionNode: increase invisible selector specificity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417479 (https://phabricator.wikimedia.org/T189267) (owner: 10DLynch) [09:26:50] (03CR) 10jenkins-bot: ce.MWTransclusionNode: increase invisible selector specificity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417479 (https://phabricator.wikimedia.org/T189267) (owner: 10DLynch) [09:31:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-Disambiguator, 10Easy: In the "Page Settings" menu, "This is a disambiguation page" is not adequately explained to the user - https://phabricator.wikimedia.org/T187116#4037635 (10Schnark) >>! In T187116#4035235, @TheDJ wrot... [09:33:53] (03PS2) 10Zfilipin: build: Use new version of commons_upload Ruby gem for language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) [09:35:29] (03CR) 10Zfilipin: "Looks like mwext-ruby-jessie is still on Jessie and it has Ruby 2.1.0. commons_upload requires Ruby 2.3. :|" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) (owner: 10Zfilipin) [09:37:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-Disambiguator, 10Easy: In the "Page Settings" menu, "This is a disambiguation page" is not adequately explained to the user - https://phabricator.wikimedia.org/T187116#4037644 (10TheDJ) Well being in use, is something alrea... [09:42:01] (03CR) 10jerkins-bot: [V: 04-1] build: Use new version of commons_upload Ruby gem for language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) (owner: 10Zfilipin) [10:01:53] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Enabling Citoid on Marathi wiki, and way forward to it - https://phabricator.wikimedia.org/T188329#4037668 (10Tiven2240) @Mvolz I have done the necessary changes needed for templates and it's template Data. Is there anything more to be done? Please re-e... [10:12:03] 10VisualEditor-CopyPaste, 10Browser-Support-Firefox, 10Technical-Debt, 10VisualEditor (Current work): VisualEditor karma test fails on Firefox v52 - https://phabricator.wikimedia.org/T182626#4037680 (10Jdforrester-WMF) a:03Esanders [10:12:19] 10VisualEditor-CopyPaste, 10Browser-Support-Firefox, 10MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), 10VisualEditor (Current work): Pasting table rows fails in Firefox 59 - https://phabricator.wikimedia.org/T189201#4037682 (10Jdforrester-WMF) [10:12:53] (03PS1) 10Jforrester: ce.MWTransclusionNode: increase invisible selector specificity [extensions/VisualEditor] (wmf/1.31.0-wmf.24) - 10https://gerrit.wikimedia.org/r/417775 (https://phabricator.wikimedia.org/T189267) [10:13:29] 10VisualEditor-MediaWiki-Templates, 10MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), 10Patch-For-Review, 10VisualEditor (Current work): Invisible templates are unexpectedly large - https://phabricator.wikimedia.org/T189267#4037013 (10Jdforrester-WMF) Made a back-port, but I won't be around... [10:18:25] (03PS1) 10Jforrester: Update VE core submodule to master (3aabb95af) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417776 (https://phabricator.wikimedia.org/T188389) [10:42:20] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (3aabb95af) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417776 (https://phabricator.wikimedia.org/T188389) (owner: 10Jforrester) [10:56:19] 10VisualEditor: support custom wikilink procedure per-wiki - https://phabricator.wikimedia.org/T188871#4037741 (10Elitre) 05duplicate>03Open [10:57:30] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Design, 10User-Ryasmeen: Adding a link with an interwiki prefix in VE doesn't work - https://phabricator.wikimedia.org/T133535#4037742 (10Elitre) I believe I reopened that, please do other necessary changes. [11:23:58] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4037783 (10Deskana) >>! In... [11:41:56] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4037817 (10TheDJ) >>! In T... [11:46:57] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4037827 (10TheDJ) I just e... [11:56:10] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4037861 (10TheDJ) Also, I... [11:57:09] (03CR) 10Jayprakash12345: [C: 031] ApiVisualEditor: Replace use of ApiBase::dieUsage() with ::dieWithError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417355 (https://phabricator.wikimedia.org/T189205) (owner: 10Jforrester) [13:20:15] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Enabling Citoid on Marathi wiki, and way forward to it - https://phabricator.wikimedia.org/T188329#4038070 (10Mvolz) >>! In T188329#4037668, @Tiven2240 wrote: > @Mvolz I have done the necessary changes needed for templates and it's template Data. Is the... [14:09:49] 10VisualEditor, 10Regression: Regression: Changes made in Wikieditor are lost when switching back to VisualEditor - https://phabricator.wikimedia.org/T189254#4038164 (10Deskana) p:05Triage>03High This appears to be a side effect of the recent edit recovery work, as the "Changes recovered" message is shown... [15:24:46] 10VisualEditor-CopyPaste, 10Browser-Support-Firefox, 10Technical-Debt, 10VisualEditor (Current work): VisualEditor karma test fails on Firefox v52 - https://phabricator.wikimedia.org/T182626#4038311 (10Deskana) 05Open>03Resolved [15:24:56] 10VisualEditor-DataModel, 10Technical-Debt, 10VisualEditor (Current work): Write unit tests for autosave methods in DM surface - https://phabricator.wikimedia.org/T189104#4038312 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [15:53:39] 10Citoid, 10VisualEditor: Enabling Citoid on Marathi wiki, and way forward to it - https://phabricator.wikimedia.org/T188329#4038434 (10Tiven2240) The translation of the same will be done in due period of time. I request you that the messages that was disabled should be enabled so we may ensure that whether th... [17:08:19] (03CR) 10Esanders: [C: 032] ApiVisualEditor: Replace use of ApiBase::dieUsage() with ::dieWithError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417355 (https://phabricator.wikimedia.org/T189205) (owner: 10Jforrester) [17:08:28] (03CR) 10Esanders: [C: 032] i18n: Sort messages alphabetically for easier updates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417354 (owner: 10Jforrester) [17:39:53] (03Merged) 10jenkins-bot: i18n: Sort messages alphabetically for easier updates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417354 (owner: 10Jforrester) [17:41:44] (03CR) 10jenkins-bot: i18n: Sort messages alphabetically for easier updates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417354 (owner: 10Jforrester) [17:56:17] 10VisualEditor-CopyPaste, 10VisualEditor (Current work): Cutting and pasting some text on a small number of articles emits JS error and doesn't let you save - https://phabricator.wikimedia.org/T187690#3982573 (10Parkywiki) Can I add that, following my report yesterday to the Village Pump (linked to by User:The... [19:10:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), 10Patch-For-Review: NWE: Categories, language links and indicators are missing in preview - https://phabricator.wikimedia.org/T153534#2883444 (10Whatamidoing-WMF) Categories are show... [19:14:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: NWE should implement a replacement for "Templates used on this page" feature - https://phabricator.wikimedia.org/T154598#4038988 (10Whatamidoing-WMF) [19:14:12] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: "Templates used" doesn't get updated - https://phabricator.wikimedia.org/T189322#4038977 (10Whatamidoing-WMF) [19:14:14] 10VisualEditor-MediaWiki-References, 10MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), 10Patch-For-Review, 10Performance, and 2 others: Wikis using template-generated references no longer seeing ref list contents while editing - https://phabricator.wikimedia.org/T187495#4038991 (10IKhitron)... [20:02:33] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), and 2 others: Pasting annotated wikitext results in double encoding and therefore s - https://phabricator.wikimedia.org/T153315#2889309 (10kaldari)... [20:45:39] (03CR) 10DLynch: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417776 (https://phabricator.wikimedia.org/T188389) (owner: 10Jforrester) [21:11:53] (03CR) 10Esanders: [C: 032] ApiVisualEditor: Replace use of ApiBase::dieUsage() with ::dieWithError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417355 (https://phabricator.wikimedia.org/T189205) (owner: 10Jforrester) [21:17:57] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (3aabb95af) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417776 (https://phabricator.wikimedia.org/T188389) (owner: 10Jforrester) [21:20:10] (03CR) 10Bartosz Dziewoński: [C: 032] LinkCache: styleParsoidElements find mw:WikiLink with ~= [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417175 (https://phabricator.wikimedia.org/T189175) (owner: 10DLynch) [21:21:51] (03CR) 10Bartosz Dziewoński: [C: 032] Update rel attribute checks to be aware of multiple rel values [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417297 (owner: 10DLynch) [21:25:25] (03CR) 10jerkins-bot: [V: 04-1] ApiVisualEditor: Replace use of ApiBase::dieUsage() with ::dieWithError() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417355 (https://phabricator.wikimedia.org/T189205) (owner: 10Jforrester) [21:32:24] (03CR) 10Esanders: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417355 (https://phabricator.wikimedia.org/T189205) (owner: 10Jforrester) [21:40:07] (03Merged) 10jenkins-bot: Update VE core submodule to master (3aabb95af) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417776 (https://phabricator.wikimedia.org/T188389) (owner: 10Jforrester) [21:42:13] (03CR) 10jenkins-bot: Update VE core submodule to master (3aabb95af) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417776 (https://phabricator.wikimedia.org/T188389) (owner: 10Jforrester) [21:44:52] (03Merged) 10jenkins-bot: LinkCache: styleParsoidElements find mw:WikiLink with ~= [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417175 (https://phabricator.wikimedia.org/T189175) (owner: 10DLynch) [21:44:54] (03Merged) 10jenkins-bot: Update rel attribute checks to be aware of multiple rel values [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417297 (owner: 10DLynch) [21:45:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418126 (owner: 10L10n-bot) [21:47:38] (03CR) 10jenkins-bot: LinkCache: styleParsoidElements find mw:WikiLink with ~= [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417175 (https://phabricator.wikimedia.org/T189175) (owner: 10DLynch) [21:49:33] (03CR) 10jenkins-bot: Update rel attribute checks to be aware of multiple rel values [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417297 (owner: 10DLynch) [21:51:59] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Visual diff: Provide a more detailed description of template changes - https://phabricator.wikimedia.org/T188389#4039354 (10DLynch) With that richer content, we get: {F14874717} Each of these list-items is the base `dm.Model`'s... [22:29:50] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4039413 (10Kerry_Raymond) [22:30:40] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4039424 (10Kerry_Raymond) [22:31:36] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4039413 (10Kerry_Raymond) [22:31:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: Have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#4039442 (10Esanders) [22:32:56] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4039446 (10Kerry_Raymond) [22:33:29] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4039413 (10Kerry_Raymond) [22:36:21] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4039452 (10Kerry_Raymond) And I think the logs need to be examined to see...