[00:32:22] 10VisualEditor, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps), 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Editing a whose GeoJSON has a wikitext link in the title of a point dirty-diffs the link to an H... - https://phabricator.wikimedia.org/T187230#4039743 [01:55:22] 10Citoid, 10VisualEditor: Enabling Citoid on Marathi wiki, and way forward to it - https://phabricator.wikimedia.org/T188329#4039823 (10Tiven2240) {F14904666} >>! In T188329#4038070, @Mvolz wrote: >>>! In T188329#4037668, @Tiven2240 wrote: >> @Mvolz I have done the necessary changes needed for templates and i... [02:20:20] 10VisualEditor, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps), and 2 others: Editing a whose GeoJSON has a wikitext link in the title of a point dirty-diffs the link to an HTML link - https://phabricator.wikimedia.org/T187230#3968657 (10Catrope) a:03Catrope [06:05:29] (03CR) 10jenkins-bot: build: Updating jakub-onderka/php-parallel-lint to 1.0.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/418377 (owner: 10Libraryupgrader) [08:01:47] edsanders, Deskana , Kemayo , Sorry for the ping, but wonder if Potentially panick-worthy lost-work bug here:  https://phabricator.wikimedia.org/T189337 is Unbreak Now? Thanks. [09:30:17] (can't login from phone, or I'd change prio myself) [10:08:26] (03PS8) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [10:10:55] (03CR) 10jerkins-bot: [V: 04-1] WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [13:29:59] (03CR) 10Esanders: "It is now" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413249 (https://phabricator.wikimedia.org/T57370) (owner: 10Esanders) [13:38:29] (03PS1) 10Esanders: Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418582 [13:42:23] (03CR) 10Jforrester: [C: 032] Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418582 (owner: 10Esanders) [13:46:35] (03PS2) 10Esanders: Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418582 [13:47:23] (03CR) 10Jforrester: [C: 032] Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418582 (owner: 10Esanders) [13:49:59] (03Merged) 10jenkins-bot: Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418582 (owner: 10Esanders) [13:52:29] (03CR) 10jenkins-bot: Follow-up Icf2d948bc9: Only reset lastStoredChange in storeDocState if using latest HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418582 (owner: 10Esanders) [13:54:21] (03PS1) 10Jforrester: Update VE core submodule to master (01609bfaa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418586 [13:55:15] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (01609bfaa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418586 (owner: 10Jforrester) [14:04:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (01609bfaa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418586 (owner: 10Jforrester) [14:06:53] (03CR) 10jenkins-bot: Update VE core submodule to master (01609bfaa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418586 (owner: 10Jforrester) [14:53:17] (03PS1) 10Esanders: Autosave: Check html === undefined to avoid matching empty string [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418587 [15:27:08] (03CR) 10Tchanders: Make gallery dialog work with native gallery implementation (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [15:55:24] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design, 10VisualEditor (Current work): Have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#4040320 (10Esanders) [16:20:40] (03PS1) 10Esanders: Remove unnecessary attachToolbarSaveButton override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418588 [16:20:42] (03PS1) 10Esanders: Factor out isSaveable method from updateToolbarSaveButtonState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418589 [16:20:44] (03PS1) 10Esanders: Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 [16:20:46] (03PS1) 10Esanders: Create show preview/changes tools to show next to save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) [16:28:21] (03CR) 10jerkins-bot: [V: 04-1] Remove unnecessary attachToolbarSaveButton override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418588 (owner: 10Esanders) [16:32:35] (03CR) 10jerkins-bot: [V: 04-1] Create show preview/changes tools to show next to save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [16:39:23] (03CR) 10jerkins-bot: [V: 04-1] Factor out isSaveable method from updateToolbarSaveButtonState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418589 (owner: 10Esanders) [16:40:07] (03CR) 10jerkins-bot: [V: 04-1] Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [17:02:42] (03PS3) 10Esanders: ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415487 (owner: 10Bartosz Dziewoński) [17:04:30] (03PS3) 10Esanders: ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415785 (owner: 10Bartosz Dziewoński) [17:05:11] (03PS40) 10Esanders: Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [17:09:32] (03CR) 10jerkins-bot: [V: 04-1] ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415487 (owner: 10Bartosz Dziewoński) [17:11:37] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415785 (owner: 10Bartosz Dziewoński) [17:12:08] (03CR) 10jerkins-bot: [V: 04-1] Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [17:16:23] (03PS4) 10Esanders: ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415487 (owner: 10Bartosz Dziewoński) [17:16:25] (03PS4) 10Esanders: ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415785 (owner: 10Bartosz Dziewoński) [17:16:27] (03PS41) 10Esanders: Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [17:16:50] (03CR) 10Esanders: [C: 032] ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415487 (owner: 10Bartosz Dziewoński) [17:17:02] (03CR) 10Esanders: [C: 032] "ok - I misunderstood what the override was doing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415487 (owner: 10Bartosz Dziewoński) [17:17:10] (03CR) 10Esanders: [V: 032] ve.ui.MWGalleryDialog: Dedupe code for saving properties of each image [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415785 (owner: 10Bartosz Dziewoński) [17:28:34] (03Merged) 10jenkins-bot: ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415487 (owner: 10Bartosz Dziewoński) [17:30:22] (03CR) 10jenkins-bot: ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/415487 (owner: 10Bartosz Dziewoński) [17:39:24] (03CR) 10jerkins-bot: [V: 04-1] Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [17:46:50] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4039413 (10Esanders) > I made some changes but then realised that the chan... [17:49:08] 10VisualEditor: Close VE gracefully when the 'Article' tab is clicked - https://phabricator.wikimedia.org/T189380#4040411 (10Esanders) [17:51:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Clear VE autosave when making changes in 2010 editor - https://phabricator.wikimedia.org/T189381#4040429 (10Esanders) [17:51:48] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4040440 (10Esanders) Article tab issue: T189380 2010WTE switch issue: T189381 [17:56:53] (03PS4) 10Tchanders: Show timeout message if diff times out [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/416230 (https://phabricator.wikimedia.org/T180842) [18:05:42] (03PS1) 10Esanders: Clear auto-save when switching to fallback wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418597 (https://phabricator.wikimedia.org/T189381) [18:06:09] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Clear VE autosave when making changes in 2010 editor - https://phabricator.wikimedia.org/T189381#4040451 (10Esanders) p:05Triage>03High [18:07:34] (03CR) 10Tchanders: Show timeout message if diff times out (037 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/416230 (https://phabricator.wikimedia.org/T180842) (owner: 10Tchanders) [18:08:28] (03PS5) 10Tchanders: Show timeout message if diff times out [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/416230 (https://phabricator.wikimedia.org/T180842) [18:14:41] (03CR) 10Esanders: "Looks good, minor cosmetic suggestion." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/416230 (https://phabricator.wikimedia.org/T180842) (owner: 10Tchanders) [18:15:15] (03PS9) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [18:31:01] (03PS1) 10Esanders: Clear VE autosave whenever WikiEditor is loaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418599 (https://phabricator.wikimedia.org/T189381) [18:34:38] (03PS2) 10Esanders: Clear VE autosave whenever WikiEditor is loaded [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418599 (https://phabricator.wikimedia.org/T189381) [18:38:40] 10VisualEditor, 10VisualEditor-VisualDiffs: Display alien node changes in visual diff - https://phabricator.wikimedia.org/T188833#4040489 (10Tchanders) a:03Tchanders [19:07:37] (03PS1) 10Esanders: Attach deactivate code to namespace tab ('Main'/'Article') [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418601 (https://phabricator.wikimedia.org/T189380) [19:23:26] (03CR) 10Esanders: Attach deactivate code to namespace tab ('Main'/'Article') (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418601 (https://phabricator.wikimedia.org/T189380) (owner: 10Esanders) [20:09:30] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Display alien node changes in visual diff - https://phabricator.wikimedia.org/T188833#4040567 (10Tchanders) [20:10:05] (03PS1) 10Tchanders: Diff original dom elements for alien node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418604 (https://phabricator.wikimedia.org/T188833) [20:16:03] 10VisualEditor, 10Regression: VE overwriting edit conflicts - https://phabricator.wikimedia.org/T189387#4040570 (10Esanders) [20:16:16] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4040581 (10Esanders) > The VE happily saved it and there was no edit confl... [20:16:36] 10VisualEditor, 10Regression: VE overwriting edit conflicts - https://phabricator.wikimedia.org/T189387#4040570 (10Esanders) p:05Triage>03High [20:26:11] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Design: Provide a 'delete' button on focusable nodes in desktop - https://phabricator.wikimedia.org/T99862#1300571 (10Mattflaschen-Personal) Another person ran into this at an editathon (specifically, "clicking "show options" -- it showed an additional tr... [20:46:25] 10VisualEditor: "Publish changes" button is confusing in Draft namespace - https://phabricator.wikimedia.org/T189389#4040601 (10Mattflaschen-Personal) [20:50:52] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor leaves content HTML in place on connection loss - https://phabricator.wikimedia.org/T189390#4040611 (10Tgr) [21:11:14] 10VisualEditor: VisualEditor resolve conflicts and editor switch not working - https://phabricator.wikimedia.org/T189392#4040646 (10Mattflaschen-Personal) [21:17:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/418671 (owner: 10L10n-bot) [21:18:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418679 (owner: 10L10n-bot) [21:42:20] 10VisualEditor: Incorrect "Do you want to leave" message after saving - https://phabricator.wikimedia.org/T189393#4040659 (10Mattflaschen-Personal) [21:44:49] 10VisualEditor: watchthis displays key instead of message - https://phabricator.wikimedia.org/T189394#4040670 (10Mattflaschen-Personal) [22:22:33] 10VisualEditor, 10Regression: VE overwriting edit conflicts - https://phabricator.wikimedia.org/T189387#4040710 (10Esanders) 05Open>03Invalid [22:26:08] 10VisualEditor, 10Regression: VE overwriting edit conflicts - https://phabricator.wikimedia.org/T189387#4040711 (10Esanders) This was me being stupid and not noticing 'Note: Edit conflicts will be ignored if you are conflicting with the current user.' [22:31:12] 10VisualEditor, 10Technical-Debt: Use action=compare in VE wikitext diff instead of action=revisions - https://phabricator.wikimedia.org/T189397#4040712 (10Esanders) [22:31:54] 10VisualEditor, 10Technical-Debt: Use action=compare in VE wikitext diff instead of prop=revisions - https://phabricator.wikimedia.org/T189397#4040723 (10Esanders) [22:35:20] (03PS1) 10Esanders: Use action=compare for wikitext diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418698 (https://phabricator.wikimedia.org/T189397) [22:40:37] (03CR) 10Esanders: [C: 04-1] "need to test section edits, real conflicts" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418698 (https://phabricator.wikimedia.org/T189397) (owner: 10Esanders) [22:54:09] (03CR) 10Esanders: "I think this will handle conflicts very slightly differently. The old API didn't pass the oldid, and so showed you exactly the diff you wo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418698 (https://phabricator.wikimedia.org/T189397) (owner: 10Esanders) [22:58:59] 10VisualEditor: Visual Editor: displaying templates in Edit mode - https://phabricator.wikimedia.org/T189399#4040747 (10Kerry_Raymond) [23:03:31] (03PS1) 10Esanders: Disable visual diffs on source mode section edits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418701 (https://phabricator.wikimedia.org/T183938) [23:17:24] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4040760 (10Kerry_Raymond) When I train with the VE, it is a common questio...