[04:47:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting long content is many times slower than inserting the same content in a different way - https://phabricator.wikimedia.org/T189556#4045502 (10matmarex) [04:54:57] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome: Pasting long content is many times slower than inserting the same content in a different way - https://phabricator.wikimedia.org/T189556#4045518 (10matmarex) This might be a Chrome-only i... [04:57:00] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome: Pasting long content is many times slower than inserting the same content in a different way - https://phabricator.wikimedia.org/T189556#4045520 (10matmarex) Looking at the performance de... [05:04:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines - https://phabricator.wikimedia.org/T189557#4045524 (10matmarex) [06:14:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines - https://phabricator.wikimedia.org/T189557#4045587 (10matmarex) I investigated this a bit and this is caused by TreeModifier doing one ve.batchSplice on the line... [06:35:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines - https://phabricator.wikimedia.org/T189557#4045595 (10dchan) Thanks, @matmarex ! The purpose of the TreeModifier is to perform the linear modifiations in an orde... [07:22:57] 10VisualEditor-CopyPaste, 10VisualEditor (Current work): Cutting and pasting some text on a small number of articles emits JS error and doesn't let you save - https://phabricator.wikimedia.org/T187690#3982573 (10matmarex) Let's split the "Sonic X-treme" issue to a separate task, that one is easily reproducible... [07:34:01] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#2565211 (10Neil_P._Quinn_WM... [09:02:16] (03PS1) 10Bartosz Dziewoński: ve.dm.Converter: Handle meta nodes for empty annotations same as normal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) [09:27:49] (03CR) 10Divec: [C: 032] ve.dm.Converter: Handle meta nodes for empty annotations same as normal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) (owner: 10Bartosz Dziewoński) [09:28:38] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Should probably have a test case, I'm still working on that though" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) (owner: 10Bartosz Dziewoński) [09:29:48] (03CR) 10Divec: [C: 04-1] "Ok - looks good so far!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) (owner: 10Bartosz Dziewoński) [09:31:25] (03CR) 10Bartosz Dziewoński: [C: 04-2] "In fact, there is a test case for "empty annotation"… why was it not failing?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) (owner: 10Bartosz Dziewoński) [09:32:56] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Hmm, test code uses getFullData(), so the alienMetas are put back to their original places." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) (owner: 10Bartosz Dziewoński) [09:43:02] (03CR) 10Bartosz Dziewoński: "I'll look into that in a separate commit, let's merge this." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) (owner: 10Bartosz Dziewoński) [09:57:30] 10VisualEditor, 10MediaWiki-extensions-GettingStarted, 10New-Editor-Experiences: Avoid contradicting messages between Getting Started and Visual editor for new users - https://phabricator.wikimedia.org/T189569#4045873 (10Pginer-WMF) [10:15:22] (03PS2) 10Esanders: Show page title in preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419079 (https://phabricator.wikimedia.org/T189540) [10:21:52] (03CR) 10jerkins-bot: [V: 04-1] Show page title in preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419079 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [10:23:57] (03PS1) 10Esanders: Parse title in show preview using hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) [10:30:32] (03CR) 10jerkins-bot: [V: 04-1] Parse title in show preview using hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [10:34:13] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Hah, I actually found a minor bug in this while updating the tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) (owner: 10Bartosz Dziewoński) [10:41:48] 10VisualEditor: Turn off switching between editing modes if access to LocalStorage is restricted - https://phabricator.wikimedia.org/T189572#4045963 (10jeblad) [10:52:02] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines - https://phabricator.wikimedia.org/T189557#4046011 (10Esanders) p:05Triage>03Low [10:54:26] (03PS2) 10Bartosz Dziewoński: ve.dm.Converter: Handle meta nodes for empty annotations same as normal [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) [10:54:28] (03PS1) 10Bartosz Dziewoński: tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419145 [10:54:36] (03PS1) 10Bartosz Dziewoński: tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419146 [10:55:35] (03CR) 10Bartosz Dziewoński: "Tests: https://gerrit.wikimedia.org/r/419145 https://gerrit.wikimedia.org/r/419146 (The bug was that I was adding the "internal: { isInlin" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419121 (https://phabricator.wikimedia.org/T189118) (owner: 10Bartosz Dziewoński) [10:56:09] (03CR) 10Bartosz Dziewoński: tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419146 (owner: 10Bartosz Dziewoński) [10:56:26] (03CR) 10Bartosz Dziewoński: "@David These cases are weird:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419145 (owner: 10Bartosz Dziewoński) [10:58:41] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4046035 (10Deskana) I expe... [10:59:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Deleting (or cutting) entire page contents in NWE is very slow on pages with many lines - https://phabricator.wikimedia.org/T189557#4046037 (10Esanders) > We could also try representing wikitext documents as just one huge paragraph node with newlines... [11:00:12] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4046038 (10Deskana) >>! In... [11:01:49] 10VisualEditor: Turn off switching between editing modes if access to LocalStorage is restricted - https://phabricator.wikimedia.org/T189572#4046039 (10jeblad) [11:02:09] (03CR) 10jerkins-bot: [V: 04-1] tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419146 (owner: 10Bartosz Dziewoński) [11:04:41] 10VisualEditor: Turn off switching between editing modes if access to LocalStorage is restricted - https://phabricator.wikimedia.org/T189572#4046043 (10jeblad) [11:13:32] 10VisualEditor: Turn off switching between editing modes if access to LocalStorage is restricted - https://phabricator.wikimedia.org/T189572#4046054 (10jeblad) [11:17:10] 10VisualEditor-CopyPaste, 10VisualEditor (Current work): Cutting and pasting some text on a small number of articles emits JS error and doesn't let you save - https://phabricator.wikimedia.org/T187690#4046085 (10matmarex) Here's a much simpler page that is also affected by the issue: https://en.wikipedia.org/w... [11:17:28] 10VisualEditor-CopyPaste, 10VisualEditor (Current work): Copy-pasting section headings emits JS error and doesn't let you save - https://phabricator.wikimedia.org/T187690#4046087 (10matmarex) [11:19:31] (03CR) 10Esanders: "ping" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418601 (https://phabricator.wikimedia.org/T189380) (owner: 10Esanders) [11:20:16] 10VisualEditor: Turn off switching between editing modes if access to LocalStorage is restricted - https://phabricator.wikimedia.org/T189572#4046092 (10jeblad) Unless there are more specific information on how to reproduce I'm going to close this myself. [11:26:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Do not "recover" edits that were intentionally abandoned (`in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046112 (10Deskana) [11:27:43] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046131 (10Deskana) [11:27:55] (03CR) 10Esanders: "NB this is only the code for standalone demo. In mediawiki we always used mw.storage, which has try/catch." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413249 (https://phabricator.wikimedia.org/T57370) (owner: 10Esanders) [11:28:42] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4046134 (10Deskana) I file... [11:28:57] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046112 (10Deskana) [11:29:03] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046112 (10Deskana) p:05Triage>03High [11:29:40] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10Technical-Debt, 10VisualEditor (Current work): ApiVisualEditor.php should not use deprecated ApiBase::dieUsage - https://phabricator.wikimedia.org/T189205#4046141 (10Deskana) [11:29:56] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10Technical-Debt, 10VisualEditor (Current work): ApiVisualEditor.php should not use deprecated ApiBase::dieUsage - https://phabricator.wikimedia.org/T189205#4034963 (10Deskana) p:05Triage>03Normal [11:30:00] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4046143 (10Esanders) An ed... [11:30:29] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046112 (10Esanders) The 'Article' tab not working is T189380 [11:31:47] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046151 (10Esanders) > leave the article a different way, such as clicking "Random article"... [11:33:55] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046160 (10Deskana) >>! In T189576#4046146, @Esanders wrote: > The 'Article' tab not working... [11:34:14] 10VisualEditor, 10Patch-For-Review: Close VE gracefully when the 'Article' tab is clicked, so that changes are not "recovered" when they shouldn't be - https://phabricator.wikimedia.org/T189380#4046161 (10Deskana) [11:34:17] 10VisualEditor, 10Patch-For-Review: Close VE gracefully when the 'Article' tab is clicked, so that changes are not "recovered" when they shouldn't be - https://phabricator.wikimedia.org/T189380#4040411 (10Deskana) p:05Triage>03High a:03Esanders [11:34:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Close VE gracefully when the 'Article' tab is clicked, so that changes are not "recovered" when they shouldn't be - https://phabricator.wikimedia.org/T189380#4040411 (10Deskana) [11:34:48] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Close VE gracefully when the 'Article' tab is clicked, so that changes are not "recovered" when they shouldn't be - https://phabricator.wikimedia.org/T189380#4040411 (10Deskana) [11:42:20] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046210 (10Esanders) Investigating a little it appears that the onUnload event does run some... [11:47:28] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4046224 (10Esanders) Note... [11:56:11] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Show H1 page title when previewing in NWE - https://phabricator.wikimedia.org/T189540#4046267 (10Esanders) p:05Triage>03High [11:56:26] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Show H1 page title when previewing in NWE - https://phabricator.wikimedia.org/T189540#4045001 (10Esanders) p:05High>03Low [12:18:06] 10VisualEditor: Allow copy/paste of cell formatting in Visual Editor Tables - https://phabricator.wikimedia.org/T189583#4046352 (10Wittylama) [12:40:23] (03PS3) 10Zfilipin: build: Use new version of commons_upload Ruby gem for language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) [12:41:39] (03PS4) 10Zfilipin: build: Use new version of commons_upload Ruby gem for language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) [12:49:48] 10Cite, 10Internet-Archive, 10Parsoid, 10Reading-Admin, and 3 others: WIP RFC: Reference API requirements and options - https://phabricator.wikimedia.org/T130663#2142431 (10kchapman) Removing from the RFC workboard as this continues to appear to be stalled. [12:50:13] 10Cite, 10Internet-Archive, 10Parsoid, 10Reading-Admin, and 2 others: WIP RFC: Reference API requirements and options - https://phabricator.wikimedia.org/T130663#4046416 (10kchapman) [12:50:36] (03PS2) 10Esanders: Parse title in show preview using hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) [12:52:12] (03CR) 10jerkins-bot: [V: 04-1] build: Use new version of commons_upload Ruby gem for language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) (owner: 10Zfilipin) [12:54:16] (03PS1) 10Esanders: WIP recovery prompt [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 [12:57:11] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) (owner: 10Zfilipin) [13:05:03] (03CR) 10jerkins-bot: [V: 04-1] WIP recovery prompt [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (owner: 10Esanders) [13:07:43] (03CR) 10jerkins-bot: [V: 04-1] build: Use new version of commons_upload Ruby gem for language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417739 (https://phabricator.wikimedia.org/T189122) (owner: 10Zfilipin) [13:44:15] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4046592 (10TheDJ) >>! In T... [14:18:36] (03PS2) 10Esanders: Autosave recovery prompt [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 [14:25:24] (03CR) 10jerkins-bot: [V: 04-1] Autosave recovery prompt [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (owner: 10Esanders) [14:25:33] 10VisualEditor-CopyPaste, 10VisualEditor (Current work): Copy-pasting section headings emits JS error and doesn't let you save - https://phabricator.wikimedia.org/T187690#4046653 (10matmarex) a:05DLynch>03matmarex How this happens: ve.ce.Surface#afterPaste is handling the "Internal paste" case. The data to... [14:40:03] (03PS1) 10Bartosz Dziewoński: ve.dm.Node: Make #getOffsetPath not fail while rebuilding the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) [14:42:05] (03CR) 10Bartosz Dziewoński: "Everything I wrote in the commit message might be wrong. Please verify carefully that this makes sense :)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) (owner: 10Bartosz Dziewoński) [14:50:19] (03PS1) 10Bartosz Dziewoński: ve.ce.LinearSelection: Don't throw exceptions only to catch on the next line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419192 [14:58:04] MatmaRex: nice sleuthing on the heading paste problem ! [15:08:50] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046760 (10Esanders) I'm also not that keen on discarding changes based on the say so of the... [15:19:55] (03PS1) 10Esanders: Fix auto-save standalone demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419199 [15:19:57] (03PS1) 10Esanders: Auto-save: Save and restore last known selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419200 [15:26:00] 10VisualEditor: Failure to restore saved edit breaks selection - https://phabricator.wikimedia.org/T189595#4046824 (10DLynch) [15:28:42] 10VisualEditor: Tabs misformatted/merged in web browser at certain window sizes - https://phabricator.wikimedia.org/T189598#4046866 (10RoySmith) [15:29:48] thedj: thanks, it was interesting :) this is an easy kind of problem though, finding out why something happens. finding out why something *doesn't* happen is worse ;) [15:32:46] (03CR) 10jerkins-bot: [V: 04-1] Fix auto-save standalone demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419199 (owner: 10Esanders) [15:33:05] (03CR) 10jerkins-bot: [V: 04-1] Auto-save: Save and restore last known selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419200 (owner: 10Esanders) [15:40:58] 10Citoid, 10VisualEditor: Upgrade Citoid to Zotero 5.0.36 (or later) - https://phabricator.wikimedia.org/T189600#4046918 (10Pigsonthewing) [15:57:48] (03CR) 10DLynch: [C: 031] "Nice catch! This definitely fixes the symptoms. I'm looking through for side-effects now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) (owner: 10Bartosz Dziewoński) [15:59:25] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419199 (owner: 10Esanders) [16:00:16] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (owner: 10Esanders) [16:01:02] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419079 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [16:03:08] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419200 (owner: 10Esanders) [16:06:25] (03CR) 10DLynch: "ping" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417003 (https://phabricator.wikimedia.org/T188389) (owner: 10DLynch) [16:06:59] (03CR) 10jerkins-bot: [V: 04-1] Autosave recovery prompt [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (owner: 10Esanders) [16:07:01] (03CR) 10Esanders: ve.dm.Node: Make #getOffsetPath not fail while rebuilding the document (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) (owner: 10Bartosz Dziewoński) [16:15:27] (03CR) 10Bartosz Dziewoński: Attach deactivate code to namespace tab ('Main'/'Article') (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418601 (https://phabricator.wikimedia.org/T189380) (owner: 10Esanders) [16:16:46] (03CR) 10DLynch: [C: 031] "I'm satisfied there's no horrible side-effects here. Want to make the suggested performance improvements for the heck of it, or shall I ju" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) (owner: 10Bartosz Dziewoński) [16:19:26] (03CR) 10Esanders: [C: 031] Show timeout message if diff times out [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/416230 (https://phabricator.wikimedia.org/T180842) (owner: 10Tchanders) [16:27:49] 10VisualEditor, 10VisualEditor-Tables: Allow copy/paste of cell formatting in Visual Editor Tables - https://phabricator.wikimedia.org/T189583#4047102 (10jhsoby) [16:29:06] 10VisualEditor, 10VisualEditor-Tables: Allow copy/paste of cell formatting in Visual Editor Tables - https://phabricator.wikimedia.org/T189583#4046352 (10jhsoby) Maybe related to T54180? [16:39:18] (03CR) 10Bartosz Dziewoński: [C: 032] Attach deactivate code to namespace tab ('Main'/'Article') [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418601 (https://phabricator.wikimedia.org/T189380) (owner: 10Esanders) [16:39:52] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4039413 (10matmarex) >>! In T189337#4040760, @Kerry_Raymond wrote: > Howev... [16:46:36] (03CR) 10jerkins-bot: [V: 04-1] Attach deactivate code to namespace tab ('Main'/'Article') [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418601 (https://phabricator.wikimedia.org/T189380) (owner: 10Esanders) [16:59:10] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4046112 (10DLynch) We could add some UI feedback for the "changes have been made since your... [17:51:53] 10VisualEditor, 10VisualEditor-EditingTools, 10User-Ryasmeen: VisualEditor: "Use an Existing Reference" option remains disabled for a reference inside Media Settings while there is a reference available to re-use in the page - https://phabricator.wikimedia.org/T62919#4047427 (10matmarex) [17:51:55] 10Cite, 10VisualEditor, 10VisualEditor-Media, 10VisualEditor-MediaWiki: Impossible to reuse references inside an image caption (in the media dialog sub-editor) - https://phabricator.wikimedia.org/T188302#4047429 (10matmarex) [18:34:38] (03CR) 10Bartosz Dziewoński: [C: 031] "Ugh, ripping a toolgroup off a toolbar to graft it inside a button group. This is actually disgusting." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [18:44:45] (03PS2) 10Bartosz Dziewoński: ve.dm.Node: Make #getOffsetPath not fail while rebuilding the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) [18:44:51] (03CR) 10Bartosz Dziewoński: ve.dm.Node: Make #getOffsetPath not fail while rebuilding the document (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) (owner: 10Bartosz Dziewoński) [18:46:14] (03CR) 10Bartosz Dziewoński: Clarify the "Log" button label on the debug bar (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415688 (owner: 10Bartosz Dziewoński) [18:46:17] (03PS2) 10Bartosz Dziewoński: Clarify the "Log" button label on the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415688 [18:52:25] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.Node: Make #getOffsetPath not fail while rebuilding the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) (owner: 10Bartosz Dziewoński) [18:55:43] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Pasting in image caption with a repeated reference causes VE to crash - https://phabricator.wikimedia.org/T73214#4047620 (10matmarex) [18:55:46] 10VisualEditor, 10VisualEditor-Performance, 10Epic, 10Patch-For-Review, 10Technical-Debt: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#4047621 (10matmarex) [18:56:46] (03CR) 10Bartosz Dziewoński: "Looks like a CI issue and not a real failure – "npm ERR! nospc ENOSPC: no space left on device, open 'npm-debug.log.1830159903'"." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419189 (https://phabricator.wikimedia.org/T187690) (owner: 10Bartosz Dziewoński) [19:09:40] 10VisualEditor: Text disappearing after pasting - https://phabricator.wikimedia.org/T189514#4044095 (10matmarex) Based on the screenshots (very helpful!), this looks like the same heading copy-paste issue as T187690. The disappearing text is a bit different than described there, but it's possible – after the "ph... [19:09:55] 10VisualEditor: Text disappearing after pasting - https://phabricator.wikimedia.org/T189514#4047653 (10matmarex) [19:09:58] 10VisualEditor-CopyPaste, 10Patch-For-Review, 10VisualEditor (Current work): Copy-pasting section headings emits JS error and doesn't let you save - https://phabricator.wikimedia.org/T187690#3982573 (10matmarex) [19:12:05] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Find out why a tag are causing edits to get mangled - https://phabricator.wikimedia.org/T189118#4047658 (10matmarex) [19:20:10] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Text entered in WTE edit window is blurry/doubled - https://phabricator.wikimedia.org/T189614#4047685 (10Capt_Swing) [19:51:29] 10VisualEditor: Tabs misformatted/merged in web browser at certain window sizes - https://phabricator.wikimedia.org/T189598#4047764 (10Deskana) 05Open>03stalled Thanks for the bug report. Sadly, there's a few problems with this report which are making it hard for me to understand. > When the window isn't wi... [21:25:26] (03CR) 10Esanders: "Yup." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [21:52:05] (03CR) 10Esanders: "All stems from T163142" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [22:09:02] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4048147 (10Alsee) Report f... [22:39:51] 10VisualEditor: Tabs misformatted/merged in web browser at certain window sizes - https://phabricator.wikimedia.org/T189598#4048244 (10RoySmith) I think I just figured out part of it. I never noticed this before, but I'm guessing the "More" tab is a general-purpose overflow menu, for all items that didn't fit o... [22:57:59] 10VisualEditor: [Regression wmf.24] Change recovery is failing to recover the edit with error "Error: Failed to restore auto-saved session: Error: Removed data not as expected" - https://phabricator.wikimedia.org/T189270#4048295 (10Deskana) p:05Triage>03High Needs further investigation. [22:58:42] 10VisualEditor: [Regression pre-wmf.24] Labels for "Minor edit" and "Watch page" checkboxes are missing after reloading the editor with unsaved changes - https://phabricator.wikimedia.org/T188796#4048299 (10Deskana) p:05Triage>03Normal