[07:58:44] 10VisualEditor, 10VisualEditor-DataModel, 10ContentTranslation, 10User-Ryasmeen: Error while building VE document model with a translation section containing block image - https://phabricator.wikimedia.org/T189643#4060234 (10Pginer-WMF) p:05Triage>03Normal [08:14:57] 10VisualEditor, 10VisualEditor-VisualDiffs: Message missing at least in NWE preview - https://phabricator.wikimedia.org/T190018#4060242 (10Schnark) [08:16:42] 10VisualEditor, 10VisualEditor-VisualDiffs: Next edit, previous edit links should be shown with Visual diffs - https://phabricator.wikimedia.org/T189944#4060256 (10Schnark) [08:16:47] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Metadata (author, edit comment, navigation links etc) not shown in historic visual diff - https://phabricator.wikimedia.org/T187614#4060259 (10Schnark) [09:16:06] 10VisualEditor: Copy and paste of photo between articles separated the caption from the photo - https://phabricator.wikimedia.org/T190023#4060387 (10Kerry_Raymond) [09:16:56] 10VisualEditor: Copy and paste of photo between articles separated the caption from the photo - https://phabricator.wikimedia.org/T190023#4060398 (10Kerry_Raymond) [10:13:47] 10TemplateData, 10VisualEditor: Allow template data wizard to appear on other configured namespaces - https://phabricator.wikimedia.org/T189989#4059558 (10Mvolz) What wiki is this? This is due to https://phabricator.wikimedia.org/T125222 You can set the namespace, for example: https://fr.wikipedia.org/wiki/Me... [10:31:31] 10Citoid, 10VisualEditor, 10Regression: Either restore landing page at http://localhost:1970/api or improve ?doc page - https://phabricator.wikimedia.org/T184913#4060606 (10Mvolz) a:03Mvolz [11:29:00] 10Citoid, 10VisualEditor, 10Regression: Spec.yaml ( ?doc page) doesn't seem to be parsing the x-amples. - https://phabricator.wikimedia.org/T184913#4060744 (10Mvolz) a:05Mvolz>03None [11:38:39] 10Citoid, 10VisualEditor, 10Regression: Spec.yaml ( ?doc page) doesn't work well. - https://phabricator.wikimedia.org/T184913#4060758 (10Mvolz) [11:47:58] 10Citoid, 10VisualEditor, 10Regression: Spec.yaml ( ?doc page) doesn't work well. - https://phabricator.wikimedia.org/T184913#4060774 (10Mvolz) a:03Mvolz [12:23:07] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10Technical-Debt: Add support for restful crossRef api - https://phabricator.wikimedia.org/T108175#4060872 (10Mvolz) [12:33:42] 10TemplateData, 10VisualEditor: Allow template data wizard to appear on other configured namespaces - https://phabricator.wikimedia.org/T189989#4060889 (10Ciencia_Al_Poder) Hmm, this won't work, I think, since the message seems to specify a subpage, while I'm using a whole new namespace. See T187007 for backg... [12:41:48] 10TemplateData, 10VisualEditor: Allow template data wizard to appear on other configured namespaces - https://phabricator.wikimedia.org/T189989#4060901 (10Mvolz) >>! In T189989#4060889, @Ciencia_Al_Poder wrote: > Hmm, this won't work, I think, since the message seems to specify a subpage, while I'm using a who... [13:58:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10Community-Liaisons, 10OOUI, and 3 others: Change OOUI WikimediaUI theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki's Vector skin - https://phabricator.wikimedia.org/T97631#4061101 (10Trizek-WMF) [14:22:21] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Add ellipsis to "Publish changes" button when editing to indicate it's not the final step - https://phabricator.wikimedia.org/T189803#4053939 (10Esanders) NB there are four messages for this button: [Save|Publish] [page|changes]. Save... [14:31:12] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Add ellipsis to "Publish changes" button when editing to indicate it's not the final step - https://phabricator.wikimedia.org/T189803#4061232 (10Esanders) a:03Esanders [14:47:25] (03PS1) 10Esanders: Create short save/publish buttons labels with ellipses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420352 (https://phabricator.wikimedia.org/T189803) [14:49:00] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Add ellipsis to "Publish changes" button when editing to indicate it's not the final step - https://phabricator.wikimedia.org/T189803#4061326 (10Esanders) The above patches just create new messages, which should b... [14:49:54] (03PS1) 10Esanders: Use ellipsis on toolbar save/publish button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420354 (https://phabricator.wikimedia.org/T189803) [14:50:52] (03CR) 10Esanders: [C: 04-2] "Should wait a few weeks for translations to be prepared." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420354 (https://phabricator.wikimedia.org/T189803) (owner: 10Esanders) [14:57:44] (03CR) 10jerkins-bot: [V: 04-1] Use ellipsis on toolbar save/publish button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420354 (https://phabricator.wikimedia.org/T189803) (owner: 10Esanders) [15:05:07] (03PS6) 10Petar.petkovic: Allow ve.ui.MWCategoryInputWidget to use different API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420008 [15:14:14] (03CR) 10DLynch: MWTransclusionNode: describe parameter changes for Visual Diffs (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417003 (https://phabricator.wikimedia.org/T188389) (owner: 10DLynch) [15:17:53] (03CR) 10jerkins-bot: [V: 04-1] Allow ve.ui.MWCategoryInputWidget to use different API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420008 (owner: 10Petar.petkovic) [15:19:17] (03PS4) 10DLynch: MWTransclusionNode: describe parameter changes for Visual Diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417003 (https://phabricator.wikimedia.org/T188389) [15:20:54] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4061472 (10Whatamidoing-WMF) [15:26:46] 10TemplateData, 10VisualEditor: Allow template data wizard to appear on other configured namespaces - https://phabricator.wikimedia.org/T189989#4061485 (10Ciencia_Al_Poder) Yes, that would work for us. [15:51:02] (03PS7) 10Petar.petkovic: Allow ve.ui.MWCategoryInputWidget to use different API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420008 [16:10:00] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4061688 (10Aklapper) Hmm, which errors? For https://office.wikimedia.org/w/index.php?oldid=228334&veaction=edit&debug=true&action=edit in Firefox 59 I get: * `unreachable code after return statement`... [16:12:01] 10VisualEditor: Escape should close toolbar panels before trying to close the entire editor - https://phabricator.wikimedia.org/T190068#4061691 (10DLynch) [16:35:45] (03CR) 10DLynch: [C: 032] Restrict width of diff feedback button mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419436 (owner: 10Esanders) [16:45:03] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4061472 (10DLynch) I tried this in Chrome, and didn't produce any errors. (I did see the `Mapping(s) missing from citoid-template-type-map.json: case` one, but that's a warning.) Firefox got the unreac... [16:46:00] (03CR) 10jerkins-bot: [V: 04-1] Restrict width of diff feedback button mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419436 (owner: 10Esanders) [16:47:12] 10VisualEditor: Fix citoid map on office wiki - https://phabricator.wikimedia.org/T190071#4061775 (10Esanders) [16:47:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid, 10Regression: Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083#3905613 (10ssastry) The NWE preview issues should be fixed now. However, VE showing external links for interwiki li... [16:47:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Regression: Consistently style links (internal, inter-wiki and external) - https://phabricator.wikimedia.org/T185083#4061788 (10ssastry) [17:01:17] 10VisualEditor: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4061840 (10Esanders) I think so - that patch relates to something discusse... [17:03:01] (03CR) 10DLynch: [C: 032] Show page title in preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419079 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [17:09:54] (03Merged) 10jenkins-bot: Show page title in preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419079 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [17:10:58] 10VisualEditor-MediaWiki, 10Community-Tech, 10Front-end-Standards-Group, 10Community-Wishlist-Survey-2017, and 4 others: [Epic] VisualEditor: Implement some form of auto-save to help with browser crash recovery and accidental tab closing - https://phabricator.wikimedia.org/T57370#4061871 (10Esanders) >>! I... [17:12:01] (03CR) 10jenkins-bot: Show page title in preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419079 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [17:17:21] (03CR) 10DLynch: Parse title in show preview using hack (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [17:27:07] 10VisualEditor, 10User-Ryasmeen: Visual Editor: "Changes recovered: Your unsaved changes have been automatically recovered." - creates edit conflicts that are NOT detected and allows subsequent edits to be lost! - https://phabricator.wikimedia.org/T189337#4061933 (10Esanders) 05Open>03Resolved a:03Esanders [17:31:52] (03PS3) 10Esanders: Autosave recovery prompt [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (https://phabricator.wikimedia.org/T190077) [17:34:18] 10VisualEditor, 10Patch-For-Review: Prompt user when restoring an auto-save against a new document version - https://phabricator.wikimedia.org/T190077#4061956 (10Esanders) Current appearance/wording: {F15885511,size=full} [17:44:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Prompt user before automatically converting pasted HTML to wikitext - https://phabricator.wikimedia.org/T190079#4061985 (10Esanders) [18:56:12] (03CR) 10Bartosz Dziewoński: "I was imagining a non-modal prompt, more like e.g. the find and replace "dialog"." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (https://phabricator.wikimedia.org/T190077) (owner: 10Esanders) [19:14:07] 10Citoid, 10VisualEditor, 10Regression, 10User-Ryasmeen: Spec.yaml ( ?doc page) doesn't work well. - https://phabricator.wikimedia.org/T184913#4062231 (10mobrovac) 05Open>03Resolved It works now :) [19:14:41] (03CR) 10VolkerE: "+1 to Bartosz' feedback" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (https://phabricator.wikimedia.org/T190077) (owner: 10Esanders) [19:16:47] (03CR) 10VolkerE: "Similar to popup opening prevented feedback in Firefox." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (https://phabricator.wikimedia.org/T190077) (owner: 10Esanders) [19:18:34] 10VisualEditor: Visual editor automatic nowiki tags in links breaks lines - https://phabricator.wikimedia.org/T190084#4062274 (10Theklan) [19:44:14] 10VisualEditor: Visual editor automatic nowiki tags in links breaks lines - https://phabricator.wikimedia.org/T190084#4062274 (10matmarex) Do you mean that with a syntax like `[[Sale]]n`, there can be a line break between "Sale" and "n"? What browser are you using? This seems like a browser bug. It does... [19:48:58] 10VisualEditor: Visual editor automatic nowiki tags in links breaks lines - https://phabricator.wikimedia.org/T190084#4062372 (10matmarex) I see, it happens only inside VE, not in view mode. {F15886970} [19:51:23] 10VisualEditor: Visual editor automatic nowiki tags in links breaks lines - https://phabricator.wikimedia.org/T190084#4062388 (10matmarex) [19:51:28] 10VisualEditor, 10VisualEditor-ContentLanguage: Link cartouches interfere with browsers' word break algorithms - https://phabricator.wikimedia.org/T134571#4062391 (10matmarex) [20:01:45] 10VisualEditor, 10VisualEditor-ContentLanguage: Link cartouches interfere with browsers' word break algorithms - https://phabricator.wikimedia.org/T134571#4062430 (10matmarex) >>! In T134571#2949758, @cscott wrote: > @dchan Have you tried using U+200D ZERO WIDTH JOINER to weld the (aka U+FFFC) to the lin... [20:08:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420423 (owner: 10L10n-bot) [20:11:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] "If we're already going to have a hack for this, and already going to have an extra API request, then we should at least make it return cor" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [20:29:49] (03CR) 10Bartosz Dziewoński: "This is broken for me. `docOrMsg.title` is always an empty string at this point." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419079 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [21:05:03] 10VisualEditor, 10MediaWiki-Page-deletion, 10MediaWiki-Page-editing, 10MediaWiki-Page-protection, and 5 others: Update web UI for increased comment length - https://phabricator.wikimedia.org/T185948#4062637 (10Anomie) 05Open>03Resolved a:03Anomie Let's call this done, since nothing has shown up for t... [21:14:40] (03CR) 10Esanders: [C: 032] Allow ve.ui.MWCategoryInputWidget to use different API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420008 (owner: 10Petar.petkovic) [21:24:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/420571 (owner: 10L10n-bot) [21:27:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420589 (owner: 10L10n-bot) [21:30:01] (03Merged) 10jenkins-bot: Allow ve.ui.MWCategoryInputWidget to use different API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420008 (owner: 10Petar.petkovic) [21:31:50] (03CR) 10jenkins-bot: Allow ve.ui.MWCategoryInputWidget to use different API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420008 (owner: 10Petar.petkovic) [21:36:00] MatmaRex: I like the prop=displaytitle idea, but I can't get it to work in practice [21:36:53] the API keeps giving me the old title [21:36:55] edsanders: mediawiki.action.edit.preview.js in MW core uses that, if you need an example [21:37:46] edsanders: btw the whole page title preview in VE is broken for me, i commented on https://gerrit.wikimedia.org/r/#/c/419079/ [21:37:53] yeah - I noticed [21:38:13] parsoid doesn't return a title unless there is an override, because it has no context [21:38:19] will fix [21:43:26] MatmaRex: same behaviour in action.edit.preview.js - the title doesn't actually preview correctly :) [21:43:39] :o [21:45:13] edsanders: hmm, works for me :o [21:45:42] weird [21:46:18] This is using live preview https://usercontent.irccloud-cdn.com/file/urVuDuZy/image.png [21:46:29] edsanders: note that there are some limits as to what values for DISPLAYTITLE are allowed - are you testing with a title text that normalized to the same title? [21:46:34] yeahh [21:46:36] oh yeah [21:46:37] duh [21:46:42] edsanders: try {{DISPLAYTITLE:simple}} [21:46:43] forgot about that :) [21:47:04] i think Parsoid actually doesn't implement that. which sucks [21:47:24] (and which is another reason to use the real thing from action=parse) [21:47:36] what does "Parse in preview mode." in the API do, and should I use it? [21:48:01] edsanders: suppresses the section edit links, and maybe some other minor things [21:48:05] ok [21:48:14] edsanders: i think it also renders autogenenerated reflists on section previews [21:48:20] probably doesn't matter for displaytitle [21:56:27] (03Abandoned) 10Hashar: (WIP) run karma:main with Firefox as well [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 (owner: 10Hashar) [21:59:04] (03PS3) 10Esanders: Parse title in show preview using hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) [21:59:06] (03PS1) 10Esanders: Fix title preview when not overridden [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420603 [22:09:45] 10VisualEditor, 10User-Ryasmeen: Fix citoid map on office wiki - https://phabricator.wikimedia.org/T190071#4062878 (10Reedy) 05Open>03Resolved a:03Reedy Stolen from enwiki [22:29:48] MatmaRex: the autosave restore popup decides which document we load, how can it be non-modal? [22:31:04] edsanders: i imagine we'd first load the document from the API request, then if the user chooses to restore, unload that and load the autosaved one [22:33:08] why? [22:41:03] edsanders: i think the current implementation often "restores" changes that were intentionally abandoned, so while what i propose would be a bit hacky, it would be better for users in the more common case [22:41:09] (sorry, i was away) [22:41:53] users would probably run into this less ofen if we had a "Cancel" button, but we don't [22:45:28] (03CR) 10Bartosz Dziewoński: Make gallery dialog work with native gallery implementation (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [23:01:21] (03PS42) 10Bartosz Dziewoński: Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [23:02:18] (03CR) 10Bartosz Dziewoński: "@Thalia Done. Note that there are still many ways to break the gallery because of things whose wikitext syntax requires newlines (e.g. man" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [23:08:05] (03CR) 10Bartosz Dziewoński: "I can't get this to work. `docOrMsg.title` is always empty. Where does this value come from?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [23:08:14] edsanders: ^ [23:16:42] (03CR) 10Bartosz Dziewoński: [C: 04-1] "So, that comes from the tag, which is missing (it looks like we get the contents of <body> only from the API). But even if it was " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [23:17:31] <wikibugs> (03CR) 10Bartosz Dziewoński: [C: 032] "I am pretty sure that `docOrMsg.title` is actually never present. So there might be another bug here. But this is better." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420603 (owner: 10Esanders) [23:18:05] <wikibugs> (03CR) 10Bartosz Dziewoński: "Fixed in https://gerrit.wikimedia.org/r/#/c/420603/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419079 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [23:24:22] <wikibugs> (03Merged) 10jenkins-bot: Fix title preview when not overridden [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420603 (owner: 10Esanders) [23:26:40] <wikibugs> (03CR) 10jenkins-bot: Fix title preview when not overridden [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420603 (owner: 10Esanders) [23:28:56] <wikibugs> (03CR) 10Esanders: [C: 032] Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [23:39:01] <wikibugs> (03Merged) 10jenkins-bot: Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [23:41:05] <wikibugs> (03CR) 10jenkins-bot: Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (https://phabricator.wikimedia.org/T150621) (owner: 10Tchanders) [23:58:13] <wikibugs> 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4063271 (10Esanders) >>! In T190056#4061688, @Aklapper wrote: > * `Mapping(s) missing from citoid-template-type-map.json: case` in ve.ui.Citoid.init.js:61:3 coming from https://office.wikimedia.org/w/e...