[00:04:10] 10VisualEditor, 10VisualEditor-VisualDiffs: Message missing at least in NWE preview - https://phabricator.wikimedia.org/T190018#4060242 (10Esanders) The message was included in the pull through https://gerrit.wikimedia.org/r/#/c/419512/ and is working for me locally and on beta labs. [00:06:02] 10VisualEditor: Copy and paste of photo between articles separated the caption from the photo - https://phabricator.wikimedia.org/T190023#4060387 (10Esanders) Thanks, can you confirm your browser, as copy/paste handling varies a lot between them? [00:43:28] 10VisualEditor, 10VisualEditor-VisualDiffs: Message missing at least in NWE preview - https://phabricator.wikimedia.org/T190018#4060242 (10matmarex) I think we skipped scap when deploying the backport for https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20180314T2300... [01:43:30] (03CR) 10DLynch: "docOrMsg.title is set for me, to whatever I have as my {{DISPLAYTITLE}}." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [01:48:16] (03CR) 10DLynch: [C: 04-1] "Ah, actually, it's *only* set if there's a DISPLAYTITLE. I wasn't testing without one. Presumably this is what's going on for Bartosz?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [01:49:07] (03CR) 10DLynch: [C: 031] "Wait, my bad, I see 420603 now, which does exactly that. :P" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419140 (https://phabricator.wikimedia.org/T189540) (owner: 10Esanders) [01:50:11] (03CR) 10DLynch: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419436 (owner: 10Esanders) [02:09:12] (03Merged) 10jenkins-bot: Restrict width of diff feedback button mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419436 (owner: 10Esanders) [02:11:22] (03CR) 10jenkins-bot: Restrict width of diff feedback button mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419436 (owner: 10Esanders) [02:34:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: Don't label the "oh well" edit summary box with "Describe your changes" when saving a new section - https://phabricator.wikimedia.org/T163026#3183764 (10Izno) I would prefer to see it editable, not least becaus... [02:53:35] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4063662 (10Whatamidoing-WMF) I was having this problem in Safari. I didn't grab a screenshot, so I can't tell you which error message it was. @Elitre, how are things working for you on office.wiki th... [10:06:31] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4064136 (10Elitre) I don't think I ever had an auto-switch issue. OTOH I haven't used VE there for over a week since it's giving me a few headaches. I will make an effort to document my problems here i... [10:49:52] 10VisualEditor, 10VisualEditor-VisualDiffs: Message missing at least in NWE preview - https://phabricator.wikimedia.org/T190018#4064205 (10Schnark) Indeed, even https://de.wikipedia.org/wiki/MediaWiki:Visualeditor-diff-timed-out is currently missing. [11:09:16] 10VisualEditor, 10Patch-For-Review, 10Technical-Debt: .oo-ui-tool-headingN: Don't use px just so that padding is not changed by font size - https://phabricator.wikimedia.org/T126030#2003075 (10matmarex) I'm confused by this task. I think the title was supposed to be "Don't use em…" rather than "Don't use px…... [11:09:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "See task" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420156 (https://phabricator.wikimedia.org/T126030) (owner: 10VolkerE) [12:47:32] (03PS1) 10Esanders: Use paste API if *any* important elements have been dropped [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420688 (https://phabricator.wikimedia.org/T190023) [12:49:36] (03PS1) 10Esanders: Improve media context item to show Image/Video/Audio instead of 'Media' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420689 [12:49:38] (03PS1) 10Esanders: MediaContext: Link filename to file page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420690 [12:56:24] (03CR) 10jerkins-bot: [V: 04-1] MediaContext: Link filename to file page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420690 (owner: 10Esanders) [12:59:47] (03CR) 10jerkins-bot: [V: 04-1] Improve media context item to show Image/Video/Audio instead of 'Media' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420689 (owner: 10Esanders) [13:02:55] (03CR) 10Esanders: [C: 04-1] MWTransclusionNode: describe parameter changes for Visual Diffs (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417003 (https://phabricator.wikimedia.org/T188389) (owner: 10DLynch) [13:04:16] (03PS3) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [13:04:18] (03PS1) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T97631) [13:04:29] (03PS1) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) [13:04:31] (03PS1) 10Bartosz Dziewoński: Update icons for new 20px grid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T97631) [13:05:32] (03PS2) 10Bartosz Dziewoński: Update icons for new 20px grid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T97631) [13:05:49] (03PS2) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T97631) [13:08:12] (03CR) 10jerkins-bot: [V: 04-1] Remove special `font-size` treatment following-up UI unified in `14px` base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [13:08:38] (03CR) 10Bartosz Dziewoński: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [13:38:24] (03PS4) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [13:38:26] (03PS3) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T97631) [13:38:28] (03PS1) 10Bartosz Dziewoński: fixup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420700 [13:40:16] (03PS5) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [13:40:18] (03PS4) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T97631) [13:40:35] (03Abandoned) 10Bartosz Dziewoński: fixup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420700 (owner: 10Bartosz Dziewoński) [13:40:56] (03PS3) 10Bartosz Dziewoński: Update icons for new 20px grid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T97631) [13:41:23] (03CR) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [14:00:51] (03CR) 10Esanders: [C: 04-1] "Context items' title icons are oversized (26.25px) (e.g. the popup you see when you focus a link)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [14:09:01] (03CR) 10Bartosz Dziewoński: "@Ed Fixed in VE/VE: https://gerrit.wikimedia.org/r/420695" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [14:12:22] (03PS4) 10Bartosz Dziewoński: Update icons for new 20px grid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T97631) [14:12:25] (03PS2) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) [14:12:27] (03PS5) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T97631) [14:12:29] (03PS6) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [14:14:21] (03PS7) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [14:16:06] (03CR) 10Esanders: "(make sure you test in both themes)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [14:16:10] (03CR) 10Bartosz Dziewoński: "I think everything looks correct now (except for icons from other extensions that I still need to adjust to 20px grid), but I've been star" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [14:16:42] (03CR) 10jerkins-bot: [V: 04-1] Update icons for new 20px grid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [14:16:48] (03CR) 10Bartosz Dziewoński: "It's blurry in Apex right now, I'm working on a patch in OOUI to make Apex also use 20px grid." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [14:17:22] (03CR) 10Bartosz Dziewoński: "Sorry, that was meant for another patch. I tested the CSS change in Apex." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [14:17:38] (03CR) 10Bartosz Dziewoński: "This makes icons look blurry in Apex right now, I'm working on a patch in OOUI to make Apex also use 20px grid." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [14:21:35] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Epic, 10VisualEditor (Current work): [Epic] Do not "recover" edits that were intentionally abandoned (in the visual and 2017 wikitext editors) - https://phabricator.wikimedia.org/T189576#4064819 (10Esanders) [14:21:39] 10VisualEditor, 10Patch-For-Review: Prompt user when restoring an auto-save against a new document version - https://phabricator.wikimedia.org/T190077#4064818 (10Esanders) [14:45:30] 10Citoid, 10VisualEditor, 10Services (watching), 10User-Sebastian_Berlin-WMSE, 10WMSE-Development-Support-2018 (Citoid-library-for-svwp): Add translator for sverigesradio.se to MW translator repo - https://phabricator.wikimedia.org/T188893#4064895 (10Sebastian_Berlin-WMSE) @Mvolz and/or @Deskana, do you... [15:08:56] (03PS5) 10Bartosz Dziewoński: Update icons for new 20px grid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T177432) [15:09:05] (03PS6) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T177432) [15:21:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Lightweight parse mode where roundtripping is not required - https://phabricator.wikimedia.org/T189261#4036878 (10cscott) I've got no problem with skipping passes, that seems like a fairly coarse-grained tool, but it does potentially ope... [15:25:04] (03PS8) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [15:25:10] (03PS2) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/420141 (https://phabricator.wikimedia.org/T189920) (owner: 10VolkerE) [15:25:36] (03PS9) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [15:25:48] (03PS3) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) [15:33:32] 10VisualEditor, 10VisualEditor-MediaWiki: Some icons in VE media dialog are missing the white "invert" variant - https://phabricator.wikimedia.org/T190166#4065109 (10matmarex) [15:33:49] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Some icons in VE media dialog are missing the white "invert" variant - https://phabricator.wikimedia.org/T190166#4065123 (10matmarex) a:03matmarex [15:34:39] (03CR) 10DLynch: MWTransclusionNode: describe parameter changes for Visual Diffs (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417003 (https://phabricator.wikimedia.org/T188389) (owner: 10DLynch) [15:35:08] (03PS5) 10DLynch: MWTransclusionNode: describe parameter changes for Visual Diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/417003 (https://phabricator.wikimedia.org/T188389) [15:36:53] (03PS1) 10Bartosz Dziewoński: ve.ui.Icons: Add missing global "invert" variant [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420737 (https://phabricator.wikimedia.org/T190166) [15:37:23] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Some icons in VE media dialog are missing the white "invert" variant - https://phabricator.wikimedia.org/T190166#4065140 (10matmarex) https://gerrit.wikimedia.org/r/420737 [15:47:06] (03CR) 10Jforrester: [C: 032] ve.ui.Icons: Add missing global "invert" variant [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420737 (https://phabricator.wikimedia.org/T190166) (owner: 10Bartosz Dziewoński) [15:52:47] 10VisualEditor, 10OOUI: Fix page settings/advanced settings icons - https://phabricator.wikimedia.org/T190175#4065287 (10Esanders) [15:54:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Lightweight parse mode where roundtripping is not required - https://phabricator.wikimedia.org/T189261#4065297 (10ssastry) p:05Normal>03Low [15:55:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Lightweight parse mode where roundtripping is not required - https://phabricator.wikimedia.org/T189261#4036878 (10ssastry) Ya, I have / had the same concerns after I posted this ... testability is a concern since all our test infra. is s... [16:01:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Apple-Safari: Unable to scroll the "Review your changes" screen on mobile (iOS Safari 9.x) - https://phabricator.wikimedia.org/T126240#4065326 (10Jdforrester-WMF) [16:03:04] (03CR) 10Esanders: [C: 031] "Waiting on OOUI release." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [16:03:19] (03CR) 10Esanders: [C: 031] "Waiting on OOUI release." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [16:05:49] (03PS3) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/420141 (https://phabricator.wikimedia.org/T189920) (owner: 10VolkerE) [16:14:03] (03CR) 10DLynch: "ping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/417298 (owner: 10DLynch) [16:15:09] (03Merged) 10jenkins-bot: ve.ui.Icons: Add missing global "invert" variant [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420737 (https://phabricator.wikimedia.org/T190166) (owner: 10Bartosz Dziewoński) [16:16:16] (03CR) 10Bartosz Dziewoński: [C: 032] "I was certain I already merged this, but turns out I only did https://gerrit.wikimedia.org/r/#/c/417297/ ." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/417298 (owner: 10DLynch) [16:17:20] (03CR) 10jenkins-bot: ve.ui.Icons: Add missing global "invert" variant [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420737 (https://phabricator.wikimedia.org/T190166) (owner: 10Bartosz Dziewoński) [16:18:51] (03Merged) 10jenkins-bot: Update rel attribute checks to be aware of multiple rel values [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/417298 (owner: 10DLynch) [16:20:42] (03CR) 10Jforrester: [C: 031] Use paste API if *any* important elements have been dropped [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420688 (https://phabricator.wikimedia.org/T190023) (owner: 10Esanders) [16:21:45] (03CR) 10jenkins-bot: Update rel attribute checks to be aware of multiple rel values [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/417298 (owner: 10DLynch) [16:22:06] (03CR) 10Jforrester: Autosave recovery prompt (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419169 (https://phabricator.wikimedia.org/T190077) (owner: 10Esanders) [16:37:43] 10VisualEditor-CopyPaste, 10Patch-For-Review, 10VisualEditor (Current work): Copy and paste of photo between articles separated the caption from the photo - https://phabricator.wikimedia.org/T190023#4065502 (10Jdforrester-WMF) a:03Esanders [16:41:12] (03CR) 10Jforrester: [C: 032] Remove unnecessary attachToolbarSaveButton override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418588 (owner: 10Esanders) [16:41:30] (03CR) 10Jforrester: [C: 032] Factor out isSaveable method from updateToolbarSaveButtonState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418589 (owner: 10Esanders) [16:43:54] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4065557 (10Whatamidoing-WMF) It works this morning. Maybe a temporary server problem? (All I recall about the error messages is that they took a very long time to appear and that the information in th... [16:48:24] (03CR) 10DLynch: [C: 04-1] "Add a test for this case in ce.Surface.test.js?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420688 (https://phabricator.wikimedia.org/T190023) (owner: 10Esanders) [16:48:27] (03CR) 10Jforrester: "Oops, sorry." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 (owner: 10Hashar) [17:00:33] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420128 (owner: 10Esanders) [17:04:34] (03PS3) 10Jforrester: demos: Separate out and fix mobile-dist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419464 (owner: 10Esanders) [17:04:38] (03CR) 10Jforrester: [C: 032] demos: Separate out and fix mobile-dist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419464 (owner: 10Esanders) [17:06:27] (03PS3) 10Jforrester: VisualDiffs: Unit test for timeout behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418897 (owner: 10Esanders) [17:07:35] (03CR) 10Jforrester: [C: 032] VisualDiffs: Unit test for timeout behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418897 (owner: 10Esanders) [17:08:32] (03CR) 10Jforrester: [C: 032] ve.ce.LinearSelection: Don't throw exceptions only to catch on the next line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419192 (owner: 10Bartosz Dziewoński) [17:08:50] (03Merged) 10jenkins-bot: demos: Separate out and fix mobile-dist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419464 (owner: 10Esanders) [17:10:17] (03PS3) 10Jforrester: Clarify the "Log" button label on the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415688 (owner: 10Bartosz Dziewoński) [17:10:20] (03CR) 10Jforrester: [C: 032] Clarify the "Log" button label on the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415688 (owner: 10Bartosz Dziewoński) [17:10:24] (03Merged) 10jenkins-bot: VisualDiffs: Unit test for timeout behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418897 (owner: 10Esanders) [17:11:09] (03Merged) 10jenkins-bot: ve.ce.LinearSelection: Don't throw exceptions only to catch on the next line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419192 (owner: 10Bartosz Dziewoński) [17:11:15] (03PS2) 10Jforrester: Fix auto-save standalone demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419199 (owner: 10Esanders) [17:12:23] (03CR) 10jenkins-bot: demos: Separate out and fix mobile-dist [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419464 (owner: 10Esanders) [17:14:02] (03Merged) 10jenkins-bot: Clarify the "Log" button label on the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415688 (owner: 10Bartosz Dziewoński) [17:14:53] (03CR) 10jenkins-bot: VisualDiffs: Unit test for timeout behaviour [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418897 (owner: 10Esanders) [17:17:20] (03CR) 10jenkins-bot: ve.ce.LinearSelection: Don't throw exceptions only to catch on the next line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419192 (owner: 10Bartosz Dziewoński) [17:19:53] (03CR) 10jenkins-bot: Clarify the "Log" button label on the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/415688 (owner: 10Bartosz Dziewoński) [17:23:08] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4065694 (10DLynch) That sounds plausibly like the "didn't get a decent answer from restbase / parsoid" case, yeah. Which would likely look like this: {F15917747} [17:25:12] (03Merged) 10jenkins-bot: Remove unnecessary attachToolbarSaveButton override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418588 (owner: 10Esanders) [17:26:40] (03Merged) 10jenkins-bot: Factor out isSaveable method from updateToolbarSaveButtonState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418589 (owner: 10Esanders) [17:27:02] (03CR) 10jenkins-bot: Remove unnecessary attachToolbarSaveButton override [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418588 (owner: 10Esanders) [17:28:22] (03PS1) 10Esanders: Use OOUI 'markup' icon instead of local 'alienextension' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420775 [17:28:44] (03PS3) 10Jforrester: demos: Fix auto-save by only storing doc state if not recovered [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419199 (owner: 10Esanders) [17:28:48] (03CR) 10jenkins-bot: Factor out isSaveable method from updateToolbarSaveButtonState [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418589 (owner: 10Esanders) [17:28:50] (03CR) 10Jforrester: [C: 032] demos: Fix auto-save by only storing doc state if not recovered [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419199 (owner: 10Esanders) [17:28:58] (03PS2) 10Jforrester: Auto-save: Save and restore last known selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419200 (owner: 10Esanders) [17:29:36] (03CR) 10Jforrester: [C: 032] Update documentation now describeChange can return jQuery [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420128 (owner: 10Esanders) [17:30:37] (03CR) 10Esanders: "Wouldn't that store a selection for every change? Seems like unnecessary bloat." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419200 (owner: 10Esanders) [17:31:56] (03Merged) 10jenkins-bot: demos: Fix auto-save by only storing doc state if not recovered [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419199 (owner: 10Esanders) [17:32:16] (03Merged) 10jenkins-bot: Update documentation now describeChange can return jQuery [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420128 (owner: 10Esanders) [17:32:36] (03PS1) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/420776 (https://phabricator.wikimedia.org/T177432) [17:33:54] (03PS2) 10Jforrester: Diff original dom elements for alien node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418604 (https://phabricator.wikimedia.org/T188833) (owner: 10Tchanders) [17:34:35] (03CR) 10Jforrester: [C: 031] Diff original dom elements for alien node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/418604 (https://phabricator.wikimedia.org/T188833) (owner: 10Tchanders) [17:34:54] (03CR) 10jenkins-bot: demos: Fix auto-save by only storing doc state if not recovered [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419199 (owner: 10Esanders) [17:35:23] (03PS6) 10Bartosz Dziewoński: Update icons for new 20px grid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T177432) [17:35:46] (03PS2) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/420776 (https://phabricator.wikimedia.org/T177432) [17:37:24] (03CR) 10jenkins-bot: Update documentation now describeChange can return jQuery [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420128 (owner: 10Esanders) [17:38:04] 10VisualEditor: VE removes line-breaks of lists and breaks the layout - https://phabricator.wikimedia.org/T190191#4065788 (10Rezonansowy) [17:38:18] (03CR) 10Divec: [C: 032] "Fair point - ok let's go with it then" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419200 (owner: 10Esanders) [17:40:54] (03Merged) 10jenkins-bot: Auto-save: Save and restore last known selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419200 (owner: 10Esanders) [17:43:34] (03CR) 10jenkins-bot: Auto-save: Save and restore last known selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/419200 (owner: 10Esanders) [17:45:56] (03PS2) 10Esanders: Improve media context item to show Image/Video/Audio instead of 'Media' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420689 [17:45:58] (03PS2) 10Esanders: MediaContext: Link filename to file page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420690 [17:57:37] (03PS1) 10Esanders: Fix deprecated icon name 'alignCentre' > 'alignCenter' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420787 [18:02:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10Community-Liaisons, 10OOUI (OOUI-0.26.0), and 3 others: Change OOUI WikimediaUI theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki's Vector skin - https://phabricator.wikimedia.org/T97631#4066003 (10Jdforrest... [18:02:48] 10VisualEditor, 10OOUI (OOUI-0.26.0): Fix page settings/advanced settings icons - https://phabricator.wikimedia.org/T190175#4066012 (10Jdforrester-WMF) [18:07:50] (03CR) 10Jforrester: [C: 032] Fix deprecated icon name 'alignCentre' > 'alignCenter' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420787 (owner: 10Esanders) [18:11:04] (03Merged) 10jenkins-bot: Fix deprecated icon name 'alignCentre' > 'alignCenter' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420787 (owner: 10Esanders) [18:14:22] (03CR) 10jenkins-bot: Fix deprecated icon name 'alignCentre' > 'alignCenter' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420787 (owner: 10Esanders) [18:22:48] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This requires OOUI 0.26.0 (to be released later today)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [18:22:51] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This requires OOUI 0.26.0 (to be released later today)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420695 (https://phabricator.wikimedia.org/T97631) (owner: 10Bartosz Dziewoński) [18:22:58] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This requires OOUI 0.26.0 (to be released later today)." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/420141 (https://phabricator.wikimedia.org/T189920) (owner: 10VolkerE) [18:23:48] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This requires OOUI 0.26.0 (to be released later today)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T177432) (owner: 10Bartosz Dziewoński) [18:23:52] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This requires OOUI 0.26.0 (to be released later today)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420696 (https://phabricator.wikimedia.org/T177432) (owner: 10Bartosz Dziewoński) [18:23:55] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This requires OOUI 0.26.0 (to be released later today)." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/420776 (https://phabricator.wikimedia.org/T177432) (owner: 10Bartosz Dziewoński) [18:27:25] (03CR) 10Jforrester: [C: 032] Improve media context item to show Image/Video/Audio instead of 'Media' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420689 (owner: 10Esanders) [18:27:28] (03CR) 10Jforrester: [C: 032] MediaContext: Link filename to file page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420690 (owner: 10Esanders) [18:32:16] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056#4066173 (10Whatamidoing-WMF) That is plausible. [18:38:54] (03Merged) 10jenkins-bot: Improve media context item to show Image/Video/Audio instead of 'Media' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420689 (owner: 10Esanders) [18:41:10] (03Merged) 10jenkins-bot: MediaContext: Link filename to file page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420690 (owner: 10Esanders) [18:41:21] (03CR) 10jenkins-bot: Improve media context item to show Image/Video/Audio instead of 'Media' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420689 (owner: 10Esanders) [18:43:10] (03CR) 10jenkins-bot: MediaContext: Link filename to file page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420690 (owner: 10Esanders) [19:12:15] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Update VE-extension icons - https://phabricator.wikimedia.org/T190151#4066327 (10Jdforrester-WMF) [19:38:23] (03PS2) 10Jforrester: Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [19:38:34] (03PS2) 10Jforrester: Create show preview/changes tools to show next to save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [19:40:55] (03CR) 10Jforrester: [C: 032] Use OOUI 'markup' icon instead of local 'alienextension' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420775 (owner: 10Esanders) [19:45:26] (03CR) 10jerkins-bot: [V: 04-1] Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [19:45:34] (03CR) 10Jforrester: [C: 032] Create short save/publish buttons labels with ellipses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420352 (https://phabricator.wikimedia.org/T189803) (owner: 10Esanders) [19:46:39] (03PS2) 10Jforrester: Use ellipsis on toolbar save/publish button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420354 (https://phabricator.wikimedia.org/T189803) (owner: 10Esanders) [19:50:11] (03CR) 10jerkins-bot: [V: 04-1] Create show preview/changes tools to show next to save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [19:50:55] (03Merged) 10jenkins-bot: Use OOUI 'markup' icon instead of local 'alienextension' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420775 (owner: 10Esanders) [19:52:52] (03CR) 10jenkins-bot: Use OOUI 'markup' icon instead of local 'alienextension' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420775 (owner: 10Esanders) [19:54:09] (03Merged) 10jenkins-bot: Create short save/publish buttons labels with ellipses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420352 (https://phabricator.wikimedia.org/T189803) (owner: 10Esanders) [19:56:00] (03CR) 10jenkins-bot: Create short save/publish buttons labels with ellipses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420352 (https://phabricator.wikimedia.org/T189803) (owner: 10Esanders) [20:03:00] (03CR) 10Bartosz Dziewoński: [C: 04-2] "'alienextension' icon was just removed in Id15596ab0013cb2078480bdb4dde25ef8e7ae50b." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T177432) (owner: 10Bartosz Dziewoński) [20:03:08] (03PS7) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T177432) [20:03:12] (03PS8) 10Bartosz Dziewoński: Update icons for new 20px grid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420694 (https://phabricator.wikimedia.org/T177432) [20:03:23] (03PS10) 10Bartosz Dziewoński: Remove special `font-size` treatment following-up UI unified in `14px` base [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [20:08:54] 10VisualEditor-MediaWiki-Media, 10Accessibility, 10MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), 10Patch-For-Review, 10VisualEditor (Current work): Add support for adding and editing alt text in the gallery tool - https://phabricator.wikimedia.org/T149596#4066482 (10matmarex) {F15920091} [20:14:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Community-Liaisons, 10OOUI (OOUI-0.26.0), and 3 others: Change OOUI WikimediaUI theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px), like MediaWiki's Vector skin - https://phabricator.wikimedia.org/T97631#4066505 (10matmarex) [20:31:05] 10VisualEditor-MediaWiki, 10MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), 10VisualEditor (Current work): Some icons in VE media dialog are missing the white "invert" variant - https://phabricator.wikimedia.org/T190166#4066552 (10matmarex) 05Open>03Resolved [20:32:10] 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10VisualEditor (Current work): Update gallery dialog to work with Parsoid's native implementation - https://phabricator.wikimedia.org/T150621#4066557 (10matmarex) 05Open>03Resolved [20:32:14] 10VisualEditor-MediaWiki-Media, 10Accessibility, 10MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), 10Patch-For-Review, 10VisualEditor (Current work): Add support for adding and editing alt text in the gallery tool - https://phabricator.wikimedia.org/T149596#4066560 (10matmarex) [20:33:04] 10VisualEditor-MediaWiki-Media, 10Accessibility, 10MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), 10VisualEditor (Current work): Add support for adding and editing alt text in the gallery tool - https://phabricator.wikimedia.org/T149596#2757413 (10matmarex) 05Open>03Resolved [20:33:40] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements ("visually"), including supporting nested templates - https://phabricator.wikimedia.org/T52355#4066589 (10Dvorapa) There is no facepalm token, so consider this little goat as the facepalm to... [20:48:52] 10VisualEditor, 10VisualEditor-MediaWiki: Allow inline editing of gallery captions and gallery image captions - https://phabricator.wikimedia.org/T190224#4066668 (10matmarex) [20:49:19] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Allow rich text editing of image captions in gallery dialog - https://phabricator.wikimedia.org/T149602#4066681 (10matmarex) [20:49:22] 10VisualEditor, 10VisualEditor-MediaWiki: Allow inline editing of gallery captions and gallery image captions - https://phabricator.wikimedia.org/T190224#4066680 (10matmarex) [20:55:21] (03PS1) 10DLynch: DiffElement: Apply margin adjustment to ul as well in labels [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/420849 (https://phabricator.wikimedia.org/T188389) [20:57:27] 10VisualEditor-MediaWiki-Media, 10Accessibility, 10MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), 10Verified, 10VisualEditor (Current work): Add support for adding and editing alt text in the gallery tool - https://phabricator.wikimedia.org/T149596#4066704 (10Ryasmeen) [21:05:56] 10VisualEditor-MediaWiki, 10User-Ryasmeen, 10VisualEditor (Current work): Allow rich text editing of image captions in gallery dialog - https://phabricator.wikimedia.org/T149602#4066729 (10Ryasmeen) @matmarex: Unlike the caption field in the Media Settings dialog, this one does not support multiline text inp... [21:08:43] 10VisualEditor-MediaWiki, 10User-Ryasmeen, 10VisualEditor (Current work): Allow rich text editing of image captions in gallery dialog - https://phabricator.wikimedia.org/T149602#4066736 (10matmarex) @Ryasmeen Yes, neither the main gallery caption nor the image captions can contain multiline text. This is a l... [21:14:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/420896 (owner: 10L10n-bot) [21:16:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420900 (owner: 10L10n-bot) [21:18:10] 10VisualEditor-MediaWiki, 10User-Ryasmeen, 10VisualEditor (Current work): Allow rich text editing of image captions in gallery dialog - https://phabricator.wikimedia.org/T149602#4066778 (10Ryasmeen) @matmarex: I have actually managed to put multiline text there by adding a block node which creates a slug rig... [21:19:33] 10VisualEditor: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4066788 (10matmarex) [21:19:59] 10VisualEditor: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4066779 (10matmarex) Good or bad idea? [21:21:02] edsanders: you mentioned doing something about single-line surfaces not disallowing multiple lines hard enough, right? is there a task or something i could reference? see https://phabricator.wikimedia.org/T149602#4066778 for an example bug :) [21:32:14] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Message missing at least in NWE preview - https://phabricator.wikimedia.org/T190018#4066826 (10matmarex) I suggest we just wait for it to fix itself, and start being concerned if it's still broken on Friday. [21:34:44] (03CR) 10Jforrester: [C: 032] Only use pre-computed measurements for position loading bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420053 (owner: 10Esanders) [21:35:06] (03CR) 10Jforrester: [C: 032] Avoid jQuery.parseHTML [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420054 (owner: 10Esanders) [21:44:37] (03Merged) 10jenkins-bot: Only use pre-computed measurements for position loading bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420053 (owner: 10Esanders) [21:44:39] (03Merged) 10jenkins-bot: Avoid jQuery.parseHTML [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420054 (owner: 10Esanders) [21:46:55] (03CR) 10jenkins-bot: Only use pre-computed measurements for position loading bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420053 (owner: 10Esanders) [21:48:45] (03CR) 10jenkins-bot: Avoid jQuery.parseHTML [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420054 (owner: 10Esanders) [22:35:54] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Coordinates template is displaying in the wrong place - https://phabricator.wikimedia.org/T67648#4066986 (10matmarex) Just for reference, since this task doesn't have a screenshot, here's how it currently looks: {F15921704} VisualEditor does its best at... [22:50:17] 10VisualEditor, 10Parsoid: Table made of mix of table syntax and row templates is uneditable - https://phabricator.wikimedia.org/T182920#3838763 (10matmarex) VE has partial support for template-generated table cells ("cellable transclusions"), but apparently none for template-generated table //rows//. Our tabl... [22:51:31] (03PS2) 10Jforrester: Use single-line editor for image captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418904 (owner: 10Esanders) [22:52:50] (03CR) 10Jforrester: [C: 032] Disable visual diffs on source mode section edits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418701 (https://phabricator.wikimedia.org/T183938) (owner: 10Esanders) [22:53:19] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Visual diff on a section edit shows every other section to have been deleted (but the edit saves correctly) - https://phabricator.wikimedia.org/T183938#4067017 (10Jdforrester-WMF) [22:53:42] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Visual diff on a section edit shows every other section to have been deleted (but the edit saves correctly) - https://phabricator.wikimedia.org/T183938#3867931 (10Jdforrester-WMF) a:03Esanders [22:57:11] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons, 10Wikimedia-Site-requests: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895#4067027 (10Jdforrester-WMF) [22:57:30] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Design, and 3 others: Support editing tags to set multi-column display on/off - https://phabricator.wikimedia.org/T53260#4067028 (10Jdforrester-WMF) [22:57:32] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons, and 2 others: Please reduce column width from 35 to 30em - https://phabricator.wikimedia.org/T161788#4067026 (10Jdforrester-WMF) [22:58:04] 10VisualEditor, 10VisualEditor-ContentEditable, 10User-Ryasmeen: VisualEditor: Centred images can appear in VE as overlapped by another image, then can't be selected - https://phabricator.wikimedia.org/T64590#4067030 (10matmarex) 05Open>03Resolved I can't reproduce this issue anymore. We must have accide... [23:02:34] (03Merged) 10jenkins-bot: Disable visual diffs on source mode section edits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418701 (https://phabricator.wikimedia.org/T183938) (owner: 10Esanders) [23:02:59] (03CR) 10Hashar: "Oh i probably did that change simply to try out Firefox and/or trick the VisualEditor team in adding Firefox to the loop :]" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/396125 (owner: 10Hashar) [23:04:30] (03CR) 10jenkins-bot: Disable visual diffs on source mode section edits [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418701 (https://phabricator.wikimedia.org/T183938) (owner: 10Esanders) [23:24:49] 10VisualEditor, 10VisualEditor-ContentEditable: Reference list
can overlap a template
because that's how HTML works - https://phabricator.wikimedia.org/T104540#1419815 (10matmarex) I think we could notably improve 99% of the cases here by just having some extra handling for Focusable nodes that are... [23:25:08] (03PS1) 10Jforrester: Update VE core submodule to master (dc98cb7ec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420932 (https://phabricator.wikimedia.org/T189687) [23:25:34] (03PS2) 10Jforrester: tests: Update ve.dm.Converter#getModelFromDom cases for new metadata behavior [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419146 (owner: 10Bartosz Dziewoński) [23:25:56] 10VisualEditor: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4066779 (10matmarex) p:05Triage>03Low a:03matmarex (I'm not working on this right now, but I'd like to investigate it) [23:26:04] 10VisualEditor, 10VisualEditor-ContentEditable: Reference list
can overlap a template
because that's how HTML works - https://phabricator.wikimedia.org/T104540#4067155 (10matmarex) a:03matmarex (I'm not working on this right now, but I'd like to investigate it soon) [23:26:52] 10VisualEditor: Coordinates template gets caught in new heading because it's invisible - https://phabricator.wikimedia.org/T168616#4067162 (10matmarex) a:03matmarex We could probably easily display the "invisible template" placeholder for absolutely positioned templates as well. [23:28:17] (03CR) 10Zoranzoki21: Update VE core submodule to master (dc98cb7ec) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420932 (https://phabricator.wikimedia.org/T189687) (owner: 10Jforrester) [23:29:48] (03CR) 10Jforrester: Update VE core submodule to master (dc98cb7ec) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420932 (https://phabricator.wikimedia.org/T189687) (owner: 10Jforrester) [23:31:16] (03CR) 10Zoranzoki21: Update VE core submodule to master (dc98cb7ec) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420932 (https://phabricator.wikimedia.org/T189687) (owner: 10Jforrester) [23:34:27] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (dc98cb7ec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420932 (https://phabricator.wikimedia.org/T189687) (owner: 10Jforrester) [23:39:13] 10VisualEditor, 10VisualEditor-MediaWiki: Allow inline editing of gallery captions and gallery image captions - https://phabricator.wikimedia.org/T190224#4067182 (10matmarex) The problem here is probably going to be not the inline editing, but rather preventing the user from entering funny stuff into the galle... [23:39:18] (03PS3) 10Jforrester: Update VE core submodule to master (dc98cb7ec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419146 (https://phabricator.wikimedia.org/T189687) (owner: 10Bartosz Dziewoński) [23:39:41] (03Abandoned) 10Jforrester: Update VE core submodule to master (dc98cb7ec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420932 (https://phabricator.wikimedia.org/T189687) (owner: 10Jforrester) [23:58:10] (03CR) 10Jforrester: [C: 031] "Mostly a +2; certainly, if MatmaRex wants to +2 that's fine by me." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/419146 (https://phabricator.wikimedia.org/T189687) (owner: 10Bartosz Dziewoński)