[00:07:41] 10VisualEditor, 10UI-Standardization, 10UI-Standardization-Kanban: Should the template buttons always be set to 14px? - https://phabricator.wikimedia.org/T190368#4071371 (10Volker_E) [00:44:17] 10VisualEditor, 10Parsoid: Any change to this paragraph adds two blank lines after it - https://phabricator.wikimedia.org/T190351#4071003 (10Xaosflux) Does not occur on import to test2wiki: https://test2.wikipedia.org/w/index.php?title=Jamil_Smith_%28journalist%29&type=revision&diff=352363&oldid=351011 (many... [01:10:55] 10VisualEditor, 10Parsoid: Any change to this paragraph adds two blank lines after it - https://phabricator.wikimedia.org/T190351#4071003 (10ssastry) This looks like something in VE. When I dump original and edited HTML [[ https://www.mediawiki.org/wiki/Parsoid/Debugging#Dumping_HTML_DOM_in_VE | following thes... [01:24:28] (03CR) 10DLynch: [C: 032] Use single-line editor for image captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418904 (owner: 10Esanders) [01:32:11] (03Merged) 10jenkins-bot: Use single-line editor for image captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418904 (owner: 10Esanders) [01:34:08] (03CR) 10jenkins-bot: Use single-line editor for image captions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418904 (owner: 10Esanders) [01:37:17] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Remove toolbar icon right border and add missing left one - https://phabricator.wikimedia.org/T190378#4071532 (10Samwilson) [06:05:02] 10VisualEditor, 10OOUI (OOUI-0.26.0), 10Regression: Fix page settings/advanced settings icons - https://phabricator.wikimedia.org/T190175#4071822 (10Volker_E) @Esanders Yeah, so the naming was kinda off for both icons reversely. I think it would be better for OOUI devs to go with clearer names: [[ https://co... [06:18:54] (03PS7) 10Divec: Use .spliceAt field when processing annotation operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/416735 (https://phabricator.wikimedia.org/T188709) [06:42:22] (03PS1) 10DLynch: DiffPage: Remember chosen diff mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421220 (https://phabricator.wikimedia.org/T189896) [06:45:22] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): When using historical visual diff beta feature, remember previous choice of visual/wikitext diff for your next diff - https://phabricator.wikimedia.org/T189896#4071925 (10DLynch) There's a patch that actually does it, so it can be... [07:02:23] (03PS1) 10Santhosh: Fix the image sizes in ve.ui.MWInternalLinkContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) [07:09:34] (03CR) 10jerkins-bot: [V: 04-1] Fix the image sizes in ve.ui.MWInternalLinkContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) (owner: 10Santhosh) [07:16:20] (03PS2) 10Santhosh: Fix the image sizes in ve.ui.MWInternalLinkContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) [07:19:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/421226 (owner: 10L10n-bot) [08:47:03] (03CR) 10VolkerE: "Screenshot on the task would help for further documentation (I plan on doing this for other changes before as well). Thx" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) (owner: 10Santhosh) [09:37:56] 10VisualEditor, 10OOUI (OOUI-0.26.0), 10Patch-For-Review, 10Regression: Fix page settings/advanced settings icons - https://phabricator.wikimedia.org/T190175#4072154 (10Volker_E) [09:45:33] 10VisualEditor, 10OOUI (OOUI-0.26.0), 10Patch-For-Review, 10Regression: Fix page settings/advanced settings icons - https://phabricator.wikimedia.org/T190175#4072166 (10Pginer-WMF) [10:27:15] (03CR) 10Santhosh: "> Patch Set 2:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) (owner: 10Santhosh) [10:28:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10Community-Liaisons, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), and 4 others: Change OOUI WikimediaUI theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px),... - https://phabricator.wikimedia.org/T97631#4072222 [10:29:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10Community-Liaisons, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), and 4 others: Change OOUI WikimediaUI theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px),... - https://phabricator.wikimedia.org/T97631#4072223 [10:58:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: Expose the configuration for the toolbar containing help and meta - https://phabricator.wikimedia.org/T114637#4072284 (10Schnark) 05Open>03Resolved a:03Schnark I don't know whether something changed, or whether at the time of reporting I just d... [11:54:47] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10Services (watching), and 2 others: Add translator for sverigesradio.se to MW translator repo - https://phabricator.wikimedia.org/T188893#4072409 (10Mvolz) I've submitted an update, @mobrovac from #services usually does deploy. FYI you can test translators loc... [12:31:37] 10WikiEditor: Bug: upload button on edit toolbar only allows images with $wgStrictFileExtensions = false - https://phabricator.wikimedia.org/T190258#4067937 (10RazeSoldier) I reproduce the step. I got: ``` One of the parameters filekey, file and url is required. ``` {F15962327} [12:36:01] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10Services (watching), and 2 others: Add translator for sverigesradio.se to MW translator repo - https://phabricator.wikimedia.org/T188893#4072506 (10Sebastian_Berlin-WMSE) Thanks you, @Mvolz. Yes, I did use the instructions on MW-wiki, in combination with the... [12:43:16] 10WikiEditor: Bug: upload button on edit toolbar only allows images with $wgStrictFileExtensions = false - https://phabricator.wikimedia.org/T190258#4072522 (10RazeSoldier) I take back what I said before, because the error was caused by the fact that I did not assign write permission to the web-server user. Whe... [12:54:26] 10WikiEditor: Bug: upload button on edit toolbar only allows images with $wgStrictFileExtensions = false - https://phabricator.wikimedia.org/T190258#4072572 (10RazeSoldier) Probably WikiEditor build-in javascript plugin does not support handling this error. The plugin can't ignore the error message and continue... [12:57:06] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10Services (watching), and 2 others: Add translator for sverigesradio.se to MW translator repo - https://phabricator.wikimedia.org/T188893#4072582 (10Mvolz) >>! In T188893#4072506, @Sebastian_Berlin-WMSE wrote: > Thanks you, @Mvolz. Yes, I did use the instructi... [13:06:18] 10WikiEditor: Bug: upload button on edit toolbar only allows images with $wgStrictFileExtensions = false - https://phabricator.wikimedia.org/T190258#4072605 (10RazeSoldier) [13:31:02] 10Citoid, 10VisualEditor, 10Services (watching), 10User-Ryasmeen, and 2 others: Add translator for sverigesradio.se to MW translator repo - https://phabricator.wikimedia.org/T188893#4072639 (10mobrovac) 05Open>03Resolved p:05Triage>03Normal a:03Mvolz Deployed, resolving. [13:31:07] (03PS1) 10Esanders: Follow-Up I84edeec38: Use font-size: 1em instead of unset for invisible templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421281 [13:33:25] 10VisualEditor, 10UI-Standardization, 10UI-Standardization-Kanban: Should the template buttons always be set to 14px? - https://phabricator.wikimedia.org/T190368#4072650 (10Esanders) In the screenshot they are too large, fixed the regression in https://gerrit.wikimedia.org/r/#/c/421281/ This is also the sty... [13:34:21] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Message missing at least in NWE preview - https://phabricator.wikimedia.org/T190018#4072653 (10Esanders) 05Open>03Resolved a:03Esanders Message is now showing on wikis: https://en.wikipedia.org/wiki/MediaWiki:Visuale... [13:40:35] 10Citoid, 10VisualEditor, 10Services (watching), 10User-Ryasmeen, and 2 others: Add translator for sverigesradio.se to MW translator repo - https://phabricator.wikimedia.org/T188893#4072681 (10Sebastian_Berlin-WMSE) Thanks a lot, @mobrovac. [14:21:05] (03CR) 10Jforrester: [C: 032] Follow-Up I84edeec38: Use font-size: 1em instead of unset for invisible templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421281 (owner: 10Esanders) [14:27:59] (03Merged) 10jenkins-bot: Follow-Up I84edeec38: Use font-size: 1em instead of unset for invisible templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421281 (owner: 10Esanders) [14:29:57] (03CR) 10jenkins-bot: Follow-Up I84edeec38: Use font-size: 1em instead of unset for invisible templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421281 (owner: 10Esanders) [14:45:54] (03CR) 10Esanders: [C: 031] Remove special `font-size` treatment following-up UI unified in `14px` base (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [14:56:23] 10Editing-team, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 10VisualEditor (Current work): Editing a page with unflagged changes should edit latest version in VE, even if you view the stable version - https://phabricator.wikimedia.org/T165283#4072888 (10clel) Ping to @jeremyb as I saw you... [14:59:01] (03PS1) 10Esanders: Increase opactiy on active tools [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/421308 [15:33:55] (03PS2) 10Jforrester: Toolbar: Increase opacity on active tools [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/421308 (owner: 10Esanders) [15:33:58] (03CR) 10Jforrester: [C: 032] Toolbar: Increase opacity on active tools [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/421308 (owner: 10Esanders) [15:38:01] (03PS3) 10Jforrester: Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [15:38:03] (03CR) 10Jforrester: Make save commands only executable when article is saveable (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [15:38:24] (03PS3) 10Jforrester: Create show preview/changes tools to show next to save button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [15:44:34] (03PS4) 10DLynch: Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [15:44:47] (03Merged) 10jenkins-bot: Toolbar: Increase opacity on active tools [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/421308 (owner: 10Esanders) [15:44:54] (03CR) 10DLynch: Make save commands only executable when article is saveable (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [15:58:15] (03PS1) 10Jforrester: Follow-up 436464af: Actually don't show the Cite tool if the config is broken [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/421328 (https://phabricator.wikimedia.org/T186276) [16:09:54] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): When using historical visual diff beta feature, remember previous choice of visual/wikitext diff for your next diff - https://phabricator.wikimedia.org/T189896#4073149 (10Deskana) Some delay is probably fine. This is still in beta... [16:31:26] (03CR) 10Jforrester: [C: 031] Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [16:54:47] (03CR) 10Esanders: [C: 04-1] "The icon still needs to be double size" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) (owner: 10Santhosh) [16:54:50] (03CR) 10DLynch: [C: 032] Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [16:55:46] (03CR) 10Bartosz Dziewoński: "Follow-ups: https://gerrit.wikimedia.org/r/#/c/421281/ https://gerrit.wikimedia.org/r/#/c/421221/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/420138 (https://phabricator.wikimedia.org/T97631) (owner: 10VolkerE) [16:57:45] 10VisualEditor, 10OOUI (OOUI-0.26.1), 10Patch-For-Review, 10Regression: Fix page settings/advanced settings icons - https://phabricator.wikimedia.org/T190175#4073357 (10Jdforrester-WMF) [16:58:55] (03CR) 10Bartosz Dziewoński: "This was my mistake in https://gerrit.wikimedia.org/r/#/c/420138/10/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.c" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) (owner: 10Santhosh) [17:01:16] (03CR) 10Bartosz Dziewoński: "Alternatively, replace these lines with "font-size: 3em;" instead." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) (owner: 10Santhosh) [17:03:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10Community-Liaisons, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), and 4 others: Change OOUI WikimediaUI theme to be optimized for font-size of 14px (0.875em×16px), instead of 12.8px (0.8em×16px),... - https://phabricator.wikimedia.org/T97631#4073385 [17:03:38] (03Merged) 10jenkins-bot: Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [17:03:40] (03PS3) 10Esanders: Fix the image sizes in ve.ui.MWInternalLinkContextItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) (owner: 10Santhosh) [17:05:36] (03CR) 10jenkins-bot: Make save commands only executable when article is saveable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418590 (owner: 10Esanders) [17:16:19] 10VisualEditor: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4073418 (10matmarex) [17:16:22] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance: Draw VisualEditor's non-CE block highlights using SVG polygons - https://phabricator.wikimedia.org/T53202#4073417 (10matmarex) [17:16:55] 10VisualEditor: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4066779 (10matmarex) [17:16:57] 10VisualEditor, 10VisualEditor-ContentEditable: Reference list
can overlap a template
because that's how HTML works - https://phabricator.wikimedia.org/T104540#4073421 (10matmarex) [17:20:53] (03CR) 10Bartosz Dziewoński: [C: 031] "Neat. I can +2 this if you're okay with this version, Santhosh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/421221 (https://phabricator.wikimedia.org/T97631) (owner: 10Santhosh) [17:22:13] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4073445 (10Jdforrester-WMF) [17:32:57] 10TemplateData, 10ProofreadPage, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10Patch-For-Review, 10VisualEditor (Current work): Remove VE `font-size` of 12.8px induced special treatment in extensions after unifying base font-size to 1... - https://phabricator.wikimedia.org/T189920#4073471 [17:33:26] 10VisualEditor-MediaWiki-2017WikitextEditor, 10WikiEditor, 10CodeEditor, 10Community-Tech, and 3 others: stashedit doesn't work as well non-wpTextbox1 editors - https://phabricator.wikimedia.org/T189824#4073475 (10Jdforrester-WMF) [17:33:53] 10Citoid, 10MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), 10Patch-For-Review, 10User-Ryasmeen, and 2 others: Prevent citoid from being enabled unless all required keys are present in MediaWiki:Citoid-template-type-map.json - https://phabricator.wikimedia.org/T186276#4073479 (10Jdforrester-W... [17:34:12] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "number" transclusion parameters - https://phabricator.wikimedia.org/T124850#4073481 (10Jdforrester-WMF) [17:34:38] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: TemplateData: Add parameter type for selecting one of predefined values (like "