[00:04:47] 10VisualEditor-MediaWiki-Mobile, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10VisualEditor (Current work): Closing mobile VE doesn't abandon auto save - https://phabricator.wikimedia.org/T190657#4079610 (10Ryasmeen) I understand the above patch fixes the case where user clicks the back... [01:47:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Internet-Explorer: In 2017 WikiEditor, dragging and dropping in editing window in Internet Explorer lead to weird results - https://phabricator.wikimedia.org/T190686#4086895 (10gh87) [07:06:59] 10WikiEditor, 10Multimedia, 10UploadWizard, 10JavaScript, 10Patch-For-Review: Bug: upload button on edit toolbar only allows images with $wgStrictFileExtensions = false - https://phabricator.wikimedia.org/T190258#4087067 (10TheDJ) Maybe we should have a discussion if wgstrictfileextensions should even co... [07:10:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Internet-Explorer: In 2017 WikiEditor, dragging and dropping and/or "Undo"-ing in editing window in Internet Explorer lead to weird results - https://phabricator.wikimedia.org/T190686#4087070 (10gh87) [07:53:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Internet-Explorer: In 2017 WikiEditor at IE11, page shifts up after eliminating one line or using keyboard shortcuts to remove a word - https://phabricator.wikimedia.org/T190903#4087092 (10gh87) [07:56:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOUI: VE help menu styling is broken on MonoBook (Apex theme) - https://phabricator.wikimedia.org/T190784#4083688 (10Schnark) >>! In T190784#4085880, @Deskana wrote: > Does the visual editor officially support Monobook? Should it? I don't think so, but I'm sure som... [09:59:01] 10WikiEditor: WikiEditor upload tool doesn't allow uploading over previously existing images - https://phabricator.wikimedia.org/T190913#4087374 (10TTO) [10:03:29] 10WikiEditor: WikiEditor upload tool doesn't allow uploading over previously existing images - https://phabricator.wikimedia.org/T190913#4087430 (10Johnywhy) {F16324592} {F16324591} [10:17:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Internet-Explorer: Syntax highlighting mode makes editing in 2017 WikiEditor in Internet Explorer worse - https://phabricator.wikimedia.org/T190720#4087494 (10Esanders) Ther... [10:19:48] 10VisualEditor, 10VisualEditor-VisualDiffs: Images not clickable in visual diff - https://phabricator.wikimedia.org/T190916#4087524 (10Schnark) [12:17:12] 10WikiEditor: WikiEditor upload tool doesn't allow uploading over previously existing images - https://phabricator.wikimedia.org/T190913#4087374 (10TheDJ) @Johnywhy correct. The UploadWizard doesn't allow this either {T42893}. It's one of those things that can be quite dangerous (especially for newbies) and beca... [13:08:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOUI: VE help menu styling is broken on MonoBook (Apex theme) - https://phabricator.wikimedia.org/T190784#4087990 (10Deskana) >>! In T190784#4087103, @Schnark wrote: > https://www.mediawiki.org/wiki/VisualEditor/Skin_requirements says yes. (Note that I'm not the on... [13:09:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOUI: VE help menu styling is broken on MonoBook (Apex theme) - https://phabricator.wikimedia.org/T190784#4087993 (10Deskana) p:05Triage>03Normal [13:18:33] (03CR) 10Esanders: [C: 04-1] API parameters with defaults cannot be required (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422133 (owner: 10simetrical) [13:50:06] (03PS2) 10simetrical: Required API parameters cannot have defaults [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422133 [14:30:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Internet-Explorer: In 2017 WikiEditor at IE11, page shifts up after eliminating one line or using keyboard shortcuts to remove a word - https://phabricator.wikimedia.org/T190903#4088171 (10gh87) [14:34:33] 10WikiEditor, 10Multimedia, 10UploadWizard, 10JavaScript, 10Patch-For-Review: Bug: upload button on edit toolbar only allows images with $wgStrictFileExtensions = false - https://phabricator.wikimedia.org/T190258#4088181 (10Johnywhy) >>! In T190258#4087067, @TheDJ wrote: > Maybe we should have a discussi... [15:58:30] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks like we always provide a 'paction' when calling this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422133 (owner: 10simetrical) [15:59:14] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Active link annotation styling conflicts with "plainlinks" class - https://phabricator.wikimedia.org/T190582#4088436 (10DLynch) [16:00:29] (03PS1) 10DLynch: MWExternalLinkAnnotation: add CSS to override plainlinks styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422427 (https://phabricator.wikimedia.org/T190582) [16:03:51] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (4922429f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 [16:06:45] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (4922429f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 (owner: 10Bartosz Dziewoński) [16:08:13] (03CR) 10Bartosz Dziewoński: [C: 031] "Implementation looks good, but I'd like someone else to look at this before I merge, I really feel like the menu options have too little h" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/422066 (owner: 10Esanders) [16:11:03] (03CR) 10Jforrester: "Hmm, yes, maybe less vertical padding might be good. That said, in VE-core they're only 33px high except for the biggest ones, which is ab" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/422066 (owner: 10Esanders) [16:13:38] (03Merged) 10jenkins-bot: Required API parameters cannot have defaults [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422133 (owner: 10simetrical) [16:14:36] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (4922429f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 (owner: 10Bartosz Dziewoński) [16:15:34] (03CR) 10Jforrester: "Ha." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 (owner: 10Bartosz Dziewoński) [16:15:36] (03CR) 10jenkins-bot: Required API parameters cannot have defaults [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422133 (owner: 10simetrical) [16:17:23] (03PS2) 10Jforrester: Update VE core submodule to master (4922429f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 (owner: 10Bartosz Dziewoński) [16:17:29] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (4922429f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 (owner: 10Bartosz Dziewoński) [16:20:35] (03CR) 10Bartosz Dziewoński: "Ha, oops." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 (owner: 10Bartosz Dziewoński) [16:28:19] (03CR) 10Bartosz Dziewoński: [C: 031] MWExternalLinkAnnotation: add CSS to override plainlinks styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422427 (https://phabricator.wikimedia.org/T190582) (owner: 10DLynch) [16:28:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Internet-Explorer: Syntax highlighting causes blurry text in 2017 WikiEditor in Internet Explorer - https://phabricator.wikimedia.org/T190720#4088560 (10TBolliger) [16:32:26] (03Merged) 10jenkins-bot: Update VE core submodule to master (4922429f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 (owner: 10Bartosz Dziewoński) [16:34:15] (03CR) 10jenkins-bot: Update VE core submodule to master (4922429f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422428 (owner: 10Bartosz Dziewoński) [17:00:17] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome, 10VisualEditor (Current work): Copy pasting wikitext between two NWE windows causes - https://phabricator.wikimedia.org/T190590#4088634 (10DLynch) a:03DLynch I couldn't find a duplicate with some quick searching. [17:05:05] 10VisualEditor, 10VisualEditor-VisualDiffs: Images not clickable in visual diff - https://phabricator.wikimedia.org/T190916#4087524 (10matmarex) This behavior disappears when I remove the following CSS rule: [it applies to an `
    ` element in that diff] ```[data-diff-action='none'] { opacity: 0.4; }```... [17:23:40] (03CR) 10Esanders: "Are we sure we want to make *all* the params required. For example a lot of wikis were missing 'case' but that wouldn't affect most users," [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/421328 (https://phabricator.wikimedia.org/T186276) (owner: 10Jforrester) [17:29:08] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome, 10VisualEditor (Current work): Copy pasting wikitext between two NWE windows causes - https://phabricator.wikimedia.org/T190590#4088749 (10matmarex) @DLynch Sorry, it was not a separate task, I just found the comment I was... [18:14:30] 10Editing-team, 10cloud-services-team (Kanban): Delete VPS project 'editor-enagement' on or after 2018-04-15 - https://phabricator.wikimedia.org/T190952#4088890 (10Andrew) [18:19:40] 10Editing-team, 10cloud-services-team (Kanban): Delete VPS project 'editor-enagement' on or after 2018-04-15 - https://phabricator.wikimedia.org/T190952#4088933 (10Andrew) update: @Catrope said I could delete deferred-changes immediately, so I did. [18:40:27] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 17.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422458 (owner: 10Libraryupgrader) [19:04:23] (03CR) 10VolkerE: [C: 032] "It's actually `42px` in height, which is sufficient (we long for minimum 40 for touch devices)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/422066 (owner: 10Esanders) [19:07:31] (03Merged) 10jenkins-bot: Remove icon padding from format tools in WMUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/422066 (owner: 10Esanders) [19:10:19] (03CR) 10jenkins-bot: Remove icon padding from format tools in WMUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/422066 (owner: 10Esanders) [19:53:02] (03PS1) 10Jforrester: doc: Document all public and protected PHP functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422481 [20:26:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/422537 (owner: 10L10n-bot) [20:27:40] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10Services (watching): Update translation-server, citoid - https://phabricator.wikimedia.org/T140539#4089285 (10akosiaris) As an FYI, T187194 has been filled in February under the is https://www.mediawiki.org/wiki/Code_stewardship_reviews context. At this point... [20:45:04] 10VisualEditor, 10VisualEditor-EditingTools, 10Browser-Support-Firefox, 10JavaScript, 10Maps (Kartographer): Map can't be saved in Basque Wikipedia with VE on Firefox - https://phabricator.wikimedia.org/T181500#4089312 (10TheDJ) ``` TypeError: this._markers is undefined [Learn More] load.php:46:201 _upda... [20:46:10] 10VisualEditor, 10VisualEditor-EditingTools, 10Discovery, 10Design, 10Maps (Kartographer): VE Map to support frame / frameless - https://phabricator.wikimedia.org/T143418#4089317 (10TheDJ) [21:55:19] 10VisualEditor, 10OOUI, 10Design: Align further (VE) icons to icon guidelines - https://phabricator.wikimedia.org/T190967#4089465 (10Volker_E) [21:56:03] 10Cite, 10OOUI: Merge Cite icons into OOUI - https://phabricator.wikimedia.org/T177847#3672297 (10Volker_E) [21:56:07] 10VisualEditor, 10OOUI, 10Design: Align further (VE) icons to icon guidelines - https://phabricator.wikimedia.org/T190967#4089479 (10Volker_E) [23:50:04] 10VisualEditor: Original wikitext editor appears as "background" when re-creating a deleted page in visual editor - https://phabricator.wikimedia.org/T190695#4089841 (10Harej) I'm trying it again with another deleted title. 1. Go to https://meta.wikimedia.org/w/index.php?title=Rfd&action=edit&redlink=1 – don't... [23:53:34] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Remove toolbar icon right border and add missing left one - https://phabricator.wikimedia.org/T190378#4089844 (10TBolliger) Without code mirror: {F16392046} [23:54:35] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Remove toolbar icon right border - https://phabricator.wikimedia.org/T190378#4089846 (10TBolliger) [23:56:39] 10WikiEditor, 10MediaWiki-extensions-CodeMirror, 10Community-Tech-Sprint: Remove toolbar icon right border - https://phabricator.wikimedia.org/T190378#4089849 (10TBolliger)