[00:07:55] 10VisualEditor, 10VisualEditor-ContentEditable: "Cannot read property 'findParent' of undefined" when editing a table - https://phabricator.wikimedia.org/T191858#4119029 (10Etonkovidova) [09:43:54] 10VisualEditor, 10VisualEditor-ContentEditable: "Cannot read property 'findParent' of undefined" when editing a table - https://phabricator.wikimedia.org/T191858#4119645 (10Esanders) p:05Triage>03Low That is definitely very broken table syntax, but ideally we wouldn't throw an exception. [09:47:42] 10VisualEditor: Insertion link into a table causes scroll jump - https://phabricator.wikimedia.org/T191878#4119663 (10Esanders) [09:50:18] 10VisualEditor: Insertion link into an empty table cell causes scroll jump - https://phabricator.wikimedia.org/T191878#4119676 (10Esanders) [10:03:31] (03PS1) 10Esanders: Use current selection for selectionBefore in staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425236 (https://phabricator.wikimedia.org/T191878) [10:04:57] (03PS1) 10Esanders: Use correct action test in CommentInspector teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 [10:09:02] (03CR) 10jerkins-bot: [V: 04-1] Use current selection for selectionBefore in staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425236 (https://phabricator.wikimedia.org/T191878) (owner: 10Esanders) [10:11:28] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425236 (https://phabricator.wikimedia.org/T191878) (owner: 10Esanders) [10:18:53] 10VisualEditor, 10ContentTranslation, 10Language-2018-Apr-June, 10Language-2018-Jan-Mar, and 2 others: CX2 translation view: JQMIGRATE: jQuery.fn.offset() requires an element connected to a document - https://phabricator.wikimedia.org/T188077#4119735 (10Nikerabbit) [12:09:42] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4091498 (10TheDJ) Speaking of.. the look on monobook at translatewiki.net, looks substantially different to me from @Esanders... [12:14:40] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4119982 (10stjn) It seems like Translatewiki uses old OOUI icons and Esanders uses new ones (see M229). Old ones have padding... [12:17:52] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4120000 (10TheDJ) https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Page_create&action=edit&useskin=monobook vs https:/... [13:27:12] 10VisualEditor, 10Community-Liaisons, 10Patch-For-Review, 10User-Ryasmeen: Change in-editor feedback tool to point to mediawiki.org - https://phabricator.wikimedia.org/T168886#4120150 (10Deskana) For reasons unknown to me, the above patch caused the feedback to be silently discarded. I have no idea why. [15:05:24] (03CR) 10Jforrester: [C: 031] Use correct action test in CommentInspector teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 (owner: 10Esanders) [15:26:09] (03CR) 10DLynch: [C: 04-1] "Action is `remove` if you press the Remove button at the bottom of the inspector." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 (owner: 10Esanders) [17:00:54] (03PS1) 10Bartosz Dziewoński: Fix margin on OOUI icon buttons in Apex theme (MonoBook) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/425315 (https://phabricator.wikimedia.org/T191031) [17:01:00] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4120820 (10matmarex) Looks like we just forgot to override some margin on OOUI buttons that is only present in Apex theme (us... [17:07:59] (03CR) 10Esanders: [C: 032] Fix margin on OOUI icon buttons in Apex theme (MonoBook) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/425315 (https://phabricator.wikimedia.org/T191031) (owner: 10Bartosz Dziewoński) [17:09:46] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4120838 (10Esanders) >>! In T191031#4119958, @TheDJ wrote: > Also I note that the new elements don't have textual content, on... [17:11:27] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4120843 (10Esanders) Also if you are referring to some icons being different in Apex that's because they are, but that will s... [17:15:11] (03Merged) 10jenkins-bot: Fix margin on OOUI icon buttons in Apex theme (MonoBook) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/425315 (https://phabricator.wikimedia.org/T191031) (owner: 10Bartosz Dziewoński) [17:29:01] (03CR) 10Esanders: "hmm - the remove button is only visible when editing" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 (owner: 10Esanders) [17:34:01] (03PS2) 10Esanders: Use correct action test in CommentInspector teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 [17:43:17] 10WikiEditor: The search and replace dialog has a white background color and no border on other skins than Vector - https://phabricator.wikimedia.org/T104600#4120944 (10Fomafix) 05Open>03Resolved a:03Esanders Solved by rEWED546933e52b37 (https://gerrit.wikimedia.org/r/423552). The search and replace dialog... [17:44:27] (03PS1) 10Esanders: Fix behaviour of getMode in NodeInspector's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425324 [17:49:11] 10VisualEditor: Ctrl + M shortcut is supposed to clear style in visual mode but it opens the ULS inspector instead on Chromium - https://phabricator.wikimedia.org/T191644#4120978 (10Catrope) [17:50:40] (03CR) 10jerkins-bot: [V: 04-1] Fix behaviour of getMode in NodeInspector's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425324 (owner: 10Esanders) [18:08:26] (03PS1) 10Jforrester: Update VE core submodule to master (66dfb2259) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425328 (https://phabricator.wikimedia.org/T191818) [18:27:50] (03CR) 10DLynch: [C: 04-1] "Now it works, but the behavior of pressing "done" on an empty comment has changed. Before it would treat done-on-empty as "remove", and no" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 (owner: 10Esanders) [18:31:39] 10Editing-team, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 10VisualEditor (Current work): Editing a page with unflagged changes should edit latest version in VE, even if you view the stable version - https://phabricator.wikimedia.org/T165283#3261893 (10matmarex) VE decides which revision... [18:33:23] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425324 (owner: 10Esanders) [18:37:27] (03PS3) 10Esanders: Use correct action test in CommentInspector teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 [18:43:46] (03PS2) 10Bartosz Dziewoński: Show revision info on historical diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/416355 (https://phabricator.wikimedia.org/T187614) (owner: 10Esanders) [18:45:06] 10VisualEditor, 10VisualEditor-ContentEditable: "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly) - https://phabricator.wikimedia.org/T191858#4121242 (10Deskana) [18:47:17] (03CR) 10Bartosz Dziewoński: "Alright, here's my proposal. Thoughts? I'm not sure if the "Highlight the headers…" part is a good idea. Screenshot: F16901875" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/416355 (https://phabricator.wikimedia.org/T187614) (owner: 10Esanders) [18:47:37] 10VisualEditor, 10VisualEditor-ContentEditable: "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly) - https://phabricator.wikimedia.org/T191858#4118944 (10Deskana) The table is still editable, despite this exception being thrown. As an aside, the table... [18:48:25] (03CR) 10Bartosz Dziewoński: "https://phabricator.wikimedia.org/F16901875" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/416355 (https://phabricator.wikimedia.org/T187614) (owner: 10Esanders) [18:56:50] 10VisualEditor, 10VisualEditor-ContentEditable, 10Discovery, 10Maps, and 2 others: Editing maps in VE - the marker area needs some adjustments - https://phabricator.wikimedia.org/T191582#4121289 (10jmatazzoni) [19:23:02] (03CR) 10Jforrester: [C: 031] "Works for me. Dan, are you OK with this design, at least for now?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/416355 (https://phabricator.wikimedia.org/T187614) (owner: 10Esanders) [19:26:51] (03CR) 10DLynch: [C: 032] Use correct action test in CommentInspector teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 (owner: 10Esanders) [19:29:56] (03Merged) 10jenkins-bot: Use correct action test in CommentInspector teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 (owner: 10Esanders) [19:33:00] (03CR) 10jenkins-bot: Use correct action test in CommentInspector teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425237 (owner: 10Esanders) [20:09:09] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 10Collaboration-Team-Triage, and 8 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#4121492 (10ssastry) [20:10:11] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10Parsoid (Section-Editing-Support): Parsoid DOM spec: Improve Cite representation to support section editing & simpler clients - https://phabricator.wikimedia.org/T146072#4121502 (10ssastry) [20:11:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 10Parsoid (Section-Editing-Support), 10Services (watching): Implement something similar to the RESTBase 'section' API to provide wikitext structure information - https://phabricator.wikimedia.org/T114402#4121505 (10ssastry) [20:19:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425399 (owner: 10L10n-bot) [21:35:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Internet-Explorer: Syntax highlighting causes blurry text in 2017 WikiEditor in Internet Explorer - https://phabricator.wikimedia.org/T190720#4121729 (10TBolliger) We will w... [22:24:08] (03PS1) 10VolkerE: Update OOUI to v0.26.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425437 [23:02:53] (03CR) 10Jforrester: [C: 032] Update OOUI to v0.26.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425437 (owner: 10VolkerE) [23:05:46] (03Merged) 10jenkins-bot: Update OOUI to v0.26.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425437 (owner: 10VolkerE) [23:09:23] (03CR) 10jenkins-bot: Update OOUI to v0.26.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425437 (owner: 10VolkerE) [23:29:45] 10VisualEditor: VisualEditor allows insertion of extension tags with empty content that later show errors - https://phabricator.wikimedia.org/T164053#3220097 (10Louperivois) One edit with the VisualEditor recently inserted «p /» in the wikicode, and the article then appeared in the Lint Errors. https://fr.wikip...