[00:03:41] 10Cite, 10Wikisource, 10Easy, 10Patch-For-Review, 10Technical-Debt: list item must not wrap the text in - https://phabricator.wikimedia.org/T49544#4125511 (10SMcCandlish) Yep. [01:17:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Internet-Explorer: In 2017 WikiEditor, dragging and dropping and/or performing IE11's "Undo" action lead to weird results - https://phabricator.wikimedia.org/T190686#4125703 (10gh87) [05:06:28] 10VisualEditor, 10ContentTranslation, 10Design, 10Patch-For-Review: Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049#4125892 (10gh87) [05:13:18] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10VisualEditor (Current work): Redirects do not appear in preview - https://phabricator.wikimedia.org/T191128#4125904 (10gh87) @Deskana I don't know why you marked it as "Resolved". Redirects are sti... [07:25:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425759 (owner: 10L10n-bot) [08:00:11] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4126136 (10Samwilson) [08:01:45] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4126148 (10Samwilson) @Simetrical is this something you know about? (You added the above failing test I think.) [08:02:01] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4126150 (10Samwilson) [08:02:59] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4126154 (10Samwilson) I don't think this has anything to do with VisualEditor, Herald. But whatever you reckon, you go for it. :) [10:02:28] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10VisualEditor (Current work): Redirects do not appear in preview - https://phabricator.wikimedia.org/T191128#4126385 (10Deskana) >>! In T191128#4125904, @gh87 wrote: > @Deskana I don't know why you... [10:40:03] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-2018-Apr-June, and 2 others: Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049#4126450 (10Pginer-WMF) [10:40:20] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-2018-Apr-June, and 2 others: Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049#4125873 (10Pginer-WMF) p:05Triage>03Normal [10:47:01] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4126458 (10Simetrical) I wrote the test in accordance with the comments in ApiBase.php: /** * (string) When PARAM_TYPE is 'submodule', used to... [10:47:17] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4126461 (10Simetrical) a:03Simetrical [10:48:35] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-2018-Apr-June, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)): Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049#4126462 (10Petar.petkovic) [10:51:00] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4126463 (10Simetrical) What's the param actually supposed to do? Just output the 'g' in paraminfo? What's the use-case? This should probably be docum... [10:59:21] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4126473 (10Simetrical) But please note that this has nothing to do with the first issue reported in this bug, which I understand w... [11:12:50] Hello, folks! [12:29:10] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Prompt user before automatically converting pasted HTML to wikitext - https://phabricator.wikimedia.org/T190079#4126681 (10Esanders) I was wondering before if the dialog should contain either a visual example of r... [12:45:42] 10Cite, 10VisualEditor, 10ContentTranslation, 10MediaWiki-extensions-Translate, and 3 others: Amazing Article Annotations - https://phabricator.wikimedia.org/T149667#4126713 (10Deskana) [12:51:28] 10VisualEditor, 10VisualEditor-VisualDiffs: Removal of license template isn't shown in visual diff - https://phabricator.wikimedia.org/T192076#4126739 (10Elitre) [13:01:34] (03CR) 10Esanders: "Do we need to do this? If the user drops some selected HTML should we give them the same option?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425462 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [13:12:50] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: The 2017 wikitext editor crashes with "Annotation with hash not found in store" when pasting certain rich text content - https://phabricator.wikimedia.org/T191487#4107407 (10Deskana) p:05Triage>03Low [13:56:44] (03PS1) 10Esanders: Apply diff attributes to all elements in an about group [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425817 (https://phabricator.wikimedia.org/T192076) [13:57:25] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Removal of license template isn't shown in visual diff - https://phabricator.wikimedia.org/T192076#4126739 (10Esanders) Testing with a monkey patch: {F16934305} [13:58:04] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Removal of license template isn't shown in visual diff - https://phabricator.wikimedia.org/T192076#4126927 (10Esanders) a:03Esanders [14:08:02] 10VisualEditor, 10Browser-Support-Firefox, 10Browser-Support-Google-Chrome: No toolbar on mobile views using Firefox and Chromium - https://phabricator.wikimedia.org/T191823#4117844 (10Esanders) Yeah - that is the noJS mobile editor. If you use desktop minerva, you will see it working fine with WikiEditor t... [14:11:13] 10VisualEditor, 10Browser-Support-Firefox, 10Browser-Support-Google-Chrome: No toolbar on mobile views using Firefox and Chromium - https://phabricator.wikimedia.org/T191823#4127001 (10Trizek-WMF) I've accessed that editor by the link located at the bottom of every page... [14:26:00] 10TemplateData, 10VisualEditor, 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Error when getting templatedata of all templates - https://phabricator.wikimedia.org/T192057#4127038 (10Anomie) >>! In T192057#4126463, @Simetrical wrote: > What's the param actually supposed to do? Just output the 'g' in... [15:03:58] (03CR) 10DLynch: "I think we need it flagged in some way -- insertDocument is used in a number of places, and I'm not sure all of them need to offer this. A" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425462 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [15:08:18] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Prompt user before automatically converting pasted HTML to wikitext - https://phabricator.wikimedia.org/T190079#4127184 (10DLynch) Snippet of your actual content in both modes does also have the drawback that we'd... [15:22:41] (03CR) 10Jforrester: [C: 031] Apply diff attributes to all elements in an about group [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425817 (https://phabricator.wikimedia.org/T192076) (owner: 10Esanders) [15:36:47] (03CR) 10Esanders: "It's used in ArticleTarget, but not mw.Target." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425559 (owner: 10Esanders) [15:38:09] (03CR) 10Jforrester: [C: 031] "Ah, yes, I see now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425559 (owner: 10Esanders) [15:38:27] (03PS2) 10Jforrester: mw.Target: Remove .protectedClasses, only used in ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425559 (owner: 10Esanders) [15:38:29] (03CR) 10Jforrester: [C: 032] mw.Target: Remove .protectedClasses, only used in ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425559 (owner: 10Esanders) [15:50:14] (03Merged) 10jenkins-bot: mw.Target: Remove .protectedClasses, only used in ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425559 (owner: 10Esanders) [15:52:21] (03CR) 10jenkins-bot: mw.Target: Remove .protectedClasses, only used in ArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425559 (owner: 10Esanders) [16:14:45] 10VisualEditor, 10WikiEditor, 10Community-Liaisons, 10Contributors-Team, and 9 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2543576 (10Capt_Swing) @Jdforrester-WMF @Whatamidoing-WMF is the rationale... [16:18:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Page-editing, 10Performance-Team (Radar): Use stashedit in new wikitext editor - https://phabricator.wikimedia.org/T189821#4127377 (10Krinkle) [16:18:25] 10VisualEditor-MediaWiki-2017WikitextEditor, 10WikiEditor, 10CodeEditor, 10Community-Tech, and 5 others: Expose api-stashedit JS to non-legacy textarea editors - https://phabricator.wikimedia.org/T189824#4127379 (10Krinkle) [16:18:49] 10VisualEditor, 10Contributors-Team, 10MediaWiki-Page-editing, 10MobileFrontend, and 2 others: Make mobile web editor use edit stashing - https://phabricator.wikimedia.org/T137338#4127380 (10Krinkle) [16:21:39] 10VisualEditor, 10VisualEditor-Media: Caption editing lets you insert text into the caption that changes the image formatting - https://phabricator.wikimedia.org/T192090#4127398 (10Deskana) [16:22:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Page-editing, 10Performance-Team (Radar): Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor) - https://phabricator.wikimedia.org/T189821#4127420 (10Jdforrester-WMF) [16:22:43] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Please strip trailing spaces and returns from media or image captions - https://phabricator.wikimedia.org/T68736#4127422 (10Deskana) p:05Normal>03Lowest [16:22:55] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Page-editing, 10Performance-Team (Radar), 10VisualEditor (Current work): Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor) - https://phabricator.wikimedia.org/T189821#4054736 (10Jdforrester-WMF) [16:23:48] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: When adding a reference, and a reference in a caption, in the same edit, then the ref in the caption is changed to the ref from the text - https://phabricator.wikimedia.org/T60322#4127430 (10Deskana) p:05Normal>03Lowest [16:23:58] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: in media item caption in a isn't blocked, which means page can get into an uneditable state on load - https://phabricator.wikimedia.org/T60270#4127432 (10Deskana) p:05Normal>03Lowest [16:24:17] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - https://phabricator.wikimedia.org/T68604#4127434 (10Deskana) p:05Normal>03Lowest [16:30:30] 10VisualEditor, 10WikiEditor, 10Community-Liaisons, 10Contributors-Team, and 9 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#4127451 (10Aklapper) @Capt_Swing: T131132#3010544 links to https://commons.... [16:41:53] 10VisualEditor: VE image search doesn't find images if the search query is entered too fast after the dialogue opens - https://phabricator.wikimedia.org/T182014#4127495 (10Deskana) p:05Normal>03Low [16:45:17] 10VisualEditor, 10VisualEditor-MediaWiki-Links: External links added using VE to Wikipedia are not language dependent - https://phabricator.wikimedia.org/T168219#4127517 (10Deskana) >>! In T168219#3716182, @Deskana wrote: > This was fixed in T177784. ...but I didn't merge them together for some reason. [16:45:24] 10VisualEditor, 10VisualEditor-MediaWiki-Links: External links added using VE to Wikipedia are not language dependent - https://phabricator.wikimedia.org/T168219#4127522 (10Deskana) [16:46:45] (03PS2) 10Esanders: MWExtensionNode: Diff mw.attrs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/423993 (https://phabricator.wikimedia.org/T191450) [16:46:47] (03PS1) 10Esanders: Refactor ve.dm.MWTransclusionNode.static.describeChanges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425854 [16:46:56] (03PS3) 10Esanders: MWExtensionNode: Diff mw.attrs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/423993 (https://phabricator.wikimedia.org/T191450) [16:46:58] (03PS2) 10Esanders: Refactor ve.dm.MWTransclusionNode.static.describeChanges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425854 [16:47:55] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Design: Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#4127538 (10Deskana) 05Open>03Invalid The icon in question is no longer there. {F16936498} [16:48:54] (03CR) 10Esanders: "ping" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397861 (owner: 10Esanders) [16:50:28] 10VisualEditor: Template highlighting gets stuck when template is shifted - https://phabricator.wikimedia.org/T168633#4127553 (10Deskana) p:05Low>03Lowest [16:50:57] 10VisualEditor: Template highlighting gets stuck when template is shifted (but the highlighting corrects itself as soon as you move the mouse) - https://phabricator.wikimedia.org/T168633#3370505 (10Deskana) [16:51:17] (03CR) 10Esanders: [C: 04-2] "Philosophically conflicts with I6afbbe303d1506426109e75c95f6be546ec48536, should be abandoned if that is merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/361731 (https://phabricator.wikimedia.org/T153315) (owner: 10Bartosz Dziewoński) [16:53:46] 10VisualEditor, 10VisualEditor-MediaWiki-Media: VisualEditor should strip trailing whitespace from the end of a media file caption - https://phabricator.wikimedia.org/T145238#4127569 (10Deskana) [16:53:50] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Please strip trailing spaces and returns from media or image captions - https://phabricator.wikimedia.org/T68736#4127567 (10Deskana) [16:56:52] 10VisualEditor, 10Community-Liaisons: Review documentation about the visual editor at Meta - https://phabricator.wikimedia.org/T137903#4127588 (10Deskana) 05Open>03declined It seems like there's no interest in actually doing this, and therefore it doesn't seem to be important to anyone. The person who reop... [16:58:15] 10VisualEditor, 10Wikimedia-Site-requests, 10Wikisource, 10User-notice: Enable VisualEditor by default for all users of all Wikisources - https://phabricator.wikimedia.org/T138391#4127592 (10Deskana) p:05Normal>03Lowest This is not a priority. [17:01:35] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: Copy/pasting a link to a page (except user page) on Flow sometimes can't be pasted (invalid/blacklisted HTML?) - https://phabricator.wikimedia.org/T135621#4127616 (10Deskana) p:05High>03Low [17:05:20] 10VisualEditor, 10WikiEditor, 10Community-Liaisons, 10Contributors-Team, and 9 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#4127627 (10Capt_Swing) Thanks @Aklapper, it does. One reasonably quick opti... [17:21:30] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10TechCom-RFC: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607#4127688 (10Quiddity) [17:28:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425867 (owner: 10L10n-bot) [17:30:51] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Design: Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#4127706 (10Jdforrester-WMF) I swear we actually made this change intentionally, but I can't find it for the life of me. [17:31:40] 10VisualEditor, 10Community-Liaisons: Review documentation about the visual editor at Meta - https://phabricator.wikimedia.org/T137903#4127711 (10Aklapper) From quickly skimming that page nowadays, basically all links go to mediawiki.org. So I'd say we're fine when it comes to duplication and bitrot. [17:32:48] (03CR) 10Jforrester: [C: 032] Refactor ve.dm.MWTransclusionNode.static.describeChanges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425854 (owner: 10Esanders) [18:16:02] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Design: Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#4127829 (10matmarex) 05Invalid>03Open If you look very closely, the icon is actually still there, but it's partially hidden under... [18:20:02] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOUI, 10Design: Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#4127846 (10Jdforrester-WMF) [18:20:14] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10OOUI, 10Design: Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#3218775 (10Jdforrester-WMF) That explains it. :-) [18:42:14] (03CR) 10Catrope: [C: 04-1] "Looks good in general, some minor issues inline" (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397861 (owner: 10Esanders) [19:27:07] (03CR) 10Esanders: Allow access to a fragment's async state (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397861 (owner: 10Esanders) [19:27:58] (03PS9) 10Esanders: Allow access to a fragment's async state [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397861 [19:30:51] (03CR) 10Jforrester: [C: 031] "Ed promises that more tests will be forthcoming in a future patch." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/397861 (owner: 10Esanders) [19:53:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: CodeMirror syntax highlighting shows overlapping text when word-wrap (hyphens, word-break) is overridden - https://phabricator.wikimedia.org/T192019#4128096 (10TBolliger) p:05Low>03Normal W... [20:11:10] 10VisualEditor, 10VisualEditor-ContentEditable, 10Discovery, 10Maps, and 2 others: Editing maps in VE - the marker area needs some adjustments - https://phabricator.wikimedia.org/T191582#4128140 (10Mooeypoo) a:03Mooeypoo [20:59:47] (03PS1) 10Esanders: Add extra copy/paste tests for clipboard keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425903 [21:04:50] (03CR) 10Jforrester: [C: 032] Add extra copy/paste tests for clipboard keys [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425903 (owner: 10Esanders) [21:08:26] 10VisualEditor, 10VisualEditor-Media, 10Parsoid: Caption editing lets you insert text into the caption that changes the image formatting - https://phabricator.wikimedia.org/T192090#4128344 (10matmarex) Parsoid needs to escape wikitext in image captions, I guess. The same might apply to gallery image captions. [21:12:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Easy: CodeMirror syntax highlighting shows overlapping text when word-wrap (hyphens, word-break) is overridden - https://phabricator.wikimedia.org/T192019#4128347 (10matmarex) Seems like an... [21:20:59] 10VisualEditor: Ctrl + M shortcut is supposed to clear style in visual mode but it opens the ULS inspector instead on Chromium - https://phabricator.wikimedia.org/T191644#4112501 (10matmarex) Same as T134164? [21:31:16] 10VisualEditor, 10VisualEditor-Media, 10Parsoid: Caption editing lets you insert text into the caption that changes the image formatting - https://phabricator.wikimedia.org/T192090#4127398 (10Arlolra) Dupe of T180611 [21:37:47] 10VisualEditor, 10VisualEditor-Media, 10Parsoid: Caption editing lets you insert text into the caption that changes the image formatting - https://phabricator.wikimedia.org/T192090#4128384 (10ssastry) [21:42:25] (03Abandoned) 10Esanders: ve.dm.MetaItem: Add removable flag, split from internal state [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/205291 (https://phabricator.wikimedia.org/T96528) (owner: 10Esanders) [21:42:35] (03Abandoned) 10Esanders: [WIP] Failing test case for removable meta items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/206846 (owner: 10Catrope) [21:51:18] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-2018-Apr-June, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)): Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049#4125873 (10Esanders) Inspectors, in particular, are going... [21:54:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Section name still appears in edit summary when you switch to full article editing - https://phabricator.wikimedia.org/T191590#4128447 (10Esanders) p:05Triage>03Low [22:08:59] 10VisualEditor: Tabbing on the caption field gives error "Uncaught TypeError: selection.isSingleCell is not a function" - https://phabricator.wikimedia.org/T192117#4128491 (10Ryasmeen) [22:15:38] (03PS1) 10Esanders: Fix layout of welcome dialog on smaller screens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425918 (https://phabricator.wikimedia.org/T191095) [22:23:15] (03PS1) 10Esanders: Hide stray checkmarks on mobile toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425919 [22:32:56] (03PS1) 10Esanders: Mobile: Hide top-level toolbar labels on narrow screens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425922 [22:43:12] (03CR) 10Jforrester: [C: 032] Hide stray checkmarks on mobile toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425919 (owner: 10Esanders) [22:43:37] (03CR) 10Jforrester: [C: 032] Mobile: Hide top-level toolbar labels on narrow screens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425922 (owner: 10Esanders) [22:44:28] (03CR) 10Jforrester: [C: 032] Fix layout of welcome dialog on smaller screens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425918 (https://phabricator.wikimedia.org/T191095) (owner: 10Esanders) [22:45:12] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): The image behind the intro dialog on mobile VE stretches strangely and makes the dialog look broken - https://phabricator.wikimedia.org/T191095#4128564 (10Jdforrester-WMF) a:03Jdforrester-WMF [22:45:35] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): The image behind the intro dialog on mobile VE stretches strangely and makes the dialog look broken - https://phabricator.wikimedia.org/T191095#4093164 (10Jdforrester-WMF) a:05Jdforrester-WMF>03Esanders [22:48:22] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), 10Patch-For-Review: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4091498 (10Volker_E) Margin of the top bar icons should be a bit increased. [22:48:52] (03CR) 10Jforrester: [C: 032] Convert remaining tools to OOUI [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/424036 (https://phabricator.wikimedia.org/T191031) (owner: 10Esanders) [22:49:33] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), 10VisualEditor (Current work): Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4128571 (10Jdforrester-WMF) a:03Esanders [22:49:59] 10WikiEditor, 10Design, 10VisualEditor (Current work): WikiEditor's Search and Replace icon is very similar to VisualEditor's "Switch to visual editing button", which is right next to it - https://phabricator.wikimedia.org/T143508#4128573 (10Jdforrester-WMF) a:03Esanders [22:50:34] (03Merged) 10jenkins-bot: Hide stray checkmarks on mobile toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425919 (owner: 10Esanders) [22:52:40] (03CR) 10jenkins-bot: Hide stray checkmarks on mobile toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425919 (owner: 10Esanders) [22:55:38] (03Merged) 10jenkins-bot: Mobile: Hide top-level toolbar labels on narrow screens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425922 (owner: 10Esanders) [22:55:40] (03Merged) 10jenkins-bot: Fix layout of welcome dialog on smaller screens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425918 (https://phabricator.wikimedia.org/T191095) (owner: 10Esanders) [22:57:25] (03Merged) 10jenkins-bot: Convert remaining tools to OOUI [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/424036 (https://phabricator.wikimedia.org/T191031) (owner: 10Esanders) [22:57:31] (03CR) 10jenkins-bot: Mobile: Hide top-level toolbar labels on narrow screens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425922 (owner: 10Esanders) [22:59:14] (03CR) 10jenkins-bot: Fix layout of welcome dialog on smaller screens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425918 (https://phabricator.wikimedia.org/T191095) (owner: 10Esanders) [22:59:33] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), 10VisualEditor (Current work): Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4128598 (10Volker_E) @TheDJ It was you about three years ago filing {T88979} :/ [23:14:26] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 2 others: Enable CodeMirror for RTL in 2017 Wikitext editor - https://phabricator.wikimedia.org/T191923#4128641 (10Jdforrester-WMF) [23:16:45] 10VisualEditor, 10VisualEditor-DataModel: Empty annotations cannot be deleted - https://phabricator.wikimedia.org/T96528#4128645 (10Jdforrester-WMF) Testing this on Beta Cluster just now given the prompt of the old code being abandonned, I confirmed that this is a problem (and possibly it's worse than it was b... [23:32:21] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 2 others: Enable CodeMirror for RTL in 2017 Wikitext editor - https://phabricator.wikimedia.org/T191923#4128676 (10Niharika) It can be done immediately. :) We need to enable Codemirror for RTL wik... [23:37:07] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 2 others: Enable CodeMirror for RTL in 2017 Wikitext editor - https://phabricator.wikimedia.org/T191923#4128682 (10TBolliger) @Niharika — I haven't tested yet, but is CodeMirror in 2017 WTE on RTL... [23:37:49] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 2 others: Enable CodeMirror for RTL in 2017 Wikitext editor - https://phabricator.wikimedia.org/T191923#4128683 (10Jdforrester-WMF) We could just hard-code in to CodeMirror's code for the 2010/2006...