[06:11:06] 10VisualEditor, 10Design: Alternatives for “Clear styling” icon - https://phabricator.wikimedia.org/T192341#4138412 (10Volker_E) @Deskana One of the pillars in the icon overhaul T177432 was to look into existing icons and evaluate them against the principles, like universality. Closest visual similarity, whic... [07:14:55] (03CR) 10Tchanders: [C: 032] MWExtensionNode: Diff mw.attrs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/423993 (https://phabricator.wikimedia.org/T191450) (owner: 10Esanders) [07:25:33] 10VisualEditor, 10Design: Alternatives for “Clear styling” icon - https://phabricator.wikimedia.org/T192341#4138487 (10Pginer-WMF) >>! In T192341#4136241, @Esanders wrote: >>>! In T192341#4135500, @Schnark wrote: >> Additionally, a separate "unlink" icon (i.e. crossed out variant of the current "link" icon) fo... [07:26:09] (03Merged) 10jenkins-bot: MWExtensionNode: Diff mw.attrs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/423993 (https://phabricator.wikimedia.org/T191450) (owner: 10Esanders) [07:26:11] (03Merged) 10jenkins-bot: Refactor ve.dm.MWTransclusionNode.static.describeChanges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425854 (owner: 10Esanders) [07:28:28] (03CR) 10jenkins-bot: MWExtensionNode: Diff mw.attrs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/423993 (https://phabricator.wikimedia.org/T191450) (owner: 10Esanders) [07:30:09] (03CR) 10jenkins-bot: Refactor ve.dm.MWTransclusionNode.static.describeChanges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425854 (owner: 10Esanders) [08:03:12] 10VisualEditor, 10Design: Alternatives for “Clear styling” icon - https://phabricator.wikimedia.org/T192341#4138527 (10RHo) >>! In T192341#4138487, @Pginer-WMF wrote: > For the case of removing links or other information elements the trash icon can be considered. The current icon always read to me as "forbidde... [08:20:32] 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10VisualEditor (Current work): [[data:image/png;base64... added to article using the VisualEditor - https://phabricator.wikimedia.org/T192392#4138546 (10TheDJ) > Thanks for letting us know! T... [09:24:51] 10VisualEditor, 10MobileFrontend: No toolbar on mobile views using Firefox and Chromium - https://phabricator.wikimedia.org/T191823#4138658 (10Trizek-WMF) While switching to mobile: ``` VM211:1 Uncaught ReferenceError: obtenir is not defined at :1:120 at DOMEval (load.php?debug=false&lang=e... [10:23:13] (03CR) 10Esanders: "mwgrep isSupported" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/405031 (owner: 10Jforrester) [10:24:56] (03CR) 10Esanders: [C: 032] "Oops, those are all false positives." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/405031 (owner: 10Jforrester) [10:32:20] (03Merged) 10jenkins-bot: Remove dummy isSupported function, deprecated in REL1_31 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/405031 (owner: 10Jforrester) [11:04:33] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10User-notice, 10VisualEditor (Current work): Add ellipsis to "Publish changes" b... - https://phabricator.wikimedia.org/T189803#4138844 [11:04:47] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#4138847 (10Deskana) [11:04:50] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10User-notice, 10VisualEditor (Current work): Add ellipsis to "Publish changes" b... - https://phabricator.wikimedia.org/T189803#4138846 [11:07:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#4138851 (10Deskana) 05Open>03Resolved a:03Deskana With the completion of T189803, there is now more... [11:14:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#4138861 (10Deskana) >>! In T44138#3957958, @Pinnerup wrote: > This issue has been open for 5+ years now. P... [11:19:24] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), 10VisualEditor (Current work): Pasting HTML in NWE can't be undone via keyboard - https://phabricator.wikimedia.org/T182402#4138870 (10Deskana) 05Open>03Resolved [16:17:12] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 3 others: Enable CodeMirror for RTL in 2017 Wikitext editor - https://phabricator.wikimedia.org/T191923#4139810 (10Deskana) >>! In T191923#4137137, @Niharika wrote: > @Deskana I'm thinking of expan... [16:46:05] (03PS1) 10DLynch: PlainTextStringTransferHandler: Forbid for paste again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427435 (https://phabricator.wikimedia.org/T192320) [16:46:44] (03PS1) 10DLynch: Add a plain text paste transfer handler for source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/427436 (https://phabricator.wikimedia.org/T192320) [16:53:04] (03PS2) 10DLynch: Add a plain text paste transfer handler for source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/427436 (https://phabricator.wikimedia.org/T190590) [16:53:13] (03PS2) 10DLynch: PlainTextStringTransferHandler: Forbid for paste again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427435 (https://phabricator.wikimedia.org/T190590) [16:53:19] (03CR) 10jerkins-bot: [V: 04-1] Add a plain text paste transfer handler for source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/427436 (https://phabricator.wikimedia.org/T190590) (owner: 10DLynch) [16:54:43] Huh, I don't think I've ever updated a commit which had another commit depending on it with the timing such that it causes a `-1 depended-on commit failed to merge` message. [17:25:27] 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10VisualEditor (Current work): [[data:image/png;base64... added to article using the VisualEditor - https://phabricator.wikimedia.org/T192392#4140120 (10matmarex) >>! In T192392#4137375, @Esa... [17:25:56] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 3 others: Enable CodeMirror in 2017 Wikitext editor in all wikis without the beta feature - https://phabricator.wikimedia.org/T191923#4140121 (10Niharika) [18:22:11] Kemayo: Isn't life fine? [18:53:33] 10VisualEditor, 10Design: Alternatives for “Clear styling” icon - https://phabricator.wikimedia.org/T192341#4140452 (10Jdforrester-WMF) We tried it out back in 2013 (?) and people assumed it would delete the link and anchor, not just the link, so we moved to the clear icon which was the same as used by Google... [19:03:42] 10VisualEditor, 10Design: Alternatives for “Clear styling” icon - https://phabricator.wikimedia.org/T192341#4140468 (10Volker_E) I'd suggest to separate concerns here, let's start with the 'clear styling' icon and separate the 'remove link' into another task. [20:14:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/427520 (owner: 10L10n-bot) [21:18:48] (03CR) 10Bartosz Dziewoński: "So this seems to work, but the size of these rules makes me think we are doing something wrong. I noticed that just removing the "width: 2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427167 (https://phabricator.wikimedia.org/T192378) (owner: 10DLynch) [21:51:38] 10VisualEditor, 10OOUI: Allow putting OOUI toolbar menus into an overlay - https://phabricator.wikimedia.org/T192505#4140980 (10matmarex) p:05Triage>03Normal [22:22:13] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome: Pasting long content is many times slower than inserting the same content in a different way - https://phabricator.wikimedia.org/T189556#4141067 (10matmarex) a:03matmarex Looks like thi... [22:26:06] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I just realized that your original fix also drastically improved the performance of plaintext pastes in NWE (T189556) so I would be sad if" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427435 (https://phabricator.wikimedia.org/T190590) (owner: 10DLynch) [22:31:24] (03CR) 10DLynch: "There's actually another part to this patch already: I71db368c683a6a846569d7627f4cc73e907a61d2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427435 (https://phabricator.wikimedia.org/T190590) (owner: 10DLynch) [22:33:05] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome: Pasting long content is many times slower than inserting the same content in a different way - https://phabricator.wikimedia.org/T189556#4141101 (10DLynch) It's going to get briefly [re-b... [22:38:44] (03CR) 10DLynch: "On one level it's just a pain because there's no meta-selector for "heading" in CSS; if we could just do `:heading .ve-ce-focusableNode-in" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427167 (https://phabricator.wikimedia.org/T192378) (owner: 10DLynch) [22:40:05] (03CR) 10Bartosz Dziewoński: [C: 031] "Leaving for Ed" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427435 (https://phabricator.wikimedia.org/T190590) (owner: 10DLynch) [22:41:04] (03CR) 10Bartosz Dziewoński: [C: 031] "(Assuming that those do in fact have some important purpose, or if you don't want to dig into this and just fix the bug, I think this is f" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427167 (https://phabricator.wikimedia.org/T192378) (owner: 10DLynch) [22:52:00] 10Editing-team, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 10VisualEditor (Current work): Editing a page with unflagged changes should edit latest version in VE, even if you view the stable version - https://phabricator.wikimedia.org/T165283#4141147 (10matmarex) a:03matmarex [23:08:15] (03CR) 10Jforrester: "Add a comment saying "// Support: IE11 (can't use :matches)" so when we drop IE11 support we can switch to that?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427167 (https://phabricator.wikimedia.org/T192378) (owner: 10DLynch) [23:12:23] (03CR) 10DLynch: "> Add a comment saying "// Support: IE11 (can't use :matches)" so" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427167 (https://phabricator.wikimedia.org/T192378) (owner: 10DLynch) [23:12:52] (03CR) 10Jforrester: "Boo. Yeah, but worth noting anyway?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427167 (https://phabricator.wikimedia.org/T192378) (owner: 10DLynch) [23:14:37] (03PS2) 10DLynch: FocusableNode: Adjust alignment in headings [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427167 (https://phabricator.wikimedia.org/T192378) [23:29:07] (03PS3) 10Jforrester: Update VE core submodule to master (bf97ca335) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/427154 (https://phabricator.wikimedia.org/T188709)