[02:22:46] (03CR) 10Krinkle: "I don't understand. The navStart expression will always evaluate to the same. It does not change or come into existence later." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) (owner: 10Krinkle) [02:30:17] (03CR) 10Krinkle: "Regarding the underlying problem, I see now that the different base numbers is intentional per Schema:Edit. The non-init actions use 'init" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) (owner: 10Krinkle) [07:48:08] 10TemplateData, 10VisualEditor, 10WMSE-Bug-Reporting-and-Translation-2018: Make docSubpage configurable - https://phabricator.wikimedia.org/T192868#4152382 (10Lokal_Profil) [10:15:56] 10VisualEditor, 10Wikimedia-Site-requests: Enable Visual Editor in Draft namespace (102) in etwiki - https://phabricator.wikimedia.org/T192254#4152796 (10Urbanecm) [10:16:04] 10VisualEditor, 10Wikimedia-Site-requests: Enable Visual Editor in Draft namespace (102) in etwiki - https://phabricator.wikimedia.org/T192254#4132797 (10Urbanecm) p:05Triage>03Low [10:20:03] 10VisualEditor, 10Wikimedia-Site-requests: Enable visual editor at fi.wikibooks.org - https://phabricator.wikimedia.org/T192135#4129026 (10Urbanecm) p:05Triage>03Low [11:26:22] (03CR) 10Esanders: [C: 032] MWWikitextSurface onCopy: set text/x-wiki content if available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428525 (owner: 10DLynch) [11:37:02] (03Merged) 10jenkins-bot: MWWikitextSurface onCopy: set text/x-wiki content if available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428525 (owner: 10DLynch) [11:39:01] (03CR) 10jenkins-bot: MWWikitextSurface onCopy: set text/x-wiki content if available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428525 (owner: 10DLynch) [12:22:56] 10Cite, 10VisualEditor, 10Parsoid, 10Wikimedia-Hackathon-2018: Improve referencing in articles - https://phabricator.wikimedia.org/T192872#4153397 (10Lea_WMDE) [12:35:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: Mediawiki | 2017 wikitext editor, custom message Templatebug - https://phabricator.wikimedia.org/T192901#4153419 (10Tomybrz) [12:35:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: Mediawiki | 2017 wikitext editor, custom message Templatebug - https://phabricator.wikimedia.org/T192901#4153422 (10Tomybrz) p:05Triage>03High [12:50:59] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Multimedia: Provide button to replace image in Visual Editor Gallery - https://phabricator.wikimedia.org/T192717#4153459 (10Anthere) Support that.... [13:23:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: Mediawiki | 2017 wikitext editor, custom message Templatebug - https://phabricator.wikimedia.org/T192901#4153567 (10Aklapper) p:05High>03Triage @Tomybrz: Thanks for reporting this and welcome to Phabricator. As you set the [[ ht... [13:29:16] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: Mediawiki | 2017 wikitext editor, custom message Templatebug - https://phabricator.wikimedia.org/T192901#4153588 (10Aklapper) 05Open>03stalled Steps: 1. I go to https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Pr%C3%A9f%C3%A9rences#mw... [13:42:26] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4153617 (10Anomie) [13:50:45] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4153617 (10ssastry) This looks like a case where Parsoid serialized the page without access to the HTML of the previous revision and did a normalizing html -> wt transformation. To be veri... [13:51:15] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4153658 (10ssastry) Ah, I have to look at the part about the {{#translate}} parser function. [14:05:30] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4153746 (10ssastry) >>! In T192909#4153658, @ssastry wrote: > Ah, I have to look at the part about the `{{#translate}}` parser function. Right, this is the part in (2) above and the bug i... [14:27:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: Mediawiki | 2017 wikitext editor, custom message Templatebug - https://phabricator.wikimedia.org/T192901#4153787 (10Tomybrz) {F17286231} I removed all gadgets and all script (local and global): nothing happened [14:45:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: Mediawiki | 2017 wikitext editor, custom message Templatebug - https://phabricator.wikimedia.org/T192901#4153880 (10Tomybrz) I found the bug, when i loading template for custom message, If a title needs to be loaded : 2017 Wikitext... [14:49:58] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: Mediawiki | 2017 wikitext editor, custom message Templatebug - https://phabricator.wikimedia.org/T192901#4153887 (10Tomybrz) {F17286400} with bug {F17286404} without bug [15:01:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: Mediawiki | 2017 wikitext editor, custom message Templatebug - https://phabricator.wikimedia.org/T192901#4153912 (10Aklapper) Please provide a clear list of steps to reproduce, step by step. See T192901#4153588 for an example. I do... [15:28:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message when no title is set - https://phabricator.wikimedia.org/T192901#4154058 (10Aklapper) 05stalled>03Open [15:28:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message when no title is set - https://phabricator.wikimedia.org/T192901#4153407 (10Aklapper) Okay, ignore my last comment. I hope this is... [15:43:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message when no title is set - https://phabricator.wikimedia.org/T192901#4154169 (10Tomybrz) 05Open>03stalled wait i write step for mo... [15:44:19] (03PS2) 10DLynch: MWWikitextSurfaceFragment: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) [15:47:53] (03PS3) 10DLynch: MWWikitextSurfaceFragment: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) [15:56:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message when no title is set - https://phabricator.wikimedia.org/T192901#4154260 (10Tomybrz) After research, gadgets and scripts do not im... [15:57:28] 10Cite, 10MediaWiki-jQuery-Tablesorter, 10Technical-Debt: Technical debt: jquery.tablesorter hardcodes exclude for span.references - https://phabricator.wikimedia.org/T192931#4154265 (10Krinkle) [15:59:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message when no title is set - https://phabricator.wikimedia.org/T192901#4154282 (10Tomybrz) [16:01:13] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature: "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message when no title is set - https://phabricator.wikimedia.org/T192901#4154284 (10matmarex) a:03matmarex [16:12:31] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DesktopArticleTarget: Setup toolbar before section title input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428678 (https://phabricator.wikimedia.org/T192901) [16:13:46] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature, 10Patch-For-Review, 10VisualEditor (Current work): "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message when no title is set - https://phabricator.wikimedia.org/T192901#4154385 (10matmarex) [16:16:13] (03CR) 10Jforrester: [C: 032] ve.init.mw.DesktopArticleTarget: Setup toolbar before section title input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428678 (https://phabricator.wikimedia.org/T192901) (owner: 10Bartosz Dziewoński) [16:24:43] (03Merged) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Setup toolbar before section title input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428678 (https://phabricator.wikimedia.org/T192901) (owner: 10Bartosz Dziewoński) [16:26:39] (03CR) 10jenkins-bot: ve.init.mw.DesktopArticleTarget: Setup toolbar before section title input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428678 (https://phabricator.wikimedia.org/T192901) (owner: 10Bartosz Dziewoński) [16:45:28] 10VisualEditor-Tables, 10VisualEditor (Current work): Users can't tab into or out of table captions - https://phabricator.wikimedia.org/T192163#4154536 (10DLynch) a:03DLynch [17:26:07] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message... - https://phabricator.wikimedia.org/T192901#4154648 [17:43:34] 10VisualEditor, 10VisualEditor-VisualDiffs: Simply cloning diff header doesn't seem like a good idea - https://phabricator.wikimedia.org/T192755#4154746 (10matmarex) a:03matmarex I supposed we could move it instead of duplicating it, would that work? [18:42:51] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4154940 (10Deskana) Moving to external for now since @ssastry thinks this is primarily a Parsoid problem; if he determines that it's not, then I'll move it back to triage. [18:49:28] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10VisualEditor (Current work): "TypeError: Cannot read property 'isDisabled' of null" trying to load a template for a custom message... - https://phabricator.wikimedia.org/T192901#4154954 [18:50:30] 10Cite, 10Parsoid, 10Wikimedia-Hackathon-2018: Improve referencing in articles - https://phabricator.wikimedia.org/T192872#4154956 (10Deskana) From what I can tell, this task is proposing a markup change that would be implemented in the Cite extension, and isn't related to the visual editor, so I'm removing... [18:50:48] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10VisualEditor (Current work): "TypeError: Cannot read property 'isDisabled' of null" when opening the editor for new section with ... - https://phabricator.wikimedia.org/T192901#4154958 [18:52:38] 10TemplateData, 10VisualEditor, 10WMSE-Bug-Reporting-and-Translation-2018: Make docSubpage configurable - https://phabricator.wikimedia.org/T192868#4154960 (10Deskana) [18:55:26] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Simply cloning diff header doesn't seem like a good idea - https://phabricator.wikimedia.org/T192755#4154978 (10Deskana) p:05Triage>03Normal [19:01:09] hmm. i'm missing the checkmarks in my checkboxes on the 2010 editor.... [19:01:17] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Multimedia: Provide button to replace image in Visual Editor Gallery - https://phabricator.wikimedia.org/T192717#4155006 (10Deskana) p:05Triage>03Low Improvements in gallery functionality are a very low priority issue for the Editin... [19:01:22] and apparently other people have too many checkmarks... [19:07:42] 10WikiEditor: Too many and too few checkmarks for checkboxes on 2010 editor - https://phabricator.wikimedia.org/T192951#4155040 (10TheDJ) [19:09:23] thedj: That's… odd. [19:10:10] MatmaRex: Might https://phabricator.wikimedia.org/T192951 be the hide-the-checkmark-icon CSS stuff? [19:11:05] James_F: no doubt [19:11:14] weirdest thing is that apparently it's somewhat intermittant. [19:11:16] * James_F sighs. [19:11:28] Yeah, might depend on RL's load order? [19:11:35] thedj: safari used to have the dumbest issues with the checkmarks [19:11:53] and i'm not sure if my issue and redrose's are related. but it seems weird that we have 2 checkmark issues in one release to not be at least slightly connected. [19:12:08] there was a particular thing where they would disappear if we used SVG background-image with no PNG fallback [19:12:18] but we do have PNG fallbacks now, so this should be a different problem [19:14:20] MatmaRex: if the checkmark is initially checked, then the checkmark is visible. [19:14:25] thedj: sherry asked me to look at that VPT thread, i was going to do this later. but i'm not sure if i can do anything other than trying out stuff and seeing what sticks [19:14:34] …huh [19:15:17] https://phabricator.wikimedia.org/F17290445 [19:15:39] first checkmark initially unchecked, checked after page load. second checkmark initially checked. [19:16:11] i don't even have a mac, so, no idea what i can do about this one [19:16:18] with the windows XP issue at least ican run it in a VM [19:23:51] that's weird... [19:24:07] the inspector says the icon is always in hover state, always matches ".oo-ui-checkboxInputWidget.oo-ui-widget-enabled [type='checkbox']:checked:hover + span" [19:24:46] ah no, it had opened the inspector from it.. [19:27:06] yuck, another one of those cases where i wish we had the old branch running somewher. [19:28:53] thedj: for reference, the old safari checkbox bug i remember was https://phabricator.wikimedia.org/T89309 , but that should no longer apply [19:30:10] does seem very similar [19:34:11] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4155124 (10ssastry) >>! In T192909#4153654, @ssastry wrote: > So, the only thing left to resolve is whether VE did something to the page OR as I speculated there, there was a RB failure wi... [19:35:16] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4155135 (10ssastry) p:05Triage>03Normal [19:35:56] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4153617 (10ssastry) a:03Arlolra [19:53:30] thedj: ooof, the closer i look the weirder it gets [19:54:08] thedj: if you look closely at the screenshot: https://en.wikipedia.org/wiki/File:Vpt_redrose64_checkmarks.PNG these checkmarks are from the old icon set. we replaced them with different ones in v0.26.3 [19:54:25] but that is the same version which added the "extra" icons to the page HTML [19:54:40] so this screenshot is impossible [19:55:01] or something was seriously messed up with WMF deployment [19:55:10] or i am terribly misunderstanding how our caching works [19:56:10] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4155231 (10Arlolra) > But, parse.js --prefix mediawikiwiki --pboutfile /tmp/dp.json --pageName 'Manual:Hooks' < /dev/null > /dev/null does the right thing. So, some edge case bug in the Pa... [19:59:48] MatmaRex: Or all of the above. [20:05:06] 10VisualEditor, 10Parsoid: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4155253 (10Arlolra) I assume what's happening is that a bug / necessary condition of section wrapping is extending the template ranges to include parts of the page with legitimate dsr and... [20:15:29] 10WikiEditor: Too many and too few checkmarks for checkboxes on 2010 editor - https://phabricator.wikimedia.org/T192951#4155040 (10matmarex) I don't know yet how this could happen, but I am thinking about it very hard. Assuming that there is no catastrophic bug in browser's parsing of CSS (this is very simple co... [20:15:33] 10VisualEditor, 10OOUI, 10Browser-Support-Apple-Safari, 10User-Ryasmeen, and 4 others: [Regression wmf17] Safari - cannot click in any check-box - https://phabricator.wikimedia.org/T89309#4155289 (10matmarex) [20:16:40] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing source code of File with Beta new wikitext feature yields blank white section. - https://phabricator.wikimedia.org/T192658#4155291 (10Framawiki) [Removing BetaFeature tags since #visualeditor-mediawiki-2017wikitexteditor looks appropriate] [20:27:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428813 (owner: 10L10n-bot) [22:26:06] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Verified, 10Verified-in-Phase0, 10VisualEditor (Current work): Comment and transclusions in headings are misaligned - https://phabricator.wikimedia.org/T192378#4155781 (10Ryasmeen) [22:40:54] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10User-notice, and 2 others: Add ellipsis to "Publish changes" button when editing ... - https://phabricator.wikimedia.org/T189803#4155799 [23:00:19] 10VisualEditor, 10MobileFrontend, 10UI-Standardization, 10Readers-Web-Backlog (Design): Abort dialog in mobile editing should feature primary destructive button - https://phabricator.wikimedia.org/T192333#4155841 (10Volker_E) @Jdlrobson You can make the Discard button whatever you want in OOUI. [23:00:43] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Refreshing a source page or a page after exiting the 2017 wikitext editor switches back to one of old editors (when VisualEditor is temporarily disabled) - https://phabricator.wikimedia.org/T190765#4155843 (10gh87) [23:03:45] 10VisualEditor, 10MobileFrontend, 10UI-Standardization, 10Readers-Web-Backlog (Design): Abort dialog in mobile editing should feature primary destructive button - https://phabricator.wikimedia.org/T192333#4155854 (10Jdlrobson) @VolkerE code is here: https://github.com/wikimedia/mediawiki-extensions-MobileF... [23:28:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Internet-Explorer: At IE11, URL address bar changes while using the NWE and selecting "Always give me the source editor" - https://phabricator.wikimedia.org/T192974#4155922 (10gh87) [23:30:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Refreshing a source page or a page after exiting the 2017 wikitext editor switches back to one of old editors (when VisualEditor is temporarily disabled) - https://phabricator.wikimedia.org/T190765#4155937 (10gh87) @Deskana My apologies for not answe... [23:33:53] (03PS1) 10VolkerE: Update OOUI to v0.26.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428857 [23:37:59] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Internet-Explorer: At IE11, URL address bar changes while using the NWE and selecting "Always give me the source editor" - https://phabricator.wikimedia.org/T192974#4155947 (10gh87) [23:40:05] MatmaRex: ^ [23:45:12] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOUI to v0.26.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428857 (owner: 10VolkerE) [23:48:40] (03Merged) 10jenkins-bot: Update OOUI to v0.26.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428857 (owner: 10VolkerE) [23:50:29] Volker_E: i'll merge mw/vendor and mw/core when you have them both up [23:50:38] MatmaRex: sure [23:50:44] (03PS1) 10Legoktm: Move PHP classes to includes/ [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/428862 [23:50:46] MatmaRex: I'm fighting with core right now [23:52:08] (03PS1) 10Legoktm: Add missing @covers tag [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/428863 [23:52:13] (03CR) 10jenkins-bot: Update OOUI to v0.26.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428857 (owner: 10VolkerE) [23:54:16] 10TemplateData, 10VisualEditor, 10Continuous-Integration-Config, 10Patch-For-Review, 10User-Ryasmeen: Set up phpunit coverage job for TemplateData - https://phabricator.wikimedia.org/T192775#4155993 (10Legoktm) 05Open>03Resolved a:03Legoktm Done. Coverage is going to be 0 until https://gerrit.wikim... [23:57:32] :) [23:58:00] Volker_E: looks like you won, good to merge? [23:58:13] depends-on is missing in commit msg [23:58:24] one mom [23:58:56] oh, indeed. (that shouldn't really matter though) [23:59:51] yeah, but to be nicely done