[00:00:02] (updated) [00:05:03] MatmaRex: thanks for your help, if you now merge the DateTimeInputWidget, I'll be more than happy :P ;) [00:05:40] MatmaRex: tongue-in-cheek msg [00:05:57] heh [00:05:58] MatmaRex: thanks and have a good night! [00:06:04] hmm, where was that patch though, did we not merge it? [00:06:18] https://gerrit.wikimedia.org/r/#/c/372596/ [00:06:23] yup [00:06:31] oh, i removed myself from it, huh [00:06:50] wasn't sure, what I did that this happened :) [00:11:19] Volker_E: +2'd, have a good evening ;) [00:11:21] so awesome [00:11:27] thanks! [00:11:51] August 2017 [00:15:04] Volker_E: pff, i just had a patch from March 2017 merged today ;) https://gerrit.wikimedia.org/r/#/c/341047/ [00:15:42] haha, doesn't make my excitement smaller [00:16:17] maybe we should not accept merging tasks that are earlier than 6 months [00:16:24] seems to help [00:16:31] ;D [00:35:26] 10VisualEditor: "Cancel" button does not change back to "Back" in Media Settings dialog when a user switches back to "Search" tab from "Upload" - https://phabricator.wikimedia.org/T192976#4156056 (10Ryasmeen) [00:37:06] 10VisualEditor: "Cancel" button does not change back to "Back" in Media Settings dialog when a user switches back to "Search" tab from "Upload" - https://phabricator.wikimedia.org/T192976#4156066 (10Ryasmeen) [01:42:35] (03PS6) 10Krinkle: LinkAnnotationInspector: add a button to edit the label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278284 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [01:50:15] (03CR) 10Krinkle: [C: 031] "I noticed in local testing that without this patch, trying to select the inner contents of a link and typing results in plain text on demo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278284 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [05:54:58] 10VisualEditor, 10ContentTranslation, 10Language-2018-Apr-June, 10Language-2018-Jan-Mar, and 2 others: CX2 translation view: JQMIGRATE: jQuery.fn.offset() requires an element connected to a document - https://phabricator.wikimedia.org/T188077#3995536 (10KartikMistry) Fixed in CX2 and deployed in Production... [08:13:48] 10VisualEditor: VE image search doesn't find images if the search query is entered too fast after the dialogue opens - https://phabricator.wikimedia.org/T182014#4156397 (10Deskana) >>! In T182014#4146456, @Whatamidoing-WMF wrote: > This happens sometimes when you're just typing. For @NH, "too fast" sometimes se... [08:14:00] 10VisualEditor: VE image search doesn't find images if the search query is entered too soon after the dialogue opens - https://phabricator.wikimedia.org/T182014#4156398 (10Deskana) [08:28:05] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor handles selecting/pasting newlines weirdly - https://phabricator.wikimedia.org/T157408#3004220 (10WolfgangRieger) The result I get (Opera 52.0, Ubuntu 16.04, Wikitext editor 2017) is: ``` abd def def... [08:33:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Link to Special:Undelete not accessible when using the Visual Editor and the beta Wikitext editor - https://phabricator.wikimedia.org/T170570#3435471 (10Deskana) >>! In T170570#4148289, @Stryn wrote: > This is one of reasons why admins possible don't... [08:41:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Category: Run experiment defaulting anonymous editors to the visual editor on the English Wikipedia - https://phabricator.wikimedia.org/T119269#4156468 (10Deskana) 05Open>03declined I'm not a fan of open tasks h... [08:41:11] 10VisualEditor, 10Wikimedia-Site-requests, 10Category, 10Notice, and 2 others: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#4156470 (10Deskana) [09:32:53] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Simply cloning diff header doesn't seem like a good idea - https://phabricator.wikimedia.org/T192755#4156669 (10Schnark) Alternatively one could wrap the header in ``, and the actual diff in `` and then only hide the body when switching t... [10:25:21] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 10Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#4156830 (10Deskana) [12:47:34] 10Cite, 10Parsoid, 10Wikimedia-Hackathon-2018: Create a prototype for improving references in articles - https://phabricator.wikimedia.org/T192872#4157390 (10Lea_WMDE) [12:50:29] 10Cite, 10Parsoid, 10Wikimedia-Hackathon-2018: Create a prototype for improving references in articles - https://phabricator.wikimedia.org/T192872#4157391 (10Lea_WMDE) @Deskana thanks for pointing out that this task sounds like a duplicate - I changed the task title to "prototype" to make the difference more... [13:25:19] 10Cite, 10Parsoid, 10Wikimedia-Hackathon-2018: Create a prototype for improving references in articles - https://phabricator.wikimedia.org/T192872#4157529 (10Deskana) >>! In T192872#4157391, @Lea_WMDE wrote: > @Deskana thanks for pointing out that this task sounds like a duplicate - I changed the task title... [15:40:07] (03CR) 10Jforrester: [C: 032] Move PHP classes to includes/ [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/428862 (owner: 10Legoktm) [15:40:19] (03CR) 10Jforrester: [C: 032] Add missing @covers tag [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/428863 (owner: 10Legoktm) [15:42:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-Linter, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), 10User-Ryasmeen: Linter isn't highlighting text in 2017 WTE anymore - https://phabricator.wikimedia.org/T185279#4158172 (10Stryn) 05Resolved>03Op... [15:46:03] (03Merged) 10jenkins-bot: Move PHP classes to includes/ [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/428862 (owner: 10Legoktm) [15:46:04] (03Merged) 10jenkins-bot: Add missing @covers tag [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/428863 (owner: 10Legoktm) [15:49:07] (03CR) 10jenkins-bot: Move PHP classes to includes/ [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/428862 (owner: 10Legoktm) [15:50:05] (03CR) 10jenkins-bot: Add missing @covers tag [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/428863 (owner: 10Legoktm) [15:52:42] 10VisualEditor: Visual editor's "leave feedback about this software" doesn't open - https://phabricator.wikimedia.org/T193043#4158228 (10Stryn) [16:17:25] (03PS1) 10DLynch: Linear/TableKeyDownHandlers: account for table captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428949 (https://phabricator.wikimedia.org/T192163) [16:21:45] (03CR) 10jerkins-bot: [V: 04-1] Linear/TableKeyDownHandlers: account for table captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428949 (https://phabricator.wikimedia.org/T192163) (owner: 10DLynch) [16:30:53] (03PS2) 10DLynch: Linear/TableKeyDownHandlers: account for table captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428949 (https://phabricator.wikimedia.org/T192163) [16:31:24] The occasional joys of realizing there was a test case explicitly guaranteeing the behavior one is fixing. [17:19:00] Kemayo: Ha. [17:24:55] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 4 others: Enable CodeMirror in 2017 Wikitext editor in all wikis without the beta feature - https://phabricator.wikimedia.org/T191923#4158736 (10Jdforrester-WMF) [18:00:47] 10VisualEditor, 10VisualEditor-EditingTools: Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4158805 (10Whatamidoing-WMF) [18:29:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Parsoid: VisualEditor removes unrecognised media properties on edit - https://phabricator.wikimedia.org/T125718#1995646 (10Quiddity) The 2 parameters mentioned above are no longer removed. (test for [[https://test.wikipedia.org/w/i... [18:37:37] (03CR) 10Niharika29: [C: 032] "I'll be bold and +2 this." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/427839 (https://phabricator.wikimedia.org/T191756) (owner: 10Samwilson) [18:37:44] (03CR) 10jerkins-bot: [V: 04-1] Guess template parameters when templatedata is missing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/427839 (https://phabricator.wikimedia.org/T191756) (owner: 10Samwilson) [18:42:20] (03PS6) 10Niharika29: Guess template parameters when templatedata is missing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/427839 (https://phabricator.wikimedia.org/T191756) (owner: 10Samwilson) [18:43:09] 10VisualEditor, 10VisualEditor-ContentEditable, 10Discovery, 10Maps, and 3 others: Editing maps in VE - the marker area needs some adjustments - https://phabricator.wikimedia.org/T191582#4110652 (10Catrope) Before Moriel's patch: {F17307879} After: {F17307877} [18:44:35] (03CR) 10Niharika29: [C: 032] "Per me, above." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/427839 (https://phabricator.wikimedia.org/T191756) (owner: 10Samwilson) [18:46:37] (03Merged) 10jenkins-bot: Guess template parameters when templatedata is missing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/427839 (https://phabricator.wikimedia.org/T191756) (owner: 10Samwilson) [18:49:04] (03CR) 10jenkins-bot: Guess template parameters when templatedata is missing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/427839 (https://phabricator.wikimedia.org/T191756) (owner: 10Samwilson) [19:11:44] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-TemplateWizard, 10Community-Tech-Sprint, and 2 others: Guess parameters for templates without TemplateData - https://phabricator.wikimedia.org/T191756#4159122 (10Niharika) @Deskana James just pointed out that we didn't get your approval for the above c... [19:35:57] (03PS1) 10Jforrester: build: Bump some devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428990 [19:59:56] (03PS1) 10Jforrester: build: Follow-up 99d3320573: Drop babel-polyfill, never used [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429001 [20:43:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429090 (owner: 10L10n-bot) [21:17:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/429083 (owner: 10L10n-bot) [21:25:26] (03CR) 10Esanders: [C: 032] build: Follow-up 99d3320573: Drop babel-polyfill, never used [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429001 (owner: 10Jforrester) [21:35:25] 10VisualEditor, 10WikiEditor, 10CodeEditor, 10Contributors-Team, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#4159564 (10daniel) Moving to backlog. Needs to be more of a technical proposal to work as an RFC. @Krinkle said... [21:38:49] 10WikiEditor, 10Contributors-Team, 10MediaWiki-Page-editing, 10Design: "Show edit toolbar" preference is confusing - https://phabricator.wikimedia.org/T32795#4159579 (10Krinkle) [21:47:35] (03CR) 10Bartosz Dziewoński: [C: 032] Use current selection for selectionBefore in empty staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425236 (https://phabricator.wikimedia.org/T191878) (owner: 10Esanders) [21:51:47] (03Merged) 10jenkins-bot: Use current selection for selectionBefore in empty staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425236 (https://phabricator.wikimedia.org/T191878) (owner: 10Esanders) [21:55:02] (03CR) 10jenkins-bot: Use current selection for selectionBefore in empty staging stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425236 (https://phabricator.wikimedia.org/T191878) (owner: 10Esanders) [22:32:55] (03CR) 10Bartosz Dziewoński: [C: 032] "I had to put in some effort to understand what this is fixing. For example, place the cursor in the middle of a link annotation, and choos" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425324 (owner: 10Esanders) [22:35:51] (03Merged) 10jenkins-bot: NodeInspector: Fix behaviour of getMode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425324 (owner: 10Esanders) [22:38:41] (03CR) 10jenkins-bot: NodeInspector: Fix behaviour of getMode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425324 (owner: 10Esanders) [22:40:23] 10VisualEditor, 10Contributors-Team, 10MediaWiki-Page-editing, 10TechCom-RFC, and 2 others: RFC: Provide clean interface to register content editing interfaces - https://phabricator.wikimedia.org/T28918#312017 (10Krinkle) [22:40:32] 10VisualEditor, 10Contributors-Team, 10MediaWiki-Page-editing, 10TechCom-RFC, and 2 others: RFC: Provide clean interface to register content editing interfaces - https://phabricator.wikimedia.org/T28918#312017 (10Krinkle) [22:58:58] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Verified, 10VisualEditor (Current work): When you create a page and then click "edit source" you get "Resume your edit... - https://phabricator.wikimedia.org/T192770#4159727 [23:22:20] 10VisualEditor, 10OOUI: [Regression pre-wmf.2] Styling for all the heading formats in the toolbar menu is missing - https://phabricator.wikimedia.org/T193098#4159752 (10Ryasmeen) [23:49:49] (03PS1) 10Bartosz Dziewoński: Update custom styles for format menu after OOUI changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429122 (https://phabricator.wikimedia.org/T193098) [23:50:01] (03PS1) 10Bartosz Dziewoński: Update custom styles for format menu after OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429123 (https://phabricator.wikimedia.org/T193098) [23:55:29] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), 10User-notice, and 2 others: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4159842 (10matmarex) @Whatamidoing-WMF Previously discussed on {T174145}… Maybe we should reopen that. [23:58:08] 10VisualEditor: Switching to VE from NWE while keeping a context menu open throws error "Uncaught TypeError: Cannot read property 'model' of undefined" - https://phabricator.wikimedia.org/T193103#4159845 (10Ryasmeen)