[00:12:46] 10WikiEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), 10User-notice, and 2 others: Use OOUI icons in WikiEditor - https://phabricator.wikimedia.org/T191031#4159889 (10Volker_E) I don't think this would lead to any improvement… [00:19:41] (03CR) 10VolkerE: [C: 032] Update custom styles for format menu after OOUI changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429122 (https://phabricator.wikimedia.org/T193098) (owner: 10Bartosz Dziewoński) [00:22:44] (03Merged) 10jenkins-bot: Update custom styles for format menu after OOUI changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429122 (https://phabricator.wikimedia.org/T193098) (owner: 10Bartosz Dziewoński) [00:26:26] (03CR) 10jenkins-bot: Update custom styles for format menu after OOUI changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429122 (https://phabricator.wikimedia.org/T193098) (owner: 10Bartosz Dziewoński) [02:28:50] 10VisualEditor, 10VisualEditor-MediaWiki: Pasting reference from one surface into another creates ☂ - https://phabricator.wikimedia.org/T193110#4159998 (10Krinkle) [02:30:56] 10VisualEditor, 10VisualEditor-MediaWiki: Pasting reference from one surface into another creates ☂ - https://phabricator.wikimedia.org/T193110#4160008 (10Krinkle) [02:31:27] 10VisualEditor, 10VisualEditor-MediaWiki: Pasting reference from one surface into another creates ☂ - https://phabricator.wikimedia.org/T193110#4159998 (10Krinkle) [02:35:30] 10VisualEditor: Switching to VE from NWE while keeping the link inspector/Add Citation dialog open throws error "Uncaught TypeError: Cannot read property 'model' of undefined" - https://phabricator.wikimedia.org/T193103#4160011 (10Ryasmeen) [06:05:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429134 (owner: 10L10n-bot) [06:20:15] 10VisualEditor, 10WikiEditor, 10Design: Provide current WikiEditor and VisualEditor icon sets on Commons - https://phabricator.wikimedia.org/T193116#4160165 (10Cirdan) [06:42:28] 10VisualEditor, 10WikiEditor, 10Design: Provide current WikiEditor and VisualEditor icon sets on Commons - https://phabricator.wikimedia.org/T193116#4160192 (10Cirdan) [07:05:36] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When creating a new section with preloadtitle in NWE, text about loading editor isn't removed - https://phabricator.wikimedia.org/T193117#4160223 (10Schnark) [07:13:16] (03PS28) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [07:15:23] (03PS29) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [07:19:18] (03CR) 10jerkins-bot: [V: 04-1] WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [07:28:01] (03PS30) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [07:55:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When creating a new section with preloadtitle in NWE, text about loading editor isn't removed - https://phabricator.wikimedia.org/T193117#4160263 (10Schnark) [07:55:59] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Beta-Feature, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10VisualEditor (Current work): "TypeError: Cannot read property 'isDisabled' of null" when opening the editor for new section with ... - https://phabricator.wikimedia.org/T192901#4160266 [09:08:07] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10Technical-Debt, 10User-Ryasmeen: Add support for restful crossRef api - https://phabricator.wikimedia.org/T108175#4160351 (10Mvolz) 05Open>03Resolved [09:08:30] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10User-Ryasmeen: Fetch citation details from Wikidata, using QIDs - https://phabricator.wikimedia.org/T176411#4160353 (10Mvolz) 05Open>03Resolved [09:08:54] 10Citoid, 10VisualEditor, 10Patch-For-Review, 10User-Ryasmeen: Fetch citation details from Wikidata, using QIDs - https://phabricator.wikimedia.org/T176411#4160355 (10Mvolz) Done using the zotero translator, although a native implementation would still be nice. [10:15:27] (03CR) 10Esanders: "Shouldn't up/down in a table caption behave the same as tab/shift-tab?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428949 (https://phabricator.wikimedia.org/T192163) (owner: 10DLynch) [11:33:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Parsoid, 10User-Ryasmeen: VisualEditor removes unrecognised media properties on edit - https://phabricator.wikimedia.org/T125718#4160944 (10Deskana) 05Open>03Resolved a:03Deskana >>! In T125718#4158955, @Quiddity wrote: > T... [12:36:59] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-TemplateWizard, 10Community-Tech-Sprint, and 2 others: Guess parameters for templates without TemplateData - https://phabricator.wikimedia.org/T191756#4161042 (10Deskana) There's no description of the user problem here, so let me see if I understand fi... [13:40:24] (03PS1) 10Esanders: Allow surfaces to change context popup's container [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429188 (https://phabricator.wikimedia.org/T166217) [13:41:40] (03PS1) 10Esanders: Set surface's $overlayContainer in DesktopArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429189 (https://phabricator.wikimedia.org/T166217) [13:42:53] (03PS2) 10Esanders: Set surface's $overlayContainer in DesktopArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429189 (https://phabricator.wikimedia.org/T166217) [13:48:26] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Patch-For-Review: Inspector's popup handle misplaced when close to edge of surface in Flow+VE - https://phabricator.wikimedia.org/T166217#4161219 (10Esanders) After: {F17322973} [14:09:08] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: betalabs: Links to non-existing File page do not display a warning in Link inspector - https://phabricator.wikimedia.org/T97832#4161263 (10Esanders) 05Open>03Invalid "page does not exist yet" only shows in the link inspector (when edit... [14:38:10] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 5 others: Enable CodeMirror in 2017 Wikitext editor in all wikis without the beta feature - https://phabricator.wikimedia.org/T191923#4121679 (10Johan) Will this be deployed next week, to all wikis... [14:38:14] (03CR) 10DLynch: "> Shouldn't up/down in a table caption behave the same as" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428949 (https://phabricator.wikimedia.org/T192163) (owner: 10DLynch) [15:02:15] (03PS1) 10Esanders: ce.Surface: Don't attempt to activate a disabled surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429209 (https://phabricator.wikimedia.org/T122910) [15:06:30] (03CR) 10Esanders: [C: 032] "Yeah - navigation should still work within a multiline caption, but also you should be able to cursor through a document with arrow keys. " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428949 (https://phabricator.wikimedia.org/T192163) (owner: 10DLynch) [15:09:56] 10VisualEditor-EditingTools, 10VisualEditor (Current work): Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4161459 (10Deskana) p:05Triage>03High Following the above steps, when you click redo, there are two separate errors: ``` Uncaught Error: Removed data not as... [15:10:22] (03Merged) 10jenkins-bot: Linear/TableKeyDownHandlers: account for table captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428949 (https://phabricator.wikimedia.org/T192163) (owner: 10DLynch) [15:11:30] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Patch-For-Review, 10VisualEditor (Current work): Link/Mention inspector: 'Uncaught Type Error' if the link inspector Edit is not explicitly closed/dismissed - https://phabricator.wikimedia.org/T122910#4161476 (10Jdforres... [15:13:28] (03CR) 10jenkins-bot: Linear/TableKeyDownHandlers: account for table captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428949 (https://phabricator.wikimedia.org/T192163) (owner: 10DLynch) [15:13:50] (03CR) 10Esanders: MWWikitextSurfaceFragment: ask the paster whether to convert to wikitext or use plain text (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [15:15:14] (03CR) 10DLynch: MWWikitextSurfaceFragment: ask the paster whether to convert to wikitext or use plain text (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [15:17:06] (03PS4) 10DLynch: MWWikitextSurfaceFragment: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) [15:26:39] (03PS1) 10Jforrester: Update VE core submodule to master (87bc18f58) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429215 (https://phabricator.wikimedia.org/T191878) [15:27:37] (03CR) 10Esanders: [C: 032] build: Bump some devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428990 (owner: 10Jforrester) [15:28:36] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (87bc18f58) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429215 (https://phabricator.wikimedia.org/T191878) (owner: 10Jforrester) [15:30:33] 10VisualEditor-DataModel, 10Patch-For-Review, 10Technical-Debt, 10VisualEditor (Current work): Remove ve.Range#clone & ve.dm.Selection#clone - https://phabricator.wikimedia.org/T192671#4161603 (10Jdforrester-WMF) [15:33:05] 10VisualEditor-Tables, 10VisualEditor (Current work): Insertion link into an empty table cell causes scroll jump - https://phabricator.wikimedia.org/T191878#4161606 (10Jdforrester-WMF) [15:33:26] 10VisualEditor-Tables, 10VisualEditor (Current work): Users can't tab into or out of table captions - https://phabricator.wikimedia.org/T192163#4161612 (10Jdforrester-WMF) [15:33:50] (03CR) 10Jforrester: [C: 032] Update custom styles for format menu after OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429123 (https://phabricator.wikimedia.org/T193098) (owner: 10Bartosz Dziewoński) [15:34:02] 10VisualEditor-EditingTools, 10VisualEditor (Current work): [Regression pre-wmf.2] Styling for all the heading formats in the toolbar menu is missing - https://phabricator.wikimedia.org/T193098#4161614 (10Jdforrester-WMF) [15:35:52] (03Merged) 10jenkins-bot: build: Bump some devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428990 (owner: 10Jforrester) [15:35:54] (03Merged) 10jenkins-bot: build: Follow-up 99d3320573: Drop babel-polyfill, never used [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429001 (owner: 10Jforrester) [15:35:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (87bc18f58) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429215 (https://phabricator.wikimedia.org/T191878) (owner: 10Jforrester) [15:38:06] (03CR) 10jenkins-bot: build: Follow-up 99d3320573: Drop babel-polyfill, never used [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429001 (owner: 10Jforrester) [15:39:55] (03CR) 10jenkins-bot: build: Bump some devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428990 (owner: 10Jforrester) [15:40:41] 10VisualEditor: VE image search doesn't find images if the search query is entered too soon after the dialogue opens - https://phabricator.wikimedia.org/T182014#4161626 (10Elitre) >>! In T182014#4156397, @Deskana wrote: >>>! In T182014#4146456, @Whatamidoing-WMF wrote: >> This happens sometimes when you're just... [15:41:34] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 5 others: Enable CodeMirror in 2017 Wikitext editor in all wikis without the beta feature - https://phabricator.wikimedia.org/T191923#4161627 (10Jdforrester-WMF) >>! In T191923#4161327, @Johan wrot... [15:41:45] (03Merged) 10jenkins-bot: Update custom styles for format menu after OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429123 (https://phabricator.wikimedia.org/T193098) (owner: 10Bartosz Dziewoński) [15:41:49] (03CR) 10DLynch: [C: 032] [DEPRECATING CHANGE] Deprecate ve.Range#clone and ve.dm.Selection#clone [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427932 (https://phabricator.wikimedia.org/T192671) (owner: 10Esanders) [15:42:07] (03CR) 10jenkins-bot: Update VE core submodule to master (87bc18f58) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429215 (https://phabricator.wikimedia.org/T191878) (owner: 10Jforrester) [15:44:09] (03CR) 10jenkins-bot: Update custom styles for format menu after OOUI changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429123 (https://phabricator.wikimedia.org/T193098) (owner: 10Bartosz Dziewoński) [15:44:43] (03Merged) 10jenkins-bot: [DEPRECATING CHANGE] Deprecate ve.Range#clone and ve.dm.Selection#clone [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427932 (https://phabricator.wikimedia.org/T192671) (owner: 10Esanders) [15:51:47] (03CR) 10jenkins-bot: [DEPRECATING CHANGE] Deprecate ve.Range#clone and ve.dm.Selection#clone [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427932 (https://phabricator.wikimedia.org/T192671) (owner: 10Esanders) [15:58:24] (03PS1) 10Jforrester: Update VE core submodule to master (174890b5e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429227 (https://phabricator.wikimedia.org/T192671) [16:27:38] (03CR) 10Divec: [C: 032] Update VE core submodule to master (174890b5e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429227 (https://phabricator.wikimedia.org/T192671) (owner: 10Jforrester) [16:36:33] (03Merged) 10jenkins-bot: Update VE core submodule to master (174890b5e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429227 (https://phabricator.wikimedia.org/T192671) (owner: 10Jforrester) [16:38:40] (03CR) 10jenkins-bot: Update VE core submodule to master (174890b5e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429227 (https://phabricator.wikimedia.org/T192671) (owner: 10Jforrester) [17:07:01] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design, 10Patch-For-Review, 10VisualEditor (Current work): Have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#2989076 (10CKoerner_WMF) When editing particularly complicated... [17:47:06] [17:47:08] Wassat? [17:47:12] Bar the obvious [17:52:51] edsanders, Kemayo ^^ [17:55:19] Reedy: That gets added in a VE PHP hook before any JS runs, then removed later in JS if appropriate. It's probably something broken in RL that's causing an overall failure/abort and so it stays. [17:55:40] https://fr.wikiquote.org/wiki/Wikiquote:Accueil [17:55:48] I seem to be able ot get one page load, and then that's it [17:55:52] changing skins gives another [17:56:09] Anything in the fatal log? [18:03:09] The page loads fine, then goes white with that [18:03:28] Hmm. [18:04:05] Seems fine if I turn js off [18:05:05] Reedy: Does it still break with safemode=1? [18:05:38] Doesn't seem to [18:05:54] Then I blame a site script or default gadget rather than VE. :-) [18:07:00] No recent changes in MW or Gadget namespaces [18:10:14] Oh, hmm, we dropped some very-deprecated JS functions in mw.util. [18:10:20] Maybe that broke. [18:10:22] * James_F looks. [18:12:34] Yeah, write and writeln got removed in 7f2c6c401644c06b0bd30e311c6247bcaebec1bc. [18:14:01] Yup, https://fr.wikiquote.org/wiki/MediaWiki:Common.js?safemode=1 has "document.write('