[01:12:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: Ctrl+Shift is ignored when using Syntax Highlighting on 2017 wikitext editor - https://phabricator.wikimedia.org/T193288#4166296 (10Guycn2) >>! In T193288#4166224, @Esanders wrote... [01:12:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: Ctrl+Shift+X is ignored when using Syntax Highlighting on 2017 wikitext editor - https://phabricator.wikimedia.org/T193288#4166297 (10Guycn2) [02:52:46] 10VisualEditor-EditingTools, 10VisualEditor (Current work): Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4166317 (10dchan) Ooooh, this happens because ve.dm.TransactionBuilder#pushAttributeChanges( { key: val }, ... ) puts a live reference to val into the Transactio... [03:57:33] (03PS1) 10Divec: Copy attribute values when building transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 [03:59:05] (03PS2) 10Divec: Copy attribute values when building transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 (https://phabricator.wikimedia.org/T193062) [04:00:45] (03CR) 10Divec: "Do we need to support cloning Node objects deeper inside an object, e.g. something like { foo: { bar: { baz: node } } } ?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [06:01:29] (03CR) 10Divec: "Alternatively would it be better to make the caller do the cloning, in those cases where the attribute value is mutable?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [12:36:40] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4166508 (10Esanders) Sounds about right, I assumed this was a shallow copy issue. [12:44:35] (03CR) 10Esanders: [C: 04-1] "I think how you have it is safer" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [13:04:18] (03CR) 10Esanders: "bug?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (owner: 10Jforrester) [13:05:13] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (e673ad6de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429526 (https://phabricator.wikimedia.org/T122910) (owner: 10Jforrester) [13:13:35] (03Merged) 10jenkins-bot: Update VE core submodule to master (e673ad6de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429526 (https://phabricator.wikimedia.org/T122910) (owner: 10Jforrester) [13:13:35] (03Merged) 10jenkins-bot: Set surface's $overlayContainer in DesktopArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429189 (https://phabricator.wikimedia.org/T166217) (owner: 10Esanders) [13:15:24] (03CR) 10jenkins-bot: Update VE core submodule to master (e673ad6de) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429526 (https://phabricator.wikimedia.org/T122910) (owner: 10Jforrester) [13:17:38] (03CR) 10jenkins-bot: Set surface's $overlayContainer in DesktopArticleTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429189 (https://phabricator.wikimedia.org/T166217) (owner: 10Esanders) [14:16:59] (03PS3) 10Divec: Copy attribute values when building transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 (https://phabricator.wikimedia.org/T193062) [16:18:42] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: "TypeError: cur is null" when pasting a string of text on a Flow page with VE enabled - https://phabricator.wikimedia.org/T134679#4166627 (10He7d3r) This still happens. The latest example was when I typed `[[`, pasted `T31272#1469722` and... [20:34:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429699 (owner: 10L10n-bot) [20:36:28] (03CR) 10Esanders: [C: 032] Copy attribute values when building transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [20:39:24] (03Merged) 10jenkins-bot: Copy attribute values when building transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [20:42:32] (03CR) 10jenkins-bot: Copy attribute values when building transactions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429649 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [20:45:40] (03PS1) 10Esanders: Follow-up Iea7ad832: Fix context in MWPopupTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429705 (https://phabricator.wikimedia.org/T193043) [21:10:52] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4158805 (10Esanders) a:03dchan [21:45:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Section edit links on file pages for Commons images don't work - https://phabricator.wikimedia.org/T193323#4166862 (10Esanders) [21:47:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Section edit links on file pages for Commons images don't work - https://phabricator.wikimedia.org/T193323#4165995 (10Esanders) These should just work correctly. The links' hrefs are correct, so ctrl+clicking the links works, but we need to disable t... [21:51:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Codemirror makes text align left when editing in 2017 WTE on RTL wikis - https://phabricator.wikimedia.org/T193260#4166865 (10Esanders) [23:07:31] 10VisualEditor, 10VisualEditor-Tables: Make it possible to convert from a list to a table (and vice versa) - https://phabricator.wikimedia.org/T193362#4166908 (10Whatamidoing-WMF)