[04:43:58] (03PS1) 10Divec: Truncate storeLengthAtHistoryLength properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/431505 [06:08:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/431508 (owner: 10L10n-bot) [06:15:30] (03Abandoned) 10Santhosh: MWLinkAnnotationInspector: Allow customization of annotation inputs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429712 (owner: 10Santhosh) [06:35:42] (03CR) 10Santhosh: [C: 031] "Thanks for this. It saves lot of customization in CX2" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/430906 (https://phabricator.wikimedia.org/T193856) (owner: 10Esanders) [07:09:30] 10Cite, 10TCB-Team, 10German-Community-Wishlist, 10Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#1967662 (10Lea_WMDE) @Cenarium @TheDJ are you going to be at the Barcelona hackathon? If yes,... [09:45:10] (03CR) 10Esanders: [C: 032] TreeModifier: Clone mutable linear data when inserting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/430413 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [09:47:54] (03Merged) 10jenkins-bot: TreeModifier: Clone mutable linear data when inserting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/430413 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [09:50:51] (03CR) 10jenkins-bot: TreeModifier: Clone mutable linear data when inserting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/430413 (https://phabricator.wikimedia.org/T193062) (owner: 10Divec) [09:59:38] 10VisualEditor, 10VisualEditor-VisualDiffs: Allow easily extending the diff mode switcher in page history - https://phabricator.wikimedia.org/T171437#4185931 (10Schnark) Actually, due to the fact that my script supports 4 modes (diff while editing in VE, diff while editing in OWE, historical diff without Visua... [10:28:50] 10VisualEditor, 10VisualEditor-ContentEditable, 10Discovery, 10Maps, and 3 others: Editing maps in VE - the marker area needs some adjustments - https://phabricator.wikimedia.org/T191582#4186038 (10Pginer-WMF) >>! In T191582#4184052, @SBisson wrote: > @Pginer-WMF Do you have an opinion about which of the 2... [10:53:01] (03PS1) 10Esanders: Add an 'api' parameter to ApiResponseCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431547 [10:53:03] (03PS1) 10Esanders: Create an MWSurface and move langChange handling there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431548 [10:53:05] (03PS1) 10Esanders: Remove references to global singleton inside LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431549 [10:53:43] (03PS2) 10Esanders: Create an MWSurface and move langChange handling there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431548 [10:53:48] (03PS2) 10Esanders: Remove references to global singleton inside LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431549 [10:53:50] (03PS2) 10Esanders: Add an 'api' parameter to ApiResponseCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431547 [11:14:54] 10WikiEditor, 10MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)): Localized toolbar buttons to the Chechen language - https://phabricator.wikimedia.org/T119716#4186225 (10Aklapper) @Umar: Please file separate tasks for separate requests and follow https://mediawiki.org/wiki/How_to_report_a_bug . This ta... [13:52:58] 10Editing-team, 10MediaWiki-Page-editing, 10MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)): Only show edit summary remaining character countdown for last 99 characters - https://phabricator.wikimedia.org/T190570#4186750 (10matmarex) 05Open>03Resolved [14:39:40] (03CR) 10Esanders: "Bug tag got removed: T190851" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/422066 (owner: 10Esanders) [14:39:49] (03PS1) 10Esanders: Revert "Remove icon padding from format tools in WMUI" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/431577 [14:39:58] (03CR) 10jerkins-bot: [V: 04-1] Revert "Remove icon padding from format tools in WMUI" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/431577 (owner: 10Esanders) [14:41:22] (03PS2) 10Esanders: Revert "Remove icon padding from format tools in WMUI" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/431577 (https://phabricator.wikimedia.org/T190851) [14:47:05] 10Editing-team, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 10MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), and 2 others: Editing a page with unflagged changes should edit latest version in VE, even if you view the stable v... - https://phabricator.wikimedia.org/T165283#4186921 [15:00:05] (03PS1) 10Esanders: Update link cache to use new descriptions API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431586 (https://phabricator.wikimedia.org/T191333) [15:11:54] 10Editing-team, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 10MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), and 2 others: Editing a page with unflagged changes should edit latest version in VE, even if you view the stable v... - https://phabricator.wikimedia.org/T165283#4186983 [15:15:24] (03CR) 10Jforrester: [C: 032] Update link cache to use new descriptions API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431586 (https://phabricator.wikimedia.org/T191333) (owner: 10Esanders) [15:17:07] (03CR) 10Jforrester: [C: 032] Use ve.resolveUrl in MediaContext/Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431092 (owner: 10Esanders) [15:22:21] (03PS1) 10Jforrester: Update VE core submodule to master (c4ad0a7e3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431590 (https://phabricator.wikimedia.org/T193062) [15:27:42] (03Merged) 10jenkins-bot: Update link cache to use new descriptions API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431586 (https://phabricator.wikimedia.org/T191333) (owner: 10Esanders) [15:28:53] (03Merged) 10jenkins-bot: Use ve.resolveUrl in MediaContext/Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431092 (owner: 10Esanders) [15:29:49] (03CR) 10jenkins-bot: Update link cache to use new descriptions API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431586 (https://phabricator.wikimedia.org/T191333) (owner: 10Esanders) [15:31:28] (03CR) 10jenkins-bot: Use ve.resolveUrl in MediaContext/Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431092 (owner: 10Esanders) [15:31:53] (03CR) 10Jforrester: "If the tests now pass, does that mean this is no longer WIP? :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [15:32:20] (03CR) 10Jforrester: [C: 032] Remove unused overrides in internal link annotation inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431095 (owner: 10Esanders) [15:33:39] 10VisualEditor-MediaWiki, 10ContentTranslation, 10Language-2018-Apr-June, 10Patch-For-Review, 10VisualEditor (Current work): Allow customization of target of VisualEditor mediawiki API requests - https://phabricator.wikimedia.org/T193856#4187102 (10Jdforrester-WMF) a:03Esanders [15:39:51] (03CR) 10Jforrester: [C: 032] Create getters for localised APIs (getContentApi/getLocalApi) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/430906 (https://phabricator.wikimedia.org/T193856) (owner: 10Esanders) [15:41:09] (03CR) 10Jforrester: [C: 032] Create an MWSurface and move langChange handling there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431548 (owner: 10Esanders) [15:41:34] (03Merged) 10jenkins-bot: Remove unused overrides in internal link annotation inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431095 (owner: 10Esanders) [15:41:52] (03CR) 10Jforrester: [C: 032] Remove references to global singleton inside LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431549 (owner: 10Esanders) [15:42:47] (03CR) 10Jforrester: [C: 032] Add an 'api' parameter to ApiResponseCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431547 (owner: 10Esanders) [15:44:05] (03CR) 10jenkins-bot: Remove unused overrides in internal link annotation inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431095 (owner: 10Esanders) [15:49:33] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), 10VisualEditor (Current work): Value null is the wrong type for property "action.saveIntent.timing" (integer expected) appears intermittently while adding a new section - https://phabricator.wikimedia.org/T193206#4162883... [15:51:39] 10VisualEditor-EditingTools, 10VisualEditor (Current work): Does not find "\n" though existing on page when searching for regular expression in VisualEditor - https://phabricator.wikimedia.org/T188651#4187187 (10Jdforrester-WMF) [15:51:46] (03Merged) 10jenkins-bot: Create getters for localised APIs (getContentApi/getLocalApi) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/430906 (https://phabricator.wikimedia.org/T193856) (owner: 10Esanders) [15:52:09] (03Merged) 10jenkins-bot: Create an MWSurface and move langChange handling there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431548 (owner: 10Esanders) [15:52:32] 10VisualEditor-EditingTools, 10VisualEditor (Current work): Anchored regular expressions behave unexpected with magic links - https://phabricator.wikimedia.org/T184163#4187194 (10Jdforrester-WMF) [15:53:02] (03Merged) 10jenkins-bot: Remove references to global singleton inside LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431549 (owner: 10Esanders) [15:53:18] (03Merged) 10jenkins-bot: Add an 'api' parameter to ApiResponseCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431547 (owner: 10Esanders) [15:53:40] (03CR) 10jenkins-bot: Create getters for localised APIs (getContentApi/getLocalApi) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/430906 (https://phabricator.wikimedia.org/T193856) (owner: 10Esanders) [15:55:29] (03CR) 10jenkins-bot: Create an MWSurface and move langChange handling there [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431548 (owner: 10Esanders) [15:57:17] (03CR) 10jenkins-bot: Remove references to global singleton inside LinkCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431549 (owner: 10Esanders) [15:59:09] (03CR) 10jenkins-bot: Add an 'api' parameter to ApiResponseCache [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431547 (owner: 10Esanders) [16:32:07] (03CR) 10Esanders: [C: 032] Truncate storeLengthAtHistoryLength properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/431505 (owner: 10Divec) [16:32:19] (03CR) 10Esanders: [C: 032] "unit test?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/431505 (owner: 10Divec) [16:32:25] (03CR) 10Esanders: [C: 04-1] Truncate storeLengthAtHistoryLength properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/431505 (owner: 10Divec) [16:32:36] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (c4ad0a7e3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431590 (https://phabricator.wikimedia.org/T193062) (owner: 10Jforrester) [16:42:17] (03Merged) 10jenkins-bot: Update VE core submodule to master (c4ad0a7e3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431590 (https://phabricator.wikimedia.org/T193062) (owner: 10Jforrester) [16:43:49] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4187391 (10Jdforrester-WMF) [16:44:14] (03CR) 10jenkins-bot: Update VE core submodule to master (c4ad0a7e3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431590 (https://phabricator.wikimedia.org/T193062) (owner: 10Jforrester) [17:02:25] (03PS3) 10Bartosz Dziewoński: Improve behavior of newlines and non-text content elements in find-and-replace [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/427022 (https://phabricator.wikimedia.org/T188651) [17:43:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: CodeMirror and 2017 Wikitext editor combination produce invisible text on Firefox - https://phabricator.wikimedia.org/T194068#4187635 (10Niharika) [18:08:20] (03PS6) 10DLynch: MWWikitextSurfaceFragment: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) [18:59:13] Comments from the VE team would be welcome on https://gerrit.wikimedia.org/r/#/c/430538/ I think, mostly on whether the functionality makes sense to have in VE itself [19:13:12] legoktm: i'm not going to review all of it, but at a glance, it doesn't do anything crazy. it seems like the use case there is improving "legacy" forms, and i'm not sure if we would want to have that in VE itself. [19:19:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: CodeMirror and 2017 Wikitext editor combination produce invisible text on Firefox - https://phabricator.wikimedia.org/T194068#4187968 (10gh87) [19:28:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: CodeMirror and 2017 Wikitext editor combination produce invisible text on Firefox - https://phabricator.wikimedia.org/T194068#4187635 (10MusikAnimal) I am able to r... [19:59:35] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Prompt user before automatically converting pasted HTML to wikitext - https://phabricator.wikimedia.org/T190079#4061985 (10kaldari) >This could work. Or to drive the point home: " ... text formatting ... '''[[wiki... [20:22:43] (03PS1) 10Esanders: Follow-up Ifdc951fdc: Don't use target when it doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431650 [20:31:45] (03CR) 10Jforrester: [C: 032] "Oops, yes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431650 (owner: 10Esanders) [20:35:57] (03PS1) 10Esanders: Remove some no longer required CSS from switch popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431652 [20:41:38] (03Merged) 10jenkins-bot: Follow-up Ifdc951fdc: Don't use target when it doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431650 (owner: 10Esanders) [20:43:38] (03CR) 10jenkins-bot: Follow-up Ifdc951fdc: Don't use target when it doesn't exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431650 (owner: 10Esanders) [20:50:09] (03PS1) 10Esanders: Add comment to htmlBlacklist item [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/431655 (https://phabricator.wikimedia.org/T150418) [20:51:44] 10VisualEditor, 10Parsoid, 10Patch-For-Review, 10User-Ryasmeen: Dirty diff and other weird corruption in table edit - https://phabricator.wikimedia.org/T192909#4188342 (10Arlolra) 05Open>03Resolved [21:13:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Browser-Support-Firefox: CodeMirror and 2017 Wikitext editor combination produce invisible text on Firefox - https://phabricator.wikimedia.org/T194068#4187635 (10deryckchan) Thanks @Niharik... [21:35:05] (03CR) 10Krinkle: "Tracking down the load path:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) (owner: 10Krinkle) [21:42:21] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), 10Verified, 10VisualEditor (Current work): Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4188469 (10Ryasmeen) [22:09:48] (03CR) 10Bartosz Dziewoński: [C: 031] "The idea seems sane. I reviewed the uses of getContentApi/getLocalApi and they also seem sane, except one, which seems hopeless (see inlin" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/430906 (https://phabricator.wikimedia.org/T193856) (owner: 10Esanders) [22:14:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10Technical-Debt: Rewrite DesktopArticleTarget#rebuildCategories, it doesn't need an API request - https://phabricator.wikimedia.org/T194092#4188542 (10matmarex) [22:15:12] (03CR) 10Bartosz Dziewoński: [C: 031] Create getters for localised APIs (getContentApi/getLocalApi) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/430906 (https://phabricator.wikimedia.org/T193856) (owner: 10Esanders) [22:27:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10Technical-Debt: Rewrite DesktopArticleTarget#rebuildCategories, it doesn't need an API request - https://phabricator.wikimedia.org/T194092#4188542 (10Jdforrester-WMF) Lovely. [23:00:32] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Deemphasizing formatting tokens - https://phabricator.wikimedia.org/T194095#4188639 (10Drewmutt) [23:01:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Deemphasizing formatting tokens - https://phabricator.wikimedia.org/T194095#4188652 (10Drewmutt) [23:01:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Deemphasizing formatting tokens - https://phabricator.wikimedia.org/T194095#4188639 (10Drewmutt) [23:29:53] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Prompt user before automatically converting pasted HTML to wikitext - https://phabricator.wikimedia.org/T190079#4188705 (10DLynch) It'd be: {F18064468} Versus: {F18064473} [23:40:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10OOUI: Save dialog footer is wrong size after showing diff in NWE - https://phabricator.wikimedia.org/T177995#4188726 (10matmarex) [23:40:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10OOUI: Process dialog measures footer incorrectly - https://phabricator.wikimedia.org/T149274#4188729 (10matmarex)