[05:07:47] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Enable Citoid on sd wiki - https://phabricator.wikimedia.org/T194637#4209344 (10Jogi_don) >>! In T194637#4204093, @Mvolz wrote: > @jogi_don Have you posted about enabling citoid on sindhi wiki anywhere? Is there community... [08:58:11] (03CR) 10Jforrester: [C: 032] Use better align change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/432979 (owner: 10Esanders) [08:58:53] (03CR) 10Jforrester: [C: 032] Simplify valign code with a loop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/432986 (owner: 10Esanders) [09:10:01] 10VisualEditor, 10User-Ryasmeen: Invisible character at end of line through copy&paste - https://phabricator.wikimedia.org/T185590#4209521 (10Deskana) 05stalled>03Resolved p:05Triage>03Normal a:03Deskana I guess we fixed at some point then. Great! [09:24:08] (03PS1) 10Esanders: Fix typo in API call for version number help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433336 [09:27:35] 10VisualEditor-MediaWiki-Templates, 10VisualEditor (Current work): When you delete a parameter, the template dialogue box scrolls up to the top, and it should stay in the same place - https://phabricator.wikimedia.org/T180151#3748615 (10DLynch) Issue is subtle fallout from the async-promises change, I think?... [09:27:58] (03CR) 10Bartosz Dziewoński: [C: 032] Fix typo in API call for version number help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433336 (owner: 10Esanders) [09:31:43] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (ca25f72ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433146 (owner: 10Jforrester) [09:37:27] (03Merged) 10jenkins-bot: Fix typo in API call for version number help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433336 (owner: 10Esanders) [09:38:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (ca25f72ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433146 (owner: 10Jforrester) [09:39:51] (03CR) 10jenkins-bot: Fix typo in API call for version number help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433336 (owner: 10Esanders) [09:41:40] (03PS1) 10Jforrester: Fix typo in API call for version number help [extensions/VisualEditor] (wmf/1.32.0-wmf.4) - 10https://gerrit.wikimedia.org/r/433339 [09:41:49] (03PS1) 10Jforrester: Fix typo in API call for version number help [extensions/VisualEditor] (wmf/1.32.0-wmf.3) - 10https://gerrit.wikimedia.org/r/433340 [09:42:44] (03CR) 10jenkins-bot: Update VE core submodule to master (ca25f72ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433146 (owner: 10Jforrester) [09:49:06] (03Merged) 10jenkins-bot: Use better align change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/432979 (owner: 10Esanders) [09:49:08] (03Merged) 10jenkins-bot: Simplify valign code with a loop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/432986 (owner: 10Esanders) [09:51:16] (03CR) 10jenkins-bot: Use better align change descriptions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/432979 (owner: 10Esanders) [09:54:25] (03CR) 10jenkins-bot: Simplify valign code with a loop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/432986 (owner: 10Esanders) [09:55:22] (03PS1) 10Esanders: Fix RTL mode in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433344 [10:50:03] (03PS1) 10DLynch: CollabTarget: set name to logged in MW user [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433353 [10:51:18] (03CR) 10DLynch: "This is the simplest-possible-version. There's a comment with TODOs for more featureful approaches." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433353 (owner: 10DLynch) [10:53:41] (03PS1) 10Esanders: Separate (Comment/Link)InspectorTools intead separate files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433354 [11:02:22] 10VisualEditor: Opening link inspector inside the Reference dialog causes VE to crash - https://phabricator.wikimedia.org/T194819#4209841 (10Ryasmeen) [11:04:26] 10VisualEditor: Opening link inspector inside the Reference dialog causes VE to crash - https://phabricator.wikimedia.org/T194819#4209873 (10Ryasmeen) [11:09:18] 10VisualEditor: [Regression wmf.3] Opening link inspector inside the Reference dialog causes VE to crash - https://phabricator.wikimedia.org/T194819#4209892 (10Ryasmeen) [11:10:10] 10VisualEditor: [Regression wmf.3] Opening link inspector inside the Reference dialog causes VE to crash - https://phabricator.wikimedia.org/T194819#4209841 (10Ryasmeen) This is broken in production as well. [13:25:25] 10VisualEditor, 10Technical-Debt: Abstract linkAnnotation-active behaviour - https://phabricator.wikimedia.org/T194825#4210076 (10Esanders) [14:35:44] 10VisualEditor, 10User-Ryasmeen: Invisible character at end of line through copy&paste - https://phabricator.wikimedia.org/T185590#4210196 (10XanonymusX) Oh no, seems like I overlooked something last night. :| The bug is still here, just reproduced it again. However I'd be glad if someone else could reproduce... [14:36:21] 10VisualEditor: VE scrolls to the top when opening the link inspector on mobile - https://phabricator.wikimedia.org/T194828#4210198 (10Catrope) [14:39:06] 10VisualEditor, 10User-Ryasmeen: Invisible character at end of line through copy&paste - https://phabricator.wikimedia.org/T185590#4210209 (10matmarex) 05Resolved>03Open a:05Deskana>03None Sounds related to T188837 or T162916. [14:51:18] (03PS2) 10Esanders: Separate (Comment/Link)InspectorTools into separate files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433354 [14:51:20] (03PS1) 10Esanders: Genericise activeLink behaviour to all annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 [14:51:22] (03PS1) 10Esanders: Create simple comment annotation type for rebaser. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433392 [14:55:08] (03CR) 10jerkins-bot: [V: 04-1] Create simple comment annotation type for rebaser. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433392 (owner: 10Esanders) [14:55:49] (03CR) 10jerkins-bot: [V: 04-1] Genericise activeLink behaviour to all annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 (owner: 10Esanders) [15:00:05] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VE Mobile editor switcher goes missing at certain widths - https://phabricator.wikimedia.org/T194833#4210299 (10Esanders) [15:03:19] (03CR) 10Esanders: [C: 04-1] CollabTarget: set name to logged in MW user (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433353 (owner: 10DLynch) [15:06:36] (03CR) 10DLynch: CollabTarget: set name to logged in MW user (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433353 (owner: 10DLynch) [15:08:08] (03CR) 10Esanders: [C: 032] CollabTarget: set name to logged in MW user [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433353 (owner: 10DLynch) [15:15:25] (03PS1) 10Esanders: Show both edit modes in edit switcher, for consistency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433398 [15:18:52] (03Merged) 10jenkins-bot: CollabTarget: set name to logged in MW user [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433353 (owner: 10DLynch) [15:35:21] (03PS3) 10Esanders: Separate (Comment/Link)InspectorTools into separate files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433354 [15:35:23] (03PS2) 10Esanders: Genericise activeLink behaviour to all annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 [15:35:25] (03PS2) 10Esanders: Create simple comment annotation type for rebaser. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433392 [15:40:49] (03CR) 10Divec: "This was written to enable I06cb8a1264ec74ae96b90d525c8328237001e99c . So if we instead implement storage as a ve.dm.RebaseClient, then ma" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/331423 (owner: 10Divec) [15:44:40] (03CR) 10jerkins-bot: [V: 04-1] Genericise activeLink behaviour to all annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 (owner: 10Esanders) [15:44:42] (03CR) 10jerkins-bot: [V: 04-1] Create simple comment annotation type for rebaser. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433392 (owner: 10Esanders) [15:47:54] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 (owner: 10Esanders) [15:49:16] (03CR) 10Divec: "Per @cscott , this would be a lot nicer implemented as a ve.dm.RebaseClient (i.e. an asynchronous store), with some forget/reload logic in" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334995 (https://phabricator.wikimedia.org/T152464) (owner: 10Divec) [15:50:25] (03Merged) 10jenkins-bot: MobileArticleTarget: Show both edit modes in edit switcher, for consistency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433398 (owner: 10Esanders) [15:53:23] (03CR) 10jenkins-bot: MobileArticleTarget: Show both edit modes in edit switcher, for consistency [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433398 (owner: 10Esanders) [15:59:46] (03PS3) 10Esanders: Create simple comment annotation type for rebaser. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433392 [15:59:56] (03PS1) 10DLynch: CollabTarget: remember current name, briefly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433412 [16:04:46] (03PS2) 10DLynch: CollabTarget: remember current name, briefly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433412 [16:12:32] (03CR) 10Esanders: [C: 032] CollabTarget: remember current name, briefly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433412 (owner: 10DLynch) [16:14:26] (03CR) 10Esanders: "This is only used by rebaser, so can be merged if good enough for testing." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433392 (owner: 10Esanders) [16:15:51] (03CR) 10jerkins-bot: [V: 04-1] CollabTarget: remember current name, briefly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433412 (owner: 10DLynch) [16:16:49] (03PS3) 10DLynch: CollabTarget: remember current name, briefly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433412 [16:17:38] (03CR) 10DLynch: [C: 032] Separate (Comment/Link)InspectorTools into separate files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433354 (owner: 10Esanders) [16:21:34] (03Merged) 10jenkins-bot: Separate (Comment/Link)InspectorTools into separate files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433354 (owner: 10Esanders) [16:24:50] (03CR) 10jenkins-bot: Separate (Comment/Link)InspectorTools into separate files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433354 (owner: 10Esanders) [16:27:52] (03CR) 10DLynch: [C: 04-1] "Isn't this going to cause problems in cases where there are multiple annotations at the focus? E.g. foo, will only store the" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 (owner: 10Esanders) [16:29:53] (03CR) 10DLynch: [C: 032] CollabTarget: remember current name, briefly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433412 (owner: 10DLynch) [16:40:12] (03Merged) 10jenkins-bot: CollabTarget: remember current name, briefly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433412 (owner: 10DLynch) [16:43:06] (03CR) 10jenkins-bot: CollabTarget: remember current name, briefly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433412 (owner: 10DLynch) [16:56:03] (03CR) 10Esanders: "Yes, that should be fixed eventually - but as this is just used for styling at the moment, it isn't critical." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 (owner: 10Esanders) [17:04:40] (03PS1) 10Esanders: CategoriesPage: Remove unnecessary input widget width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433426 [17:09:33] (03CR) 10DLynch: [C: 04-1] "I do have a patch up that depends on it functionally: https://gerrit.wikimedia.org/r/#/c/272510/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 (owner: 10Esanders) [17:19:46] (03CR) 10Esanders: [C: 04-1] LinkContextItem: add label information to the context (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [17:21:06] (03CR) 10DLynch: [C: 032] "I'll be updating that patch to not require the method." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 (owner: 10Esanders) [17:22:36] (03PS14) 10DLynch: LinkContextItem: add label information to the context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) [17:23:00] (03PS3) 10Esanders: Genericise activeLink behaviour to all annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433391 [17:23:02] (03PS4) 10Esanders: Create simple comment annotation type for rebaser. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433392 [17:53:30] (03PS1) 10Esanders: Fix ve.ce.MWTransclusionNode#filterRendering to work with non-element nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433430 [18:20:49] (03PS15) 10DLynch: LinkContextItem: add label information to the context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) [21:11:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433480 (owner: 10L10n-bot) [21:36:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/433476 (owner: 10L10n-bot) [21:59:54] (03CR) 10Bartosz Dziewoński: [C: 032] CategoriesPage: Remove unnecessary input widget width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433426 (owner: 10Esanders) [22:06:14] (03Merged) 10jenkins-bot: CategoriesPage: Remove unnecessary input widget width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433426 (owner: 10Esanders) [22:08:18] (03CR) 10jenkins-bot: CategoriesPage: Remove unnecessary input widget width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433426 (owner: 10Esanders) [23:58:24] (03PS1) 10VolkerE: build: Extend 'svgmin' options and amend [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433497 (https://phabricator.wikimedia.org/T185596)