[05:03:08] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#4216032 (10kaldari) @Mvolz: Hmm, doesn't look like that went over very well. What's the downside to coercing "title" to "chapterTitle" i... [05:57:29] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#4216048 (10Mvolz) >>! In T114450#4216032, @kaldari wrote: > @Mvolz: Hmm, doesn't look like that went over very well. What's the downside... [08:51:10] (03PS1) 10Divec: WIP POC: Reject partially conflicting ve.dm.Changes atomically [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433932 [08:56:06] (03CR) 10jerkins-bot: [V: 04-1] WIP POC: Reject partially conflicting ve.dm.Changes atomically [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433932 (owner: 10Divec) [09:03:18] (03PS1) 10Esanders: Follow-up I6abf7535: Call parent method in onPopupToggle override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433936 [09:34:18] (03PS1) 10Esanders: Follow-up I2a49315d0: Fix right padding of active external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433943 [09:35:18] (03PS1) 10Esanders: Use same padding across skins for external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433944 [09:53:47] (03PS2) 10Esanders: Import button for CollabPad [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433756 [10:06:44] (03CR) 10Jforrester: [C: 032] Follow-up I6abf7535: Call parent method in onPopupToggle override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433936 (owner: 10Esanders) [10:09:52] (03Merged) 10jenkins-bot: Follow-up I6abf7535: Call parent method in onPopupToggle override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433936 (owner: 10Esanders) [10:12:53] (03CR) 10jenkins-bot: Follow-up I6abf7535: Call parent method in onPopupToggle override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433936 (owner: 10Esanders) [10:13:10] (03PS1) 10Jforrester: Update VE core submodule to master (700ab1015) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433947 [10:25:58] (03PS1) 10DLynch: Fix tests for new qunit package name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433951 [10:44:35] (03CR) 10Jforrester: [C: 032] "Oops." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433951 (owner: 10DLynch) [10:47:48] (03Merged) 10jenkins-bot: Fix tests for new qunit package name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433951 (owner: 10DLynch) [10:53:02] (03CR) 10jenkins-bot: Fix tests for new qunit package name [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433951 (owner: 10DLynch) [11:14:00] 10VisualEditor, 10Math, 10Wikimedia-Hackathon-2018, 10User-zeljkofilipin: WebdriverIO tests for Math - https://phabricator.wikimedia.org/T162455#4216639 (10zeljkofilipin) 05stalled>03Open a:03Physikerwelt [11:16:34] 10VisualEditor, 10Math, 10Wikimedia-Hackathon-2018, 10User-zeljkofilipin: Selenium tests for Math - https://phabricator.wikimedia.org/T162455#4216654 (10zeljkofilipin) [11:43:08] (03PS3) 10Divec: Import button for CollabPad [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433756 (owner: 10Esanders) [11:52:11] (03CR) 10Jforrester: Import button for CollabPad (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433756 (owner: 10Esanders) [12:09:05] (03CR) 10Divec: [C: 031] "+2 to the parts I didn't write" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433756 (owner: 10Esanders) [12:17:55] (03CR) 10Esanders: [C: 031] Import button for CollabPad [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433756 (owner: 10Esanders) [12:18:05] (03CR) 10Divec: [C: 032] Import button for CollabPad [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433756 (owner: 10Esanders) [12:28:43] (03Merged) 10jenkins-bot: Import button for CollabPad [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433756 (owner: 10Esanders) [12:32:00] (03CR) 10jenkins-bot: Import button for CollabPad [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433756 (owner: 10Esanders) [12:48:47] (03PS8) 10DLynch: MWWikitextSurfaceFragment: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) [12:53:35] (03PS1) 10Esanders: Language input fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433977 [12:59:24] 10VisualEditor, 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10Discovery, and 2 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4216867 (10Esanders) [13:01:27] (03PS1) 10DLynch: ce.Surface: Refactor afterPaste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433980 (https://phabricator.wikimedia.org/T190079) [13:03:17] (03PS9) 10DLynch: ce.MWWikitextSurface: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) [13:03:54] (03Abandoned) 10DLynch: SurfaceFragment: tell insertDocument whether it's from a paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425462 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [13:04:12] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up I2a49315d0: Fix right padding of active external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433943 (owner: 10Esanders) [13:04:16] (03CR) 10Bartosz Dziewoński: [C: 032] Use same padding across skins for external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433944 (owner: 10Esanders) [13:04:47] (03CR) 10jerkins-bot: [V: 04-1] ce.Surface: Refactor afterPaste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433980 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [13:05:44] (03PS2) 10DLynch: ce.Surface: Refactor afterPaste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433980 (https://phabricator.wikimedia.org/T190079) [13:05:50] (03CR) 10jerkins-bot: [V: 04-1] ce.MWWikitextSurface: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [13:14:51] (03Merged) 10jenkins-bot: Follow-up I2a49315d0: Fix right padding of active external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433943 (owner: 10Esanders) [13:17:07] (03CR) 10jenkins-bot: Follow-up I2a49315d0: Fix right padding of active external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433943 (owner: 10Esanders) [13:20:36] (03Merged) 10jenkins-bot: Use same padding across skins for external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433944 (owner: 10Esanders) [13:23:31] (03CR) 10jenkins-bot: Use same padding across skins for external links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433944 (owner: 10Esanders) [13:34:27] (03CR) 10Esanders: [C: 04-1] Language input fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433977 (owner: 10Esanders) [13:36:26] (03PS2) 10Esanders: Remove nested fields from LanguageInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433977 [13:46:44] (03PS1) 10Divec: Rebaser: Check universe before synchronizing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433990 [14:22:39] (03PS2) 10Divec: Rebaser: Check universe before synchronizing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433990 [14:28:14] (03PS1) 10DLynch: MWSaveDialog: Display of limit behavior unified with old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) [14:35:12] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor: Only show edit summary remaining character countdown for last 99 characters - https://phabricator.wikimedia.org/T194458#4217215 (10DLynch) a:03DLynch [15:09:22] (03PS10) 10DLynch: ce.MWWikitextSurface: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) [15:19:33] (03CR) 10jerkins-bot: [V: 04-1] ce.MWWikitextSurface: ask the paster whether to convert to wikitext or use plain text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [15:25:55] 10VisualEditor, 10OOUI: Scrolling through a long template dialog causes focus to jump - https://phabricator.wikimedia.org/T195072#4217308 (10Esanders) [15:30:52] (03CR) 10Divec: [C: 032] "A lot more readable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433980 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [15:32:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Looks good but we should hide the little box for the label when it is empty. https://phabricator.wikimedia.org/F18358422 .ve-ui-mwSaveDial" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [15:33:54] (03Merged) 10jenkins-bot: ce.Surface: Refactor afterPaste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433980 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [15:37:09] (03CR) 10jenkins-bot: ce.Surface: Refactor afterPaste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433980 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [15:49:04] (03PS2) 10DLynch: MWSaveDialog: Display of limit behavior unified with old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) [15:52:43] (03PS11) 10DLynch: ce.MWWikitextSurface: ask on paste about wikitext conversion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) [15:59:42] (03CR) 10jerkins-bot: [V: 04-1] ce.MWWikitextSurface: ask on paste about wikitext conversion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [16:07:16] (03CR) 10Jforrester: [C: 04-1] "We shouldn't have the down-counter magically appear and reflow the content box. That's not cool for users. :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [16:08:28] (03CR) 10DLynch: "> Patch Set 2: Code-Review-1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [16:10:44] (03CR) 10DLynch: "> Patch Set 2:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [16:11:13] (03PS1) 10Esanders: Add 'safe' flag to language dialog 'back' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434026 [16:11:49] (03PS1) 10Esanders: rebaser: Clarify document name is optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434027 [16:20:45] (03CR) 10jerkins-bot: [V: 04-1] Add 'safe' flag to language dialog 'back' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434026 (owner: 10Esanders) [16:40:42] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434026 (owner: 10Esanders) [16:45:11] (03PS1) 10DLynch: Use passive event listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434031 (https://phabricator.wikimedia.org/T178371) [16:47:07] (03CR) 10DLynch: "This adds some helpers for passive events, and applies them to the low hanging fruit of our scroll handlers which definitely don't use pre" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434031 (https://phabricator.wikimedia.org/T178371) (owner: 10DLynch) [17:01:09] 10Citoid, 10VisualEditor: Unable to cite baby center.com - https://phabricator.wikimedia.org/T195080#4217568 (10Mvolz) [17:01:38] 10Citoid, 10VisualEditor: Unable to cite baby center.com - https://phabricator.wikimedia.org/T195080#4217579 (10Mvolz) p:05Triage>03Normal [17:05:37] (03CR) 10Jforrester: [C: 04-1] "Sorry, yes, reflow the checkboxes (BTW the image you shared is private to you ;-))" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [17:06:54] (03CR) 10Jforrester: [C: 032] Add 'safe' flag to language dialog 'back' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434026 (owner: 10Esanders) [17:08:08] (03CR) 10Jforrester: [C: 032] Remove nested fields from LanguageInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433977 (owner: 10Esanders) [17:10:27] (03CR) 10DLynch: "> Patch Set 2:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [17:10:42] (03PS3) 10DLynch: MWSaveDialog: Display of limit behavior unified with old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) [17:10:57] (03Merged) 10jenkins-bot: Add 'safe' flag to language dialog 'back' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434026 (owner: 10Esanders) [17:12:43] (03Merged) 10jenkins-bot: Remove nested fields from LanguageInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433977 (owner: 10Esanders) [17:15:08] (03CR) 10jenkins-bot: Add 'safe' flag to language dialog 'back' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434026 (owner: 10Esanders) [17:19:22] (03CR) 10Jforrester: "The line already overflows on wikis with flagged revs on (even in English), let alone for languages with long labels. :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [17:19:39] (03CR) 10Jforrester: [C: 031] MWSaveDialog: Display of limit behavior unified with old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [17:19:49] (03CR) 10jenkins-bot: Remove nested fields from LanguageInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433977 (owner: 10Esanders) [17:24:56] (03PS2) 10Jforrester: Update VE core submodule to master (511911451) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433947 (https://phabricator.wikimedia.org/T190079) [17:28:38] (03CR) 10Jforrester: [C: 032] rebaser: Clarify document name is optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434027 (owner: 10Esanders) [17:31:36] (03PS1) 10DLynch: DesktopArticleTarget: on escape close toolbar dialogs first [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434038 (https://phabricator.wikimedia.org/T190068) [17:32:25] (03Merged) 10jenkins-bot: rebaser: Clarify document name is optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434027 (owner: 10Esanders) [17:33:02] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (511911451) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433947 (https://phabricator.wikimedia.org/T190079) (owner: 10Jforrester) [17:36:42] (03CR) 10jenkins-bot: rebaser: Clarify document name is optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434027 (owner: 10Esanders) [17:36:43] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), 10OOUI (OOUI-0.27.0), 10VisualEditor (Current work): WMUI: Don't add icon padding to menu dropdowns without icons - https://phabricator.wikimedia.org/T194050#4217647 (10Esanders) 05Open>03Resolved [17:37:25] 10VisualEditor-Performance, 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Use passive events where appropriate - https://phabricator.wikimedia.org/T178371#4217650 (10DLynch) a:03DLynch [17:38:40] 10VisualEditor-Performance, 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Use passive events where appropriate - https://phabricator.wikimedia.org/T178371#3690107 (10DLynch) [17:38:42] 10VisualEditor, 10Readers-Web-Backlog (Tracking): [Bug] Mobile VisualEditor prints ~1200 non-passive event listener violations to console - https://phabricator.wikimedia.org/T190550#4217653 (10DLynch) [17:42:35] 10VisualEditor-MediaWiki-Templates, 10MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), 10VisualEditor (Current work): VisualEditor crashes on a particular template insertion - https://phabricator.wikimedia.org/T194839#4210502 (10Jdforrester-WMF) [17:42:52] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), 10Technical-Debt, 10VisualEditor (Current work): Rewrite DesktopArticleTarget#rebuildCategories, it doesn't need an API request - https://phabricator.wikimedia.org/T194092#4217665 (10Jdforrester-WMF) [17:42:57] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), 10VisualEditor (Current work): Consider adding back RevisionSlider header to VisualDiffs - https://phabricator.wikimedia.org/T193839#4217666 (10Jdforrester-WMF) [17:43:25] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), 10VisualEditor (Current work): Hashlinks with question marks shown as missing articles in preview - https://phabricator.wikimedia.org/T194463#4217667 (10Jdforrester-WMF) [17:43:46] (03Merged) 10jenkins-bot: Update VE core submodule to master (511911451) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433947 (https://phabricator.wikimedia.org/T190079) (owner: 10Jforrester) [17:47:03] (03CR) 10jenkins-bot: Update VE core submodule to master (511911451) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433947 (https://phabricator.wikimedia.org/T190079) (owner: 10Jforrester) [17:47:28] (03CR) 10Jforrester: [C: 031] DesktopArticleTarget: on escape close toolbar dialogs first [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434038 (https://phabricator.wikimedia.org/T190068) (owner: 10DLynch) [17:48:18] (03PS12) 10Jforrester: ce.MWWikitextSurface: ask on paste about wikitext conversion [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/425464 (https://phabricator.wikimedia.org/T190079) (owner: 10DLynch) [18:05:44] (03CR) 10Divec: [C: 04-2] "As per Roan: the client has to reject consistently with the server, which right now it won't because it has no stored concept of what was " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433932 (owner: 10Divec) [18:32:58] 10VisualEditor: [Regression pre-wmf.4] Sort buttons on table header cells are overlapping with the text in it - https://phabricator.wikimedia.org/T195108#4218003 (10Ryasmeen) [18:33:52] 10VisualEditor: [Regression pre-wmf.4] Sort buttons on table header cells are overlapping with the text in it - https://phabricator.wikimedia.org/T195108#4218013 (10Ryasmeen) [19:08:48] 10VisualEditor, 10Technical-Debt: Avoid jQuery in ve.dm. - https://phabricator.wikimedia.org/T195111#4218064 (10Esanders) [19:11:31] (03PS1) 10Esanders: $.isEmptyObject -> ve.isEmptyObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434053 (https://phabricator.wikimedia.org/T195111) [19:45:29] (03PS1) 10Esanders: Don't use $.isNumeric in DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434056 (https://phabricator.wikimedia.org/T195111) [19:45:31] (03PS1) 10Esanders: Avoid more jQuery in DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434057 (https://phabricator.wikimedia.org/T195111) [19:45:33] (03PS1) 10Esanders: Replace $.extend with ve.extendObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434058 [20:01:29] (03CR) 10Esanders: [C: 032] MWSaveDialog: Display of limit behavior unified with old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [20:10:53] (03Merged) 10jenkins-bot: MWSaveDialog: Display of limit behavior unified with old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [20:12:59] (03CR) 10jenkins-bot: MWSaveDialog: Display of limit behavior unified with old editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/433997 (https://phabricator.wikimedia.org/T194458) (owner: 10DLynch) [20:13:50] 10VisualEditor-Initialisation, 10Patch-For-Review, 10VisualEditor (Current work): &veaction=edit URL parameter does not work on mobile site - https://phabricator.wikimedia.org/T185729#4218183 (10DLynch) a:03DLynch [20:19:17] (03CR) 10DLynch: [C: 032] Replace $.extend with ve.extendObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434058 (owner: 10Esanders) [20:19:59] (03CR) 10DLynch: [C: 032] $.isEmptyObject -> ve.isEmptyObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434053 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:21:24] (03CR) 10DLynch: [C: 032] Don't use $.isNumeric in DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434056 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:23:11] (03CR) 10DLynch: [C: 032] Avoid more jQuery in DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434057 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:23:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434090 (owner: 10L10n-bot) [20:23:41] (03Merged) 10jenkins-bot: $.isEmptyObject -> ve.isEmptyObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434053 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:25:50] (03Merged) 10jenkins-bot: Don't use $.isNumeric in DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434056 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:26:21] (03Merged) 10jenkins-bot: Avoid more jQuery in DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434057 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:27:27] (03CR) 10jenkins-bot: $.isEmptyObject -> ve.isEmptyObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434053 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:27:55] (03Merged) 10jenkins-bot: Replace $.extend with ve.extendObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434058 (owner: 10Esanders) [20:31:12] (03CR) 10jenkins-bot: Don't use $.isNumeric in DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434056 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:32:53] (03PS7) 10Krinkle: init: Use local variable for action.init.duration in mw.trackSubscriber [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) [20:34:06] (03CR) 10jenkins-bot: Avoid more jQuery in DM [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434057 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [20:36:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10Performance, 10User-Ryasmeen: Typing into text field in media search dialog hangs and then crashes browser tab when using Opera (Chromium-like) on Windows 7 - https://phabricator.wikimedia.org/T126546#4218207 (10matmarex) 05Open>03Resolved No longer happening... [20:36:43] (03CR) 10jenkins-bot: Replace $.extend with ve.extendObject [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434058 (owner: 10Esanders) [20:58:43] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4218229 (10matmarex) Demo of highlights with holes using SVG clip-paths and masks: {F18362749} [21:04:30] (03PS1) 10Bartosz Dziewoński: [WIP] FocusableNode: Allow the highlights to have holes (using SVG) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434103 (https://phabricator.wikimedia.org/T53202) [21:04:37] (03PS1) 10Bartosz Dziewoński: [WIP] ve.ce.MWBlockImageNode: Leave a hole for the caption in the focus highlight [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434104 (https://phabricator.wikimedia.org/T190226) [21:04:46] (03CR) 10jerkins-bot: [V: 04-1] [WIP] ve.ce.MWBlockImageNode: Leave a hole for the caption in the focus highlight [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434104 (https://phabricator.wikimedia.org/T190226) (owner: 10Bartosz Dziewoński) [21:06:05] (03PS8) 10Krinkle: mw.trackSubscriber: Remove action.init.timing value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) [21:06:14] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 10Patch-For-Review: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4218239 (10matmarex) Screenshot (I've put no effort yet into tweaking the CSS): {F18... [21:06:58] (03CR) 10jerkins-bot: [V: 04-1] [WIP] FocusableNode: Allow the highlights to have holes (using SVG) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434103 (https://phabricator.wikimedia.org/T53202) (owner: 10Bartosz Dziewoński) [22:52:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-ResourceLoader, 10Performance-Team (Radar): safemode parameter doesn't work with VE - https://phabricator.wikimedia.org/T185303#4218326 (10Krinkle) [23:26:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-ResourceLoader, 10Performance-Team (Radar): safemode parameter doesn't work with VE - https://phabricator.wikimedia.org/T185303#4218352 (10Krinkle) a:05Krinkle>03matmarex [23:27:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-ResourceLoader, 10Performance-Team (Radar): safemode parameter doesn't work with VE - https://phabricator.wikimedia.org/T185303#3912314 (10Krinkle) Re-assigning given the ResourceLoader part seems done. Please verify whether this solves the issue for VE...