[01:54:14] 10TemplateData, 10VisualEditor, 10Test-Coverage: TemplateData extension is missing @covers tags - https://phabricator.wikimedia.org/T195164#4218544 (10Legoktm) [07:00:24] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#1695626 (10Xover) The CS1-based templates—which are actually in use across a lot of different language wikipedias—quite correctly provid... [07:29:41] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), 10VisualEditor (Current work): VisualEditor: Only show edit summary remaining character countdown for last 99 characters - https://phabricator.wikimedia.org/T194458#4218701 (10Jdforrester-WMF) [07:36:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance: Support editing parts of a page in VisualEditor-MediaWiki - https://phabricator.wikimedia.org/T50429#4218705 (10Jdforrester-WMF) [07:39:41] 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 10Epic, 10VisualEditor (Current work): Load/display document-level data (e.g. internal lists, meta lists) for the whole document but only the content for a part of the document - https://phabricator.wikimedia.org/T76541#4218707 (10Jdforrester-WMF) a:03... [07:42:07] (03PS2) 10Divec: WIP POC: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) [07:44:44] (03CR) 10jerkins-bot: [V: 04-1] WIP POC: Support only surfacing part of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433753 (https://phabricator.wikimedia.org/T76541) (owner: 10Divec) [07:45:37] 10VisualEditor, 10Patch-For-Review, 10Technical-Debt: Avoid jQuery in ve.dm. - https://phabricator.wikimedia.org/T195111#4218064 (10Jdforrester-WMF) Remaining uses are `$.Deferred`, `$.parseHTML`, `$.getJSON`, `$.when`, and `$.noop`. [07:46:07] 10VisualEditor-DataModel, 10Technical-Debt, 10VisualEditor (Current work): Avoid jQuery in ve.dm. - https://phabricator.wikimedia.org/T195111#4218723 (10Jdforrester-WMF) a:03Esanders [07:47:17] 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 10Epic, 10Patch-For-Review, 10VisualEditor (Current work): Load/display document-level data (e.g. internal lists, meta lists) for the whole document but only the content for a part of the document - https://phabricator.wikimedia.org/T76541#4218726 (10d... [09:37:32] (03PS1) 10Esanders: Initialise socketIO twice to avoid query cache [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434145 [09:37:34] (03PS1) 10Esanders: Teardown synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434146 [09:59:35] (03PS1) 10Esanders: [PULL THROUGH] Pass import promise to setSynchronizer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434150 [10:00:29] (03PS1) 10Esanders: $.isEmptyObject -> ve.isEmptyObject [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434151 [10:01:03] (03PS1) 10Esanders: Show progress bar while connecting to rebase server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434152 [10:01:09] (03CR) 10jerkins-bot: [V: 04-1] [PULL THROUGH] Pass import promise to setSynchronizer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434150 (owner: 10Esanders) [10:01:19] (03CR) 10jerkins-bot: [V: 04-1] Show progress bar while connecting to rebase server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434152 (owner: 10Esanders) [10:06:05] 10VisualEditor: rebaser: Import an page to Special:CollabPad - https://phabricator.wikimedia.org/T195180#4218871 (10Esanders) [10:07:18] 10VisualEditor: rebaser: Import an page to Special:CollabPad - https://phabricator.wikimedia.org/T195180#4218901 (10Esanders) Implemented in https://gerrit.wikimedia.org/r/#/c/433756/: {F18372065,size=full} [10:17:31] (03PS2) 10Esanders: Initialise socketIO twice to avoid query cache [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434145 [10:17:33] (03PS2) 10Esanders: Teardown synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434146 [10:17:35] (03PS2) 10Esanders: Show progress bar while connecting to rebase server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434152 [10:19:02] (03PS1) 10Esanders: Temporarily disable broken ref tools in CollabTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434153 (https://phabricator.wikimedia.org/T194838) [10:23:05] (03PS3) 10Esanders: Initialise socketIO twice to avoid query cache [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434145 [10:23:07] (03PS3) 10Esanders: Teardown synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434146 [10:23:09] (03PS3) 10Esanders: Show progress bar while connecting to rebase server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434152 [10:39:41] (03CR) 10DLynch: [C: 031] "I'm okay with this -- the init `timing` was fairly meaningless. If we could get a Product +1 as well, that'd be ideal, just so they don't " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) (owner: 10Krinkle) [10:53:54] (03PS1) 10Esanders: Make options actually optional as documented [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434160 [10:57:55] (03CR) 10Jforrester: [C: 032] Make options actually optional as documented [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434160 (owner: 10Esanders) [10:58:09] (03CR) 10Jforrester: [C: 032] Temporarily disable broken ref tools in CollabTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434153 (https://phabricator.wikimedia.org/T194838) (owner: 10Esanders) [10:58:23] (03CR) 10Jforrester: [C: 032] $.isEmptyObject -> ve.isEmptyObject [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434151 (owner: 10Esanders) [11:07:42] (03Merged) 10jenkins-bot: Make options actually optional as documented [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434160 (owner: 10Esanders) [11:09:49] (03Merged) 10jenkins-bot: Temporarily disable broken ref tools in CollabTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434153 (https://phabricator.wikimedia.org/T194838) (owner: 10Esanders) [11:09:52] (03Merged) 10jenkins-bot: $.isEmptyObject -> ve.isEmptyObject [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434151 (owner: 10Esanders) [11:10:34] (03CR) 10jenkins-bot: Make options actually optional as documented [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434160 (owner: 10Esanders) [11:14:00] (03CR) 10jenkins-bot: Temporarily disable broken ref tools in CollabTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434153 (https://phabricator.wikimedia.org/T194838) (owner: 10Esanders) [11:15:53] (03CR) 10jenkins-bot: $.isEmptyObject -> ve.isEmptyObject [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434151 (owner: 10Esanders) [11:24:00] 10VisualEditor: Cite menu option is missing on the Mobile VE toolbar - https://phabricator.wikimedia.org/T195191#4219126 (10Ryasmeen) [11:25:34] 10VisualEditor: Cite menu option is missing on the Mobile VE toolbar - https://phabricator.wikimedia.org/T195191#4219136 (10Ryasmeen) [11:48:09] (03CR) 10Divec: [C: 032] Initialise socketIO twice to avoid query cache [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434145 (owner: 10Esanders) [11:48:55] (03CR) 10Divec: [C: 032] Teardown synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434146 (owner: 10Esanders) [11:50:51] 10VisualEditor, 10VisualEditor-VisualDiffs: "element.setAttribute is not a function" error due to comment nodes, when switching to historic visual diff - https://phabricator.wikimedia.org/T187616#3980841 (10DLynch) Doesn't seem to happen any more, so I imagine T187070 fixed it as a side-effect. [11:51:06] (03Merged) 10jenkins-bot: Initialise socketIO twice to avoid query cache [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434145 (owner: 10Esanders) [11:51:54] (03PS1) 10Bartosz Dziewoński: ve.ce.FocusableNode: Fix minor code issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434172 [11:51:56] (03PS1) 10Bartosz Dziewoński: ve.ce.FocusableNode: Remove "ve-ce-focusableNode-highlight-relocatable-marker" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434173 [11:53:51] (03Merged) 10jenkins-bot: Teardown synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434146 (owner: 10Esanders) [11:55:06] (03PS2) 10Bartosz Dziewoński: [WIP] FocusableNode: Allow the highlights to have holes (using SVG) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434103 (https://phabricator.wikimedia.org/T53202) [11:55:19] (03CR) 10jenkins-bot: Initialise socketIO twice to avoid query cache [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434145 (owner: 10Esanders) [11:57:45] (03CR) 10jerkins-bot: [V: 04-1] [WIP] FocusableNode: Allow the highlights to have holes (using SVG) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434103 (https://phabricator.wikimedia.org/T53202) (owner: 10Bartosz Dziewoński) [11:59:49] (03CR) 10jenkins-bot: Teardown synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434146 (owner: 10Esanders) [12:27:35] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#4219242 (10kaldari) @Mvolz: I think part of the problem with my specific example in the description is that Citoid/Zotero identifies tha... [12:27:50] (03PS3) 10Bartosz Dziewoński: [WIP] FocusableNode: Allow the highlights to have holes (using SVG) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434103 (https://phabricator.wikimedia.org/T53202) [12:29:13] (03PS2) 10Bartosz Dziewoński: [WIP] ve.ce.MWBlockImageNode: Leave a hole for the caption in the focus highlight [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434104 (https://phabricator.wikimedia.org/T190226) [12:31:06] (03CR) 10jerkins-bot: [V: 04-1] [WIP] FocusableNode: Allow the highlights to have holes (using SVG) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434103 (https://phabricator.wikimedia.org/T53202) (owner: 10Bartosz Dziewoński) [12:36:34] (03CR) 10jerkins-bot: [V: 04-1] [WIP] ve.ce.MWBlockImageNode: Leave a hole for the caption in the focus highlight [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434104 (https://phabricator.wikimedia.org/T190226) (owner: 10Bartosz Dziewoński) [13:45:09] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#4219406 (10Mvolz) >>! In T114450#4219242, @kaldari wrote: > @Mvolz: I think part of the problem with my specific example in the descript... [13:45:41] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#4219407 (10Mvolz) [13:56:01] 10VisualEditor, 10VisualEditor-ContentEditable: Reference list
can overlap a template
because that's how HTML works - https://phabricator.wikimedia.org/T104540#4219437 (10matmarex) [13:58:25] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 10Wikimedia-Hackathon-2018, 10Patch-For-Review: Allow "holes" inside focusable highlights, e.g. for images with editable captions - https://phabricator.wikimedia.org/T190226#4219439 (10matmarex) [13:58:46] 10VisualEditor, 10VisualEditor-ContentEditable, 10Wikimedia-Hackathon-2018: Reference list
can overlap a template
because that's how HTML works - https://phabricator.wikimedia.org/T104540#4219440 (10matmarex) [14:14:47] 10Citoid, 10VisualEditor, 10Community-consensus-needed: Citoid/VisualEditor doesn't handle citations for book chapters correctly - https://phabricator.wikimedia.org/T114450#4219459 (10kaldari) @Mvolz: Actually it's not that bad due to how the TemplateData mapping is set up in Cite book. If you put http://acc... [16:21:05] (03PS1) 10Divec: Rebaser: show connect/disconnect in the server console [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434196 [16:22:19] (03PS3) 10Divec: WIP POC: Rebaser: Check universe before synchronizing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/433990 [16:23:33] (03CR) 10jerkins-bot: [V: 04-1] Rebaser: show connect/disconnect in the server console [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434196 (owner: 10Divec) [16:27:13] (03PS2) 10Divec: Rebaser: show connect/disconnect in the server console [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434196 [16:44:55] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: Visual Editor should fix automatically equal links and linktexts ([[text|text]]) - https://phabricator.wikimedia.org/T195215#4219653 (10Bencemac) [16:48:20] (03CR) 10Divec: [C: 032] DesktopArticleTarget: on escape close toolbar dialogs first [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434038 (https://phabricator.wikimedia.org/T190068) (owner: 10DLynch) [16:52:55] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Templates: Transclusion dialog should not suggest documentation sub pages as templates - https://phabricator.wikimedia.org/T54448#4219675 (10Bencemac) [[ https://hu.wikipedia.org/w/index.php?title=Vars%C3%A1nyi_Istv%C3%A1n&diff=prev&oldid=... [16:55:03] (03Merged) 10jenkins-bot: DesktopArticleTarget: on escape close toolbar dialogs first [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434038 (https://phabricator.wikimedia.org/T190068) (owner: 10DLynch) [16:57:28] (03CR) 10jenkins-bot: DesktopArticleTarget: on escape close toolbar dialogs first [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434038 (https://phabricator.wikimedia.org/T190068) (owner: 10DLynch) [17:04:47] (03CR) 10Divec: [C: 032] Use passive event listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434031 (https://phabricator.wikimedia.org/T178371) (owner: 10DLynch) [17:09:42] (03Merged) 10jenkins-bot: Use passive event listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434031 (https://phabricator.wikimedia.org/T178371) (owner: 10DLynch) [17:10:21] 10VisualEditor-Performance, 10Patch-For-Review, 10Performance, 10VisualEditor (Current work): Use passive events where appropriate - https://phabricator.wikimedia.org/T178371#4219705 (10DLynch) @Ryasmeen: Testing for the merged patch should be on scrolling behavior. (The floating toolbar, find/replace sear... [17:11:56] (03PS3) 10Divec: Rebaser: show connect/disconnect in the server console [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434196 [17:13:21] (03CR) 10jenkins-bot: Use passive event listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434031 (https://phabricator.wikimedia.org/T178371) (owner: 10DLynch) [17:22:15] 10VisualEditor, 10ContentTranslation, 10Parsoid-Nowiki: Parsoid should autoconvert "[[link|lin]]k" to "[[link]]" - https://phabricator.wikimedia.org/T142927#4219748 (10Dvorapa) 05declined>03Open I would oppose. This seems to be completely unintentional [17:24:44] 10VisualEditor, 10ContentTranslation, 10Parsoid-Nowiki: consider stopping adding tags around [[text with double square brackets]] - https://phabricator.wikimedia.org/T142928#4219752 (10Dvorapa) Consider at least prompting user if that part is correct, like in {T190079} [17:29:43] 10VisualEditor-Initialisation, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): &veaction=edit URL parameter does not work on mobile site - https://phabricator.wikimedia.org/T185729#4219761 (10Jdforrester-WMF) [17:30:09] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), 10VisualEditor (Current work): Escape should close toolbar panels before trying to close the entire editor - https://phabricator.wikimedia.org/T190068#4219764 (10Jdforrester-WMF) [17:30:54] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10MobileFrontend, 10VisualEditor (Current work): Dialog asking "Do you really want to abandon your edit?" appears while saving an edit with mobile VE - https://phabricator.wikimedia.org/T190591#4219767 (10Jdforrester-WMF) [18:26:13] (03PS1) 10Divec: Rebaser: make the server synchronous again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434202 [18:30:58] (03CR) 10jerkins-bot: [V: 04-1] Rebaser: make the server synchronous again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434202 (owner: 10Divec) [18:39:00] (03PS2) 10Divec: Rebaser: make the server synchronous again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434202 [18:42:06] (03CR) 10jerkins-bot: [V: 04-1] Rebaser: make the server synchronous again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434202 (owner: 10Divec) [18:44:11] (03PS3) 10Divec: Rebaser: make the server synchronous again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434202