[00:00:17] 10VisualEditor: [Regression pre-wmf.6] UI for dialogs with multiple tabs in VE is broken on Beta - https://phabricator.wikimedia.org/T195544#4230421 (10Ryasmeen) [04:25:07] (03PS1) 10Legoktm: Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag issues [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/435085 [06:38:26] (03PS2) 10Santhosh: ApiResponseCache: Support redirects data processing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 [06:41:12] (03CR) 10Santhosh: ApiResponseCache: Support redirects data processing (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 (owner: 10Santhosh) [09:57:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435144 (owner: 10L10n-bot) [10:51:48] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-MediaWiki-References, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10User-Ryasmeen, 10VisualEditor (Current work): Cite menu option is missing on the Mobile VE toolbar - https://phabricator.wikimedia.org/T195191#4231131 (10Deskana) 05Ope... [11:07:21] 10VisualEditor, 10VisualEditor-CopyPaste: Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4229529 (10Esanders) Actually you don't even need nested lists: ``` * [A * B] ``` fixupInsertion is not happy about the unbalanced range being pasted (spec... [11:09:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10Regression: Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4231143 (10Esanders) p:05Triage>03High [11:11:11] 10VisualEditor, 10VisualEditor-CopyPaste, 10Regression: Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4231148 (10Esanders) Bisect blames https://gerrit.wikimedia.org/r/#/c/433980/ (@DLynch) [11:14:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10Regression: Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4231161 (10Esanders) Looks like in the refactor of afterPasteExtractClipboardData we moved the #insertContent call (the one that throws the... [11:19:39] 10VisualEditor, 10VisualEditor-CopyPaste, 10Regression: Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4231165 (10Esanders) a:03Esanders [11:19:54] 10VisualEditor-CopyPaste, 10Regression, 10VisualEditor (Current work): Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4231168 (10Esanders) p:05High>03Unbreak! [11:34:49] (03PS1) 10Esanders: Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435155 (https://phabricator.wikimedia.org/T195514) [11:35:18] (03PS2) 10Esanders: Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435155 (https://phabricator.wikimedia.org/T195514) [11:39:02] (03CR) 10jerkins-bot: [V: 04-1] Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435155 (https://phabricator.wikimedia.org/T195514) (owner: 10Esanders) [13:51:51] (03PS3) 10Esanders: Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435155 (https://phabricator.wikimedia.org/T195514) [13:56:33] (03CR) 10DLynch: [C: 032] Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435155 (https://phabricator.wikimedia.org/T195514) (owner: 10Esanders) [14:00:37] (03Merged) 10jenkins-bot: Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435155 (https://phabricator.wikimedia.org/T195514) (owner: 10Esanders) [14:04:58] (03CR) 10jenkins-bot: Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435155 (https://phabricator.wikimedia.org/T195514) (owner: 10Esanders) [14:09:59] (03PS1) 10Esanders: Fix async beforeEach in ve.ce.Surface tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435175 [14:17:37] 10VisualEditor-MediaWiki-Templates, 10OOUI (OOUI-0.27.1), 10VisualEditor (Current work): Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#4231589 (10Volker_E) 05Open>03Resolved [14:30:22] 10VisualEditor: ErrorException from line 351 of "ApiVisualEditor.php": PHP Warning: Illegal string offset 'revid' - https://phabricator.wikimedia.org/T195590#4231610 (10Kghbln) [14:39:41] (03CR) 10Esanders: [C: 031] ApiResponseCache: Support redirects data processing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 (owner: 10Santhosh) [14:40:39] (03CR) 10Esanders: [C: 032] Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag issues [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/435085 (owner: 10Legoktm) [14:47:22] 10VisualEditor: ErrorException from line 351 of "ApiVisualEditor.php": PHP Warning: Illegal string offset 'revid' - https://phabricator.wikimedia.org/T195590#4231610 (10Deskana) This seems to be the same as {T193718}. [14:47:33] 10VisualEditor: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4177770 (10Deskana) [14:47:35] 10VisualEditor: ErrorException from line 351 of "ApiVisualEditor.php": PHP Warning: Illegal string offset 'revid' - https://phabricator.wikimedia.org/T195590#4231682 (10Deskana) [14:48:38] 10VisualEditor: ErrorException from line 351 of "ApiVisualEditor.php": PHP Warning: Illegal string offset 'revid' - https://phabricator.wikimedia.org/T195590#4231683 (10Kghbln) Indeed looks like it. Let's hope for a fix. Cheers [14:49:48] 10VisualEditor: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4231686 (10Kghbln) I ran into the same issue. Here are my data: **Setup** - MediaWiki 1.31.0-rc.0 (a3335f4) 07:55, 23. Mai 2018 - PHP 7.0.27-0+deb9u1 (apache2handler) - MariaD... [14:56:51] (03Merged) 10jenkins-bot: Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag issues [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/435085 (owner: 10Legoktm) [15:07:43] 10VisualEditor: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4231718 (10Esanders) I'm not sure under what circumstances the API request would not return a revid. Perhaps you could inspect the contents of `$result` (on line 346) to find out... [15:18:03] 10VisualEditor: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4231761 (10Kghbln) I have no idea how to do this. I get this with ?veaction=editsource. [16:04:40] 10VisualEditor: Using back button to go back to Special:CollabPad adds a new toolbar - https://phabricator.wikimedia.org/T194837#4210453 (10DLynch) I don't think this is happening any more. (Or, it's not to me.) [16:20:50] 10VisualEditor-CopyPaste, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4229529 (10Jdforrester-WMF) Eurgh. Doesn't cherry-pick nicely. :-( [16:22:03] (03CR) 10Jforrester: [C: 032] Fix async beforeEach in ve.ce.Surface tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435175 (owner: 10Esanders) [16:22:48] (03CR) 10Jforrester: [C: 032] Strip 'about' attributes when comparing alien nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435053 (https://phabricator.wikimedia.org/T195344) (owner: 10Esanders) [16:26:55] (03Merged) 10jenkins-bot: Fix async beforeEach in ve.ce.Surface tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435175 (owner: 10Esanders) [16:26:57] (03Merged) 10jenkins-bot: Strip 'about' attributes when comparing alien nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435053 (https://phabricator.wikimedia.org/T195344) (owner: 10Esanders) [16:30:00] (03CR) 10jenkins-bot: Fix async beforeEach in ve.ce.Surface tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435175 (owner: 10Esanders) [16:33:03] (03CR) 10jenkins-bot: Strip 'about' attributes when comparing alien nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435053 (https://phabricator.wikimedia.org/T195344) (owner: 10Esanders) [16:33:25] (03PS1) 10DLynch: DesktopArticleTarget: Section-scroll as part of restoring the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) [16:35:42] (03PS1) 10Jforrester: build: Bump devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435191 [16:40:57] (03CR) 10jerkins-bot: [V: 04-1] DesktopArticleTarget: Section-scroll as part of restoring the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) (owner: 10DLynch) [16:43:51] (03PS2) 10DLynch: DesktopArticleTarget: Section-scroll as part of restoring the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) [18:03:12] 10VisualEditor: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4177770 (10Jdforrester-WMF) The relevant code from [[https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/VisualEditor/+/REL1_31/includes/ApiVisualEditor.php#351 |... [18:07:18] (03PS1) 10Jforrester: ApiVisualEditor: Defensively check that query prop revisions returns arrays [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435200 (https://phabricator.wikimedia.org/T193718) [18:08:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4232294 (10Jdforrester-WMF) [18:26:33] (03PS1) 10Jforrester: Update VE core submodule to master (a17837fa6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435203 (https://phabricator.wikimedia.org/T195344) [18:40:55] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (a17837fa6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435203 (https://phabricator.wikimedia.org/T195344) (owner: 10Jforrester) [18:45:46] (03CR) 10Bartosz Dziewoński: [C: 04-1] "See task" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435200 (https://phabricator.wikimedia.org/T193718) (owner: 10Jforrester) [18:45:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4177770 (10matmarex) >>! In T193718#4232281, @Jdforrester-WMF wrote: > "Illegal string offset" means that `$revArr` (which shoul... [18:51:07] (03Merged) 10jenkins-bot: Update VE core submodule to master (a17837fa6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435203 (https://phabricator.wikimedia.org/T195344) (owner: 10Jforrester) [18:54:18] (03CR) 10jenkins-bot: Update VE core submodule to master (a17837fa6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435203 (https://phabricator.wikimedia.org/T195344) (owner: 10Jforrester) [19:13:30] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10VisualEditor (Current work): Unchanged alien nodes sometimes show up in visual diff - https://phabricator.wikimedia.org/T195344#4232542 (10Jdforrester-WMF) a:03Esanders [19:13:36] 10VisualEditor-CopyPaste, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Regression, 10VisualEditor (Current work): Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4232545 (10Jdforrester-WMF) [20:18:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435269 (owner: 10L10n-bot) [20:28:56] (03PS1) 10Jforrester: build: Introduce eslint-plugin-qunit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435279 [20:28:58] (03PS1) 10Jforrester: build: Enable eslint's qunit/literal-compare-order rule, with an exception [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435280 [20:29:00] (03PS1) 10Jforrester: build: Enable eslint's qunit/no-ok-equality rule [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435281 [20:47:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/435260 (owner: 10L10n-bot) [21:04:54] (03PS2) 10Esanders: ApiVisualEditor: Defensively check that query prop revisions returns arrays [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435200 (https://phabricator.wikimedia.org/T193718) (owner: 10Jforrester) [21:05:03] (03CR) 10Esanders: [C: 031] "Added comment" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435200 (https://phabricator.wikimedia.org/T193718) (owner: 10Jforrester) [21:29:12] (03CR) 10Esanders: DesktopArticleTarget: Section-scroll as part of restoring the page (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) (owner: 10DLynch) [21:29:48] (03CR) 10DLynch: DesktopArticleTarget: Section-scroll as part of restoring the page (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) (owner: 10DLynch) [21:30:26] (03PS3) 10DLynch: DesktopArticleTarget: Section-scroll as part of restoring the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) [21:30:43] (03CR) 10Krinkle: [C: 031] build: Enable eslint's qunit/literal-compare-order rule, with an exception [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435280 (owner: 10Jforrester) [21:31:53] (03CR) 10Krinkle: [C: 031] "Nice" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435281 (owner: 10Jforrester) [21:35:06] (03CR) 10Esanders: [C: 032] build: Enable eslint's qunit/literal-compare-order rule, with an exception [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435280 (owner: 10Jforrester) [22:08:18] (03PS1) 10Jforrester: Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] (wmf/1.32.0-wmf.5) - 10https://gerrit.wikimedia.org/r/435292 (https://phabricator.wikimedia.org/T195514) [22:14:40] (03CR) 10Jforrester: [C: 032] Fix try/catch in internal paste with original data [VisualEditor/VisualEditor] (wmf/1.32.0-wmf.5) - 10https://gerrit.wikimedia.org/r/435292 (https://phabricator.wikimedia.org/T195514) (owner: 10Jforrester) [22:24:03] 10VisualEditor-CopyPaste, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4233085 (10Jdforrester-WMF) [23:09:10] tried copying from google docs into NWE and found it kept an internal link but not external/interwikis (?) [23:19:51] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 20.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435301 (owner: 10Libraryupgrader) [23:33:18] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 20.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435301 (owner: 10Libraryupgrader)