[00:14:01] 10VisualEditor-CopyPaste, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Regression, 10Verified, 10VisualEditor (Current work): Can't copy and paste a list on office.wiki page in the visual editor - https://phabricator.wikimedia.org/T195514#4241673 (10Ryasmeen) [08:00:59] 10WikiEditor: Bug: When a Talk Page is Refreshed After Saving Edits, it Re-Enters Edit-Mode - https://phabricator.wikimedia.org/T195761#4241978 (10Johnywhy) 05stalled>03Open [10:57:06] 10VisualEditor, 10Commons: Outline the process of proposing that Visual Editor be available to all editors in the Commons: namespace - https://phabricator.wikimedia.org/T195956#4242475 (10Mrjohncummings) [12:19:09] 10WikiEditor: Bug: When a Talk Page is Refreshed After Saving Edits, it Re-Enters Edit-Mode - https://phabricator.wikimedia.org/T195761#4236150 (10Aklapper) T195914 (coming from https://en.wikipedia.org/wiki/Wikipedia:Help_desk?#Prevent_edit_source_auto_launch ) might be the same problem: "the User TalkPage auto... [12:19:36] 10WikiEditor, 10MediaWiki-Page-editing: Bug: When a Talk Page is Refreshed After Saving Edits, it Re-Enters Edit-Mode - https://phabricator.wikimedia.org/T195761#4242628 (10Aklapper) [14:14:33] (03PS2) 10Esanders: Update language variant node to new use invisible icon API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436062 (https://phabricator.wikimedia.org/T195887) [14:15:07] (03PS3) 10Esanders: Update language variant node to new use invisible icon API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436062 (https://phabricator.wikimedia.org/T195887) [14:17:53] 10VisualEditor, 10Commons: Outline the process of proposing that Visual Editor be available to all editors in the Commons: namespace - https://phabricator.wikimedia.org/T195956#4243044 (10Deskana) 05Open>03Invalid What's the process? Well, it's the same as anything else: hold a discussion, and if there's e... [14:26:40] (03CR) 10jerkins-bot: [V: 04-1] Update language variant node to new use invisible icon API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436062 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [15:10:33] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10Discovery, 10Maps, and 2 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4243180 (10Jdforrester-WMF) a:03Esanders [15:46:42] (03CR) 10DLynch: [C: 04-1] "This does have a visible side-effect of making the icons in comments bigger, like so https://www.dropbox.com/s/ar4qgnqbaz9e4u3/Screenshot%" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [15:51:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Don't show the loading bar on the 2017 Wikitext editor for the first 750ms - https://phabricator.wikimedia.org/T193665#4243287 (10DLynch) @Deskana it's not merged yet, so I think what you're saying is that the current state of a... [16:08:25] (03PS22) 10DLynch: LinkContextItem: add label information to the context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) [16:14:57] (03CR) 10Esanders: "Yeah - I considered long comments, should be rare, and shouldn't be much of an issue." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [16:17:06] (03CR) 10Esanders: "They are slightly larger in Apex, but WMUI was already enforcing a min-size of 20px to avoid blurry icons." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [16:24:20] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Epic: Make the visual diff functionality in the visual editor a standalone tool - https://phabricator.wikimedia.org/T194601#4243329 (10Archonic001) That's understandable. I'm using CKEditor 5 in my app, and they have their own data model and virtual DOM. A standa... [16:27:10] (03CR) 10DLynch: [C: 04-1] "> Patch Set 3:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [16:41:32] (03CR) 10Esanders: [C: 032] "Was giving Bartosz a chance to look. Probably okay though." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 (owner: 10Santhosh) [16:53:08] (03Merged) 10jenkins-bot: ApiResponseCache: Support redirects data processing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 (owner: 10Santhosh) [16:55:59] (03PS23) 10DLynch: LinkContextItem: add label information to the context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) [16:56:45] (03CR) 10jenkins-bot: ApiResponseCache: Support redirects data processing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 (owner: 10Santhosh) [17:18:15] (03PS4) 10Esanders: Upstream comment node's invisble icon with label into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) [17:18:28] (03CR) 10Esanders: "fixed" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [17:24:05] (03PS1) 10Esanders: Factor out synchronous part of updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436329 [17:25:32] (03PS1) 10Esanders: Bypass expensive hasRendering calculation for CommentNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436330 [17:27:21] (03CR) 10Esanders: [C: 04-1] "Label vertical alignment is off in WMUI" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [17:31:52] (03CR) 10jerkins-bot: [V: 04-1] Factor out synchronous part of updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436329 (owner: 10Esanders) [17:46:00] (03CR) 10Esanders: [C: 04-1] LinkContextItem: add label information to the context (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [17:55:38] (03CR) 10Esanders: [C: 04-1] LinkContextItem: add label information to the context (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [18:23:43] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436329 (owner: 10Esanders) [18:26:47] (03PS1) 10Esanders: Fix OOUI deprecation warning from tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436348 [18:30:33] (03CR) 10Bartosz Dziewoński: [C: 032] Fix OOUI deprecation warning from tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436348 (owner: 10Esanders) [18:35:43] (03Merged) 10jenkins-bot: Fix OOUI deprecation warning from tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436348 (owner: 10Esanders) [18:39:30] 10VisualEditor, 10VisualEditor-EditingTools, 10Discovery, 10Maps, and 2 others: Make it possible to add a caption on a mapframe map - https://phabricator.wikimedia.org/T193658#4243832 (10JTannerWMF) [18:40:19] (03CR) 10jenkins-bot: Fix OOUI deprecation warning from tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436348 (owner: 10Esanders) [19:40:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4244053 (10Kghbln) I wanted to test the patch pulled. Thus killed my wiki. I am not sure what is going one since this one was su... [20:03:18] (03CR) 10Bartosz Dziewoński: [C: 032] ApiVisualEditor: Defensively check that query prop revisions returns arrays [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435200 (https://phabricator.wikimedia.org/T193718) (owner: 10Jforrester) [20:04:31] (03PS1) 10Esanders: build: Introduce eslint-plugin-qunit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436358 [20:30:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436396 (owner: 10L10n-bot) [20:35:13] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10Discovery, 10Maps, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4175631 (10jmatazzoni) So, I'm looking at the map and thinking this must have been fixed (unless I just don't... [20:53:52] (03CR) 10Jforrester: [C: 032] build: Introduce eslint-plugin-qunit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436358 (owner: 10Esanders) [21:01:56] (03Merged) 10jenkins-bot: build: Introduce eslint-plugin-qunit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436358 (owner: 10Esanders) [21:05:51] (03CR) 10jenkins-bot: build: Introduce eslint-plugin-qunit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436358 (owner: 10Esanders) [21:41:08] 10VisualEditor, 10Parsoid: DOMDiffing tripped up by manipulations made by VE - https://phabricator.wikimedia.org/T196025#4244457 (10Arlolra) [21:42:21] 10VisualEditor, 10Parsoid: DOMDiffing tripped up by manipulations made by VE - https://phabricator.wikimedia.org/T196025#4244457 (10ssastry) We already know about
wrapper stripping which we account for. [21:43:29] 10VisualEditor, 10Parsoid: DOMDiffing tripped up by manipulations made by VE - https://phabricator.wikimedia.org/T196025#4244481 (10Arlolra) Yes, that bag of worms is in T193500 [21:43:50] 10VisualEditor, 10Parsoid: DOMDiffing tripped up by manipulations made by VE - https://phabricator.wikimedia.org/T196025#4244483 (10Arlolra) p:05Triage>03High [21:50:56] 10VisualEditor, 10Parsoid: DOMDiffing tripped up by manipulations made by VE - https://phabricator.wikimedia.org/T196025#4244489 (10Arlolra) `mw:NumberedLink` looks to be from T188429 [21:52:35] 10VisualEditor, 10Parsoid: Identify editing-client DOM transformations that Parsoid needs to account for during DOM diffs - https://phabricator.wikimedia.org/T196025#4244491 (10ssastry) [21:53:38] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435200 (https://phabricator.wikimedia.org/T193718) (owner: 10Jforrester) [21:55:05] 10VisualEditor, 10Parsoid: Identify editing-client DOM transformations that Parsoid needs to account for during DOM diffs - https://phabricator.wikimedia.org/T196025#4244494 (10ssastry) Ideally, Parsoid shouldn't have to account for these since we cannot be trying to add adaptors based on different editing cli... [21:57:45] (03CR) 10Bartosz Dziewoński: [C: 032] DesktopArticleTarget: Section-scroll as part of restoring the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) (owner: 10DLynch) [22:03:36] (03Merged) 10jenkins-bot: ApiVisualEditor: Defensively check that query prop revisions returns arrays [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435200 (https://phabricator.wikimedia.org/T193718) (owner: 10Jforrester) [22:03:49] (03Merged) 10jenkins-bot: DesktopArticleTarget: Section-scroll as part of restoring the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) (owner: 10DLynch) [22:07:48] (03CR) 10jenkins-bot: ApiVisualEditor: Defensively check that query prop revisions returns arrays [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435200 (https://phabricator.wikimedia.org/T193718) (owner: 10Jforrester) [22:10:35] (03CR) 10jenkins-bot: DesktopArticleTarget: Section-scroll as part of restoring the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435190 (https://phabricator.wikimedia.org/T194631) (owner: 10DLynch) [22:14:34] (03PS1) 10Bartosz Dziewoński: ApiVisualEditor: Defensively check that query prop revisions returns arrays [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/436414 (https://phabricator.wikimedia.org/T193718) [22:15:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4244548 (10matmarex) >>! In T193718#4244053, @Kghbln wrote: > I wanted to test the patch and pulled it. Thus I killed my wiki. I... [22:15:48] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4244549 (10matmarex) [22:21:55] (03CR) 10Jforrester: [C: 032] ApiVisualEditor: Defensively check that query prop revisions returns arrays [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/436414 (https://phabricator.wikimedia.org/T193718) (owner: 10Bartosz Dziewoński) [22:26:26] (03Merged) 10jenkins-bot: ApiVisualEditor: Defensively check that query prop revisions returns arrays [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/436414 (https://phabricator.wikimedia.org/T193718) (owner: 10Bartosz Dziewoński) [22:35:37] 10Citoid, 10VisualEditor, 10Code-Stewardship-Reviews, 10Operations, 10Services (watching): zotero translation server: code stewardship request - https://phabricator.wikimedia.org/T187194#4244596 (10Jrbranaa) @danstillman thanks for the additional info regarding your developments. As timing is of the ess... [23:14:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOUI: Floating menu can be misplaced under certain circumstances - https://phabricator.wikimedia.org/T155976#4244689 (10matmarex) The VE bug seems like it's still valid. I don't think there's a OOUI bug here. Let's make this about VE. [23:15:11] 10VisualEditor, 10VisualEditor-MediaWiki: Floating menu (attached to MWSaveDialog's editSummaryInput by a script/gadget) can be misplaced under certain circumstances - https://phabricator.wikimedia.org/T155976#4244691 (10matmarex)