[00:13:17] (03CR) 10Bartosz Dziewoński: [C: 032] Disconnect surface model history listener when tearing down [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435794 (https://phabricator.wikimedia.org/T195775) (owner: 10Esanders) [00:23:38] (03Merged) 10jenkins-bot: Disconnect surface model history listener when tearing down [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435794 (https://phabricator.wikimedia.org/T195775) (owner: 10Esanders) [00:24:27] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Exception thrown when closing editor while inspector still open - https://phabricator.wikimedia.org/T195775#4244763 (10Jdforrester-WMF) [00:26:09] (03CR) 10jenkins-bot: Disconnect surface model history listener when tearing down [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435794 (https://phabricator.wikimedia.org/T195775) (owner: 10Esanders) [00:39:28] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10VisualEditor (Current work): Canceling section edit in NWE takes you to start of page - https://phabricator.wikimedia.org/T194631#4244780 (10Jdforrester-WMF) [00:42:30] 10WikiEditor, 10OOUI, 10I18n, 10Patch-For-Review, 10Regression: No localized Chechen letter for WikiEditor toolbar buttons is provided in Chechen Wikipedia - https://phabricator.wikimedia.org/T194211#4244786 (10matmarex) This change has been merged and is included in OOUI v0.27.1, which will be included... [00:43:37] 10WikiEditor, 10OOUI, 10I18n, 10Patch-For-Review, and 2 others: No localized Chechen letter for WikiEditor toolbar buttons is provided in Chechen Wikipedia - https://phabricator.wikimedia.org/T194211#4244787 (10matmarex) (The same icon will be used by VisualEditor.) [00:44:05] 10VisualEditor, 10VisualEditor-Tables: Table context off screen and causing(?) scrolling after OOUI update - https://phabricator.wikimedia.org/T163474#4244789 (10matmarex) [01:04:09] (03CR) 10Bartosz Dziewoński: [C: 031] "Sorry, I'm flooded with Gerrit mail." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 (owner: 10Santhosh) [02:35:56] (03PS2) 10Krinkle: Make VE mobile tools use full height [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435827 (https://phabricator.wikimedia.org/T190596) (owner: 10VolkerE) [02:36:11] (03CR) 10jerkins-bot: [V: 04-1] Make VE mobile tools use full height [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435827 (https://phabricator.wikimedia.org/T190596) (owner: 10VolkerE) [06:37:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436455 (owner: 10L10n-bot) [07:23:41] 10WikiEditor, 10MediaWiki-Page-editing: Bug: When a Talk Page is Refreshed After Saving Edits, it Re-Enters Edit-Mode - https://phabricator.wikimedia.org/T195761#4245088 (10Johnywhy) @Aklapper have you duplicated the problem? [08:40:24] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10Patch-For-Review, 10VisualEditor (Current work): Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4245214 (10Kghbln) 05Open>03Resolved a:03J... [08:40:52] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10VisualEditor (Current work): Illegal string offset 'revid' in VisualEditor/includes/ApiVisualEditor.php - https://phabricator.wikimedia.org/T193718#4245217 (10Kghbln) [09:21:30] 10VisualEditor: VisualEditor TeX options dialog has black icons on blue background - https://phabricator.wikimedia.org/T196050#4245351 (10Cirdan) [09:34:59] 10VisualEditor: Image Type dropdown does not change icon color when selected - https://phabricator.wikimedia.org/T196052#4245384 (10Cirdan) [09:38:14] 10VisualEditor, 10OOUI: Image Type dropdown does not change icon color when selected - https://phabricator.wikimedia.org/T196052#4245404 (10Deskana) [09:38:39] 10VisualEditor, 10OOUI: VisualEditor TeX options dialog has black icons on blue background - https://phabricator.wikimedia.org/T196050#4245405 (10Deskana) [09:50:18] 10WikiEditor, 10OOUI, 10I18n, 10Patch-For-Review, and 2 others: No localized Chechen letter for WikiEditor toolbar buttons is provided in Chechen Wikipedia - https://phabricator.wikimedia.org/T194211#4245456 (10Deskana) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [09:50:42] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10VisualEditor (Current work): Canceling section edit in NWE takes you to start of page - https://phabricator.wikimedia.org/T194631#4245460 (10Deskana) 05Open>03Resolved [09:51:03] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10VisualEditor (Current work): Exception thrown when closing editor while inspector still open - https://phabricator.wikimedia.org/T195775#4245461 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [09:52:17] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Patch-For-Review, 10VisualEditor (Current work): Template diff should consider empty string as unset - https://phabricator.wikimedia.org/T195764#4245465 (10Deskana) 05Open>03Resolved p:05Triage>03Normal a:... [10:06:04] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10Discovery, 10Maps, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4175631 (10Deskana) >>! In T193659#4244248, @jmatazzoni wrote: > So, I'm looking at the map and thinking this... [13:02:01] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10Discovery, 10Maps, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4245828 (10Deskana) 05Open>03Resolved Oops, forgot to close this as resolved with my last comment. [13:02:18] 10VisualEditor-EditingTools, 10Browser-Support-Firefox, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Regression, 10VisualEditor (Current work): Inspectors not quite tall enough in Firefox - https://phabricator.wikimedia.org/T195854#4245830 (10Deskana) 05Open>03Resolved [13:02:37] 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Regression, 10VisualEditor (Current work): Left-most position inside a link is not considered active (regression) - https://phabricator.wikimedia.org/T195843#4245833 (10Deskana)... [13:12:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Don't show the loading bar on the 2017 Wikitext editor for the first 750ms - https://phabricator.wikimedia.org/T193665#4245852 (10Deskana) >>! In T193665#4243287, @DLynch wrote: > @Deskana it's not merged yet, so I think what yo... [13:48:35] 10VisualEditor, 10Parsoid: Identify editing-client DOM transformations that Parsoid needs to account for during DOM diffs - https://phabricator.wikimedia.org/T196025#4244457 (10Esanders) It looks like these were still serving a purpose, as when we write to the clipboard we want to (1) add some text ("[1]") to... [13:49:32] 10VisualEditor: External link icon appearing twice - https://phabricator.wikimedia.org/T188656#4015230 (10Esanders) This is due to a change in the Parsoid DOM spec (v1.6) which adds 'external' classes. We need to update our CE code. [14:08:35] (03PS1) 10Esanders: Fix parsing of external links, now Parsoid adds 'external' classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436544 (https://phabricator.wikimedia.org/T196025) [14:38:31] (03PS1) 10Esanders: Add test coverage for preview mode (optionally) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436555 [14:44:15] (03CR) 10Subramanya Sastry: Fix parsing of external links, now Parsoid adds 'external' classes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436544 (https://phabricator.wikimedia.org/T196025) (owner: 10Esanders) [14:54:46] (03PS2) 10Esanders: Add test coverage for preview mode (optionally) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436555 [15:13:12] (03PS1) 10Esanders: Add preview mode converter tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436562 [15:15:33] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10User-Ryasmeen: Make it possible to convert a bare URL reference that I just added - https://phabricator.wikimedia.org/T123776#4246168 (10Whatamidoing-WMF) This works as desired for me now. [15:25:01] (03CR) 10jerkins-bot: [V: 04-1] Add preview mode converter tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436562 (owner: 10Esanders) [15:45:04] (03PS3) 10VolkerE: Make VE mobile tools use full height [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435827 (https://phabricator.wikimedia.org/T190596) [15:45:18] (03CR) 10jerkins-bot: [V: 04-1] Make VE mobile tools use full height [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/435827 (https://phabricator.wikimedia.org/T190596) (owner: 10VolkerE) [16:16:26] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10Discovery, 10Maps, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4246310 (10jmatazzoni) Oh, great. Thanks for adding the language in to VE! [16:35:56] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10Discovery, 10Maps, and 3 others: Make it possible to set a preferred language in a map in VE - https://phabricator.wikimedia.org/T193659#4246401 (10Deskana) >>! In T193659#4246310, @jmatazzoni wrote: > Oh, great. Thanks for adding the language in... [16:43:17] (03CR) 10Esanders: [C: 04-1] ve.ce.FocusableNode: Remove "ve-ce-focusableNode-highlight-relocatable-marker" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434173 (owner: 10Bartosz Dziewoński) [16:44:43] (03CR) 10Esanders: [C: 04-1] ve.ce.FocusableNode: Remove "ve-ce-focusableNode-highlight-relocatable-marker" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/434173 (owner: 10Bartosz Dziewoński) [16:49:36] (03CR) 10Jforrester: [C: 031] Add test coverage for preview mode (optionally) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436555 (owner: 10Esanders) [16:51:53] (03CR) 10DLynch: [C: 032] Add test coverage for preview mode (optionally) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436555 (owner: 10Esanders) [16:56:14] (03Merged) 10jenkins-bot: Add test coverage for preview mode (optionally) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436555 (owner: 10Esanders) [17:00:49] (03CR) 10jenkins-bot: Add test coverage for preview mode (optionally) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436555 (owner: 10Esanders) [17:07:20] (03CR) 10Petar.petkovic: ApiResponseCache: Support redirects data processing (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 (owner: 10Santhosh) [17:10:45] (03PS1) 10Jforrester: Update VE core submodule to master (6847cfba6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436594 [18:27:13] (03PS9) 10Krinkle: mw.trackSubscriber: Remove action.init.timing value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) [18:44:47] (03PS1) 10Esanders: Fix documentation in dm.Selection/Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436610 [18:44:51] (03PS1) 10Esanders: Refactor document drag/drop to use copy/paste methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436611 [18:46:33] (03CR) 10Krinkle: "@Neil: Could use your input here with regards to how data from EventLogging/ "Edit" schema is used. In particular, is the "action.init.tim" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) (owner: 10Krinkle) [18:49:35] 10Citoid, 10VisualEditor: Most newspapers.com variables don't/no longer map - https://phabricator.wikimedia.org/T196097#4246901 (10Skybunny) [18:54:38] (03CR) 10jerkins-bot: [V: 04-1] Refactor document drag/drop to use copy/paste methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436611 (owner: 10Esanders) [19:08:02] (03CR) 10jerkins-bot: [V: 04-1] Fix documentation in dm.Selection/Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436610 (owner: 10Esanders) [19:10:02] (03CR) 10Jforrester: [C: 032] "It's not used in the dashboard (which is broken anyway)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) (owner: 10Krinkle) [19:16:08] (03Merged) 10jenkins-bot: mw.trackSubscriber: Remove action.init.timing value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) (owner: 10Krinkle) [19:19:15] (03CR) 10jenkins-bot: mw.trackSubscriber: Remove action.init.timing value [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/428397 (https://phabricator.wikimedia.org/T160315) (owner: 10Krinkle) [19:59:09] 10Citoid, 10VisualEditor: Citoid is broken in euwiki - https://phabricator.wikimedia.org/T196103#4247073 (10Theklan) [20:33:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436669 (owner: 10L10n-bot) [21:05:43] 10VisualEditor: Error loading data from server http- Arabic Wikipeida - https://phabricator.wikimedia.org/T196111#4247285 (10alanajjar) [21:07:22] 10VisualEditor: Error loading data from server http- Arabic Wikipeida - https://phabricator.wikimedia.org/T196111#4247295 (10alanajjar) [21:08:30] 10VisualEditor: Error message: Error loading data from server http- Arabic Wikipeida - https://phabricator.wikimedia.org/T196111#4247285 (10alanajjar) [21:08:49] 10VisualEditor: Error message: Error loading data from server http - https://phabricator.wikimedia.org/T196111#4247285 (10alanajjar) [21:26:25] (03PS2) 10Esanders: Refactor document drag/drop to use copy/paste methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436611 [21:30:09] (03CR) 10jerkins-bot: [V: 04-1] Refactor document drag/drop to use copy/paste methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436611 (owner: 10Esanders) [21:42:14] (03PS2) 10Esanders: Fix documentation in dm.Surface, remove duplicate dm.Selection.equals [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436610 [21:42:16] (03PS3) 10Esanders: Refactor document drag/drop to use copy/paste methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436611 [22:04:06] 10VisualEditor: [Regression pre-wmf.7] Drop down for template search results appears to go over the dialog when the template description is too long and not wrapping - https://phabricator.wikimedia.org/T196117#4247423 (10Ryasmeen) [22:20:15] 10VisualEditor: The bullets/numbers of a list that follows a left aligned image overlaps with it - https://phabricator.wikimedia.org/T196119#4247460 (10Ryasmeen) [22:26:43] (03CR) 10Jforrester: [C: 032] "How did the duplicate ve.dm.Selection.prototype.equals not get flagged by eslint? I thought we had a test for this…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436610 (owner: 10Esanders) [22:31:04] (03Merged) 10jenkins-bot: Fix documentation in dm.Surface, remove duplicate dm.Selection.equals [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436610 (owner: 10Esanders) [22:35:17] (03CR) 10jenkins-bot: Fix documentation in dm.Surface, remove duplicate dm.Selection.equals [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436610 (owner: 10Esanders) [23:02:43] (03CR) 10Jforrester: [C: 032] Bypass expensive hasRendering calculation for CommentNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436330 (owner: 10Esanders) [23:06:11] (03Merged) 10jenkins-bot: Bypass expensive hasRendering calculation for CommentNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436330 (owner: 10Esanders) [23:10:03] (03CR) 10jenkins-bot: Bypass expensive hasRendering calculation for CommentNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436330 (owner: 10Esanders) [23:13:51] 10VisualEditor-MediaWiki-Templates, 10OOUI (OOUI-0.27.1), 10Verified, 10VisualEditor (Current work): Consider removing icon-add element from Transclusion dialog's options - https://phabricator.wikimedia.org/T164027#4247535 (10Ryasmeen) [23:30:42] 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Regression, and 4 others: Left-most position inside a link is not considered active (regression) - https://phabricator.wikimedia.org/T195843#4247558 (10Ryasmeen)