[06:06:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/437167 (owner: 10L10n-bot) [08:21:45] (03PS1) 10Santhosh: ApiResponseCache: Add a check for data.query before accessing redirects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437192 [08:22:08] (03CR) 10Santhosh: "> Patch Set 2:" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/434669 (owner: 10Santhosh) [10:20:44] 10VisualEditor, 10VisualEditor-VisualDiffs: Changing an image should always be shown as deletion + insertion in visual diff - https://phabricator.wikimedia.org/T196343#4253140 (10Schnark) [10:31:32] 10Citoid, 10TemplateData, 10VisualEditor: Allow for conditional field mapping in Citoid - https://phabricator.wikimedia.org/T190841#4253195 (10Mvolz) [10:38:00] 10Citoid, 10TemplateData, 10VisualEditor: Allow for conditional field mapping in Citoid - https://phabricator.wikimedia.org/T190841#4085132 (10Mvolz) If we have OCLC, we always have the ISBN, so I think probably the simplest thing to do for your case is simply to remove the OCLC mapping from the citoid map.... [10:38:12] 10Citoid, 10TemplateData, 10VisualEditor: Allow for conditional field mapping in Citoid - https://phabricator.wikimedia.org/T190841#4253221 (10Mvolz) 05Open>03declined p:05Triage>03Normal [10:53:06] 10Citoid, 10VisualEditor, 10WikiCite, 10Wikidata, 10Epic: Add citoid support for WikiBase to the Citoid extension - https://phabricator.wikimedia.org/T196353#4253305 (10Mvolz) [10:58:30] 10Citoid, 10VisualEditor, 10WikiCite, 10Wikidata, and 4 others: [Story] Support for citoid in Wikidata - https://phabricator.wikimedia.org/T131661#4253324 (10Mvolz) [10:58:33] 10Citoid, 10VisualEditor, 10WikiCite, 10Wikidata, 10Epic: Add citoid support for WikiBase to the Citoid extension - https://phabricator.wikimedia.org/T196353#4253323 (10Mvolz) [11:43:07] 10Citoid, 10VisualEditor, 10Epic, 10Services (watching), 10Technical-Debt: Restructure so that citoid can be run without Zotero - https://phabricator.wikimedia.org/T93579#4253392 (10Mvolz) a:03Mvolz [13:21:02] 10VisualEditor, 10Discovery, 10Graphs, 10Patch-For-Review: Number of columns for X and Y values for a graph keep increasing every time I open the dialog for empty node - https://phabricator.wikimedia.org/T151262#2812556 (10hashar) I tried to add the QUnit tests in CI, the `ve.ui.TableWidget` tests... [13:33:26] 10VisualEditor, 10Discovery, 10Graphs, 10Patch-For-Review: Number of columns for X and Y values for a graph keep increasing every time I open the dialog for empty node - https://phabricator.wikimedia.org/T151262#4253776 (10hashar) CI now runs the QUnit tests, though the job is non voting. An exampl... [13:44:37] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile, 10Regression: Links containing "action=xxx" always show the editor on mobile version - https://phabricator.wikimedia.org/T196150#4253801 (10Jdlrobson) This seems like a regression. This used to work fine. Not sure if editing code outside... [14:15:03] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile, 10Regression: Links containing "action=xxx" always show the editor on mobile version - https://phabricator.wikimedia.org/T196150#4253885 (10Daimona) Yeah, VE is quite likely involved in this bug. I also tried to test this bug on my local... [14:16:32] (03PS1) 10Esanders: Remove unused & untested HashValueStore.filter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/437252 [14:48:24] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile, 10Regression: Links containing "action=xxx" always show the editor on mobile version - https://phabricator.wikimedia.org/T196150#4253968 (10Jdlrobson) @DLynch I'm not sure 100% sure, but T185729 ([[ https://gerrit.wikimedia.org/r/#/c/4340... [14:48:38] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile, 10Regression: Regression: Links containing "action" always show the editor on mobile version regardless of value - https://phabricator.wikimedia.org/T196150#4253972 (10Jdlrobson) [14:48:45] 10VisualEditor, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: `FATAL: java.io.IOException: java.nio.file.NoSuchFileException: ...build/screenshots.yml` for language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T193883#4182477 (10zeljkofilipin) a:03zeljkofil... [14:50:32] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Staged citation insert creates unremovable pile of inline slugs - https://phabricator.wikimedia.org/T196244#4253977 (10Krinkle) There is another way to reproduce this issue, which might help narrow down the cause. For the i... [14:54:00] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile, 10Regression: Regression: Links containing "action" always show the editor on mobile version regardless of value - https://phabricator.wikimedia.org/T196150#4253983 (10ovasileva) p:05Triage>03Normal [14:55:00] 10VisualEditor, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-Ryasmeen, 10User-zeljkofilipin: `FATAL: java.io.IOException: java.nio.file.NoSuchFileException: ...build/screenshots.yml` for language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T193883#4253988 (10zeljkofilip... [15:01:01] 10VisualEditor: language-screenshots-VisualEditor fails with `stderr: warning: failed to remove cache` - https://phabricator.wikimedia.org/T196374#4254001 (10zeljkofilipin) [15:03:05] 10VisualEditor, 10Easy: No right margin is needed for the last child in the save dialog's checkboxes block - https://phabricator.wikimedia.org/T196375#4254015 (10Jack_who_built_the_house) [15:04:36] 10VisualEditor, 10Easy: No right margin is needed for the last child of the save dialog's checkboxes block - https://phabricator.wikimedia.org/T196375#4254025 (10Jack_who_built_the_house) [15:18:08] 10VisualEditor, 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile, 10Regression: Regression: Links containing "action" always show the editor on mobile version regardless of value - https://phabricator.wikimedia.org/T196150#4254059 (10DLynch) a:03DLynch [15:18:26] 10VisualEditor, 10Easy: No right margin is needed for the last child of the save dialog's checkboxes block - https://phabricator.wikimedia.org/T196375#4254015 (10matmarex) Sounds reasonable. Do you want to submit a patch? You can find this code in the mediawiki/extensions/VisualEditor Git repository, in modul... [15:26:00] (03CR) 10Jforrester: [C: 032] Remove unused & untested HashValueStore.filter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/437252 (owner: 10Esanders) [15:31:34] (03Merged) 10jenkins-bot: Remove unused & untested HashValueStore.filter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/437252 (owner: 10Esanders) [15:37:23] (03CR) 10jenkins-bot: Remove unused & untested HashValueStore.filter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/437252 (owner: 10Esanders) [15:40:20] (03CR) 10DLynch: [C: 032] Upstream comment node's invisble icon with label into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [15:43:49] (03Merged) 10jenkins-bot: Upstream comment node's invisble icon with label into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [15:46:37] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Patch-For-Review, 10VisualEditor (Current work): Prompt user before automatically converting pasted HTML to wikitext - https://phabricator.wikimedia.org/T190079#4254160 (10DLynch) @Bencemac: On th... [15:47:50] (03CR) 10jenkins-bot: Upstream comment node's invisble icon with label into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436058 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [15:48:43] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff shows unchanged text containing a reference as removed/inserted (absent from source diff) - https://phabricator.wikimedia.org/T196380#4254170 (10Krinkle) [15:54:51] (03CR) 10Bartosz Dziewoński: [C: 032] ApiResponseCache: Add a check for data.query before accessing redirects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437192 (owner: 10Santhosh) [16:02:42] 10WikiEditor, 10OOUI: Provide localized Bold and Italic icons for Urdu - https://phabricator.wikimedia.org/T196208#4254238 (10Volker_E) p:05Triage>03Normal [16:04:20] (03Merged) 10jenkins-bot: ApiResponseCache: Add a check for data.query before accessing redirects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437192 (owner: 10Santhosh) [16:07:30] (03CR) 10jenkins-bot: ApiResponseCache: Add a check for data.query before accessing redirects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437192 (owner: 10Santhosh) [16:12:08] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Patch-For-Review, 10VisualEditor (Current work): Prompt user before automatically converting pasted HTML to wikitext - https://phabricator.wikimedia.org/T190079#4254257 (10Bencemac) @DLynch What d... [16:17:24] (03PS1) 10DLynch: Paste conversion dialog shouldn't be escapable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437282 [16:24:46] (03CR) 10Bartosz Dziewoński: "(Escape could cancel/undo the paste?)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437282 (owner: 10DLynch) [16:24:55] (03CR) 10Jforrester: [C: 031] Paste conversion dialog shouldn't be escapable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437282 (owner: 10DLynch) [16:32:21] 10VisualEditor: language-screenshots-VisualEditor fails with `stderr: warning: failed to remove cache` - https://phabricator.wikimedia.org/T196374#4254430 (10zeljkofilipin) p:05Triage>03Low [16:32:37] 10VisualEditor, 10User-zeljkofilipin: language-screenshots-VisualEditor fails with `stderr: warning: failed to remove cache` - https://phabricator.wikimedia.org/T196374#4254001 (10zeljkofilipin) [16:33:21] 10VisualEditor, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: language-screenshots-VisualEditor fails with `stderr: warning: failed to remove cache` - https://phabricator.wikimedia.org/T196374#4254436 (10zeljkofilipin) a:03zeljkofilipin [16:34:20] (03CR) 10Esanders: [C: 032] Paste conversion dialog shouldn't be escapable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437282 (owner: 10DLynch) [16:37:47] (03CR) 10DLynch: "> Patch Set 1:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437282 (owner: 10DLynch) [16:44:40] (03Merged) 10jenkins-bot: Paste conversion dialog shouldn't be escapable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437282 (owner: 10DLynch) [16:46:26] (03PS1) 10Jforrester: Update VE core submodule to master (aca98533e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437288 (https://phabricator.wikimedia.org/T195887) [16:47:22] (03CR) 10jenkins-bot: Paste conversion dialog shouldn't be escapable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437282 (owner: 10DLynch) [16:48:56] (03CR) 10DLynch: [C: 032] Factor out synchronous part of updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436329 (owner: 10Esanders) [16:48:58] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (aca98533e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437288 (https://phabricator.wikimedia.org/T195887) (owner: 10Jforrester) [16:52:50] (03Merged) 10jenkins-bot: Factor out synchronous part of updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436329 (owner: 10Esanders) [16:55:29] 10VisualEditor, 10Easy: No right margin is needed for the last child of the save dialog's checkboxes block - https://phabricator.wikimedia.org/T196375#4254015 (10Esanders) That space is reserved for the "remaining characters" counter. We recently changed it to only show when there are <100(?) chars remaining,... [16:56:41] (03CR) 10jenkins-bot: Factor out synchronous part of updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/436329 (owner: 10Esanders) [17:01:19] (03Merged) 10jenkins-bot: Update VE core submodule to master (aca98533e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437288 (https://phabricator.wikimedia.org/T195887) (owner: 10Jforrester) [17:05:13] (03CR) 10jenkins-bot: Update VE core submodule to master (aca98533e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437288 (https://phabricator.wikimedia.org/T195887) (owner: 10Jforrester) [17:09:03] 10VisualEditor, 10Easy: No right margin is needed for the last child of the save dialog's checkboxes block - https://phabricator.wikimedia.org/T196375#4254509 (10matmarex) This margin is unnecessary though, and I think that's what we're proposing to remove: {F18747839} [17:15:45] (03PS1) 10Esanders: VisualDiff: Don't compare images with different src's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437292 (https://phabricator.wikimedia.org/T196343) [17:34:24] (03PS5) 10Jforrester: Update language variant node to use new invisible icon API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436062 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [17:35:55] (03CR) 10Jforrester: [C: 04-1] VisualDiff: Don't compare images with different src's (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437292 (https://phabricator.wikimedia.org/T196343) (owner: 10Esanders) [17:36:29] 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): LanguageVariantNode's not rendering correctly - https://phabricator.wikimedia.org/T195887#4254627 (10Jdforrester-WMF) [17:42:00] 10VisualEditor: The bullets/numbers of a list that follows a left aligned image overlaps with it - https://phabricator.wikimedia.org/T196119#4254639 (10matmarex) [17:42:04] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Increase indentation is not working when the list is wrapped around a left aligned image - https://phabricator.wikimedia.org/T70540#4254640 (10matmarex) [17:49:48] (03PS2) 10Esanders: VisualDiff: Don't compare images with different src's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437292 (https://phabricator.wikimedia.org/T196343) [17:50:07] (03CR) 10Esanders: VisualDiff: Don't compare images with different src's (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437292 (https://phabricator.wikimedia.org/T196343) (owner: 10Esanders) [17:50:59] (03CR) 10Esanders: [C: 04-1] "This exposes a bug in diffing root nodes, so we may want to hold off until I've fixed that, as the presentation of the diff regresses." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437292 (https://phabricator.wikimedia.org/T196343) (owner: 10Esanders) [17:54:20] (03CR) 10Esanders: [C: 04-1] "It seems the diffing is fixed by tchanders' follow up I033bcbb9e8fcf9f7794a22647436e146616d4d0a, so we can just wait for that." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437292 (https://phabricator.wikimedia.org/T196343) (owner: 10Esanders) [18:11:07] 10VisualEditor, 10Easy: No right margin is needed for the last child of the save dialog's checkboxes block - https://phabricator.wikimedia.org/T196375#4254699 (10Esanders) Ok, I was going off the margin shown in the first screenshot in the description. [18:16:05] (03PS6) 10Jforrester: WIP Separate out list diffs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428259 (https://phabricator.wikimedia.org/T184977) (owner: 10Tchanders) [18:19:27] (03CR) 10Jforrester: [C: 032] Update language variant node to use new invisible icon API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436062 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [18:19:58] 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10VisualEditor (Current work): LanguageVariantNode's not rendering correctly - https://phabricator.wikimedia.org/T195887#4254729 (10Jdforrester-WMF) [18:42:47] (03Merged) 10jenkins-bot: Update language variant node to use new invisible icon API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436062 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [18:45:44] (03CR) 10jenkins-bot: Update language variant node to use new invisible icon API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436062 (https://phabricator.wikimedia.org/T195887) (owner: 10Esanders) [18:53:25] (03PS3) 10Jforrester: Add preview mode converter tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436562 (owner: 10Esanders) [18:59:33] (03CR) 10jerkins-bot: [V: 04-1] Add preview mode converter tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436562 (owner: 10Esanders) [19:00:20] (03CR) 10Jforrester: [C: 032] "Oh, oops, I didn't see the real dependency." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436562 (owner: 10Esanders) [19:00:35] (03PS4) 10Jforrester: Add preview mode converter tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/436562 (owner: 10Esanders) [20:49:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/437348 (owner: 10L10n-bot) [21:24:38] 10VisualEditor, 10Patch-For-Review: [Regression pre-wmf.7] Drop down for template search results appears to go over the dialog when the template description is too long and not wrapping - https://phabricator.wikimedia.org/T196117#4247423 (10matmarex) This seems to be intentional and a result of {T195257}. [22:26:35] 10VisualEditor, 10OOUI, 10Patch-For-Review: Image Type dropdown does not change icon color when selected - https://phabricator.wikimedia.org/T196052#4255517 (10matmarex) >>! In T196052#4248809, @Volker_E wrote: > @matmarex @Jdforrester-WMF As far as I remember that's an issue with VE code and not OOUI…? VE'...