[06:23:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441763 (owner: 10L10n-bot) [08:43:41] 10VisualEditor: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link - https://phabricator.wikimedia.org/T198064#4310559 (10Trizek-WMF) [09:59:43] 10VisualEditor, 10Easy: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link - https://phabricator.wikimedia.org/T198064#4310827 (10Esanders) [10:10:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Categories: Show category content when switching from source code to visual editing - https://phabricator.wikimedia.org/T197951#4310860 (10Esanders) [10:42:06] 10VisualEditor, 10ContentTranslation, 10Language-2018-Apr-June: CX2: Uncaught TypeError: Cannot read property 'element' of null - https://phabricator.wikimedia.org/T197845#4310993 (10Pginer-WMF) p:05Triage>03Normal [10:51:49] 10VisualEditor, 10ContentTranslation, 10ContentTranslation-FY2017-18, 10Contributors-Team, and 3 others: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#4311038 (10Arrbee) [10:51:50] 10VisualEditor, 10ContentTranslation, 10Epic, 10User-Ryasmeen: ContentTranslation: integrate VisualEditor - https://phabricator.wikimedia.org/T168221#4311037 (10Arrbee) 05Open>03Resolved [10:54:19] (03PS3) 10Divec: Use getter to retrieve change stores [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441600 [10:54:26] 10VisualEditor, 10ContentTranslation, 10Epic, 10User-Ryasmeen: ContentTranslation: integrate VisualEditor - https://phabricator.wikimedia.org/T168221#3358901 (10Pginer-WMF) [[ https://www.mediawiki.org/wiki/Content_translation/V2 | Content Translation version 2 ]] already integrates Visual Editor editing s... [10:57:40] (03PS1) 10Divec: Use ve.dm.Change object for completeHistory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441823 [11:08:53] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Links, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): Inspector position breaks when cursoring between two adjacent links with no space between - https://phabricator.wikimedia.org/T197894#4311137 (10Des... [11:24:10] 10VisualEditor, 10ContentTranslation, 10Contributors-Team, 10Design, and 2 others: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#4311190 (10Arrbee) [12:18:10] 10VisualEditor, 10Collaboration-Team-Triage, 10In-Context-Help-and-Onboarding, 10New-Editor-Experiences: Show a hint on how to add or remove pages from a category when editing a category page in VE - https://phabricator.wikimedia.org/T197953#4307871 (10Trizek-WMF) You mean add pages in that category? Is so... [13:13:58] 10VisualEditor, 10Collaboration-Team-Triage, 10In-Context-Help-and-Onboarding, 10New-Editor-Experiences: Show a hint on how to add or remove pages from a category when editing a category page in VE - https://phabricator.wikimedia.org/T197953#4311681 (10Cirdan) >>! In T197953#4311486, @Trizek-WMF wrote: > Y... [13:59:16] 10VisualEditor, 10Collaboration-Team-Triage, 10In-Context-Help-and-Onboarding, 10New-Editor-Experiences, 10Design: Show a hint on how to add or remove pages from a category when editing a category page in VE - https://phabricator.wikimedia.org/T197953#4311924 (10Deskana) p:05Triage>03Low [14:02:23] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10TemplateStyles: Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563#4311940 (10Deskana) p:05Triage>03High [14:04:40] 10VisualEditor-ContentLanguage, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Technical-Debt, 10VisualEditor (Current work): VisualEditor standalone allows raw HTML in some messages - https://phabricator.wikimedia.org/T197723#4311976 (10Deskana) 05Open>03Resolved [14:06:38] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): Descriptive text can't be distinguished from content text in visual diffs - https://phabricator.wikimedia.org/T195243#4311979 (10Deskana) [14:06:48] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): Descriptive text can't be distinguished from content text in visual diffs - https://phabricator.wikimedia.org/T195243#4220496 (10Deskana) 05Open>03Resolved [14:10:05] 10VisualEditor-DataModel, 10ContentTranslation, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): Cannot read property 'constructor' of null - https://phabricator.wikimedia.org/T197139#4311987 (10Deskana) 05Open>03Resolved [14:14:54] 10VisualEditor-MediaWiki-Templates, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): VisualEditor occasionally opens a link within a template instead of the template's settings when clicked - https://phabricator.wikimedia.org/T197659#4312027 (10Deskana) 05Open... [14:35:01] 10TemplateData, 10VisualEditor, 10User-MarcoAurelio: format = inline displays as "custom" while not true - https://phabricator.wikimedia.org/T160252#3093203 (10stjn) Related issue to this: this message uses some icon that does not exist in OOUI and therefore is invisible in interface and pushes the text off-... [14:36:44] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): Can't reload a page by clicking article tab after editing in VE - https://phabricator.wikimedia.org/T197445#4312125 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [14:44:54] 10Citoid, 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, and 4 others: Citoid restbase endpoint not configured correctly in vagrant - https://phabricator.wikimedia.org/T153214#2873043 (10Mvolz) [14:47:26] 10Citoid, 10VisualEditor, 10MediaWiki-Vagrant, 10RESTBase, and 4 others: Citoid restbase endpoint not configured correctly in vagrant - https://phabricator.wikimedia.org/T153214#4312167 (10Mvolz) >>! In T153214#4015515, @mobrovac wrote: > @Mvolz is this still an issue? Just updated everything, and yup :) [14:48:15] 10VisualEditor-MediaWiki, 10ProofreadPage, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): Three slugs in every header/footer on Wikisource VisualEditor, two of them don't work (cause an exception) - https://phabricator.wikimedia.org/T196921#4312169 (10Deskana... [14:49:25] 10Cite, 10ContentTranslation, 10Tracking: ContentTranslation issues with references (tracking) - https://phabricator.wikimedia.org/T115045#4312175 (10Arrbee) [14:54:59] 10Cite, 10ContentTranslation, 10Tracking: ContentTranslation issues with references (tracking) - https://phabricator.wikimedia.org/T115045#4312214 (10Pginer-WMF) [15:01:14] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Regression, 10User-Ryasmeen, and 2 others: [Regression pre-wmf.4] Sort buttons on table header cells are overlapping with the text in it - https://phabricator.wikimedia.org/T195108#4312260 (10Deskana) 05Open>03R... [15:19:02] (03CR) 10Bartosz Dziewoński: [C: 032] Give up on realistic styling of mw-collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441596 (https://phabricator.wikimedia.org/T197987) (owner: 10Esanders) [15:26:52] edsanders: wanted to check in to get your thoughts on https://phabricator.wikimedia.org/T78550#4303996 when you have a moment [15:38:00] (03Merged) 10jenkins-bot: Give up on realistic styling of mw-collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441596 (https://phabricator.wikimedia.org/T197987) (owner: 10Esanders) [15:41:49] (03CR) 10jenkins-bot: Give up on realistic styling of mw-collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441596 (https://phabricator.wikimedia.org/T197987) (owner: 10Esanders) [15:42:37] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10Tech-Ambassadors, and 2 others: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype - https://phabricator.wikimedia.org/T124305#4312355 (10Deskana) Let's schedule it for the t... [15:56:48] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Regression, 10VisualEditor (Current work): Uncaught TypeError: Cannot read property 'ownerDocument' of undefined - https://phabricator.wikimedia.org/T197987#4312401 (10Jdforrester-WMF) [15:56:53] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Regression, 10VisualEditor (Current work): Uncaught TypeError: Cannot read property 'ownerDocument' of undefined - https://phabricator.wikimedia.org/T197987#4308831 (10Jdforrester-WMF) a:03Esanders [16:04:33] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Regression, 10VisualEditor (Current work): Uncaught TypeError: Cannot read property 'ownerDocument' of undefined - https://phabricator.wikimedia.org/T197987#4312433 (10Deskana) 05Open>03Resolved [16:22:36] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): jquery.textSelection methods work incorrectly with 2017 wikitext editor - https://phabricator.wikimedia.org/T198010#4312474 (10Jdforrester-WMF) a:03Esanders [16:33:53] (03CR) 10DLynch: [C: 032] If VE was opened on action=edit URL, redirect to view URL when closing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441505 (https://phabricator.wikimedia.org/T122388) (owner: 10Bartosz Dziewoński) [16:34:47] (03CR) 10DLynch: [C: 032] ve.ui.MWTemplateDialog: Prevent scrolling to top after removing a parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441424 (https://phabricator.wikimedia.org/T180151) (owner: 10Bartosz Dziewoński) [16:50:27] (03Merged) 10jenkins-bot: If VE was opened on action=edit URL, redirect to view URL when closing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441505 (https://phabricator.wikimedia.org/T122388) (owner: 10Bartosz Dziewoński) [16:51:01] 10VisualEditor, 10TimedMediaHandler: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4312629 (10Aklapper) [16:53:11] (03Merged) 10jenkins-bot: ve.ui.MWTemplateDialog: Prevent scrolling to top after removing a parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441424 (https://phabricator.wikimedia.org/T180151) (owner: 10Bartosz Dziewoński) [16:53:31] (03CR) 10jenkins-bot: If VE was opened on action=edit URL, redirect to view URL when closing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441505 (https://phabricator.wikimedia.org/T122388) (owner: 10Bartosz Dziewoński) [16:54:40] (03CR) 10Mooeypoo: [C: 032] Add isResizable method to dynamically disable resizing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/439947 (owner: 10Esanders) [16:56:35] (03CR) 10jenkins-bot: ve.ui.MWTemplateDialog: Prevent scrolling to top after removing a parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441424 (https://phabricator.wikimedia.org/T180151) (owner: 10Bartosz Dziewoński) [16:57:16] 10VisualEditor, 10TimedMediaHandler: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4312664 (10Mrjohncummings) [16:58:28] (03PS1) 10DLynch: mw.DesktopArticleTarget: remove action=edit when tearing down as single-tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441914 (https://phabricator.wikimedia.org/T197615) [16:59:15] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): 2017 wikitext editor does not update the address bar URL after edit save - https://phabricator.wikimedia.org/T197615#4312670 (10DLynch) a:03DLynch [16:59:24] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 wikitext editor interacts badly with the responsive design mode of Firefox - https://phabricator.wikimedia.org/T198015#4309355 (10matmarex) Works fine for me using Firefox 61.0b14 on Windows 10. [16:59:29] (03Merged) 10jenkins-bot: Add isResizable method to dynamically disable resizing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/439947 (owner: 10Esanders) [17:00:17] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): 2017 wikitext editor does not update the address bar URL after edit save - https://phabricator.wikimedia.org/T197615#4297418 (10DLynch) Didn't strictly need to save -- any teardown would cause it. It relied on the single-edit-tab be... [17:01:16] 10VisualEditor, 10TimedMediaHandler: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4312680 (10Mrjohncummings) [17:04:47] (03CR) 10jenkins-bot: Add isResizable method to dynamically disable resizing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/439947 (owner: 10Esanders) [17:17:56] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 wikitext editor interacts badly with the responsive design mode of Firefox - https://phabricator.wikimedia.org/T198015#4312741 (10Kaartic) >>! In T198015#4312672, @matmarex wrote: > Works fine for me using Firefox 61.0b14 on Windows 10. Interes... [17:20:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 wikitext editor interacts badly with the responsive design mode of Firefox - https://phabricator.wikimedia.org/T198015#4312746 (10Kaartic) OK. I think I tracked down the real culprit. It seems to be Syntax highlighting that is causing the issues... [17:22:36] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: 2017 wikitext editor interacts badly with the responsive design mode of Firefox - https://phabricator.wikimedia.org/T198015#4312752 (10Kaartic) [17:26:58] 10VisualEditor, 10Parsoid: Visual editor inserts extraneous blank lines. - https://phabricator.wikimedia.org/T197990#4312766 (10matmarex) Any change to the first paragraph of the page seems to cause this. There is a `` tag in it, which becomes an `alienMeta` in our model and is pulled out of the para... [17:33:59] (03CR) 10Jforrester: [C: 032] Use getter to retrieve change stores [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441600 (owner: 10Divec) [17:34:01] (03CR) 10Bartosz Dziewoński: [C: 032] mw.DesktopArticleTarget: remove action=edit when tearing down as single-tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441914 (https://phabricator.wikimedia.org/T197615) (owner: 10DLynch) [17:34:31] (03CR) 10Jforrester: [C: 032] Use ve.dm.Change object for completeHistory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441823 (owner: 10Divec) [18:05:54] (03CR) 10jenkins-bot: Show images/descriptions on import's title widget if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441641 (owner: 10Esanders) [18:39:53] (03CR) 10Esanders: "I'm convinced there is a neater solution to this empty transaction hack, but Mr. Fermat couldn't fit it in the margin. Oh well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441823 (owner: 10Divec) [18:39:58] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (c8d6dac8b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441926 (owner: 10Jforrester) [18:41:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Syntax highlighting for 2017 wikitext editor interacts badly with the responsive design mode of Firefox - https://phabricator.wikimedia.org/T198015#4313018 (10Kaartic) [19:07:08] (03Merged) 10jenkins-bot: Update VE core submodule to master (c8d6dac8b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441926 (owner: 10Jforrester) [19:10:39] (03CR) 10jenkins-bot: Update VE core submodule to master (c8d6dac8b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441926 (owner: 10Jforrester) [19:30:12] (03PS5) 10Esanders: ve.dm.Document: Handle no valid offsets in #getNearestCursorOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441091 (https://phabricator.wikimedia.org/T197651) (owner: 10Bartosz Dziewoński) [19:30:58] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441644 (owner: 10Esanders) [19:54:42] (03CR) 10Divec: [C: 032] ve.dm.Document: Handle no valid offsets in #getNearestCursorOffset (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441091 (https://phabricator.wikimedia.org/T197651) (owner: 10Bartosz Dziewoński) [19:59:35] (03Merged) 10jenkins-bot: ve.dm.Document: Handle no valid offsets in #getNearestCursorOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441091 (https://phabricator.wikimedia.org/T197651) (owner: 10Bartosz Dziewoński) [20:03:32] 10Cite: Resolve inconsistent numbering of references in text and in bibliography - https://phabricator.wikimedia.org/T198021#4313270 (10Huji) a:03Esanders Since Ed has provided feedback in both children tasks, respectfully, I am assigning him as the owner of this parent task. [20:06:11] (03CR) 10jenkins-bot: ve.dm.Document: Handle no valid offsets in #getNearestCursorOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441091 (https://phabricator.wikimedia.org/T197651) (owner: 10Bartosz Dziewoński) [20:27:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441968 (owner: 10L10n-bot) [20:46:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/441963 (owner: 10L10n-bot) [22:28:28] kostajh, ping me tomorrow and we can talk, thanks for looking into that [22:39:54] 10VisualEditor: 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE - https://phabricator.wikimedia.org/T198150#4313663 (10Esanders) [23:20:38] 10VisualEditor, 10Parsoid: Visual editor inserts extraneous blank lines. - https://phabricator.wikimedia.org/T197990#4308872 (10Arlolra) > The Parsoid presumably wraps the `` in a paragraph, then removes the now-useless empty ``, and that leaves it with an empty paragraph, which becomes two newl...