[00:19:48] 10VisualEditor, 10VisualEditor-EditingTools, 10Discovery, 10Maps, and 3 others: Add a Help link to maps tool in Visual Editor - https://phabricator.wikimedia.org/T196711#4266181 (10Etonkovidova) Checked in betalabs (disregard non-displayed map in the screenshot below) {F22656217} {F22656226} The link wil... [10:15:38] 10VisualEditor, 10RESTBase-API, 10Services (blocked): VisualEditor should explicitly set Accept-Language - https://phabricator.wikimedia.org/T198186#4314714 (10Pchelolo) p:05Triage>03High [11:21:56] 10VisualEditor, 10Wikimedia-Site-requests: Turn on the visual editor on every space name on fr.wikiversity - https://phabricator.wikimedia.org/T198193#4314929 (10Aklapper) a:05Aklapper>03None @Lionel_Scheepmans: Please do not assign tasks to someone without their consent. Setting #Wikimedia-Site-Requests... [11:24:23] 10VisualEditor, 10Wikimedia-Site-requests: Turn on the visual editor on every space name on fr.wikiversity - https://phabricator.wikimedia.org/T198193#4314941 (10Lionel_Scheepmans) >>! In T198193#4314929, @Aklapper wrote: > @Lionel_Scheepmans: Please do not assign tasks to someone without their consent. Ok, s... [12:03:39] (03PS1) 10Esanders: Pass video thumbtime to thumbnail metadata request [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442082 (https://phabricator.wikimedia.org/T198150) [13:02:30] 10VisualEditor, 10RESTBase-API, 10Services (blocked): VisualEditor should explicitly set Accept-Language - https://phabricator.wikimedia.org/T198186#4315318 (10Pchelolo) Just verified in Vagrant that explicitly specifying `Accept-Language` in VE works and visual editing works as well if we provide the page_l... [13:13:51] 10VisualEditor: Extension of the Visual Editor namespaces on the French Wikiversity - https://phabricator.wikimedia.org/T126561#4315362 (10Deskana) [13:13:55] 10VisualEditor, 10Wikimedia-Site-requests: Turn on the visual editor on every space name on fr.wikiversity - https://phabricator.wikimedia.org/T198193#4315364 (10Deskana) [13:18:18] 10VisualEditor, 10TimedMediaHandler: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4311829 (10Esanders) I think the issue is TMH currently only knows about PHP HTML, so doesn't work with Parsoid HTML. [13:30:13] 10Citoid, 10VisualEditor: "Add a citation" dialog on fr.wikiversity should offer "Automatic" - https://phabricator.wikimedia.org/T198191#4315455 (10Aklapper) [14:01:29] 10VisualEditor-DataModel, 10VisualEditor (Current work): ve.dm.InternalList#sortGroupIndexes throws javascript error - https://phabricator.wikimedia.org/T191011#4315578 (10Deskana) p:05Triage>03Normal [14:43:04] 10VisualEditor-MediaWiki-Templates, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): When you delete a parameter, the template dialogue box scrolls up to the top, and it should stay in the same place - https://phabricator.wikimedia.org/T180151#4315706 (10Deskana... [14:43:16] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): Probably wrong usage of "this" in ve.init.mw.DesktopArticleTarget.js - https://phabricator.wikimedia.org/T197762#4315707 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [14:49:35] edsanders: ping? we would have a semi-urgent request for you to look into T198186 [14:49:35] T198186: VisualEditor should explicitly set Accept-Language - https://phabricator.wikimedia.org/T198186 [14:49:48] hi [14:49:58] it should be a simple "fix", and we need it to be able to deploy restbase [14:50:03] hello :) that too [14:50:04] lol [14:50:12] * mobrovac is impolite for no reason [14:50:28] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10VisualEditor (Current work): 2017 wikitext editor does not update the address bar URL after edit save - https://phabricator.wikimedia.org/T197615#4315740 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [14:50:29] ha, so which request is it that needs to be modified? [14:50:45] both the original html fetch and the transform [14:50:58] basically all the requests that VE makes to either RB or Parsoid [14:51:48] if we keep things as-is, VE-editors in multi-variant wikis would not be happy [14:52:00] does the browser currently set accept-language? [14:52:08] in practice, this would be noticeable on a very tiny fraction of pages, but still [14:52:17] yes, that's the unfortunate thing [14:52:30] it sets it for all requests, including ajax ones [14:52:38] and you want to completely override it with the article content language? [14:52:44] and that's based on the browser's locale ofc [14:52:46] yes, for now [14:53:01] but only for reqs directed at rb and parsoid [14:53:11] we tested that overriding it works [14:53:38] like this: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Citoid/+/196581/3/modules/ve.ui.CiteFromIdInspector.js [14:54:32] hehe indeed, citoid already does that [14:54:41] yes, something like that, but using the page_language property [14:54:43] of the page [14:55:34] is that different from contentLanguage? [14:55:34] that's actually the same thing afaik [14:55:38] the contentlang [14:55:40] yes yes :) [14:55:41] ok [14:55:45] sorry [14:56:29] some of the requests are passed through ApiVisualEditor.php [14:57:11] will the headers get passed through on a DerivativeRequest? [14:59:33] not sure i know a definitive answer to that [14:59:37] but that's a good questin [14:59:47] my assumption would be yes, but we'd need to check [15:09:06] what about multi-language wikis? should we use contentLang or the article's specific language? [15:15:01] yup [15:15:11] which one? [15:15:22] even though the caveat here is that a bit more work on both rb and parsoid side is needed for this to work [15:15:28] ah right, sorry hehe [15:15:31] the article's lang [15:18:46] 10Cite, 10Parsoid: Support dir for refs for in Parsoid - https://phabricator.wikimedia.org/T198221#4315791 (10Arlolra) [15:32:54] 10VisualEditor, 10VisualEditor-EditingTools, 10Discovery, 10Maps, and 4 others: Add a Help link to maps tool in Visual Editor - https://phabricator.wikimedia.org/T196711#4315855 (10jmatazzoni) 05Open>03Resolved Resolving this, but @Volker_E I continue to have a bad reaction to the ? with no circle arou... [15:33:02] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid: References can get lost while editing under some circumstances - https://phabricator.wikimedia.org/T197760#4315858 (10ssastry) We realized this is not a Parsoid bug right now. It looks like this is happening because (a) tags have a pointer... [15:35:32] edsanders: i've just checked derivativerequest, if you set the headers in ApiVisualEditor, they'll be sent through [15:37:55] 10VisualEditor, 10VisualEditor-EditingTools, 10Discovery, 10Maps, and 4 others: Add a Help link to maps tool in Visual Editor - https://phabricator.wikimedia.org/T196711#4315873 (10Volker_E) @jmatazzoni Sorry, didn't mean to take that long to make it into OOUI. As soon as the circled icon is available, I'l... [15:38:24] 10VisualEditor: Visual editor inserts extraneous blank lines. - https://phabricator.wikimedia.org/T197990#4315876 (10ssastry) [15:42:06] thanks [15:48:40] 10VisualEditor: Incorrect page title after editing if editor is switched while editing - https://phabricator.wikimedia.org/T198225#4315910 (10Kaartic) [15:49:00] 10VisualEditor: Incorrect page title after editing; if editor is switched while editing - https://phabricator.wikimedia.org/T198225#4315920 (10Kaartic) [15:55:42] 10Citoid, 10VisualEditor: Enable citoid on fr.wikiversity - https://phabricator.wikimedia.org/T198191#4315953 (10Mvolz) [15:56:21] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Help some smaller Wikipedias' communities by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354#4315956 (10Mvolz) [15:56:23] 10Citoid, 10VisualEditor: Enable citoid on fr.wikiversity - https://phabricator.wikimedia.org/T198191#4314861 (10Mvolz) [16:22:35] 10VisualEditor, 10Graphs: [Graph] extension fails QUnit tests due to timeout - https://phabricator.wikimedia.org/T198229#4316131 (10hashar) [16:24:15] 10VisualEditor: VisualEditor: characters typed at the end of link should become part of it if they match the linktrail regexp - https://phabricator.wikimedia.org/T128060#4316159 (10Tgr) [16:24:48] 10VisualEditor: VisualEditor: characters typed at the end of link should become part of it if they match the linktrail regexp - https://phabricator.wikimedia.org/T128060#2062815 (10Tgr) I've reverted the title and description of this task as it wasn't even remotely related to the issue it was originally about. I... [16:25:32] 10VisualEditor, 10Graphs: [Graph] extension fails QUnit tests due to timeout - https://phabricator.wikimedia.org/T198229#4316131 (10hashar) [16:27:37] 10VisualEditor, 10Graphs: [Graph] extension fails QUnit tests due to timeout - https://phabricator.wikimedia.org/T198229#4316193 (10hashar) [16:30:38] 10VisualEditor: Incorrect page title after editing; if editor is switched while editing - https://phabricator.wikimedia.org/T198225#4316212 (10DLynch) Duplicate of T197490, which @matmarex recently fixed, I think? [16:44:31] 10VisualEditor, 10Graphs: [Graph] extension fails QUnit tests due to timeout - https://phabricator.wikimedia.org/T198229#4316281 (10hashar) I looked at `ve.ui.TableWidget` failure previously T151262#4253730 The test should be skipped/marked pending. The timeout one, I havent investigated. [16:48:13] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Parsoid-Serializer, 10User-Ryasmeen, and 2 others: Parsoid: Linking on a part of a word triggers linktrail - https://phabricator.wikimedia.org/T35091#4316309 (10Tgr) [16:48:15] 10VisualEditor: VisualEditor makes it easy to create partially linked words, when the user expects a fully linked one - https://phabricator.wikimedia.org/T128060#4316299 (10Tgr) [16:49:19] 10VisualEditor, 10Easy: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link - https://phabricator.wikimedia.org/T198064#4310559 (10DLynch) Note that this is totally my fault from back in 2015 with 7ecde6c05. Arguably, it shouldn't be "clear styling" for any situation where th... [16:50:22] That chain of "...that's familiar, it might be my fault from years ago; it is me; but I should leave it as an easy getting into the code fix..." ;_; [16:54:43] 10VisualEditor: Incorrect page title after editing; if editor is switched while editing - https://phabricator.wikimedia.org/T198225#4316350 (10Kaartic) >>! In T198225#4316212, @DLynch wrote: > Duplicate of T197490, which @matmarex recently fixed, I think? Yep. Seems to be a dupe. [16:55:49] 10VisualEditor: Incorrect page title after editing; if editor is switched while editing - https://phabricator.wikimedia.org/T198225#4316356 (10Kaartic) When is that supposed to be deployed? [16:57:13] 10VisualEditor: Incorrect page title after editing; if editor is switched while editing - https://phabricator.wikimedia.org/T198225#4316373 (10DLynch) Should be today, I think, unless something blocks the train. It'd be up on beta already, e.g. https://simple.wikipedia.beta.wmflabs.org/ [16:57:41] 10VisualEditor: Incorrect page title after editing; if editor is switched while editing - https://phabricator.wikimedia.org/T198225#4316376 (10DLynch) [16:57:45] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Page title stuck as "Editing ..." if a page is published after switching between VE/NWE - https://phabricator.wikimedia.org/T197490#4316379 (10DLynch) [17:03:27] (03PS1) 10Esanders: Correct documentation of $title Title object and add type hints [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442147 [17:03:29] (03PS1) 10Esanders: Pass content language in Accept-Language header to RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442148 (https://phabricator.wikimedia.org/T198186) [17:06:57] 10Cite, 10Contributors-Team, 10MediaWiki-Configuration, 10MediaWiki-ResourceLoader, and 5 others: Support listing modules in extension.json that are registered iff another extension is installed - https://phabricator.wikimedia.org/T128012#4316452 (10Krinkle) [17:11:25] (03CR) 10Jforrester: [C: 031] "Worth linking to https://www.mediawiki.org/wiki/Specs/HTML#Audio/Video somewhere?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442082 (https://phabricator.wikimedia.org/T198150) (owner: 10Esanders) [17:15:33] 10VisualEditor, 10RESTBase-API, 10Patch-For-Review, 10Services (blocked): VisualEditor should explicitly set Accept-Language - https://phabricator.wikimedia.org/T198186#4314714 (10cscott) Even after editing in variants works, we'll want to set `accept-language` to the user's mediawiki-preferred variant, no... [17:21:27] (03CR) 10Jforrester: [C: 04-1] Pass content language in Accept-Language header to RESTBase (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442148 (https://phabricator.wikimedia.org/T198186) (owner: 10Esanders) [17:22:38] (03CR) 10Jforrester: [C: 032] Correct documentation of $title Title object and add type hints [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442147 (owner: 10Esanders) [17:26:26] (03CR) 10C. Scott Ananian: Pass content language in Accept-Language header to RESTBase (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442148 (https://phabricator.wikimedia.org/T198186) (owner: 10Esanders) [17:33:12] (03CR) 10C. Scott Ananian: Pass content language in Accept-Language header to RESTBase (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442148 (https://phabricator.wikimedia.org/T198186) (owner: 10Esanders) [17:35:39] 10VisualEditor, 10RESTBase-API, 10Patch-For-Review, 10Services (blocked): VisualEditor should explicitly set Accept-Language - https://phabricator.wikimedia.org/T198186#4316556 (10cscott) In order to unblock the current stage of RESTBase work, VE could also just hardcode `Accept-Language: en` for every req... [17:42:29] (03Merged) 10jenkins-bot: Correct documentation of $title Title object and add type hints [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442147 (owner: 10Esanders) [17:44:41] 10VisualEditor, 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10Discovery, and 3 others: Make it possible to add a caption on a mapframe map - https://phabricator.wikimedia.org/T193658#4316579 (10JTannerWMF) 05Open>03Resolved [17:45:29] (03CR) 10jenkins-bot: Correct documentation of $title Title object and add type hints [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442147 (owner: 10Esanders) [17:45:45] (03CR) 10Jforrester: [C: 04-1] Pass content language in Accept-Language header to RESTBase (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442148 (https://phabricator.wikimedia.org/T198186) (owner: 10Esanders) [17:49:43] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#4316592 (10Tgr) [17:50:42] (03PS1) 10C. Scott Ananian: Override browser/PHP's default Accept-Language header sent to RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442159 (https://phabricator.wikimedia.org/T198186) [17:52:57] (03CR) 10C. Scott Ananian: "For consideration as an alternative to Ed's more correct patch, in order to unblock restbase quickly." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442159 (https://phabricator.wikimedia.org/T198186) (owner: 10C. Scott Ananian) [17:53:12] (03CR) 10jerkins-bot: [V: 04-1] Override browser/PHP's default Accept-Language header sent to RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442159 (https://phabricator.wikimedia.org/T198186) (owner: 10C. Scott Ananian) [17:56:55] 10VisualEditor, 10VisualEditor-Tables: Table layout breaks when table-formatting template {{no}} is present, and a new column is inserted after it - https://phabricator.wikimedia.org/T198236#4316613 (10Whatamidoing-WMF) [17:58:50] (03CR) 10Jforrester: [C: 032] Pass content language in Accept-Language header to RESTBase (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442148 (https://phabricator.wikimedia.org/T198186) (owner: 10Esanders) [18:01:23] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#4316650 (10Tgr) [18:04:07] (03PS2) 10C. Scott Ananian: Override browser/PHP's default Accept-Language header sent to RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442159 (https://phabricator.wikimedia.org/T198186) [18:06:10] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563#4316688 (10Deskana) [18:06:25] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563#4296000 (10Deskana) Needs investigation from Editing engineers. [18:12:16] 10VisualEditor, 10Easy: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link - https://phabricator.wikimedia.org/T198064#4310559 (10Deskana) What shall we set the message to? Google uses "remove formatting", which is better than "clear styling", though it's still not ideal… but... [18:18:07] 10VisualEditor, 10Easy: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link - https://phabricator.wikimedia.org/T198064#4316777 (10DLynch) I'd say: 1. Update the default message to "remove formatting" (as you say, it's better than "clear styling") 2. Update the link context sp... [18:18:27] 10VisualEditor, 10Easy: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link - https://phabricator.wikimedia.org/T198064#4316781 (10DLynch) a:03DLynch [18:35:14] 10VisualEditor, 10VisualEditor-Tables: Table layout breaks when table-formatting template {{no}} is present, and a new column is inserted after it - https://phabricator.wikimedia.org/T198236#4316863 (10Deskana) p:05Triage>03Low [18:36:44] 10Citoid, 10VisualEditor: Enable citoid on fr.wikiversity - https://phabricator.wikimedia.org/T198191#4316872 (10Deskana) p:05Triage>03Normal [18:41:10] (03Merged) 10jenkins-bot: Pass content language in Accept-Language header to RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442148 (https://phabricator.wikimedia.org/T198186) (owner: 10Esanders) [18:43:33] 10VisualEditor: VisualEditor makes it easy to create partially linked words, when the user expects a fully linked one - https://phabricator.wikimedia.org/T128060#2062815 (10Deskana) Part of the problem is that the construct of linking part of a word appears to be used in some wikis as a feature, such as the Basq... [18:43:44] (03CR) 10jenkins-bot: Pass content language in Accept-Language header to RESTBase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442148 (https://phabricator.wikimedia.org/T198186) (owner: 10Esanders) [18:57:12] 10VisualEditor, 10TimedMediaHandler: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317101 (10Deskana) I guess this is an issue with TimedMediaHandler and not the visual editor? [18:58:16] 10VisualEditor, 10Easy: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link - https://phabricator.wikimedia.org/T198064#4317112 (10Deskana) p:05Triage>03Normal [18:59:56] 10Citoid, 10VisualEditor, 10I18n, 10RTL: On sdwiki and hewiki, opens bare reference instead of template for templates not in the MediaWiki:Visualeditor-cite-tool-definition.json message. - https://phabricator.wikimedia.org/T197972#4308339 (10Deskana) This is a bug in the visual editor then, right? [19:17:50] 10VisualEditor, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317135 (10brion) [19:24:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317153 (10matmarex) Fixing T154844 (using PHP Parser rather than Parsoid for NWE previews) wou... [19:26:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317162 (10brion) In Chrome I'm not experiencing disappearing thumbnails or unusual size on htt... [20:16:36] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE - https://phabricator.wikimedia.org/T198150#4317333 (10matmarex) [20:30:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317367 (10brion) (I do see that the thumbnail changes on the example taken from the referenced... [20:33:14] (03CR) 10Bartosz Dziewoński: [C: 032] Don't break before/after multiline insert in source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441602 (https://phabricator.wikimedia.org/T198010) (owner: 10Esanders) [20:36:58] (03Merged) 10jenkins-bot: Don't break before/after multiline insert in source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441602 (https://phabricator.wikimedia.org/T198010) (owner: 10Esanders) [20:40:38] (03CR) 10jenkins-bot: Don't break before/after multiline insert in source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441602 (https://phabricator.wikimedia.org/T198010) (owner: 10Esanders) [20:44:54] (03CR) 10Bartosz Dziewoński: "Looks nice, but we will need a more general solution, the same problem also affects other extension thumbnail parameters, e.g. page=N for " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442082 (https://phabricator.wikimedia.org/T198150) (owner: 10Esanders) [20:46:29] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE - https://phabricator.wikimedia.org/T198150#4313663 (10matmarex) The same problem also affects other extension thumbnail parameters, e.g. page=N fo... [20:49:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317400 (10matmarex) @brion It's about the preview functionality of new wikitext editor, you ha... [20:53:42] 10VisualEditor, 10VisualEditor-EditingTools, 10User-Ryasmeen: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - https://phabricator.wikimedia.org/T68604#4317433 (10matmarex) 05Open>03Resolved This seems to work correctly now. I can't re... [21:07:19] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10Tech-Ambassadors, and 2 others: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype - https://phabricator.wikimedia.org/T124305#4317491 (10matmarex) OK. I added it to https://... [21:10:20] (03CR) 10Bartosz Dziewoński: [C: 032] "Dan says shipping next week~" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:10:42] MatmaRex: There's no train next week. https://wikitech.wikimedia.org/wiki/Deployments#Week_of_July_2nd [21:10:58] hummm. [21:11:31] well, it will be the week after that then, i guess [21:12:55] Sorry, Deskana, best laid plans and all that. [21:13:11] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10Tech-Ambassadors, and 2 others: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype - https://phabricator.wikimedia.org/T124305#4317494 (10matmarex) Apparently, there will be... [21:13:26] ¯\_(ツ)_/¯ [21:14:21] (03Merged) 10jenkins-bot: LinkContextItem: add label information to the context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:15:13] (03Abandoned) 10Jforrester: LinkAnnotationInspector: add a button to edit the label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278284 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:15:19] (03Abandoned) 10Jforrester: LinkAnnotationInspector: add a "label" field [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) (owner: 10DLynch) [21:16:31] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (fab33197b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442202 (https://phabricator.wikimedia.org/T124305) [21:16:57] (03PS2) 10Bartosz Dziewoński: Update link contexts with label info from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440985 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:17:08] (03CR) 10Bartosz Dziewoński: [C: 032] Update link contexts with label info from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440985 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:17:20] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (fab33197b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442202 (https://phabricator.wikimedia.org/T124305) (owner: 10Bartosz Dziewoński) [21:18:07] (03CR) 10jenkins-bot: LinkContextItem: add label information to the context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:18:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317512 (10brion) Gotcha -- yes, can reproduce the bug in Chrome and Safari. Thanks for filing... [21:20:03] (03CR) 10Jforrester: [C: 032] "So that this isn't a self-merge. :-P" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442202 (https://phabricator.wikimedia.org/T124305) (owner: 10Bartosz Dziewoński) [21:20:59] * James_F tsks MatmaRex. [21:21:27] pff [21:22:04] it's just a submodule update, the changes were already reviewed [21:22:08] but thanks :) [21:23:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317513 (10brion) Yeah, looks like the old-style mwembed player in TMH is getting confused abou... [21:26:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4311829 (10Jdforrester-WMF) >>! In T198103#4317513, @brion wrote: > Yeah, looks like the old-st... [21:43:16] (03Merged) 10jenkins-bot: Update VE core submodule to master (fab33197b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442202 (https://phabricator.wikimedia.org/T124305) (owner: 10Bartosz Dziewoński) [21:43:19] (03Merged) 10jenkins-bot: Update link contexts with label info from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440985 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:45:49] (03CR) 10jenkins-bot: Update VE core submodule to master (fab33197b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442202 (https://phabricator.wikimedia.org/T124305) (owner: 10Bartosz Dziewoński) [21:47:56] (03CR) 10jenkins-bot: Update link contexts with label info from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440985 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [21:55:51] (03CR) 10Esanders: "This can probably just be extended for each param." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442082 (https://phabricator.wikimedia.org/T198150) (owner: 10Esanders) [22:21:17] 10VisualEditor, 10VisualEditor-EditingTools, 10User-Ryasmeen, 10Verified: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - https://phabricator.wikimedia.org/T68604#4317647 (10Ryasmeen) [22:21:24] 10VisualEditor, 10VisualEditor-EditingTools, 10User-Ryasmeen, 10Verified: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - https://phabricator.wikimedia.org/T68604#683507 (10Ryasmeen) Me neither. [22:30:06] (03PS1) 10Esanders: Pass page parameter for PDF tumbnails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442212 [22:32:20] (03CR) 10Jforrester: [C: 031] Pass page parameter for PDF tumbnails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442212 (owner: 10Esanders) [22:33:19] (03CR) 10Bartosz Dziewoński: "Yeah… I guess I was kind of hoping that Parsoid could generate the 'iiurlparam' parameter for us, but we will need to parse them anyway if" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442082 (https://phabricator.wikimedia.org/T198150) (owner: 10Esanders) [22:34:32] (03CR) 10Bartosz Dziewoński: [C: 04-1] Pass video thumbtime to thumbnail metadata request (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442082 (https://phabricator.wikimedia.org/T198150) (owner: 10Esanders) [22:38:48] 10VisualEditor, 10VisualEditor-MediaWiki: Visual editor inserts extraneous blank lines. - https://phabricator.wikimedia.org/T197990#4317670 (10matmarex) [22:48:28] 10Cite, 10Parsoid: Support dir for refs for in Parsoid - https://phabricator.wikimedia.org/T198221#4317710 (10Arlolra) p:05Triage>03Normal [22:48:35] (03PS2) 10Bartosz Dziewoński: Pass page parameter for PDF thumbnails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442212 (owner: 10Esanders) [22:52:16] (03CR) 10Bartosz Dziewoński: Pass page parameter for PDF thumbnails (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442212 (owner: 10Esanders) [23:08:55] 10VisualEditor: [Regression pre-wmf.9] Clicking on "Edit Source" while VE is open, does not switch the editor on Firefox - https://phabricator.wikimedia.org/T198272#4317750 (10Ryasmeen) [23:27:02] 10VisualEditor: [Regression wmf.8?] The textbox size inside Add citation dialog is too small on Firefox - https://phabricator.wikimedia.org/T198274#4317797 (10Ryasmeen) [23:39:36] 10VisualEditor, 10MinervaNeue (Desktop): VE Wikitext editor cursor is misplaced - https://phabricator.wikimedia.org/T198276#4317826 (10Jdlrobson) [23:39:42] 10VisualEditor, 10MinervaNeue (Desktop): VE Wikitext editor cursor is misplaced on Minerva desktop - https://phabricator.wikimedia.org/T198276#4317836 (10Jdlrobson) [23:42:10] 10VisualEditor: [Regression pre-wmf.10] Clicking on "Edit Source" while VE is open, does not switch the editor on Firefox - https://phabricator.wikimedia.org/T198272#4317847 (10Ryasmeen) [23:50:40] 10VisualEditor: [Regression ?] The text typed on the first line while adding a new section is blurry on Firefox - https://phabricator.wikimedia.org/T198278#4317875 (10Ryasmeen) [23:52:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10TimedMediaHandler-Player: specifying image size to videos with thumbnail on English Wikipedia breaks the preview of the video - https://phabricator.wikimedia.org/T198103#4317886 (10brion) I'm having trouble reproducing this in an isolated environment. MediaWiki-va... [23:54:09] 10WikiEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), 10Patch-For-Review: Remove toolbar icon right border - https://phabricator.wikimedia.org/T190378#4317907 (10Niharika)