[00:38:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10ConfirmEdit (CAPTCHA extension), 10ContentTranslation, 10Technical-Debt: Improve ConfirmEdit hook to not require edit interfaces to hardcode message handling - https://phabricator.wikimedia.org/T198672 (10Krinkle) [00:39:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10ConfirmEdit (CAPTCHA extension), 10ContentTranslation, 10Technical-Debt: Improve ConfirmEdit hook to not require edit interfaces to hardcode message handling - https://phabricator.wikimedia.org/T198672 (10Krinkle) [08:48:16] 10VisualEditor: [Regression pre-wmf.11] VE crashes with an error "VM51:1122 Uncaught TypeError: Cannot read property 'thumbtime' of undefined" while trying to add an image - https://phabricator.wikimedia.org/T198660 (10Schnark) Caused by {rEVED715d67b5647ff2d04cf27e5c7fb05dc6825c4bc1}: The `|| {}` was important. [09:24:57] (03CR) 10Petar.petkovic: Pass page parameter for multipage file (PDF, DjVu) thumbnails (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442212 (https://phabricator.wikimedia.org/T182392) (owner: 10Esanders) [09:37:46] 10VisualEditor, 10ProofreadPage: Switching between editors, the header and footer are moved into the body - https://phabricator.wikimedia.org/T198688 (10BethNaught) [11:05:56] (03PS1) 10Santhosh: Fix error in ve.dm.InternalList#sortGroupIndexes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443591 (https://phabricator.wikimedia.org/T191011) [11:08:38] (03CR) 10jerkins-bot: [V: 04-1] Fix error in ve.dm.InternalList#sortGroupIndexes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443591 (https://phabricator.wikimedia.org/T191011) (owner: 10Santhosh) [12:16:19] 10VisualEditor, 10Parsoid: Infobox overlaps with text, prevents editing the latter. - https://phabricator.wikimedia.org/T194945 (10Deskana) >>! In T194945#4392162, @Od1n wrote: > Though it's quite clear these `` are tricky, I'd say the issue discussed here is rather in the visual editor, which should... [13:24:01] (03PS1) 10Esanders: Fix toolbar group names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443617 (https://phabricator.wikimedia.org/T198583) [13:28:29] (03CR) 10Esanders: [C: 032] Change transaction manipulation functions into methods (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443466 (owner: 10Divec) [13:31:03] 10VisualEditor, 10ProofreadPage: Switching between editors on WIkiSource, the header and footer are moved into the body - https://phabricator.wikimedia.org/T198688 (10Esanders) [13:33:31] (03CR) 10jerkins-bot: [V: 04-1] Change transaction manipulation functions into methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443466 (owner: 10Divec) [14:28:25] 10Citoid, 10VisualEditor, 10User-Ryasmeen: Enable citoid on sw wikipedia. - https://phabricator.wikimedia.org/T196866 (10MusikAnimal) [14:29:33] 10Citoid, 10VisualEditor, 10Wikidata, 10Wikidocumentaries: Add citoid support for WikiBase to the Citoid extension - https://phabricator.wikimedia.org/T196353 (10MusikAnimal) [14:47:39] (03PS1) 10Zoranzoki21: Test [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 [14:58:26] (03PS2) 10Zoranzoki21: Tag for adding new row is wrong in WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 (https://phabricator.wikimedia.org/T198720) [15:04:05] (03CR) 10Aklapper: "-1 as per https://phabricator.wikimedia.org/T198720#4394445" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 (https://phabricator.wikimedia.org/T198720) (owner: 10Zoranzoki21) [15:04:48] (03CR) 10Aklapper: "For future reference, please also follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines . The current commit message does" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 (https://phabricator.wikimedia.org/T198720) (owner: 10Zoranzoki21) [15:05:50] (03Abandoned) 10Zoranzoki21: Tag for adding new row is wrong in WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 (https://phabricator.wikimedia.org/T198720) (owner: 10Zoranzoki21) [16:11:51] (03CR) 10Jforrester: [C: 032] Fix toolbar group names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443617 (https://phabricator.wikimedia.org/T198583) (owner: 10Esanders) [16:25:28] (03Merged) 10jenkins-bot: Fix toolbar group names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443617 (https://phabricator.wikimedia.org/T198583) (owner: 10Esanders) [16:28:20] (03CR) 10jenkins-bot: Fix toolbar group names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443617 (https://phabricator.wikimedia.org/T198583) (owner: 10Esanders) [16:36:30] (03PS1) 10Esanders: Handle ctrl+click events on links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443651 (https://phabricator.wikimedia.org/T145850) [16:37:18] (03PS1) 10Esanders: Fix window target when opening feedbackUrl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443652 [16:38:13] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443466 (owner: 10Divec) [16:39:50] (03CR) 10Bartosz Dziewoński: [C: 032] Fix window target when opening feedbackUrl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443652 (owner: 10Esanders) [16:44:47] (03CR) 10jerkins-bot: [V: 04-1] Change transaction manipulation functions into methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443466 (owner: 10Divec) [16:49:57] (03CR) 10Jforrester: "CI seems unwell." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443466 (owner: 10Divec) [16:55:57] (03Merged) 10jenkins-bot: Fix window target when opening feedbackUrl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443652 (owner: 10Esanders) [16:58:53] (03CR) 10jenkins-bot: Fix window target when opening feedbackUrl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443652 (owner: 10Esanders) [17:00:27] (03PS1) 10Esanders: De-duplicate and fix updating of file link in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443657 (https://phabricator.wikimedia.org/T198565) [17:11:21] (03CR) 10Jforrester: [C: 032] De-duplicate and fix updating of file link in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443657 (https://phabricator.wikimedia.org/T198565) (owner: 10Esanders) [17:27:38] (03Merged) 10jenkins-bot: De-duplicate and fix updating of file link in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443657 (https://phabricator.wikimedia.org/T198565) (owner: 10Esanders) [17:30:11] (03CR) 10jenkins-bot: De-duplicate and fix updating of file link in media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443657 (https://phabricator.wikimedia.org/T198565) (owner: 10Esanders) [18:13:42] (03PS1) 10Bartosz Dziewoński: ve.ui.MWTemplatePlaceholderPage: Avoid Firefox rendering issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443667 (https://phabricator.wikimedia.org/T198274) [18:32:50] 10VisualEditor, 10ProofreadPage: Switching between editors on Wikisource, the header and footer are moved into the body - https://phabricator.wikimedia.org/T198688 (10Deskana) p:05Triage>03Low [18:36:00] 10VisualEditor-Media, 10VisualEditor (Current work): [Regression pre-wmf.11] VE crashes with an error "VM51:1122 Uncaught TypeError: Cannot read property 'thumbtime' of undefined" while trying to add an image - https://phabricator.wikimedia.org/T198660 (10Deskana) p:05Triage>03High [18:36:14] 10VisualEditor-Media, 10VisualEditor (Current work): [Regression pre-wmf.11] VE crashes with an error "VM51:1122 Uncaught TypeError: Cannot read property 'thumbtime' of undefined" while trying to add an image - https://phabricator.wikimedia.org/T198660 (10Deskana) Needs fixing before the next train. [18:43:23] (03CR) 10Esanders: [C: 032] ve.ui.MWTemplatePlaceholderPage: Avoid Firefox rendering issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443667 (https://phabricator.wikimedia.org/T198274) (owner: 10Bartosz Dziewoński) [18:47:14] 10VisualEditor, 10VisualEditor-MediaWiki: Visual editor inserts extraneous blank lines (due to pulled out of paragraph and then disappearing) - https://phabricator.wikimedia.org/T197990 (10Deskana) p:05Triage>03Low [18:57:12] (03Merged) 10jenkins-bot: ve.ui.MWTemplatePlaceholderPage: Avoid Firefox rendering issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443667 (https://phabricator.wikimedia.org/T198274) (owner: 10Bartosz Dziewoński) [18:57:55] 10WikiEditor: Bug? MediaWiki Editor Fails to Include Leading Colon when Linking to Category - https://phabricator.wikimedia.org/T198746 (10Johnywhy) [18:58:18] 10WikiEditor: Bug? MediaWiki Editor Fails to Include Leading Colon when Linking to Category - https://phabricator.wikimedia.org/T198746 (10Johnywhy) [18:59:34] (03CR) 10jenkins-bot: ve.ui.MWTemplatePlaceholderPage: Avoid Firefox rendering issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443667 (https://phabricator.wikimedia.org/T198274) (owner: 10Bartosz Dziewoński) [19:04:04] (03PS1) 10Petar.petkovic: Quickfix "Cannot read property 'thumbtime' of undefined" error [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443677 [19:05:18] (03PS1) 10Bartosz Dziewoński: MWImageNode: Make 'mw' attribute optional again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443678 (https://phabricator.wikimedia.org/T198660) [19:06:43] (03CR) 10Bartosz Dziewoński: Pass page parameter for multipage file (PDF, DjVu) thumbnails (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442212 (https://phabricator.wikimedia.org/T182392) (owner: 10Esanders) [20:20:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443724 (owner: 10L10n-bot) [20:42:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/443716 (owner: 10L10n-bot) [21:18:24] 10Editing-team, 10MinervaNeue, 10MobileFrontend: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10matmarex) [21:24:13] (03Abandoned) 10Petar.petkovic: Quickfix "Cannot read property 'thumbtime' of undefined" error [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443677 (owner: 10Petar.petkovic) [21:24:27] 10Editing-team, 10MinervaNeue, 10MobileFrontend: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10matmarex) I propose we do this in three steps (separate patches for each, and we can stop after ste... [21:43:53] (03CR) 10Bartosz Dziewoński: "Looks neat, what is this for?" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441645 (owner: 10Esanders) [21:47:49] (03CR) 10Bartosz Dziewoński: [C: 031] "Code looks but I don't see why we are making this change. Is this way better for some reason I don't understand? Do you have something in " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441644 (owner: 10Esanders) [22:11:55] (03PS1) 10Bartosz Dziewoński: DesktopArticleTarget.init: Fix URI comparison if it contains a port number [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443745 [22:14:39] (03CR) 10Bartosz Dziewoński: [C: 032] "Discovered another issue while reviewing this: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/443745" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442750 (https://phabricator.wikimedia.org/T198272) (owner: 10DLynch) [22:27:44] (03Merged) 10jenkins-bot: DesktopArticleTarget: consolidate edit tab behavior [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442750 (https://phabricator.wikimedia.org/T198272) (owner: 10DLynch) [22:30:19] (03CR) 10jenkins-bot: DesktopArticleTarget: consolidate edit tab behavior [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/442750 (https://phabricator.wikimedia.org/T198272) (owner: 10DLynch) [22:59:39] (03CR) 10Jforrester: [C: 032] DesktopArticleTarget.init: Fix URI comparison if it contains a port number [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443745 (owner: 10Bartosz Dziewoński) [23:16:35] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: Fix URI comparison if it contains a port number [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443745 (owner: 10Bartosz Dziewoński) [23:19:14] (03CR) 10jenkins-bot: DesktopArticleTarget.init: Fix URI comparison if it contains a port number [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443745 (owner: 10Bartosz Dziewoński) [23:36:38] (03PS1) 10Jforrester: Pass content language in Accept-Language header to RESTBase [extensions/VisualEditor] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443754 (https://phabricator.wikimedia.org/T198186)