[04:10:06] (03CR) 10Santhosh: Fix error in ve.dm.InternalList#sortGroupIndexes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443591 (https://phabricator.wikimedia.org/T191011) (owner: 10Santhosh) [10:08:39] edsanders: hello [10:08:47] would you be ok with us swatting https://gerrit.wikimedia.org/r/#/c/443754/ today? [10:09:10] there is no mw train this week, and so if don't push it out, we have to postpone getting the rb support out for two more weeks [11:55:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443948 (owner: 10L10n-bot) [12:34:05] mobrovac: go for it [12:52:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-Performance, 10Specialists-Support (Jul-Sep-2018): Community Liaison support for improving the performance of the 2017 wikitext editor - https://phabricator.wikimedia.org/T190794 (10Elitre) [13:15:41] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10CommRel-Specialists-Support, 10Wikimedia-Site-requests: Support wikis in converting reference lists over to `responsive` - https://phabricator.wikimedia.org/T159895 (10Elitre) [13:15:59] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10CommRel-Specialists-Support: Make a list of wikis that will probably want to have enabled by default - https://phabricator.wikimedia.org/T160971 (10Elitre) [13:46:30] 10VisualEditor, 10Community-Relations: Phases 4, 5 in building the visual editor taskforce - https://phabricator.wikimedia.org/T147174 (10Elitre) [14:11:03] (03CR) 10Mobrovac: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443754 (https://phabricator.wikimedia.org/T198186) (owner: 10Jforrester) [14:18:20] (03CR) 10Mobrovac: [C: 032] "recheck" [extensions/VisualEditor] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443754 (https://phabricator.wikimedia.org/T198186) (owner: 10Jforrester) [14:30:25] (03Merged) 10jenkins-bot: Pass content language in Accept-Language header to RESTBase [extensions/VisualEditor] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443754 (https://phabricator.wikimedia.org/T198186) (owner: 10Jforrester) [14:45:27] (03PS1) 10Esanders: Fix cleanup of PreviewElement after render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443981 (https://phabricator.wikimedia.org/T198826) [14:50:48] (03CR) 10Bartosz Dziewoński: [C: 032] Change transaction manipulation functions into methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443466 (owner: 10Divec) [14:55:10] (03Merged) 10jenkins-bot: Change transaction manipulation functions into methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443466 (owner: 10Divec) [15:00:41] (03CR) 10jenkins-bot: Change transaction manipulation functions into methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443466 (owner: 10Divec) [15:13:22] (03PS1) 10Esanders: Create basic tests for PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443993 (https://phabricator.wikimedia.org/T198871) [15:15:47] (03CR) 10Bartosz Dziewoński: ve.ce.MWTableNode: Compatibility with new jQuery.makeCollapsible toggle styles (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/432421 (https://phabricator.wikimedia.org/T194323) (owner: 10Bartosz Dziewoński) [15:18:08] (03PS2) 10Esanders: Add getNameByTrigger to TriggerRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441645 [15:23:12] (03CR) 10jerkins-bot: [V: 04-1] Create basic tests for PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443993 (https://phabricator.wikimedia.org/T198871) (owner: 10Esanders) [15:35:12] (03CR) 10Jforrester: [C: 031] Handle ctrl+click events on links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443651 (https://phabricator.wikimedia.org/T145850) (owner: 10Esanders) [15:41:56] (03PS1) 10Bartosz Dziewoński: Move some styles from mw.ArticleTarget to mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444003 [15:41:58] (03PS1) 10Bartosz Dziewoński: Apply edit surface jQuery.makeCollapsible overrides to visual diffs too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444004 (https://phabricator.wikimedia.org/T194725) [15:42:16] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Collapsed tables broken in visual diff - https://phabricator.wikimedia.org/T194725 (10matmarex) p:05Triage>03Low [15:42:20] (03CR) 10DLynch: [C: 032] Handle ctrl+click events on links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443651 (https://phabricator.wikimedia.org/T145850) (owner: 10Esanders) [15:44:41] can someone give me hint how to add a button with a custom command next to the "Save changes..." button? Not as a widget but as a extension. [15:45:59] (03CR) 10DLynch: [C: 032] Fix cleanup of PreviewElement after render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443981 (https://phabricator.wikimedia.org/T198826) (owner: 10Esanders) [15:46:18] can someone give me hint how to add a button with a custom command next to the "Save changes..." button? Not as a gadget but as a extension. [15:47:21] (03Merged) 10jenkins-bot: Handle ctrl+click events on links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443651 (https://phabricator.wikimedia.org/T145850) (owner: 10Esanders) [15:48:10] Jan_k_: hmm, try to adapt some of the examples from https://www.mediawiki.org/wiki/VisualEditor/Gadgets [15:48:52] Jan_k_: the "Save changes" button is annoyingly special, so it might be tricky to fiddle with it, but you can add normal tools to the toolbar more easily [15:50:23] (03Merged) 10jenkins-bot: Fix cleanup of PreviewElement after render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443981 (https://phabricator.wikimedia.org/T198826) (owner: 10Esanders) [15:51:04] (03CR) 10jenkins-bot: Handle ctrl+click events on links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443651 (https://phabricator.wikimedia.org/T145850) (owner: 10Esanders) [15:52:45] (03CR) 10Esanders: [C: 032] Move some styles from mw.ArticleTarget to mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444003 (owner: 10Bartosz Dziewoński) [15:54:34] (03CR) 10jerkins-bot: [V: 04-1] Apply edit surface jQuery.makeCollapsible overrides to visual diffs too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444004 (https://phabricator.wikimedia.org/T194725) (owner: 10Bartosz Dziewoński) [15:55:01] (03CR) 10DLynch: Add getNameByTrigger to TriggerRegistry (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441645 (owner: 10Esanders) [15:56:00] (03CR) 10jenkins-bot: Fix cleanup of PreviewElement after render [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443981 (https://phabricator.wikimedia.org/T198826) (owner: 10Esanders) [15:56:19] (03PS1) 10Esanders: Show and capture paste triggers in wikitext conversion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444008 (https://phabricator.wikimedia.org/T196789) [15:58:44] (03CR) 10Esanders: Add getNameByTrigger to TriggerRegistry (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441645 (owner: 10Esanders) [15:58:49] (03PS3) 10Bartosz Dziewoński: MWWelcomeDialog: Shrink the background image by 1/3 so the CTAs show [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (https://phabricator.wikimedia.org/T191095) (owner: 10Jforrester) [15:59:00] (03CR) 10Bartosz Dziewoński: [C: 031] MWWelcomeDialog: Shrink the background image by 1/3 so the CTAs show [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (https://phabricator.wikimedia.org/T191095) (owner: 10Jforrester) [15:59:05] (03CR) 10jerkins-bot: [V: 04-1] Move some styles from mw.ArticleTarget to mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444003 (owner: 10Bartosz Dziewoński) [16:00:01] (03PS3) 10Esanders: Add getNameByTrigger to TriggerRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441645 [16:00:06] (03CR) 10jerkins-bot: [V: 04-1] Show and capture paste triggers in wikitext conversion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444008 (https://phabricator.wikimedia.org/T196789) (owner: 10Esanders) [16:01:18] (03PS2) 10Bartosz Dziewoński: Move some styles from mw.ArticleTarget to mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444003 [16:02:31] (03PS2) 10Esanders: Show and capture paste triggers in wikitext conversion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444008 (https://phabricator.wikimedia.org/T196789) [16:09:14] (03PS2) 10Bartosz Dziewoński: Apply edit surface jQuery.makeCollapsible overrides to visual diffs too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444004 (https://phabricator.wikimedia.org/T194725) [16:48:24] 10Cite, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10VisualEditor (Current work): Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode - https://phabricator.wikimedia.org/T198826 (10Petar.petkovic) [17:24:25] (03CR) 10Esanders: [C: 032] ve.ui.TableLineContext: Use automatic width [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435932 (https://phabricator.wikimedia.org/T195707) (owner: 10Bartosz Dziewoński) [17:30:57] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.TableLineContext: Use automatic width [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435932 (https://phabricator.wikimedia.org/T195707) (owner: 10Bartosz Dziewoński) [17:37:53] (03CR) 10Esanders: [C: 04-1] "See comment on bug" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (https://phabricator.wikimedia.org/T191095) (owner: 10Jforrester) [17:38:47] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435932 (https://phabricator.wikimedia.org/T195707) (owner: 10Bartosz Dziewoński) [17:39:37] (03PS2) 10Bartosz Dziewoński: ve.ui.TableLineContext: Use automatic width [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435932 (https://phabricator.wikimedia.org/T195707) [17:40:29] (03CR) 10Bartosz Dziewoński: [C: 032] "(Rebased on top of the OOUI update, so that it works as described when tested with rebasing on master.)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435932 (https://phabricator.wikimedia.org/T195707) (owner: 10Bartosz Dziewoński) [17:42:32] MatmaRex: For https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/441644 (well, https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/441645) Ed pushed https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/444008 for https://phabricator.wikimedia.org/T196789 :-) [17:45:14] i see, neat [17:51:40] (03Merged) 10jenkins-bot: ve.ui.TableLineContext: Use automatic width [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435932 (https://phabricator.wikimedia.org/T195707) (owner: 10Bartosz Dziewoński) [17:56:40] (03CR) 10jenkins-bot: ve.ui.TableLineContext: Use automatic width [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435932 (https://phabricator.wikimedia.org/T195707) (owner: 10Bartosz Dziewoński) [18:04:35] MatmaRex: 'Cos apparently he's totally unable to actually answer your questions on gerrit. :-) [18:05:34] (03PS4) 10Bartosz Dziewoński: MWWelcomeDialog: Shrink the background image by 1/3 so the CTAs show [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (https://phabricator.wikimedia.org/T191095) (owner: 10Jforrester) [18:05:36] (03PS1) 10Bartosz Dziewoński: MWWelcomeDialog: Refactor splash image to allow resizing it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444035 (https://phabricator.wikimedia.org/T191095) [18:11:43] (03CR) 10Bartosz Dziewoński: "No longer needed for T195707 (it is fixed in a different way), but we might want to do this anyway for T178387." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435783 (https://phabricator.wikimedia.org/T195707) (owner: 10Esanders) [18:11:49] (03PS3) 10Bartosz Dziewoński: VWIP Table context to dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435783 (https://phabricator.wikimedia.org/T178387) (owner: 10Esanders) [18:11:59] (03CR) 10jerkins-bot: [V: 04-1] VWIP Table context to dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/435783 (https://phabricator.wikimedia.org/T178387) (owner: 10Esanders) [19:52:31] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443993 (https://phabricator.wikimedia.org/T198871) (owner: 10Esanders) [19:59:51] (03CR) 10Esanders: [C: 032] "Nice!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (https://phabricator.wikimedia.org/T191095) (owner: 10Jforrester) [20:00:08] (03CR) 10Bartosz Dziewoński: [C: 031] Show and capture paste triggers in wikitext conversion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444008 (https://phabricator.wikimedia.org/T196789) (owner: 10Esanders) [20:00:10] (03CR) 10Esanders: [C: 032] MWWelcomeDialog: Refactor splash image to allow resizing it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444035 (https://phabricator.wikimedia.org/T191095) (owner: 10Bartosz Dziewoński) [20:00:25] (03CR) 10Bartosz Dziewoński: [C: 031] "Used in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/444008" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441645 (owner: 10Esanders) [20:00:29] (03CR) 10Bartosz Dziewoński: [C: 031] "Used in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/444008" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441644 (owner: 10Esanders) [20:02:36] (03CR) 10Esanders: [C: 032] MWImageNode: Make 'mw' attribute optional again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443678 (https://phabricator.wikimedia.org/T198660) (owner: 10Bartosz Dziewoński) [20:17:01] (03Merged) 10jenkins-bot: MWWelcomeDialog: Refactor splash image to allow resizing it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444035 (https://phabricator.wikimedia.org/T191095) (owner: 10Bartosz Dziewoński) [20:17:04] (03Merged) 10jenkins-bot: MWWelcomeDialog: Shrink the background image by 1/3 so the CTAs show [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (https://phabricator.wikimedia.org/T191095) (owner: 10Jforrester) [20:17:35] (03Merged) 10jenkins-bot: MWImageNode: Make 'mw' attribute optional again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443678 (https://phabricator.wikimedia.org/T198660) (owner: 10Bartosz Dziewoński) [20:20:51] (03CR) 10jenkins-bot: MWWelcomeDialog: Refactor splash image to allow resizing it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444035 (https://phabricator.wikimedia.org/T191095) (owner: 10Bartosz Dziewoński) [20:23:54] (03CR) 10jenkins-bot: MWWelcomeDialog: Shrink the background image by 1/3 so the CTAs show [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (https://phabricator.wikimedia.org/T191095) (owner: 10Jforrester) [20:26:15] (03CR) 10jenkins-bot: MWImageNode: Make 'mw' attribute optional again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/443678 (https://phabricator.wikimedia.org/T198660) (owner: 10Bartosz Dziewoński) [20:51:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444114 (owner: 10L10n-bot) [21:02:24] (03PS1) 10Esanders: Make invisible icon button unclickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) [21:34:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/444105 (owner: 10L10n-bot) [22:46:07] 10VisualEditor-Media, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10VisualEditor (Current work): [Regression pre-wmf.11] VE crashes with an error "VM51:1122 Uncaught TypeError: Cannot read property 'thumbtime' of undefined" while trying to add an... - https://phabricator.wikimedia.org/T198660 [22:47:49] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10VisualEditor (Current work): The image behind the intro dialog on mobile VE stretches strangely and makes the dialog look broken - https://phabricator.wikimedia.org/T191095 (10Jdforr... [22:48:49] (03CR) 10Jforrester: [C: 032] Create basic tests for PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443993 (https://phabricator.wikimedia.org/T198871) (owner: 10Esanders) [23:06:00] (03Merged) 10jenkins-bot: Create basic tests for PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443993 (https://phabricator.wikimedia.org/T198871) (owner: 10Esanders) [23:08:09] (03Abandoned) 10Jforrester: [WIP] [PULL THROUGH] Add high-level transactions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187409 (owner: 10C. Scott Ananian) [23:09:37] (03CR) 10jenkins-bot: Create basic tests for PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/443993 (https://phabricator.wikimedia.org/T198871) (owner: 10Esanders) [23:09:57] (03PS1) 10Jforrester: Update VE core submodule to master (bbe825690) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444139 (https://phabricator.wikimedia.org/T145850)