[04:10:07] 10VisualEditor, 10VisualEditor-MediaWiki: Suggestions for category in VE should be case-insensitive - https://phabricator.wikimedia.org/T161786 (10Whatamidoing-WMF) @Deskana, is this a duplicate of {T59302}? [04:10:09] 10VisualEditor, 10VisualEditor-MediaWiki: Suggestions for category in VE should be case-insensitive - https://phabricator.wikimedia.org/T161786 (10Whatamidoing-WMF) @Deskana, is this a duplicate of {T59302}? [04:17:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: If a user adds a link to a disambiguation page in the mainspace, suggest changing the link - https://phabricator.wikimedia.org/T198936 (10Whatamidoing-WMF) [04:17:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10Design: If a user adds a link to a disambiguation page in the mainspace, suggest changing the link - https://phabricator.wikimedia.org/T198936 (10Whatamidoing-WMF) [04:20:06] 10Citoid, 10VisualEditor, 10I18n, 10RTL: On sdwiki and hewiki, opens bare reference instead of template for templates not in the MediaWiki:Visualeditor-cite-tool-definition.json message. - https://phabricator.wikimedia.org/T197972 (10Whatamidoing-WMF) [04:20:08] 10Citoid, 10VisualEditor, 10I18n, 10RTL: On sdwiki and hewiki, opens bare reference instead of template for templates not in the MediaWiki:Visualeditor-cite-tool-definition.json message. - https://phabricator.wikimedia.org/T197972 (10Whatamidoing-WMF) [07:46:25] thank you matmarex [09:05:46] 10WikiEditor: Bug? MediaWiki Editor Fails to Include Leading Colon when Linking to Category - https://phabricator.wikimedia.org/T198746 (10Aklapper) Ah, alright, I'm sorry - did not see that this was added in a task description edit. Feel free to use "Edit Related Tasks... > Close As Duplicate" in such cases. [09:05:53] 10WikiEditor: Bug? MediaWiki Editor Fails to Include Leading Colon when Linking to Category - https://phabricator.wikimedia.org/T198746 (10Aklapper) Ah, alright, I'm sorry - did not see that this was added in a task description edit. Feel free to use "Edit Related Tasks... > Close As Duplicate" in such cases. [09:16:16] i wrote a little extension adding a close button to the ve. can someone do a code review and point out what i did wrong? :) [09:24:12] 10VisualEditor, 10ContentTranslation, 10Language-2018-July-September: CX2: Uncaught TypeError: Cannot read property 'element' of null - https://phabricator.wikimedia.org/T197845 (10Pginer-WMF) [09:24:14] 10VisualEditor, 10ContentTranslation, 10Language-2018-July-September: CX2: Uncaught TypeError: Cannot read property 'element' of null - https://phabricator.wikimedia.org/T197845 (10Pginer-WMF) [09:39:40] 10VisualEditor, 10VisualEditor-MediaWiki: Suggestions for category in VE should be case-insensitive - https://phabricator.wikimedia.org/T161786 (10Deskana) >>! In T161786#4402231, @Whatamidoing-WMF wrote: > @Deskana, is this a duplicate of {T59302}? I assume so. [09:39:44] 10VisualEditor, 10VisualEditor-MediaWiki: Suggestions for category in VE should be case-insensitive - https://phabricator.wikimedia.org/T161786 (10Deskana) >>! In T161786#4402231, @Whatamidoing-WMF wrote: > @Deskana, is this a duplicate of {T59302}? I assume so. [09:39:55] 10VisualEditor, 10VisualEditor-MediaWiki: Suggest case insensitive results when searching for categories to add - https://phabricator.wikimedia.org/T59302 (10Deskana) [09:39:57] 10VisualEditor, 10VisualEditor-MediaWiki: Suggestions for category in VE should be case-insensitive - https://phabricator.wikimedia.org/T161786 (10Deskana) [09:40:04] 10VisualEditor, 10VisualEditor-MediaWiki: Suggest case insensitive results when searching for categories to add - https://phabricator.wikimedia.org/T59302 (10Deskana) [09:40:06] 10VisualEditor, 10VisualEditor-MediaWiki: Suggestions for category in VE should be case-insensitive - https://phabricator.wikimedia.org/T161786 (10Deskana) [09:51:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design, 10Patch-For-Review: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere - https://phabricator.wikimedia.org/T196789 (10Deskana) What does it look like on mobile? Aside from taking up extra scree... [09:51:32] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design, 10Patch-For-Review: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere - https://phabricator.wikimedia.org/T196789 (10Deskana) What does it look like on mobile? Aside from taking up extra scree... [10:16:26] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-2018-July-September: Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049 (10Pginer-WMF) [10:16:31] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-2018-July-September: Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049 (10Pginer-WMF) [13:52:39] 10Citoid, 10VisualEditor: Enabling Citoid on GA Wikipedia (Vicipéid) - https://phabricator.wikimedia.org/T187909 (10Smirkybec) I have started the conversation on the Vicipéid Village Pump about enabling the citation tool by using the templates that already exist: https://ga.wikipedia.org/wiki/Vicip%C3%A9id:Hal... [13:52:41] 10Citoid, 10VisualEditor: Enabling Citoid on GA Wikipedia (Vicipéid) - https://phabricator.wikimedia.org/T187909 (10Smirkybec) I have started the conversation on the Vicipéid Village Pump about enabling the citation tool by using the templates that already exist: https://ga.wikipedia.org/wiki/Vicip%C3%A9id:Hal... [14:41:25] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (bbe825690) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444139 (https://phabricator.wikimedia.org/T145850) (owner: 10Jforrester) [14:52:18] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (bbe825690) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444139 (https://phabricator.wikimedia.org/T145850) (owner: 10Jforrester) [17:25:32] (03CR) 10DLynch: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444139 (https://phabricator.wikimedia.org/T145850) (owner: 10Jforrester) [17:45:43] 10Citoid, 10VisualEditor: Enabling Citoid on GA Wikipedia (Vicipéid) - https://phabricator.wikimedia.org/T187909 (10Mvolz) FYI @Smirkybec and I are at Celtic Knot Conference 2018 together and made some progress on getting template data added to two templates that already existed, https://ga.wikipedia.org/wiki/... [17:46:54] (03CR) 10Jforrester: [C: 032] "Per Bartosz." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444139 (https://phabricator.wikimedia.org/T145850) (owner: 10Jforrester) [17:58:59] (03PS1) 10Jforrester: build: Bump linters for eslint 5 and make pass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444257 [17:59:01] (03PS1) 10Jforrester: build: Enable and make pass no-prototype-builtins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444258 [17:59:03] (03PS1) 10Jforrester: build: Enable and make pass max-len [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444259 [17:59:06] (03PS1) 10Jforrester: build: Bump devDependencies related to the screenshots task [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444260 [18:13:48] (03Merged) 10jenkins-bot: Update VE core submodule to master (bbe825690) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444139 (https://phabricator.wikimedia.org/T145850) (owner: 10Jforrester) [18:17:06] (03CR) 10jenkins-bot: Update VE core submodule to master (bbe825690) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444139 (https://phabricator.wikimedia.org/T145850) (owner: 10Jforrester) [18:19:11] 10VisualEditor-EditingTools, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10User-Ryasmeen, 10VisualEditor (Current work): visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link - https://phabricator.wikimedia.org/T198064 (10Jdforrester-WMF) 05Re... [18:19:41] 10Cite, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10VisualEditor (Current work): Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode - https://phabricator.wikimedia.org/T198826 (10... [18:59:26] 10VisualEditor, 10Technical-Debt: VisualEditor: Make ve.dm.Transaction chainable - https://phabricator.wikimedia.org/T50913 (10Krinkle) 05Open>03declined [19:01:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10Technical-Debt: Handle api data.error values and reduce getProp() defense - https://phabricator.wikimedia.org/T88878 (10Krinkle) 05Open>03declined Vague idea from past me that probably isn't worth keeping a task for. [19:07:55] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Duplicate resize handles appear on unhighlighted image nodes after resize - https://phabricator.wikimedia.org/T72817 (10Krinkle) [19:08:57] 10VisualEditor, 10VisualEditor-ContentEditable, 10User-Ryasmeen: VisualEditor: Duplicate resize handles appear on unhighlighted image nodes after resize - https://phabricator.wikimedia.org/T72817 (10Krinkle) 05Open>03Resolved a:03Krinkle I can't reproduce this anymore. Looks like it was fixed. [19:10:23] 10VisualEditor, 10Technical-Debt: VisualEditor: Refactor dialog to not need hardcoded padding for each subclass - https://phabricator.wikimedia.org/T51924 (10Krinkle) 05Open>03declined Closing vague idea from past me. Looks like this may've been an issue in what's now become OOUI. [19:11:41] 10VisualEditor, 10Technical-Debt, 10User-Ryasmeen: VisualEditor: Remove (and stop adding) useless documentation - https://phabricator.wikimedia.org/T53650 (10Krinkle) 05Open>03Resolved a:03Krinkle [19:13:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10Regression, 10User-Ryasmeen: [Regression] VisualEditor expands TOC during loading phase - https://phabricator.wikimedia.org/T118819 (10Krinkle) 05Open>03Resolved a:03Krinkle This has been fixed. Current version of VE-MediaWiki in prod no longer performs mu... [19:13:57] 10VisualEditor, 10VisualEditor-ContentEditable, 10Technical-Debt, 10User-Ryasmeen: Clean up mixed use of getters, attributes and properties around rowspan/colspan in TableCellNode - https://phabricator.wikimedia.org/T87798 (10Krinkle) 05Open>03Resolved a:03Krinkle [19:43:59] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Cursor position should account for padding on inline annotations - https://phabricator.wikimedia.org/T50680 (10Krinkle) [19:44:12] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Cursor position does not match point of insertion (when inline annotation has padding) - https://phabricator.wikimedia.org/T50680 (10Krinkle) [19:46:04] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Cursor position does not match point of insertion (when inline annotation has padding) - https://phabricator.wikimedia.org/T50680 (10Krinkle) Back in 2013, a similar issue exited with links and their labels. Both issues were cause due to a limitatio... [19:53:19] 10VisualEditor, 10VisualEditor-ContentEditable, 10Browser-Support-Firefox, 10User-Ryasmeen: VisualEditor: Spellcheck freaks out in Firefox when focusable nodes are focused - https://phabricator.wikimedia.org/T56975 (10Krinkle) 05Open>03Resolved a:03Krinkle Can't reproduce this issue anymore. [19:54:13] 10VisualEditor, 10Technical-Debt: VisualEditor: Main application namespace should be capitalised and not 2 characters short (ve -> VisualEditor) - https://phabricator.wikimedia.org/T69642 (10Krinkle) 05Open>03declined Lowercase globals aren't ideal, but I think the ship has sailed on this for both `ve` and... [19:54:27] 10VisualEditor, 10Technical-Debt: VisualEditor: Main application namespace should be capitalised and not 2 characters short (ve -> VisualEditor) - https://phabricator.wikimedia.org/T69642 (10Krinkle) [19:54:28] 10VisualEditor, 10Technical-Debt: Load visualeditor modules in a closure mapping $/mw/ve to their globals - https://phabricator.wikimedia.org/T50885 (10Krinkle) [19:56:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10Regression, 10User-Ryasmeen: VisualEditor: [Regression] The #contentSub should not be removed during loading phase - https://phabricator.wikimedia.org/T72954 (10Krinkle) 05Open>03Resolved a:03Krinkle [19:57:28] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10User-Ryasmeen: Browser disconnects when running QUnit tests with local browsers - https://phabricator.wikimedia.org/T89075 (10Krinkle) [19:57:31] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10User-Ryasmeen: Concurrent builds using local Chromium/Firefox browsers on Linux host fail - https://phabricator.wikimedia.org/T90673 (10Krinkle) 05Open>03Resolved a:03Krinkle Fixed. And also, for Chromium we no longer need Xvfb, given `--headle... [19:57:34] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10User-Ryasmeen: Jenkins: Convert mediawiki qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063 (10Krinkle) [20:08:45] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This only partially fixes the issue for me (testing with Chromium). The cursor doesn't jump to the beginning of the document, but instead " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [20:17:24] 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): Clicking on focusable inside table cell can jump cursor to start of document - https://phabricator.wikimedia.org/T198912 (10Esanders) [20:43:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444305 (owner: 10L10n-bot) [22:00:28] (03PS2) 10Bartosz Dziewoński: Remove special handling for category and file pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441509 (https://phabricator.wikimedia.org/T139191) [22:01:45] (03PS3) 10Bartosz Dziewoński: Remove special handling for category and file pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441509 (https://phabricator.wikimedia.org/T139191) [22:03:17] (03CR) 10Bartosz Dziewoński: "I am not entirely sure if it's okay to "pluck out" the div.mw-parser-output like this. I think it should be fine, but maybe we should just" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441509 (https://phabricator.wikimedia.org/T139191) (owner: 10Bartosz Dziewoński) [22:04:38] (03PS1) 10Jforrester: build: Upgrade to eslint 5.x [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444321