[00:03:05] (03PS1) 10Reedy: Fix wikimediafoundation link [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446512 (https://phabricator.wikimedia.org/T199812) [00:03:59] (03Abandoned) 10Reedy: Fix wikimediafoundation link [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446512 (https://phabricator.wikimedia.org/T199812) (owner: 10Reedy) [00:12:59] (03CR) 10Bartosz Dziewoński: "Hmm, maybe it is desktop-specific (although that may change in the future), but it needs to apply to all desktop targets, and not just Des" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444004 (https://phabricator.wikimedia.org/T194725) (owner: 10Bartosz Dziewoński) [00:24:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Page_Forms, 10User-Ryasmeen: Provide an integration of VisualEditor for Page Forms - https://phabricator.wikimedia.org/T131686 (10Yaron_Koren) 05Open>03Resolved I'm happy to mark this as resolved, with the official launch of the VEForAll... [00:32:28] 10Cite, 10Contributors-Team, 10Growth-Team, 10MediaWiki-Configuration, and 6 others: Support listing modules in extension.json that are registered iff another extension is installed - https://phabricator.wikimedia.org/T128012 (10Krinkle) [00:46:44] 10VisualEditor-Media, 10VisualEditor (Current work): [Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog is appearing at the bottom of the dialog for a split second while editing an image - https://phabricator.wikimedia.org/T199841 (10matmarex) [00:46:53] (03PS1) 10Bartosz Dziewoński: ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446516 (https://phabricator.wikimedia.org/T185944) [00:51:29] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446516 (https://phabricator.wikimedia.org/T185944) (owner: 10Bartosz Dziewoński) [00:54:13] (03PS3) 10Bartosz Dziewoński: Update VE core submodule to master (8d0ab0587) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446218 (https://phabricator.wikimedia.org/T185745) (owner: 10Jforrester) [00:55:41] (03CR) 10Bartosz Dziewoński: [C: 032] "Should pass now (hopefully)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446218 (https://phabricator.wikimedia.org/T185745) (owner: 10Jforrester) [01:14:05] (03Merged) 10jenkins-bot: Update VE core submodule to master (8d0ab0587) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446218 (https://phabricator.wikimedia.org/T185745) (owner: 10Jforrester) [01:17:32] (03CR) 10jenkins-bot: Update VE core submodule to master (8d0ab0587) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446218 (https://phabricator.wikimedia.org/T185745) (owner: 10Jforrester) [03:28:53] 10VisualEditor-Media, 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog are appearing at the bottom of the dialog for a split second while editing an image - https://phabricator.wikimedia.org/T199841 (10Ryasmeen) [04:24:43] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel: Rebaser: A SurfaceSynchronizer sometimes receives newChange before registered/initDoc - https://phabricator.wikimedia.org/T185745 (10Jdforrester-WMF) [04:27:12] 10VisualEditor-DataModel, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Performance, 10VisualEditor (Current work): Provide a way to compact multiple transactions into one - https://phabricator.wikimedia.org/T188026 (10Jdforrester-WMF) [04:30:54] (03PS2) 10Jforrester: ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446516 (https://phabricator.wikimedia.org/T185944) (owner: 10Bartosz Dziewoński) [04:31:12] (03CR) 10Jforrester: [C: 032] ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446516 (https://phabricator.wikimedia.org/T185944) (owner: 10Bartosz Dziewoński) [04:32:26] 10VisualEditor-Media, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Regression, 10VisualEditor (Current work): [Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog are appearing at the bottom of the dialog for... - https://phabricator.wikimedia.org/T199841 [04:51:51] (03Merged) 10jenkins-bot: ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446516 (https://phabricator.wikimedia.org/T185944) (owner: 10Bartosz Dziewoński) [04:55:16] (03CR) 10jenkins-bot: ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446516 (https://phabricator.wikimedia.org/T185944) (owner: 10Bartosz Dziewoński) [06:02:02] (03PS1) 10Jforrester: ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess [extensions/VisualEditor] (wmf/1.32.0-wmf.13) - 10https://gerrit.wikimedia.org/r/446529 (https://phabricator.wikimedia.org/T185944) [06:19:52] (03CR) 10Jforrester: [C: 032] "Boo, more tech debt. :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444004 (https://phabricator.wikimedia.org/T194725) (owner: 10Bartosz Dziewoński) [06:36:57] (03Merged) 10jenkins-bot: Apply edit surface jQuery.makeCollapsible overrides to visual diffs too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444004 (https://phabricator.wikimedia.org/T194725) (owner: 10Bartosz Dziewoński) [06:40:03] (03CR) 10jenkins-bot: Apply edit surface jQuery.makeCollapsible overrides to visual diffs too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/444004 (https://phabricator.wikimedia.org/T194725) (owner: 10Bartosz Dziewoński) [07:53:01] 10VisualEditor-DataModel, 10Patch-For-Review, 10VisualEditor (Current work): ve.dm.InternalList#sortGroupIndexes throws javascript error - https://phabricator.wikimedia.org/T191011 (10Arrbee) @Catrope Hello, did you manage to take another look at this? Looks like we added a one more blocked ticket to the lis... [08:08:30] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10VisualEditor (Current work): Collapsed tables broken in visual diff - https://phabricator.wikimedia.org/T194725 (10Jdforrester-WMF) [09:19:07] 10VisualEditor, 10Regression: [Regression wmf.13] Input field getting both red and blue highlight at the same time in Citation dialog - https://phabricator.wikimedia.org/T199838 (10Peachey88) [11:17:53] (03PS1) 10Santhosh: ve.dm.MWInlineImageNode: Fix undefined data-mw in toDomElements output [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446575 (https://phabricator.wikimedia.org/T198941) [11:21:18] (03CR) 10Santhosh: "Before the fix: https://i.imgur.com/sZlipfO.png" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446575 (https://phabricator.wikimedia.org/T198941) (owner: 10Santhosh) [11:51:34] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), and 5 others: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype - https://phabricator.wikimedia.org/T124305 (10... [11:59:08] (03PS2) 10Jforrester: Move annotation nail functionality to a mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446277 (owner: 10Esanders) [12:09:59] 10VisualEditor-Media, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): [Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog are appearing at the b... - https://phabricator.wikimedia.org/T199841 [12:18:46] (03CR) 10Divec: [C: 04-1] "Looking good. We should test carefully when we get to the point of adding annotations that could potentially nest/overlap (i.e. we don't n" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446277 (owner: 10Esanders) [12:22:20] (03PS2) 10Divec: WIP: More test cases for squashing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/445612 (https://phabricator.wikimedia.org/T188026) [12:30:35] (03CR) 10jerkins-bot: [V: 04-1] WIP: More test cases for squashing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/445612 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [12:33:34] (03CR) 10Jforrester: "Looks like one (or more) of these tests are too expensive, causing the browser to infinite loop or at least take too long to response?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/445612 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [12:36:15] 10VisualEditor, 10Wikimedia-Site-requests, 10User-Zoranzoki21: Enable visual editor at fi.wikibooks.org - https://phabricator.wikimedia.org/T192135 (10Zoranzoki21) a:03Zoranzoki21 Hi @Zache, I no know, but I will enable it tomorrow if my request for it be accepted. [12:43:53] 10VisualEditor, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Zoranzoki21: Enable visual editor at fi.wikibooks.org - https://phabricator.wikimedia.org/T192135 (10Zoranzoki21) Scheduled for tomorrow SWAT deployment between 13:00-14:00 per UTC+2 timezone. [13:42:50] (03CR) 10Esanders: [C: 032] "Oops!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446575 (https://phabricator.wikimedia.org/T198941) (owner: 10Santhosh) [13:43:08] (03CR) 10Esanders: [C: 032] "This highlights a missing unit tests too" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446575 (https://phabricator.wikimedia.org/T198941) (owner: 10Santhosh) [13:45:18] (03PS3) 10Esanders: Move annotation nail functionality to a mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446277 [13:47:14] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff shows non-minimal diff that could easily be improved - https://phabricator.wikimedia.org/T197928 (10Tchanders) This looks the same as T187589 and is probably due to something in the diff-patch-match library which does the linear diffs. [13:57:48] (03Merged) 10jenkins-bot: ve.dm.MWInlineImageNode: Fix undefined data-mw in toDomElements output [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446575 (https://phabricator.wikimedia.org/T198941) (owner: 10Santhosh) [14:01:06] (03CR) 10jenkins-bot: ve.dm.MWInlineImageNode: Fix undefined data-mw in toDomElements output [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446575 (https://phabricator.wikimedia.org/T198941) (owner: 10Santhosh) [14:09:03] 10TemplateData, 10VisualEditor, 10Parsoid: VisualEditor manipulation based on TemplateData source code formatting does not handle newlines before and after correctly - https://phabricator.wikimedia.org/T199849 (10Esanders) [15:22:54] (03CR) 10Divec: [C: 032] Move annotation nail functionality to a mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446277 (owner: 10Esanders) [15:27:49] (03Merged) 10jenkins-bot: Move annotation nail functionality to a mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446277 (owner: 10Esanders) [15:34:05] (03CR) 10jenkins-bot: Move annotation nail functionality to a mixin [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446277 (owner: 10Esanders) [16:07:55] 10VisualEditor: Display template names without the "Generated from:" prefix in template inspectors - https://phabricator.wikimedia.org/T199923 (10Pginer-WMF) [16:47:02] 10VisualEditor, 10Growth-Team, 10Parsoid, 10StructuredDiscussions: {{!}} is not working on Parsoid - https://phabricator.wikimedia.org/T199718 (10kostajh) [16:47:31] (03CR) 10Esanders: [C: 032] selenium: disable beta dialog popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/445963 (https://phabricator.wikimedia.org/T199644) (owner: 10Hashar) [16:53:19] 10VisualEditor: Be able to insert horizontal rules (
or ----) - https://phabricator.wikimedia.org/T199925 (10Whatamidoing-WMF) [16:53:58] 10VisualEditor, 10Growth-Team, 10Parsoid, 10StructuredDiscussions: {{!}} is not working on Parsoid - https://phabricator.wikimedia.org/T199718 (10ssastry) >>! In T199718#4431524, @Sbailey wrote: > So on my development Parsoid (some configuration info is not the same as production), I cannot reproduce this... [17:09:25] 10VisualEditor: Toolbar menu positioning broken when zoom level > 100% - https://phabricator.wikimedia.org/T199752 (10Esanders) Maybe just Chrome only. [17:10:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Bold and big not highlighted correctly in the 2017WTE - https://phabricator.wikimedia.org/T199740 (10Esanders) We disabled the bold/italic rules as in some browsers (probably IE) they were caus... [17:15:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-CodeMirror: Bold and big not highlighted correctly in the 2017WTE - https://phabricator.wikimedia.org/T199740 (10Niharika) [17:29:44] 10VisualEditor, 10ContentTranslation, 10Language-2018-July-September: CX2: Uncaught TypeError: Cannot read property 'element' of null - https://phabricator.wikimedia.org/T197845 (10KartikMistry) It seems T198826 is merged and deployed. We should check this again if that's fixing this issue? [17:34:51] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), and 5 others: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype - https://phabricator.wikimedia.org/T124305 (10... [17:47:46] (03PS1) 10Esanders: Use opacity for comment annotation background [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446629 [17:47:48] (03PS1) 10Esanders: Mixin NailedAnnotation to CommentAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446630 [17:48:47] (03CR) 10Esanders: [C: 04-1] "As David predicted, this exposes some weird behaviour with overlapping NailedAnnotations :/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446630 (owner: 10Esanders) [17:54:32] 10VisualEditor: Overlapping NailedAnnotations don't work very well - https://phabricator.wikimedia.org/T199934 (10Esanders) [17:54:50] (03CR) 10Esanders: [C: 04-1] "See T199934" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446630 (owner: 10Esanders) [17:56:46] (03CR) 10jerkins-bot: [V: 04-1] Mixin NailedAnnotation to CommentAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446630 (owner: 10Esanders) [18:20:30] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual diff fails with "jQuery.Deferred exception: listContents is undefined" - https://phabricator.wikimedia.org/T199298 (10Tchanders) It already is giving us a CommentMetaItem... Sounds like it's related to T189543 [18:58:04] 10VisualEditor, 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, 10Design: increase the line spacing in Flow's VisualEditor - https://phabricator.wikimedia.org/T95858 (10EBernhardson) [19:05:58] 10VisualEditor, 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: Click outside to close doesn't always work as intended for mention inspector - https://phabricator.wikimedia.org/T94109 (10EBernhardson) [19:06:49] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 10CX-cxserver, and 7 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676 (10EBernhardson) [19:08:25] 10VisualEditor, 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions: Flow shows different values for magic words after the comment is saved (compared to VE preview) - https://phabricator.wikimedia.org/T95681 (10EBernhardson) [19:25:09] 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10Design, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), and 5 others: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype - https://phabricator.wikimedia.org/T124305 (10... [19:41:18] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 10Multimedia, and 5 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10hashar) [20:16:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446676 (owner: 10L10n-bot) [20:36:14] 10Cite, 10TCB-Team, 10German-Community-Wishlist, 10Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840 (10cscott) Just for reference, see also {T146072}. It *may* be that we can collaborate on im... [20:37:56] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10Parsoid (Section-Editing-Support): Parsoid DOM spec: Improve Cite representation to support section editing & simpler clients - https://phabricator.wikimedia.org/T146072 (10cscott) WMDE would like to think about cita... [20:43:38] 10VisualEditor-Media, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10Regression, and 2 others: [Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog are appearing at the bottom of the dialog... - https://phabricator.wikimedia.org/T199841 [21:12:29] 10Editing-team, 10MediaWiki-extensions-Babel, 10Regression, 10Wikimedia-log-errors: Fatal MWException in Babel: "Language::isValidBuiltInCode must be passed a string" - https://phabricator.wikimedia.org/T199941 (10greg) +#editing-team per Developers/Maintainers mw.org page. [21:44:16] 10Editing-team, 10MediaWiki-extensions-Babel, 10Regression, 10Wikimedia-log-errors: Fatal MWException in Babel: "Language::isValidBuiltInCode must be passed a string" - https://phabricator.wikimedia.org/T199941 (10MarcoAurelio) I've found two recent patches to Core that added some language code checks: *... [23:00:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOUI, 10Regression: [Regression wmf.13] Input field getting both red and blue highlight at the same time in Citation dialog - https://phabricator.wikimedia.org/T199838 (10matmarex) There are actually two issues here: 1. OOUI styling for focussed multiline text in... [23:07:19] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.32.0-wmf.13) - 10https://gerrit.wikimedia.org/r/446529 (https://phabricator.wikimedia.org/T185944) (owner: 10Jforrester) [23:26:11] (03Merged) 10jenkins-bot: ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess [extensions/VisualEditor] (wmf/1.32.0-wmf.13) - 10https://gerrit.wikimedia.org/r/446529 (https://phabricator.wikimedia.org/T185944) (owner: 10Jforrester) [23:27:53] (03PS1) 10Divec: WIP: Make undo concurrency-aware [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446706 [23:30:32] 10VisualEditor-MediaWiki, 10OOUI, 10Regression, 10VisualEditor (Current work): [Regression wmf.13] Input field getting both red and blue highlight at the same time in Citation dialog - https://phabricator.wikimedia.org/T199838 (10matmarex) a:03matmarex [23:32:53] (03CR) 10jerkins-bot: [V: 04-1] WIP: Make undo concurrency-aware [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446706 (owner: 10Divec) [23:44:38] (03PS1) 10Bartosz Dziewoński: ve.ui.MWTemplateDialog: Prevent focus changes in the setup process [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446708 (https://phabricator.wikimedia.org/T199838) [23:48:09] 10VisualEditor-Media, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10Regression, and 2 others: [Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog are appearing at the bottom of the dialog... - https://phabricator.wikimedia.org/T199841 [23:48:38] 10VisualEditor-MediaWiki, 10OOUI, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): [Regression wmf.13] Input field getting both red and blue highlight at the same time in Citation dialog - https://phabricator.wikimedia.org/T199838 (10matmarex)