[02:44:38] (03CR) 10Krinkle: [C: 032] Don't use PAGE_IMAGES_INSTALLED [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/447926 (https://phabricator.wikimedia.org/T200381) (owner: 10Legoktm) [03:02:38] (03Merged) 10jenkins-bot: Don't use PAGE_IMAGES_INSTALLED [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/447926 (https://phabricator.wikimedia.org/T200381) (owner: 10Legoktm) [03:05:25] (03CR) 10jenkins-bot: Don't use PAGE_IMAGES_INSTALLED [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/447926 (https://phabricator.wikimedia.org/T200381) (owner: 10Legoktm) [03:38:09] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Editing a page using visual editor removes captions of inline images - https://phabricator.wikimedia.org/T200214 (10Cirdan) p:05Unbreak!>03Normal... [07:31:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Javascript error when opening a page with ?action=edit - https://phabricator.wikimedia.org/T200368 (10Schnark) Maybe related or even a duplicate: {T199484}, which also fails on `range.start`, where `range` is `null`. [08:09:29] 10VisualEditor, 10ContentTranslation, 10Language-2018-July-September: CX2: Uncaught TypeError: Cannot read property 'element' of null - https://phabricator.wikimedia.org/T197845 (10KartikMistry) I can't reproduce this no longer (Both original issue and Yandex issues). So, this is unblocked and can be closed. [08:17:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/447990 (owner: 10L10n-bot) [09:01:19] 10VisualEditor, 10ContentTranslation, 10Language-2018-July-September, 10User-Ryasmeen: CX2: Uncaught TypeError: Cannot read property 'element' of null - https://phabricator.wikimedia.org/T197845 (10Arrbee) 05Open>03Resolved a:03Arrbee [09:01:33] 10VisualEditor, 10ContentTranslation, 10Language-2018-July-September, 10User-Ryasmeen: CX2: Uncaught TypeError: Cannot read property 'element' of null - https://phabricator.wikimedia.org/T197845 (10Arrbee) a:05Arrbee>03None [12:48:36] 10WikiEditor, 10CodeEditor, 10MediaWiki-extensions-CodeMirror, 10Accessibility, and 2 others: Add toggle/state buttons to WikiEditor - https://phabricator.wikimedia.org/T198781 (10Trizek-WMF) How that task can be explained in one simple sentence? When will it be deployed? [12:57:06] (03PS3) 10Petar.petkovic: Make link annotations more flexible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440843 (https://phabricator.wikimedia.org/T195064) [12:59:22] (03CR) 10Petar.petkovic: Make link annotations more flexible (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440843 (https://phabricator.wikimedia.org/T195064) (owner: 10Petar.petkovic) [13:12:31] (03PS4) 10Petar.petkovic: Make link annotations more flexible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440843 (https://phabricator.wikimedia.org/T195064) [13:26:28] 10VisualEditor: rebaser: Handle document changes in the same session - https://phabricator.wikimedia.org/T200427 (10Esanders) [13:38:39] 10VisualEditor: rebaser: Connecting to a document tries to repaint every cursor position in history - https://phabricator.wikimedia.org/T200429 (10Esanders) [13:39:21] (03PS1) 10Esanders: ce.Surface: Debounce position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448039 (https://phabricator.wikimedia.org/T200429) [13:42:22] (03PS2) 10Esanders: Pull through check list support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/447223 [13:51:29] (03CR) 10jerkins-bot: [V: 04-1] Pull through check list support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/447223 (owner: 10Esanders) [14:14:43] 10WikiEditor, 10CodeEditor, 10MediaWiki-extensions-CodeMirror, 10Accessibility, and 2 others: Add toggle/state buttons to WikiEditor - https://phabricator.wikimedia.org/T198781 (10Esanders) "Make toolbar toggle buttons more accessible"? [14:49:28] (03PS6) 10Esanders: CollabTarget: Add convert to wikitext dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354871 [14:56:29] (03CR) 10Jforrester: [C: 031] ce.Surface: Debounce position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448039 (https://phabricator.wikimedia.org/T200429) (owner: 10Esanders) [14:58:14] 10VisualEditor, 10VisualEditor-MediaWiki: rebaser: Export collabpad directly to a wiki page - https://phabricator.wikimedia.org/T200438 (10Esanders) [15:07:17] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 (owner: 10Esanders) [15:10:25] (03CR) 10jerkins-bot: [V: 04-1] Remove EasyDeflate libs, upstreamed to core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 (owner: 10Esanders) [15:29:36] (03PS2) 10Jforrester: Remove EasyDeflate libs, upstreamed to core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 (owner: 10Esanders) [15:30:22] (03PS3) 10Jforrester: Remove EasyDeflate libs, upstreamed to core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 (owner: 10Esanders) [15:31:39] (03CR) 10Jforrester: CollabTarget: Add convert to wikitext dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/354871 (owner: 10Esanders) [15:32:28] (03CR) 10Legoktm: [C: 04-1] Remove EasyDeflate libs, upstreamed to core (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 (owner: 10Esanders) [15:44:15] (03CR) 10Jforrester: Remove EasyDeflate libs, upstreamed to core (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 (owner: 10Esanders) [15:48:22] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), 10Regression, 10VisualEditor (Current work): Editing a page using visual editor removes captions of inline images - https://phabricator.wikimedia.org/T200214 (10Jdforrester-WMF) [15:58:49] (03CR) 10DLynch: [C: 032] ce.Surface: Debounce position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448039 (https://phabricator.wikimedia.org/T200429) (owner: 10Esanders) [16:03:54] (03Merged) 10jenkins-bot: ce.Surface: Debounce position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448039 (https://phabricator.wikimedia.org/T200429) (owner: 10Esanders) [16:05:26] Kemayo: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/447229 would be good… :-) [16:06:33] Let me take a look... [16:10:53] (03CR) 10jenkins-bot: ce.Surface: Debounce position events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448039 (https://phabricator.wikimedia.org/T200429) (owner: 10Esanders) [16:38:43] (03PS1) 10DLynch: Add Horizontal Rules to the insert menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448067 (https://phabricator.wikimedia.org/T199925) [16:38:45] (03PS1) 10DLynch: Clean up after sequence insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) [16:40:34] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (740285b11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/447229 (owner: 10Jforrester) [16:41:13] (03CR) 10Jforrester: Add Horizontal Rules to the insert menu (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448067 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [16:42:14] (03CR) 10DLynch: Add Horizontal Rules to the insert menu (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448067 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [16:43:55] (03CR) 10jerkins-bot: [V: 04-1] Clean up after sequence insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [16:45:07] (03PS1) 10Jforrester: build: Update mediawiki/mediawiki-codesniffer to 21.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/448070 [16:49:21] (03CR) 10jerkins-bot: [V: 04-1] Add Horizontal Rules to the insert menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448067 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [16:49:37] (03PS2) 10DLynch: Add Horizontal Rules to the insert menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448067 (https://phabricator.wikimedia.org/T199925) [16:49:39] (03PS2) 10DLynch: Clean up after sequence insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) [16:54:43] (03PS1) 10DLynch: Add horizontal rule sequence (----) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/448074 (https://phabricator.wikimedia.org/T199925) [17:03:24] (03Merged) 10jenkins-bot: Update VE core submodule to master (740285b11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/447229 (owner: 10Jforrester) [17:06:16] (03CR) 10jenkins-bot: Update VE core submodule to master (740285b11) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/447229 (owner: 10Jforrester) [17:31:21] 10VisualEditor, 10VisualEditor-ContentEditable, 10ContentTranslation: CX2: Cannot edit caption below the video - https://phabricator.wikimedia.org/T200453 (10Petar.petkovic) [18:00:48] 10VisualEditor, 10VisualEditor-Links, 10Browser-Support-Internet-Explorer: VisualEditor linking doesn’t work in IE11 - https://phabricator.wikimedia.org/T200455 (10Tacsipacsi) [18:01:26] (03CR) 10Esanders: [C: 04-1] Clean up after sequence insertion (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [18:03:15] (03PS4) 10Esanders: Remove EasyDeflate libs, upstreamed to core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 [18:06:25] (03PS5) 10Esanders: Remove EasyDeflate libs, upstreamed to core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 [18:08:51] (03PS1) 10Jforrester: Update VE core submodule to master (218cad9c7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/448088 (https://phabricator.wikimedia.org/T200429) [18:10:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-CodeMirror: Bold and big not highlighted correctly in the 2017WTE - https://phabricator.wikimedia.org/T199740 (10Whatamidoing-WMF) Section headings get a larger font in the 2010 WTE: {F24163947} so presumably text is not re... [18:14:31] 10VisualEditor, 10Parsoid: VisualEditor losing Media: links - https://phabricator.wikimedia.org/T198511 (10Whatamidoing-WMF) I'm seeing the same problem, but it's not functional. See https://en.wikipedia.org/w/index.php?title=User:Whatamidoing_(WMF)/sandbox&diff=852111094&oldid=852110412&diffmode=source and h... [18:15:24] (03CR) 10Esanders: "We need to remove the CX dependency first: I0fa382c2828ff2644ed308dc1ccca85735d0a80d" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 (owner: 10Esanders) [18:18:56] (03PS6) 10Jforrester: Remove EasyDeflate libs, upstreamed to core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/439489 (owner: 10Esanders) [18:33:58] 10VisualEditor, 10Parsoid:
tags get nowiki'd - https://phabricator.wikimedia.org/T200457 (10Whatamidoing-WMF) [19:01:19] 10VisualEditor, 10Parsoid:
tags get nowiki'd - https://phabricator.wikimedia.org/T200457 (10Arlolra) Hmm, we have tests for serializing LST since it's enable on the WMF cluster https://github.com/wikimedia/parsoid/blob/master/tests/parserTests.txt#L25152-L25184 Maybe this is specific to their wiki c... [19:24:56] 10VisualEditor, 10VisualEditor-ContentEditable, 10ContentTranslation: CX2: Cannot edit videos - https://phabricator.wikimedia.org/T200453 (10Esanders) [19:36:18] 10VisualEditor, 10VisualEditor-ContentEditable, 10ContentTranslation: CX2: Cannot edit videos - https://phabricator.wikimedia.org/T200453 (10Esanders) Two issues: 1. In the client, cxFigure isn't inheriting properly from mwBlockImage. 2. On the server, the empty around the