[02:39:26] 10VisualEditor: Cannot read property 'getOffset' of null - https://phabricator.wikimedia.org/T199754 (10matmarex) [02:39:41] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Cannot read property 'getOffset' of null - https://phabricator.wikimedia.org/T199754 (10matmarex) a:03matmarex [02:47:58] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Handle null native selections in #getSelectionState and #showSelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449392 (https://phabricator.wikimedia.org/T199011) [02:48:02] (03PS1) 10Bartosz Dziewoński: Remove unused second parameters to ve.ce.Document#getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449393 (https://phabricator.wikimedia.org/T199754) [15:00:19] (03CR) 10Divec: [C: 032] "> Patch Set 1:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [15:06:59] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.TransactionProcessor: Fix edge case handling, avoid ES6 methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [15:09:06] (03CR) 10Bartosz Dziewoński: [C: 032] "(retrying)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [15:19:27] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.TransactionProcessor: Fix edge case handling, avoid ES6 methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [15:27:43] (03CR) 10Bartosz Dziewoński: [C: 032] "Let's try once more before we start investigating why it's randomly failing…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [15:50:35] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.TransactionProcessor: Fix edge case handling, avoid ES6 methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [15:59:39] 10VisualEditor, 10VisualEditor-Tables, 10Accessibility, 10WCAG-Level-A: In VE table editor, cannot move cursor out of caption area using keyboard - https://phabricator.wikimedia.org/T181416 (10Volker_E) @DLynch It's insofar weird, as you can move with the up arrow key into the caption, but with down not in... [16:04:54] (03PS2) 10Esanders: ve.ce.Surface: Handle null native selections in #getSelectionState and #showSelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449392 (https://phabricator.wikimedia.org/T199011) (owner: 10Bartosz Dziewoński) [16:08:31] (03CR) 10Esanders: [C: 04-1] "Looks good." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449392 (https://phabricator.wikimedia.org/T199011) (owner: 10Bartosz Dziewoński) [16:27:43] (03PS3) 10DLynch: Add Horizontal Rule insert command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448067 (https://phabricator.wikimedia.org/T199925) [16:27:45] (03PS3) 10DLynch: Clean up after sequence insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) [16:28:27] (03PS2) 10DLynch: Add horizontal rule sequence (----) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/448074 (https://phabricator.wikimedia.org/T199925) [16:46:06] 10VisualEditor, 10VisualEditor-Tables, 10Accessibility, 10WCAG-Level-A: In VE table editor, cannot move cursor out of caption area using keyboard - https://phabricator.wikimedia.org/T181416 (10DLynch) Actually, new development, T200525 made it so that arrows will move out of it. [16:47:10] 10VisualEditor, 10ContentTranslation, 10Patch-For-Review: Allow cursoring between active nodes - https://phabricator.wikimedia.org/T200525 (10DLynch) For the table caption case, should we special case it so that it jumps the selection into the table rather than skipping it? [16:47:28] 10VisualEditor: Clicking to the left of a line moves the cursor few lines above in some cases - https://phabricator.wikimedia.org/T200819 (10Ryasmeen) [16:47:56] (03CR) 10jerkins-bot: [V: 04-1] Clean up after sequence insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [16:48:57] (03CR) 10DLynch: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [16:49:58] The current level of tests failing due to the browser timing out is a bit of a pain. [16:54:44] yeah. do they ever pass, actually? flaky or straight broken? [16:54:49] (03CR) 10Bartosz Dziewoński: [C: 032] ve.dm.TransactionProcessor: Fix edge case handling, avoid ES6 methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [16:55:31] (03CR) 10jerkins-bot: [V: 04-1] Clean up after sequence insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [16:55:57] MatmaRex: They do occasionally pass, so I'd say flaky. [16:56:42] Just... very flaky currently. [16:59:30] 10VisualEditor: action=edit does not show deletion log, where applicable - https://phabricator.wikimedia.org/T176070 (10DLynch) Am I right in thinking that T199087 is a duplicate of this? Because I have a patch for that which gets us: {F23685615} [17:00:56] (03CR) 10jerkins-bot: [V: 04-1] Add Horizontal Rule insert command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448067 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [17:03:12] hallo [17:03:30] There's a new message to translate: Visualeditor-listbutton-check-tooltip [17:03:41] it says: "Check list" [17:03:45] what is it exactly? [17:03:50] (03Merged) 10jenkins-bot: ve.dm.TransactionProcessor: Fix edge case handling, avoid ES6 methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [17:04:00] Where does it appear? [17:04:03] qqq doesn't make it clear [17:04:24] we're in a meeting, i'll go find out in a minute [17:05:25] It looks like it might be a specialized list type where there's a checkbox by the list item, like a todo list app. [17:06:40] Kemayo: that's one possibility, which I considered. It could also be a list of things to check, in a completely different context, in which case the translation will be different, too. I can wait patiently and hear from the people who made it :) [17:12:05] Reading the code, I think that's it. edsanders can confirm, though. [17:13:17] Kemayo: thanks. can I test it anywhere, by any chance? [17:13:22] Yes, it's what Kemayo said, a todo-style list [17:18:06] I think it’s not actually exposed anywhere yet, edsanders? [17:24:36] 10Cite, 10Design, 10Need-volunteer: Resolve inconsistent numbering of references in text and in bibliography - https://phabricator.wikimedia.org/T198021 (10thiemowmde) > This is achieved through the use of group parameter […] It looks like this feature was added in 2010 via {T24265}. Notice the discussion th... [17:26:34] (03CR) 10jenkins-bot: ve.dm.TransactionProcessor: Fix edge case handling, avoid ES6 methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449269 (https://phabricator.wikimedia.org/T200455) (owner: 10Bartosz Dziewoński) [17:38:20] 10VisualEditor: action=edit does not show deletion log, where applicable - https://phabricator.wikimedia.org/T176070 (10MusikAnimal) >>! In T176070#4466014, @DLynch wrote: > Am I right in thinking that T199087 is a duplicate of this? Because I have a patch for that which gets us: > > F23685615 That gives us th... [17:38:43] (03CR) 10Legoktm: [C: 04-1] Don't use MagicWord static methods (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/449244 (https://phabricator.wikimedia.org/T200247) (owner: 10simetrical) [17:42:54] (03PS4) 10simetrical: Don't use deprecated MagicWord static methods [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/449244 (https://phabricator.wikimedia.org/T200247) [17:43:05] (03CR) 10simetrical: Don't use deprecated MagicWord static methods (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/449244 (https://phabricator.wikimedia.org/T200247) (owner: 10simetrical) [17:45:02] (03CR) 10Legoktm: [C: 032] Don't use deprecated MagicWord static methods [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/449244 (https://phabricator.wikimedia.org/T200247) (owner: 10simetrical) [17:55:43] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10OOUI (OOUI-0.27.6), 10Regression, and 5 others: [Regression wmf.13] Input field getting both red and blue highlight at the same time in Citation dialog - https://phabricator.wikimedia.org/T199838 (10Ryasmeen) [18:20:46] 10VisualEditor-Links, 10Browser-Support-Internet-Explorer, 10VisualEditor (Current work): VisualEditor linking doesn’t work in IE11 - https://phabricator.wikimedia.org/T200455 (10matmarex) [18:34:24] 10Cite, 10Design, 10Need-volunteer: Resolve inconsistent numbering of references in text and in bibliography - https://phabricator.wikimedia.org/T198021 (10Huji) Like you, @thiemowmde, I am not a big fan of the `Cite_link_label_group-*` idea to begin with. T196828 was indeed my first proposal to at least mak... [18:36:24] 10VisualEditor-Media, 10VisualEditor (Current work): VisualEditor losing Media: links - https://phabricator.wikimedia.org/T198511 (10Deskana) p:05Triage>03High Fairly bad. [18:37:33] 10VisualEditor: VisualEditor: Template converted to span tags at Javanese Wikipedia - https://phabricator.wikimedia.org/T64411 (10Deskana) 05stalled>03Invalid No steps to reproduce given in the past three years. [18:38:15] 10VisualEditor, 10Browser-Support-Firefox: VisualEditor: Firefox displays new lists incorrectly, if you've just pasted the text onto the page - https://phabricator.wikimedia.org/T67014 (10Deskana) 05stalled>03declined [18:40:27] 10VisualEditor: Editing parameters of a multiref template within a reference is not recognised as a change to the reference - https://phabricator.wikimedia.org/T73969 (10Deskana) 05stalled>03declined This template is barely used anywhere any more (~30 articles?), was probably never used widely anyway, and I... [18:40:44] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 10Browser-Support-Google-Chrome: VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Cirdan) [18:41:22] 10VisualEditor: VisualEditor: Babel box not updated correctly upon editing - https://phabricator.wikimedia.org/T63356 (10Deskana) 05stalled>03Open p:05Triage>03Low [18:42:00] 10VisualEditor: VisualEditor: What you put into the template editor is not what it gives back (more Babel box bugs) - https://phabricator.wikimedia.org/T64746 (10Deskana) 05stalled>03Open p:05Triage>03Low [18:43:04] 10VisualEditor: VisualEditor: If you insert a gallery into a list, the list formatting remains visible but is removed in wikitext - https://phabricator.wikimedia.org/T67022 (10Deskana) 05stalled>03Open p:05Triage>03Low [18:44:19] 10VisualEditor: VisualEditor: Provide ability to deal easily with dead links - https://phabricator.wikimedia.org/T71547 (10Deskana) 05stalled>03Open p:05Triage>03Low [18:46:58] 10VisualEditor-MediaWiki-Templates, 10OOUI, 10Browser-Support-Google-Chrome, 10VisualEditor (Current work): VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Deskana) p:05Triage>03Normal That's strange... [18:48:07] (03CR) 10jerkins-bot: [V: 04-1] Don't use deprecated MagicWord static methods [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/449244 (https://phabricator.wikimedia.org/T200247) (owner: 10simetrical) [18:50:04] 10Editing-team, 10MediaWiki-extensions-Score, 10Wikimedia-log-errors: PHP Notice: Undefined index from line 507 of includes/Score.php - https://phabricator.wikimedia.org/T200835 (10Krinkle) [18:53:54] 10Editing-team, 10MediaWiki-extensions-Quiz, 10Wikimedia-log-errors: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 - https://phabricator.wikimedia.org/T196684 (10Krinkle) [18:54:22] 10Editing-team, 10MediaWiki-extensions-Quiz, 10Wikimedia-log-errors: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 - https://phabricator.wikimedia.org/T196684 (10Krinkle) Still seen. About 50 records in Logstash July 2018. Errors such as these make it harder to detect and prevent... [18:55:56] 10VisualEditor-MediaWiki-Templates, 10OOUI, 10Browser-Support-Google-Chrome, 10VisualEditor (Current work): VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Cirdan) I investigated this a bit further and it seems that the large boxes on... [18:56:49] 10VisualEditor, 10VisualEditor-ContentEditable: Visual Editor messes up paragraphs when switching between source and visual - https://phabricator.wikimedia.org/T200561 (10Deskana) 05Open>03stalled p:05Triage>03Normal I can't reproduce this problem. I made a page with this source text in the 2010 wikite... [18:57:52] 10VisualEditor, 10ContentTranslation, 10Patch-For-Review: Allow cursoring between active nodes - https://phabricator.wikimedia.org/T200525 (10Deskana) I don't understand what this task is about. Can you explain, please? [19:00:30] 10VisualEditor, 10VisualEditor-VisualDiffs: Table row height in the VisualEditor is increased before editing cells, and after editing in VisualDiff - https://phabricator.wikimedia.org/T200476 (10Deskana) p:05Triage>03Low [19:11:32] Kemayo: yeah, it's only used in the collabpad demo [19:37:49] 10VisualEditor, 10VisualEditor-ContentEditable: Visual Editor messes up paragraphs when switching between source and visual - https://phabricator.wikimedia.org/T200561 (10Smalyshev) It doesn't happen every time, unfortunately. I am not sure yet what is the trigger, but it happens to me a lot when I am editing.... [20:01:43] 10Cite, 10RemexHtml, 10Tidy: in ordered list or unordered list closes surrounding element - https://phabricator.wikimedia.org/T27939 (10Izno) Remex outputs some giggle-worthy soup, which isn't even valid HTML: ```
  • Item 1
      (03PS3) 10Bartosz Dziewoński: ve.ce.Surface: Handle null native selections in #getSelectionState and #showSelectionState [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449392 (https://phabricator.wikimedia.org/T199011) [23:02:21] (03CR) 10Bartosz Dziewoński: ve.ce.Surface: Handle null native selections in #getSelectionState and #showSelectionState (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/449392 (https://phabricator.wikimedia.org/T199011) (owner: 10Bartosz Dziewoński) [23:11:35] (03Merged) 10jenkins-bot: Update VE core submodule to master (086de2707) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449530 (https://phabricator.wikimedia.org/T196521) (owner: 10Bartosz Dziewoński) [23:16:02] (03CR) 10jenkins-bot: Update VE core submodule to master (086de2707) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449530 (https://phabricator.wikimedia.org/T196521) (owner: 10Bartosz Dziewoński) [23:31:34] 10VisualEditor, 10ContentTranslation, 10Patch-For-Review: Allow cursoring between active nodes - https://phabricator.wikimedia.org/T200525 (10DLynch) @Deskana: "active node" means one which can have cursor focus within it, in a way that's somewhat separate from the general article flow. This patch makes it s... [23:50:32] 10Editing-team, 10Contributors-Team, 10MediaWiki-Logging, 10MediaWiki-Page-editing, 10Wikimedia-log-errors: Unable to open edit page, or view Special:Log, for certain pages ("MWException: Expected title, got null" from LogFormatter.php) - https://phabricator.wikimedia.org/T185049 (10matmarex) I investiga...