[00:49:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/450825 (owner: 10L10n-bot) [02:33:17] 10VisualEditor-Media, 10Parsoid, 10VisualEditor (Current work): VisualEditor losing Media: links - https://phabricator.wikimedia.org/T198511 (10cscott) Looks like Media handling was added back in T151277; we probably should have ensured VE handled these correctly at the same time, but it looks like our focus... [02:57:27] 10VisualEditor-Media, 10Parsoid, 10VisualEditor (Current work): VisualEditor losing Media: links - https://phabricator.wikimedia.org/T198511 (10DLynch) @cscott: Oh, I totally agree that this UX isn't optimal, and that we should add it to @iamjessklein's big pile of VE design thoughts. I'm just happy to fix t... [04:46:26] 10VisualEditor-MediaWiki-Templates, 10OOUI, 10VisualEditor (Current work): VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Cirdan) Just occured in Firefox as well, for a newly created reference: {F24621589} [11:00:40] 10VisualEditor-MediaWiki-Templates, 10OOUI, 10Regression, 10VisualEditor (Current work): VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Esanders) [11:00:48] 10VisualEditor-MediaWiki-Templates, 10OOUI, 10Regression, 10VisualEditor (Current work): VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Esanders) Looks like an OOUI regression. [11:40:33] (03PS1) 10Esanders: Template dialog: Lazy resize multiline text inputs on first focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450946 (https://phabricator.wikimedia.org/T134814) [11:45:42] 10VisualEditor-MediaWiki-Templates, 10OOUI, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Esanders) The above patch will cause all multi-line inputs to be collapsed... [11:46:16] 10VisualEditor-MediaWiki-Templates, 10OOUI, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Esanders) a:03Esanders [12:14:57] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10Esanders) Perhaps the TemplateStyles engineers could help us with this? The styles are only loaded on read pages, but... [12:56:37] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10Tgr) The styles are part of the page content ([[https://ru.wikipedia.org/api/rest_v1/page/html/%D0%A1%D0%B5%D0%B2%D0%... [14:36:18] 10Cite, 10ContentTranslation, 10Tracking: ContentTranslation issues with references (tracking) - https://phabricator.wikimedia.org/T115045 (10Pginer-WMF) [14:53:34] 10VisualEditor, 10Patch-For-Review, 10User-Ryasmeen: rebaser: Make author colours work properly - https://phabricator.wikimedia.org/T200128 (10Esanders) 05Open>03Resolved a:03Esanders [14:56:33] 10VisualEditor, 10Patch-For-Review, 10User-Ryasmeen: rebaser: Author list doesn't always populate fully - https://phabricator.wikimedia.org/T201244 (10Esanders) 05Open>03Resolved a:03Esanders [15:16:39] 10VisualEditor, 10Phabricator, 10Release-Engineering-Team (Kanban), 10User-Ryasmeen: 404 on VisualEditor workboard (due to custom filter applied which did not exist in database) - https://phabricator.wikimedia.org/T199207 (10Esanders) 05Resolved>03Open Unfortunately this is happening again... [15:20:14] 10VisualEditor, 10Phabricator, 10Release-Engineering-Team (Kanban), 10User-Ryasmeen: 404 on VisualEditor workboard (due to custom filter applied which did not exist in database) - https://phabricator.wikimedia.org/T199207 (10Esanders) p:05Unbreak!>03High >>! In T199207#4413718, @Krenair wrote: > For re... [15:20:54] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10Esanders) [15:21:01] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10Esanders) a:03Esanders [15:28:08] 10VisualEditor, 10Design: Clicking the "Change label" button needs to give the user clearer feedback - https://phabricator.wikimedia.org/T201232 (10Esanders) So in the initial design in T124305#3971292 the context is suppressed on click. The main problem with that is the context will reappear on the next conte... [15:33:31] 10Citoid, 10VisualEditor: List of urls unabled to cite - https://phabricator.wikimedia.org/T195080 (10Mvolz) [15:40:22] 10VisualEditor, 10Design: Clicking the "Change label" button needs to give the user clearer feedback - https://phabricator.wikimedia.org/T201232 (10Esanders) A simpler approach might be to hide the "Change label" bar iff the link is fully selected. [15:45:26] (03CR) 10jerkins-bot: [V: 04-1] Mixin NailedAnnotation to Comment/LanguageAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/446630 (owner: 10Esanders) [16:33:52] (03PS1) 10Chris Barnard: Working on Task #T52355 - ve.ui.MWTemplateDialog and ve.ui.MWParameterPage changed. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451020 [16:33:54] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451020 (owner: 10Chris Barnard) [16:58:45] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10User-Ryasmeen, 10VisualEditor (Current work), 10Wikimedia-log-errors: InvalidArgumentException from line 58 of includes/libs/EasyDeflate.php: Data does not begin with def... - https://phabricator.wikimedia.org/T201083 [17:07:34] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (efccd8b41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450658 (https://phabricator.wikimedia.org/T199011) (owner: 10Jforrester) [18:01:03] MatmaRex: https://phabricator.wikimedia.org/T201329 [18:09:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: VisualEditor: Provide support for BLP edit notices on enwiki - https://phabricator.wikimedia.org/T56029 (10Jack_who_built_the_house) Just to make you know: in ruwiki, we adapted RockMFR's "magic editintros" to work with VisualEditor (although the... [18:10:22] looking [18:10:48] ta [18:16:49] MatmaRex: oh and https://phabricator.wikimedia.org/T200834, which I think you worked around in the past [18:35:34] 10VisualEditor: rebaser: Make server crash-proof - https://phabricator.wikimedia.org/T201320 (10Deskana) p:05Triage>03Low [18:35:38] 10VisualEditor: rebaser: Disable synchronizer while surface is staging - https://phabricator.wikimedia.org/T201319 (10Deskana) p:05Triage>03Low [18:36:41] 10VisualEditor, 10Design: Clicking the "Change label" button needs to give the user clearer feedback - https://phabricator.wikimedia.org/T201232 (10Deskana) p:05Triage>03Low [18:44:24] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-Parser, 10Parsoid: [[?oldid=851713451]] is a valid link in the new preview, but not when the page is saved - https://phabricator.wikimedia.org/T201072 (10Deskana) p:05Triage>03Low [18:45:00] 10VisualEditor: Back button navigation to NWE doesn't restore section editing - https://phabricator.wikimedia.org/T201019 (10Deskana) p:05Triage>03Low [18:47:15] 10VisualEditor, 10VisualEditor-EditingTools: support new section editing - https://phabricator.wikimedia.org/T200974 (10Deskana) 05Open>03declined Forcing the visual editor to load in a namespace where it is not enabled is not supported functionality. Additionally, the visual editor is not designed to be u... [18:53:02] 10VisualEditor, 10MediaWiki-Page-editing: Edit-adaptive templates support (no caching when {{REVISIONID}} magic word is met) - https://phabricator.wikimedia.org/T178354 (10Deskana) p:05Triage>03Lowest [18:54:30] 10VisualEditor, 10VisualEditor-MediaWiki: rebaser: Export collabpad directly to a wiki page - https://phabricator.wikimedia.org/T200438 (10Deskana) p:05Triage>03Low [18:54:38] 10VisualEditor: rebaser: Handle document changes in the same session - https://phabricator.wikimedia.org/T200427 (10Deskana) p:05Triage>03Low [18:55:39] 10VisualEditor, 10Gadgets, 10Documentation: Improve documentation on how to write user scripts and gadgets for VisualEditor - https://phabricator.wikimedia.org/T200469 (10Deskana) p:05Triage>03Normal [18:56:01] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (efccd8b41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450658 (https://phabricator.wikimedia.org/T199011) (owner: 10Jforrester) [18:58:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Javascript error when opening a page with ?action=edit - https://phabricator.wikimedia.org/T200368 (10Deskana) I'm going to assume that this is a duplicate of T199484 per @Schnark, and if it's not then this can be reopened. [18:59:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Javascript error when opening a page with ?action=edit - https://phabricator.wikimedia.org/T200368 (10Deskana) [19:16:22] 10VisualEditor: [javascript:] added within references when editing using the VisualEditor - https://phabricator.wikimedia.org/T200971 (10Cirdan) @Deskana Don't you think that a filter such as [[https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/427191/1/modules/ve-mw/init/ve.init.mw.Target.js... [19:31:02] (03Merged) 10jenkins-bot: Update VE core submodule to master (efccd8b41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450658 (https://phabricator.wikimedia.org/T199011) (owner: 10Jforrester) [19:33:53] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Cannot read property 'getOffset' of null - https://phabricator.wikimedia.org/T199754 (10Jdforrester-WMF) [19:33:59] 10VisualEditor, 10User-Ryasmeen: rebaser: Make author colours work properly - https://phabricator.wikimedia.org/T200128 (10Jdforrester-WMF) [19:34:02] 10VisualEditor, 10User-Ryasmeen: rebaser: Hide cursors of disconnected users - https://phabricator.wikimedia.org/T201017 (10Jdforrester-WMF) [19:34:06] 10VisualEditor, 10User-Ryasmeen: rebaser: Author list doesn't always populate fully - https://phabricator.wikimedia.org/T201244 (10Jdforrester-WMF) [19:36:34] (03PS3) 10Esanders: rebaser: Use upstream username persistence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450408 [19:38:20] (03CR) 10Jforrester: [C: 031] rebaser: Use upstream username persistence (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450408 (owner: 10Esanders) [19:38:28] (03CR) 10jenkins-bot: Update VE core submodule to master (efccd8b41) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450658 (https://phabricator.wikimedia.org/T199011) (owner: 10Jforrester) [19:45:53] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10VisualEditor (Current work): Fake slugs appearing under each individual images in a gallery - https://phabricator.wikimedia.org/T200387 (10Ryasmeen) Checked and verified that no more... [19:57:42] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): Cannot read property 'getOffset' of null - https://phabricator.wikimedia.org/T199754 (10Ryasmeen) Followed the steps mentioned in T199011 to verify this, not getting this error anymore. [20:30:31] (03CR) 10Esanders: rebaser: Use upstream username persistence (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450408 (owner: 10Esanders) [20:37:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451170 (owner: 10L10n-bot) [20:42:16] (03CR) 10Jforrester: [C: 031] rebaser: Use upstream username persistence (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450408 (owner: 10Esanders) [21:18:02] 10VisualEditor, 10VisualEditor-CopyPaste: Pasting content sometimes scrambles it - https://phabricator.wikimedia.org/T200107 (10Esanders) Going to be hard to investigate without a repeatable test case... [21:22:34] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10User-Ryasmeen, 10VisualEditor (Current work): Be able to insert horizontal rules (
or ----) - https://phabricator.wikimedia.org/T199925 (10Ryasmeen) >>! In T199925#4470198, @matmarex wrote: > Current version of... [21:25:10] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10User-Ryasmeen, 10VisualEditor (Current work): Be able to insert horizontal rules (
or ----) - https://phabricator.wikimedia.org/T199925 (10DLynch) It's the same as how pasting `* ` doesn't make it become a list... [21:26:33] 10VisualEditor, 10Phabricator, 10Release-Engineering-Team (Kanban), 10User-Ryasmeen: 404 on VisualEditor workboard (due to custom filter applied which did not exist in database) - https://phabricator.wikimedia.org/T199207 (10mmodell) Indeed, I have no idea how/why this occurs. [21:27:54] (03CR) 10Divec: [C: 032] rebaser: Use upstream username persistence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450408 (owner: 10Esanders) [21:30:26] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10User-Ryasmeen, 10VisualEditor (Current work): Be able to insert horizontal rules (
or ----) - https://phabricator.wikimedia.org/T199925 (10Esanders) Yes, "sequences" are only triggered if you actually type them... [21:31:39] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10User-Ryasmeen, 10VisualEditor (Current work): Be able to insert horizontal rules (
or ----) - https://phabricator.wikimedia.org/T199925 (10Ryasmeen) >>! In T199925#4486719, @Esanders wrote: > Yes, "sequences" a... [21:39:23] (03CR) 10Esanders: "Oops, this breaks the behaviour of the list generators: '* ' & '1. ' ('# ' in MW)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448068 (https://phabricator.wikimedia.org/T199925) (owner: 10DLynch) [21:39:36] Kemayo: ^ [21:40:17] edsanders: yeah, I’d just noticed that as well. The change to containsContent, maybe. I’ll take a closer look. [21:44:24] Kemayo: blame said it was just that patch [21:45:31] edsanders: I meant the change in that patch at the last minute to use containsContent rather than narrowly scoping it to paragraphs. I was sure I’d checked out some of the list before that. (But might be wrong.) [21:45:54] *the list sequences [21:46:13] right [21:46:29] well list/listItem aren't contains content, but they do generate wrapper paragraphs inside [21:47:49] I’m casting aspersions at my own testing procedures in response to feedback, mostly. [21:51:23] did someone say unit tests? [21:54:37] also I think you want .remove not .delete, the latter is for when you want the cursor to end up in a sane place, but this is a noAutoSelect fragment? [22:04:09] I think you may have to add another config param to the sequence, any attempt to guess what to do might just be too hacky [22:18:43] edsanders: Kemayo: my bad, i should have noticed it as well… shall we revert https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/448068 then, and backport that, or do you want to work on a fix now? [22:35:16] 10VisualEditor-ContentEditable, 10ContentTranslation, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10VisualEditor (Current work): Allow cursoring between active nodes - https://phabricator.wikimedia.org/T200525 (10Ryasmeen) @DLynch/ @Esanders: Are the following cursoring behaviors inte... [22:38:28] (03Merged) 10jenkins-bot: rebaser: Use upstream username persistence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450408 (owner: 10Esanders) [22:40:23] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Verified, 10VisualEditor (Current work): Collapsed tables broken in visual diff - https://phabricator.wikimedia.org/T194725 (10Ryasmeen) [22:41:07] (03CR) 10jenkins-bot: rebaser: Use upstream username persistence [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450408 (owner: 10Esanders) [22:45:16] 10VisualEditor-MediaWiki-Media, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Verified, 10Verified-in-Phase0, and 2 others: VE: Broken link to file-description page - https://phabricator.wikimedia.org/T198565 (10Ryasmeen) [22:46:48] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Verified, 10Verified-in-Phase0, and 2 others: Collapsed tables broken in visual diff - https://phabricator.wikimedia.org/T194725 (10Ryasmeen) [22:49:38] 10VisualEditor, 10VisualEditor-MediaWiki: List insertion by typing '#', '*' is broken - https://phabricator.wikimedia.org/T201472 (10matmarex) [22:49:49] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): List insertion by typing '#', '*' is broken - https://phabricator.wikimedia.org/T201472 (10matmarex) [22:49:54] edsanders: Kemayo: i filed the task ^ so we don't forget [22:51:25] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Verified, 10VisualEditor (Current work): Fake slugs appearing under each individual images in a gallery - https://phabricator.wikimedia.org/T200387 (10Ryasmeen) [22:52:12] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): Be able to insert horizontal rules (
or ----) - https://phabricator.wikimedia.org/T199925 (10Ryasmeen) [22:53:24] 10VisualEditor-ContentEditable, 10Verified, 10VisualEditor (Current work): Cannot read property 'getOffset' of null - https://phabricator.wikimedia.org/T199754 (10Ryasmeen) [22:54:10] MatmaRex: I [22:54:21] 'm seeing if I can work out a quick fix now. [22:55:17] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), 10Verified-in-Phase2, 10VisualEditor (Current work): Visual diff fails with "jQuery.Deferred exception: listContents is undefined" - https://phabricator.wikimedia.org/T199298 (10Ryasmeen) [22:56:11] 10VisualEditor-ContentEditable, 10ContentTranslation, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10VisualEditor (Current work): Allow cursoring between active nodes - https://phabricator.wikimedia.org/T200525 (10DLynch) Question 1 is what I was asking above in my first comment on this... [23:01:09] 10VisualEditor-ContentEditable, 10ContentTranslation, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10VisualEditor (Current work): Allow cursoring between active nodes - https://phabricator.wikimedia.org/T200525 (10Ryasmeen) >>! In T200525#4486910, @DLynch wrote: > Question 1 is what I w... [23:05:20] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): List insertion by typing '#', '*' is broken - https://phabricator.wikimedia.org/T201472 (10DLynch) a:03DLynch [23:06:29] edsanders / MatmaRex: I think I have a fairly sane way to guess this. If the remaining content-containing leaf node from the sequence range *doesn't* contain the current selection, I'm pretty sure that covers all our concerns. [23:06:59] Now let me go test that and see if I didn't think of something. [23:09:27] that sounds scary [23:24:33] Hm, and sequences appear to be one of the bits we've rather failed to unit test, based on the coverage report: https://doc.wikimedia.org/cover/visualeditor/src/ui/ve.ui.Sequence.js.html [23:26:41] MatmaRex: Alternative would probably be to also make sure the empty leaf node we see is one which is constrained to the very beginning of the sequence fragment. [23:28:22] (03PS1) 10DLynch: ui.Sequence: fix post-sequence cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451211 (https://phabricator.wikimedia.org/T201472)