[00:13:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/451158 (owner: 10L10n-bot) [06:27:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Javascript error when opening a page with ?action=edit - https://phabricator.wikimedia.org/T200368 (10Kaartic) It could be a duplicate of T199484 as the error seem pretty similar but the scenarios were slightly different. The scenario for this task o... [06:29:41] does VE have an api for finding a section by name in the currently open page, and for inserting text at the beginning of a particular section whose number is known? [07:03:50] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): Be able to insert horizontal rules (
or ----) - https://phabricator.wikimedia.org/T199925 (10Schnark) >>! In T199925#4486719, @Esanders wrote: > Yes,... [07:39:31] 10VisualEditor, 10Mobile: Preload does not work correctly on mobile view - https://phabricator.wikimedia.org/T126190 (10Ijon) Hello. I request this be re-triaged. It's been 2.5 years. And it breaks more than Wikinews. For example, it makes it impossible for mobile users (remember some people *don't* have a... [07:39:59] 10VisualEditor, 10Mobile: Preload does not work correctly on mobile view - https://phabricator.wikimedia.org/T126190 (10Ijon) (Also, it's not just on the Visual Editor. It doesn't work with wikitext editing either, on mobile.) [12:46:14] (03PS1) 10Petar.petkovic: Remove duplicated usage of article "the" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451311 (https://phabricator.wikimedia.org/T201491) [13:58:11] 10VisualEditor-ContentEditable, 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): Cannot read property 'getOffset' of null - https://phabricator.wikimedia.org/T199754 (10Deskana) 05Open>03Resolved [14:29:59] (03PS1) 10Esanders: Restore cursor trapping functionality to table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451331 (https://phabricator.wikimedia.org/T200525) [14:32:54] (03CR) 10Esanders: [C: 032] Remove duplicated usage of article "the" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451311 (https://phabricator.wikimedia.org/T201491) (owner: 10Petar.petkovic) [14:36:54] (03CR) 10jerkins-bot: [V: 04-1] Restore cursor trapping functionality to table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451331 (https://phabricator.wikimedia.org/T200525) (owner: 10Esanders) [14:38:16] (03CR) 10jerkins-bot: [V: 04-1] Remove duplicated usage of article "the" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451311 (https://phabricator.wikimedia.org/T201491) (owner: 10Petar.petkovic) [14:56:02] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451331 (https://phabricator.wikimedia.org/T200525) (owner: 10Esanders) [14:56:50] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10Technical-Debt: Get rid of the legacy metaList accessor function in surface/document - https://phabricator.wikimedia.org/T185520 (10Deskana) [14:57:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review: Don't show the loading bar on the 2017 Wikitext editor for the first 750ms - https://phabricator.wikimedia.org/T193665 (10Deskana) p:05Triage>03Low [14:57:55] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): List insertion by typing '#', '*' is broken - https://phabricator.wikimedia.org/T201472 (10Esanders) Happy to apply this as a quick fix, however I think ultimately we should move the paragraph cleanup into the command... [15:13:33] 10VisualEditor, 10Design: Clicking the "Change label" button needs to give the user clearer feedback - https://phabricator.wikimedia.org/T201232 (10Esanders) In addition to T199617 I think the change label button still needs some work. [15:15:33] 10VisualEditor, 10Design: Clicking the "Change label" button needs to give the user clearer feedback - https://phabricator.wikimedia.org/T201232 (10Esanders) >>! In T201232#4484982, @Esanders wrote: > A simpler approach might be to hide the "Change label" bar iff the link is fully selected. You can paste this... [15:17:13] (03CR) 10Jforrester: [C: 032] "Still broken cursoring between nodes, which I guess is coming next?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451331 (https://phabricator.wikimedia.org/T200525) (owner: 10Esanders) [15:23:10] (03Merged) 10jenkins-bot: Restore cursor trapping functionality to table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451331 (https://phabricator.wikimedia.org/T200525) (owner: 10Esanders) [15:29:18] (03CR) 10jenkins-bot: Restore cursor trapping functionality to table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451331 (https://phabricator.wikimedia.org/T200525) (owner: 10Esanders) [15:53:11] (03PS2) 10Petar.petkovic: Remove duplicated usage of article "the" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451311 (https://phabricator.wikimedia.org/T201491) [15:56:37] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 10 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784 (10Jhernandez) [16:37:28] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): List insertion by typing '#', '*' is broken - https://phabricator.wikimedia.org/T201472 (10DLynch) @Esanders: Makes sense, and I agree on the general case. If you merge it, I can make a new task for fixing it up more p... [17:03:20] 10Editing-team, 10Contributors-Team, 10MediaWiki-Logging, 10MediaWiki-Page-editing, and 2 others: Unable to open edit page, or view Special:Log, for certain pages ("MWException: Expected title, got null" from LogFormatter.php) - https://phabricator.wikimedia.org/T185049 (10Jdforrester-WMF) 05Open>03Reso... [17:11:04] (03PS15) 10Jforrester: WIP Update to Unicode 9.0.0 [unicodejs] - 10https://gerrit.wikimedia.org/r/348975 (https://phabricator.wikimedia.org/T201533) [17:11:42] (03PS6) 10Jforrester: Go back to storing strings as code units [unicodejs] - 10https://gerrit.wikimedia.org/r/391820 (https://phabricator.wikimedia.org/T201534) (owner: 10Esanders) [17:33:14] Kemayo: can you respond on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/449919 (wpUltimateParam thing)? i left a tiny comment there, i'm happy to merge it in either form [17:34:15] MatmaRex: sure, I’m just eating lunch now, but I’ll do it first thing after that. [18:00:49] (03PS1) 10Esanders: Wikitext surface getCaretPosition: Handle null ranges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451392 (https://phabricator.wikimedia.org/T199484) [18:52:44] (03PS2) 10Esanders: Wikitext surface getCaretPosition: Handle null ranges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451392 (https://phabricator.wikimedia.org/T199484) [18:53:13] (03CR) 10Esanders: [C: 032] ui.Sequence: fix post-sequence cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451211 (https://phabricator.wikimedia.org/T201472) (owner: 10DLynch) [18:58:37] (03Merged) 10jenkins-bot: ui.Sequence: fix post-sequence cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451211 (https://phabricator.wikimedia.org/T201472) (owner: 10DLynch) [19:05:58] (03CR) 10jenkins-bot: ui.Sequence: fix post-sequence cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451211 (https://phabricator.wikimedia.org/T201472) (owner: 10DLynch) [19:14:56] (03CR) 10DLynch: [C: 032] Wikitext surface getCaretPosition: Handle null ranges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451392 (https://phabricator.wikimedia.org/T199484) (owner: 10Esanders) [19:28:09] (03PS2) 10DLynch: Include wpUltimateParam when switching from VE to source editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) [19:30:49] (03CR) 10DLynch: "> Patch Set 1: Code-Review-1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [19:32:41] 10VisualEditor, 10Design: Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [19:33:16] (03Merged) 10jenkins-bot: Wikitext surface getCaretPosition: Handle null ranges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451392 (https://phabricator.wikimedia.org/T199484) (owner: 10Esanders) [19:36:49] (03CR) 10jenkins-bot: Wikitext surface getCaretPosition: Handle null ranges [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451392 (https://phabricator.wikimedia.org/T199484) (owner: 10Esanders) [19:39:48] 10VisualEditor, 10Design: Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10Whatamidoing-WMF) [19:49:35] (03PS3) 10Bartosz Dziewoński: Include wpUltimateParam when switching from VE to source editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [19:50:00] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks. PS3 fixes a typo in a code comment." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [19:50:25] (03CR) 10DLynch: "> Patch Set 3: Code-Review+2" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [19:51:06] (03PS4) 10Bartosz Dziewoński: Include wpUltimateParam when switching from VE to source editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [19:51:18] (03CR) 10Bartosz Dziewoński: [C: 032] "Two typos :D" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [19:51:57] (03CR) 10Jforrester: [C: 032] "🙄" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [19:52:48] Properly capitalizing the name of our product is too high a bar for me, clearly. [20:01:19] 10VisualEditor, 10Design: Identify what heuristics we will be evaluating - https://phabricator.wikimedia.org/T201549 (10iamjessklein) [20:02:16] 10VisualEditor, 10Design: Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [20:15:17] 10VisualEditor, 10Design: Recruit 1- 3 additional evaluators for Heuristic Evaluation - https://phabricator.wikimedia.org/T201550 (10iamjessklein) [20:15:44] 10VisualEditor, 10Design: Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [20:19:19] 10VisualEditor, 10Design: Write up and share findings by integrating them into the Mobile Report - https://phabricator.wikimedia.org/T201551 (10iamjessklein) [20:21:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451516 (owner: 10L10n-bot) [20:21:22] 10VisualEditor, 10Design: Write up and share findings by integrating them into the Mobile Report - https://phabricator.wikimedia.org/T201551 (10iamjessklein) [20:23:18] (03Merged) 10jenkins-bot: Include wpUltimateParam when switching from VE to source editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [20:24:17] 10VisualEditor, 10Design: Write up and share findings by integrating them into the Mobile Report - https://phabricator.wikimedia.org/T201551 (10iamjessklein) [20:24:53] 10VisualEditor, 10Design: Write up and share findings of VE Heuristic Analysis - https://phabricator.wikimedia.org/T201551 (10iamjessklein) [20:25:58] (03CR) 10jenkins-bot: Include wpUltimateParam when switching from VE to source editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/449919 (https://phabricator.wikimedia.org/T199554) (owner: 10DLynch) [20:26:14] 10VisualEditor, 10Design: Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [20:30:58] 10VisualEditor, 10Design: Determine questions for the mobile web Visual Editor usability test - https://phabricator.wikimedia.org/T201553 (10iamjessklein) [20:31:40] 10VisualEditor, 10Design: Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [20:38:11] 10VisualEditor, 10Design-Research, 10Design: Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [20:46:23] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Switching between visual editor and source mode gives error message - https://phabricator.wikimedia.org/T199554 (10DLynch) > (Note that there is no data loss, for VE or other affected tools, just a misleading message.) I do think i... [20:49:06] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The changes to `section` handling are incorrect (at least some of them). In particular, if you open VE from a section edit link, make chan" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [20:50:47] (03CR) 10DLynch: "> Patch Set 1: Code-Review-1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [20:57:18] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (7e57bf17b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451530 (https://phabricator.wikimedia.org/T200525) [21:03:17] (03CR) 10Bartosz Dziewoński: "Yeah, this is not what it's trying to say. "Preformatted plain text" stands for "Text using fixed-width font [=preformatted] that you can'" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/446758 (owner: 10Amire80) [21:03:51] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (7e57bf17b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451530 (https://phabricator.wikimedia.org/T200525) (owner: 10Bartosz Dziewoński) [21:25:06] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every line - https://phabricator.wikimedia.org/T201561 (10brion) [21:25:29] (03Merged) 10jenkins-bot: Update VE core submodule to master (7e57bf17b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451530 (https://phabricator.wikimedia.org/T200525) (owner: 10Bartosz Dziewoński) [21:28:23] (03CR) 10jenkins-bot: Update VE core submodule to master (7e57bf17b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451530 (https://phabricator.wikimedia.org/T200525) (owner: 10Bartosz Dziewoński) [21:31:24] 10VisualEditor, 10VisualEditor-CopyPaste: Selection of visual "end" of a
  • from external paste should work as user expects, even when it has a link annotation - https://phabricator.wikimedia.org/T201564 (10Jdforrester-WMF) [21:45:32] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Switching between visual editor and source mode gives error message - https://phabricator.wikimedia.org/T199554 (10Ryasmeen) I can't reproduce this anywhere Beta cluster/production following the steps mentioned. So not sure how can... [22:02:30] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10VisualEditor (Current work): Switching between visual editor and source mode gives error message - https://phabricator.wikimedia.org/T199554 (10Jdforrester-WMF) [22:24:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/451500 (owner: 10L10n-bot) [22:44:16] (03CR) 10Jforrester: [C: 032] Remove duplicated usage of article "the" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451311 (https://phabricator.wikimedia.org/T201491) (owner: 10Petar.petkovic) [22:49:50] (03Merged) 10jenkins-bot: Remove duplicated usage of article "the" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451311 (https://phabricator.wikimedia.org/T201491) (owner: 10Petar.petkovic) [23:04:52] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10VisualEditor (Current work): List insertion by typing '#', '*' is broken - https://phabricator.wikimedia.org/T201472 (10matmarex) I think we should backport this fix to wmf.16. On... [23:06:42] (03PS1) 10Bartosz Dziewoński: ui.Sequence: fix post-sequence cleanup [VisualEditor/VisualEditor] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/451543 (https://phabricator.wikimedia.org/T201472) [23:19:38] (03CR) 10Reedy: [C: 032] ui.Sequence: fix post-sequence cleanup [VisualEditor/VisualEditor] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/451543 (https://phabricator.wikimedia.org/T201472) (owner: 10Bartosz Dziewoński) [23:37:02] * Reedy waits [23:39:43] Jerkins hasn't merged it yet anyway [23:48:29] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10VisualEditor (Current work): Switching between visual editor and source mode gives error message - https://phabricator.wikimedia.org/T199554 (10Ryasmeen) @matmarex: Ah! This is about OWE. Thanks for clarifying that :... [23:50:39] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to wmf/1.32.0-wmf.16 [extensions/VisualEditor] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/451545 (https://phabricator.wikimedia.org/T201472) [23:51:08] (03CR) 10Reedy: [C: 032] Update VE core submodule to wmf/1.32.0-wmf.16 [extensions/VisualEditor] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/451545 (https://phabricator.wikimedia.org/T201472) (owner: 10Bartosz Dziewoński) [23:52:12] (for future reference, i ran `bin/updateSubmodule.sh wmf/1.32.0-wmf.16` to make that commit) [23:53:17] (03CR) 10jenkins-bot: ui.Sequence: fix post-sequence cleanup [VisualEditor/VisualEditor] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/451543 (https://phabricator.wikimedia.org/T201472) (owner: 10Bartosz Dziewoński)