[00:11:48] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.32.0-wmf.16 [extensions/VisualEditor] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/451545 (https://phabricator.wikimedia.org/T201472) (owner: 10Bartosz Dziewoński) [00:20:42] 10VisualEditor, 10Design-Research, 10Design: Determine questions for the mobile web Visual Editor usability test - https://phabricator.wikimedia.org/T201553 (10iamjessklein) [00:24:39] 10VisualEditor, 10Design-Research, 10Design: Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [00:30:03] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10VisualEditor (Current work): List insertion by typing '#', '*' is broken - https://phabricator.wikimedia.org/T201472 (10matmarex) Fixed and deployed to production wikis. [00:34:34] This stupid bot chatter prevents you from noticing when a person asked a question, doesn't it? [00:35:11] Wouldn't it be better for the bot to use /notice, so that your irc client notification level is appropriate -- right now it is either "botspam" or "highlight", and questions from a newcomer are easily missed [00:35:25] MatmaRex, ^^ [00:36:36] Sveta: IRC clients treat /notice inconsistently. it was tried in the past, and at least my client generated a sound notification for each one [00:36:47] MatmaRex, what irc client are you using? [00:36:48] same as it does for pings (by nickname) [00:37:16] and i have no idea where to disable it :) [00:37:29] Miranda NG. i think other folks using other ones had similar experiences [00:38:03] Sveta: https://phabricator.wikimedia.org/T101575 [00:38:50] also https://phabricator.wikimedia.org/T72881#750406 [00:39:03] oh, wasn't it you filing that task? hah [00:39:12] at bugzilla :o [00:39:42] ya I think it was me, I'll follow up in a bit after attempting to fix whatever clients people mentioned in the comments [01:17:14] (03PS1) 10Bartosz Dziewoński: ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) [01:17:24] (03PS1) 10Bartosz Dziewoński: ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) [01:17:34] (03PS1) 10Bartosz Dziewoński: ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) [01:19:42] (03CR) 10Bartosz Dziewoński: "I am not sure about this. This might be too low-level? SurfaceFragment#insertContent might also be a good place to do this… The changes to" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [01:21:29] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [01:21:53] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [01:22:22] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [03:09:31] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10VisualEditor (Current work): Switching between visual editor and source mode gives error message - https://phabricator.wikimedia.org/T199554 (10matmarex) [07:39:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451575 (owner: 10L10n-bot) [09:22:19] 10Editing-team, 10Mobile: Mobile web does not present edit notices - https://phabricator.wikimedia.org/T201595 (10TheDJ) [09:22:38] 10Editing-team, 10Mobile: Mobile web does not present edit notices - https://phabricator.wikimedia.org/T201595 (10TheDJ) [09:30:58] 10Editing-team, 10Mobile: Mobile web does not present edit notices - https://phabricator.wikimedia.org/T201595 (10TheDJ) [09:42:10] 10Editing-team, 10MediaWiki-Page-editing, 10Mobile: Mobile web does not present edit notices - https://phabricator.wikimedia.org/T201595 (10Aklapper) Is this about mobile apps, or the mobile frontend in browsers, or both? :) [09:46:37] 10Editing-team, 10MediaWiki-Page-editing, 10MinervaNeue, 10Mobile: Mobile web does not present edit notices - https://phabricator.wikimedia.org/T201595 (10TheDJ) [09:46:57] 10Editing-team, 10MediaWiki-Page-editing, 10MinervaNeue, 10Mobile: Mobile web (and Minerva desktop) does not present edit notices - https://phabricator.wikimedia.org/T201595 (10TheDJ) [09:58:46] 10Citoid, 10VisualEditor, 10I18n, 10RTL: On sdwiki and hewiki, opens bare reference instead of template for templates not in the MediaWiki:Visualeditor-cite-tool-definition.json message. - https://phabricator.wikimedia.org/T197972 (10Mvolz) >>! In T197972#4323435, @Whatamidoing-WMF wrote: > See also {T7149... [10:08:52] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Help some smaller Wikipedias' communities by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354 (10Mvolz) >>! In T127354#4202527, @Jogi_don wrote: > I request here , Please enable this feature on Sin... [10:17:24] (03PS1) 10Divec: Move DOM selection from block slug even if model selection is unchanged [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451605 (https://phabricator.wikimedia.org/T201599) [10:17:57] 10Citoid, 10VisualEditor: Create error message specific to the template lacking a citoid maps value instead of generic error message - https://phabricator.wikimedia.org/T201601 (10Mvolz) p:05Triage>03Normal [10:19:36] 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): It is possible to get the cursor into a block slug - https://phabricator.wikimedia.org/T201599 (10dchan) [10:41:47] 10Citoid, 10VisualEditor, 10translatewiki.net, 10I18n: Restore the translations of "null" in VisualEditor Cite and Citoid messages as "optional" - https://phabricator.wikimedia.org/T183678 (10Amire80) I didn't examine the relevant Cite and VE code, but it probably must not be translated, because it may be... [11:22:13] hi edsanders [11:22:17] looking at your comments at https://translatewiki.net/w/i.php?title=User_talk:Celestinesucess&offset=20180719141825#cut_.2F_copy_55221 [11:24:10] 10VisualEditor: VisualEditor: Add a shortcut to add an image - https://phabricator.wikimedia.org/T192258 (10Deskana) p:05Triage>03Low [11:25:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The same changes were made twice at Wikivoyage - https://phabricator.wikimedia.org/T191475 (10Deskana) 05Open>03stalled This needs specific steps to reproduce before it can be investigated more. [11:29:11] edsanders: where are Copy and Cut actually used? Are they used anywhere on Wikimedia sites? Or only in the generic VE? [11:32:56] 10VisualEditor, 10Collaboration-Team-Triage, 10Maps, 10User-Ryasmeen: Map preview is not loading in VE - https://phabricator.wikimedia.org/T190892 (10Deskana) 05Open>03Resolved a:03Deskana The 400 isn't happening any more, although the map is blank. As far as I know, for performance reasons, only ver... [11:35:24] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056 (10Deskana) This was almost certainly the same issue as T187951, and I can't reproduce this any more, so I'm merging these together. [11:35:43] 10VisualEditor: Can't open an office.wiki page in the visual editor - https://phabricator.wikimedia.org/T190056 (10Deskana) [11:38:07] 10VisualEditor: VisualEditor resolve conflicts and editor switch not working - https://phabricator.wikimedia.org/T189392 (10Deskana) I suspect this was the same issue, or a closely related issue, to T201210; all the discussion happened on that task, so I'm merging this one into that one. [11:38:22] 10VisualEditor: VisualEditor resolve conflicts and editor switch not working - https://phabricator.wikimedia.org/T189392 (10Deskana) [11:47:08] 10VisualEditor, 10Design-Research, 10Design: Write up and share findings of VE Heuristic Analysis - https://phabricator.wikimedia.org/T201551 (10iamjessklein) [11:47:18] 10VisualEditor, 10Design-Research, 10Design: Recruit 1- 3 additional evaluators for Heuristic Evaluation - https://phabricator.wikimedia.org/T201550 (10iamjessklein) [11:47:27] 10VisualEditor, 10Design-Research, 10Design: Identify what heuristics we will be evaluating - https://phabricator.wikimedia.org/T201549 (10iamjessklein) [12:15:17] 10Citoid, 10VisualEditor, 10translatewiki.net, 10I18n: Restore the translations of "null" in VisualEditor Cite and Citoid messages as "optional" - https://phabricator.wikimedia.org/T183678 (10Nikerabbit) It's ignored for "Cite", not for "Cite - VisualEditor" where it exists. [12:26:57] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (watching), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Deskana) 05stalled>03Open a:03Mvolz [12:35:29] 10Editing-team, 10MediaWiki-Page-editing, 10MinervaNeue, 10Mobile: Mobile web (and Minerva desktop) does not present edit notices - https://phabricator.wikimedia.org/T201595 (10HairyDude) Both. Editnotices are not displayed in either case. See for example any BLP on enwiki, which have the BLP editnotice. [12:44:08] (03CR) 10Esanders: "My reading of the docs is that fixupInsertion is for correcting unbalanced transactions, or transactions that would leave the doc in an in" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [12:49:46] 10VisualEditor, 10Parsoid: VE mixing HTML and wikitext syntax for tables - https://phabricator.wikimedia.org/T201607 (10NicoV) [12:55:34] (03CR) 10Esanders: "Does this affect the ability to drag-select into a slug (which I think was part of the reason we made them CE=true)? If so we could only d" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451605 (https://phabricator.wikimedia.org/T201599) (owner: 10Divec) [12:56:55] 10VisualEditor, 10Parsoid: VE mixing HTML and wikitext syntax for tables - https://phabricator.wikimedia.org/T201607 (10NicoV) Other edit from the same user seem to have the same kind of problems : https://fr.wikipedia.org/w/index.php?title=Forces_fran%C3%A7aises_%C3%A0_Djibouti&diff=prev&oldid=151141910 [13:08:15] 10Citoid, 10Operations, 10Services (watching), 10VisualEditor (Current work): Deploy translation-server-v2 - https://phabricator.wikimedia.org/T201611 (10Mvolz) p:05Triage>03High [13:09:00] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (watching), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Mvolz) [13:18:44] (03PS2) 10Esanders: ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:19:56] (03CR) 10Esanders: [C: 032] ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:20:24] (03PS2) 10Esanders: ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:20:31] (03PS2) 10Esanders: ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:20:56] (03CR) 10Esanders: [C: 032] ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:21:02] (03CR) 10Esanders: [C: 032] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:26:55] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:27:21] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:33:09] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:36:27] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:36:29] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:36:31] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:43:24] 10Editing-team, 10MediaWiki-Page-editing, 10MinervaNeue, 10MobileFrontend, 10Mobile: Mobile web (and Minerva desktop) does not present edit notices - https://phabricator.wikimedia.org/T201595 (10Liuxinyu970226) >>! 在T201595#4490981中，@Aklapper写道： > Is this about mobile apps, or the mobile frontend in brow... [13:47:35] 10Editing-team, 10MediaWiki-Page-editing, 10MinervaNeue, 10MobileFrontend, 10Mobile: Mobile web (and Minerva desktop) does not present edit notices - https://phabricator.wikimedia.org/T201595 (10TheDJ) >>! In T201595#4490981, @Aklapper wrote: > Is this about mobile apps, or the mobile frontend in browser... [13:49:12] (03PS3) 10Esanders: ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:49:18] (03CR) 10Esanders: [C: 032] ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [13:58:12] (03Merged) 10jenkins-bot: ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [14:09:42] (03PS1) 10Esanders: Replace Bugzilla numbers with Phab numbers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451632 [14:11:37] (03PS1) 10Esanders: Replace Bugzilla numbers with Phab numbers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451633 [14:12:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: VisualEditor: Provide support for BLP edit notices on enwiki - https://phabricator.wikimedia.org/T56029 (10TheDJ) [14:14:00] aharoni, it's in all versions of VE in the keyboard shortcuts dialogs (Ctrl+?) [14:18:25] (03CR) 10jerkins-bot: [V: 04-1] Replace Bugzilla numbers with Phab numbers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451632 (owner: 10Esanders) [14:19:10] aharoni https://usercontent.irccloud-cdn.com/file/wSuucViW/image.png [14:21:21] (03CR) 10jenkins-bot: ve.dm.Document: Replace empty nodes after inserting non-text data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451552 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [14:50:09] 10VisualEditor-MediaWiki-Media, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Verified, 10Verified-in-Phase0, and 2 others: VE: Broken link to file-description page - https://phabricator.wikimedia.org/T198565 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [15:08:15] 10Citoid, 10Operations, 10Services, 10Service-deployment-requests, and 2 others: Deploy translation-server-v2 - https://phabricator.wikimedia.org/T201611 (10mobrovac) [15:09:46] (03PS3) 10Bartosz Dziewoński: ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) [15:09:58] (03CR) 10Bartosz Dziewoński: [C: 032] ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:10:00] (03PS3) 10Bartosz Dziewoński: ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) [15:10:12] (03CR) 10Bartosz Dziewoński: [C: 032] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:12:17] edsanders: any thoughts on the FIXME in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/451554/3/src/ui/ve.ui.Sequence.js ? [15:20:22] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:20:25] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:20:27] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:20:31] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:21:30] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (watching), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10mobrovac) >>! In T197242#4441138, @faidon wrote: > Is there any progress and/or timeline for this? Thank... [15:21:50] (03CR) 10Esanders: [C: 032] "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:23:31] MatmaRex: I suppose you could use staging [15:23:47] 10Citoid, 10VisualEditor, 10RESTBase-API, 10Services (doing): Remove bibtex from Citoid's public API - https://phabricator.wikimedia.org/T201618 (10mobrovac) p:05Triage>03Normal [15:24:05] 10Citoid, 10VisualEditor, 10RESTBase-API, 10Services (doing): Remove bibtex from Citoid's public API - https://phabricator.wikimedia.org/T201618 (10mobrovac) [15:24:11] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (watching), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10mobrovac) [15:24:23] but also it should be pretty rare that the command fails? [15:24:42] edsanders: the example i was testing with is typing '* ' while already inside a list item [15:24:59] yeah, it's an edge case [15:31:20] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:31:22] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [15:41:34] (03CR) 10Jforrester: [C: 032] Replace Bugzilla numbers with Phab numbers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451633 (owner: 10Esanders) [15:43:11] (03CR) 10Jforrester: [C: 032] Replace Bugzilla numbers with Phab numbers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451632 (owner: 10Esanders) [15:51:15] (03Merged) 10jenkins-bot: Replace Bugzilla numbers with Phab numbers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451632 (owner: 10Esanders) [15:52:29] (03PS1) 10Esanders: Create unit tests for sequences [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451649 [15:52:31] (03PS1) 10Esanders: Upsteam horizontalRule sequence and fix command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451650 [16:00:44] (03CR) 10jenkins-bot: Replace Bugzilla numbers with Phab numbers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451632 (owner: 10Esanders) [16:03:34] (03Merged) 10jenkins-bot: Replace Bugzilla numbers with Phab numbers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451633 (owner: 10Esanders) [16:09:03] (03CR) 10jenkins-bot: Replace Bugzilla numbers with Phab numbers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451633 (owner: 10Esanders) [16:13:24] (03PS1) 10Bartosz Dziewoński: ve.dm.Document: Improve docs of #fixupInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451653 [16:27:02] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10Esanders) Typically not, but we did implement a hack to extract RL modules from the restbase response when loading th... [16:29:01] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10Tgr) These are not RL modules, just plain `style` tags with the CSS inlined. If you do not load the page HTML, where... [16:45:58] 10VisualEditor, 10RESTBase: Cannot edit subpages, probably due to percent-encoding of URIs - https://phabricator.wikimedia.org/T201628 (10Whatamidoing-WMF) [16:49:18] (03CR) 10Esanders: [C: 04-1] ve.dm.Document: Improve docs of #fixupInsertion (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451653 (owner: 10Bartosz Dziewoński) [16:50:41] (03CR) 10Esanders: [C: 032] "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [16:50:47] 10Citoid, 10VisualEditor, 10RESTBase-API, 10Services (doing): Remove bibtex from Citoid's public API - https://phabricator.wikimedia.org/T201618 (10mobrovac) [PR #1046](https://github.com/wikimedia/restbase/pull/1046) removes the support for it. [16:52:20] 10VisualEditor, 10VisualEditor-DataModel, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Technical-Debt: Avoid jQuery in ve.dm. - https://phabricator.wikimedia.org/T195111 (10Esanders) [16:54:10] (03CR) 10Divec: [C: 04-1] "findBlockSlug itself returns null if the selection is not collapsed, so what's there right now is logically correct. But putting the test " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451605 (https://phabricator.wikimedia.org/T201599) (owner: 10Divec) [17:00:37] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: VE mixing HTML and wikitext syntax for tables - https://phabricator.wikimedia.org/T201607 (10Cirdan) [17:01:45] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: VE mixing HTML and wikitext syntax for tables - https://phabricator.wikimedia.org/T201607 (10Cirdan) Possible duplicate of {T186007} [17:05:23] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10DLynch) The requirement is more specific than just switching to VE -- it has to be switching to VE from the classic e... [17:06:11] (03PS2) 10Divec: Move DOM selection from block slug even if model selection is unchanged [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451605 (https://phabricator.wikimedia.org/T201599) [17:07:37] (03Merged) 10jenkins-bot: ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [17:07:39] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [17:09:24] (03PS4) 10Esanders: ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [17:15:17] (03CR) 10jerkins-bot: [V: 04-1] Move DOM selection from block slug even if model selection is unchanged [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451605 (https://phabricator.wikimedia.org/T201599) (owner: 10Divec) [17:16:36] (03CR) 10jenkins-bot: ve.ui.Sequence: Revert sequence stripping changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451553 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [17:16:49] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10Esanders) See `ve.init.mw.ArticleTarget.prototype.loadSuccess`, as that is where we pick apart the full Parsoid DOM,... [17:21:18] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10DLynch) I suspect the most relevant bit for that is `ve.init.mw.Target.prototype.setupSurface`, since that's where we... [17:26:53] 10VisualEditor, 10RESTBase, 10Services (next): Cannot edit subpages, probably due to percent-encoding of URIs - https://phabricator.wikimedia.org/T201628 (10mobrovac) p:05Triage>03Normal The symptoms described by the user seems to suggest there is a problem in the Apache config of the site. Asked them to... [17:32:40] (03PS1) 10Bartosz Dziewoński: [WIP] ve.dm.Document: Remove incorrect handling for combining characters in #fixupInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451669 (https://phabricator.wikimedia.org/T85093) [17:34:39] 10VisualEditor, 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, and 3 others: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093 (10matmarex) If you want to test this and can't easily insert combining c... [17:34:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 wikitext editor gets very confused while typing signature (combining diacritics and non-breaking spaces?) - https://phabricator.wikimedia.org/T182404 (10matmarex) [17:34:51] 10VisualEditor, 10UniversalLanguageSelector: jquery.ime keyboard layouts that convert letters to combining characters works incorrectly - https://phabricator.wikimedia.org/T198719 (10matmarex) [17:34:56] 10VisualEditor, 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, and 3 others: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093 (10matmarex) [17:38:03] (03CR) 10jerkins-bot: [V: 04-1] [WIP] ve.dm.Document: Remove incorrect handling for combining characters in #fixupInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451669 (https://phabricator.wikimedia.org/T85093) (owner: 10Bartosz Dziewoński) [18:10:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: Make the VisualEditor/ProofreadPage integration good enough to enable by default - https://phabricator.wikimedia.org/T138966 (10matmarex) [18:10:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 10Wikisource, 10User-Ryasmeen: Writing manual s into header/footer using VisualEditor with ProofreadPage corrupts the page - https://phabricator.wikimedia.org/T138604 (10matmarex) 05stalled>03Resolved Per my previous comment. I think th... [18:11:30] 10VisualEditor, 10ProofreadPage, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): VisualEditor/ProofreadPage splitting of the page content into header/section/footer is incompatible with existing content (and more generally, with the layout of physica... - https://phabricator.wikimedia.org/T196863 [18:11:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 10Wikisource, 10User-Ryasmeen: Writing manual s into header/footer using VisualEditor with ProofreadPage corrupts the page - https://phabricator.wikimedia.org/T138604 (10matmarex) [18:11:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: Make the VisualEditor/ProofreadPage integration good enough to enable by default - https://phabricator.wikimedia.org/T138966 (10matmarex) [18:22:41] 10VisualEditor, 10VisualEditor-ContentEditable: Inserting a combining diacritic mark into a VE surface messes up cursoring and causes duplicate text - https://phabricator.wikimedia.org/T185987 (10matmarex) [18:22:49] 10VisualEditor, 10Collaboration-Team-Triage, 10Growth-Team, 10StructuredDiscussions, and 3 others: Regression: Using Unicode Combining diacritics duplicates/replaces/adds unwanted characters - https://phabricator.wikimedia.org/T85093 (10matmarex) [18:51:07] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): When editing source, sometimes characters get put in strange places if you have too many characters on a line (?) - https://phabricator.wikimedia.org/T188839 (10matmarex) I can reproduce this, and I th... [18:51:29] 10Citoid, 10VisualEditor, 10RESTBase-API, 10Services (doing): Remove bibtex from Citoid's public API - https://phabricator.wikimedia.org/T201618 (10Mvolz) If this graph is accurate, it seems to suggest that 1/4 of our traffic is bibtex :/ https://grafana.wikimedia.org/dashboard/db/service-citoid?orgId=1 [19:23:33] (03PS5) 10Bartosz Dziewoński: ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) [19:25:24] edsanders: regarding my earlier question about the FIXME about undos. i'm not sure if we can use staging, it seems like we might not have a consistent way to pop staging if the command (or the command's window) succedds? but instead, i found truncateUndoStack(), i think that works: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/451554/5/src/ui/ve.ui.Sequence.js [19:31:08] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.Sequence: Strip sequence before running the command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [19:31:42] (03CR) 10Bartosz Dziewoński: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451554 (https://phabricator.wikimedia.org/T201573) (owner: 10Bartosz Dziewoński) [20:04:07] 10VisualEditor: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field - https://phabricator.wikimedia.org/T196686 (10matmarex) I think the current design is okay. I would suggest declining this task… @DLynch @Ryasmeen Do you feel strongly that it's a problem? :) [20:30:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/451773 (owner: 10L10n-bot) [20:50:35] 10VisualEditor: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field - https://phabricator.wikimedia.org/T196686 (10Ryasmeen) @matmarex: I don't think it's a major issue but I still feel slightly odd about this design having a textfield with focus highlight and a disabled... [20:51:21] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (watching), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Krenair) Hopefully this is the right place for my questions (sorry if not): So I'd like to get rid of th... [20:56:59] 10Editing-team, 10MediaWiki-Page-editing, 10MinervaNeue, 10MobileFrontend, and 2 others: Mobile web (and Minerva desktop) does not present edit notices - https://phabricator.wikimedia.org/T201595 (10Jdlrobson) [20:59:30] 10Editing-team, 10MediaWiki-Page-editing, 10MinervaNeue, 10MobileFrontend, and 2 others: Mobile web (and Minerva desktop) does not present edit notices - https://phabricator.wikimedia.org/T201595 (10Jdlrobson) 05Open>03stalled Blocked on https://phabricator.wikimedia.org/T45683 [21:08:04] 10WikiEditor, 10Community-Tech, 10Growth-Team, 10MediaWiki-extensions-CodeMirror, and 5 others: WikiEditor toolbar overlaps Notifications flyout in Timeless and Modern skins - https://phabricator.wikimedia.org/T200148 (10Amorymeltzer) @Isarra Thanks for fixing this! I first noticed this as it affected the... [21:13:19] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10VisualEditor (Current work): Switching between visual editor and source mode gives error message - https://phabricator.wikimedia.org/T199554 (10matmarex) @Ryasmeen On a closer look, the "Remember that this is only a... [21:41:47] (03PS2) 10Bartosz Dziewoński: DesktopArticleTarget.init: always bind to #ca-edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [21:42:36] (03CR) 10Bartosz Dziewoński: [C: 031] "@DLynch I think this is all we need to fix T199655, and the section changes are not needed. Please review my changes. I hate this code." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [21:43:09] (03CR) 10Bartosz Dziewoński: [C: 031] "By the way, switchToWikitextSection() is all broken (or wrongly documented). It only handles these cases correctly:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [21:49:39] (03CR) 10DLynch: "> Luckily, these are also the only cases where we call it!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [21:53:40] (03CR) 10DLynch: [C: 032] "This seems like a sensible restriction of my initial patch; you're right that the section stuff isn't strictly required and dropping it ma" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [22:07:14] (03CR) 10Bartosz Dziewoński: [C: 031] "Yes, making any changes here is also scary to me. I definitely don't have all of the Target code in my head. There are so many combination" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [22:18:56] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: always bind to #ca-edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [22:20:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/451765 (owner: 10L10n-bot) [22:21:48] (03CR) 10jenkins-bot: DesktopArticleTarget.init: always bind to #ca-edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/450160 (https://phabricator.wikimedia.org/T199655) (owner: 10DLynch) [22:53:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-CodeMirror, 10Easy, 10Patch-For-Review: CodeMirror syntax highlighting shows overlapping text when word-wrap (hyphens, word-break) is overridden - https://phabricator.wikimedia.org/T192019 (10Niharika) [22:53:40] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-CodeMirror, 10Patch-For-Review, 10VisualEditor (Current work): CodeMirror and 2017 Wikitext editor combination produce invisible text in Category and File namespaces - https://phabricator.wikimedia.org/T194068 (10Niharika) [23:04:08] 10VisualEditor: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field - https://phabricator.wikimedia.org/T196686 (10matmarex) I agree with Volker that the focus states in David's mockups look weird :/ Honestly I like the old design the most… The current design seems okay... [23:05:05] 10Editing-team, 10MassMessage, 10Wikimedia-log-errors: Notice: Undefined index: 0 in /srv/mediawiki/php-1.27.0-wmf.9/extensions/MassMessage/includes/MassMessage.php on line 391 - https://phabricator.wikimedia.org/T123258 (10Krinkle) [23:13:59] (03PS2) 10Bartosz Dziewoński: ve.dm.Document: Improve docs of #fixupInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/451653