[00:00:51] (03PS3) 10VolkerE: Replace 'settings' by renamed 'pageSettings' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453306 (https://phabricator.wikimedia.org/T190581) [00:02:30] (03Merged) 10jenkins-bot: Fix icons broken by OOUI update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453269 (owner: 10Esanders) [00:03:56] Volker_E: Gah. Please don't make late patches later like that. :-( [00:04:36] Oh, I see, it's a different one? [00:04:39] Too many patches. [00:04:51] (03CR) 10Jforrester: "You missed Ie0307ebc1 apparently." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453269 (owner: 10Esanders) [00:04:57] (03CR) 10Jforrester: [C: 032] Replace 'settings' by renamed 'pageSettings' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453306 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [00:05:23] (03CR) 10jenkins-bot: Fix icons broken by OOUI update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453269 (owner: 10Esanders) [00:28:06] (03Merged) 10jenkins-bot: Replace 'settings' by renamed 'pageSettings' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453306 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [00:30:33] (03CR) 10jenkins-bot: Replace 'settings' by renamed 'pageSettings' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453306 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [00:49:19] James_F: hmm? Did I miss something? [00:49:45] Volker_E: Just me getting confused, ignore me. :-) [07:39:51] 10VisualEditor, 10MediaWiki-Page-editing, 10MediaWiki-extensions-Translate, 10Epic: Reduce or eliminate the need for the user to touch tags and unit markers - https://phabricator.wikimedia.org/T131516 (10planetenxin) I added this issue to MediaWiki Stakeholders' Group/TechConf Input: https://w... [07:40:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-Translate: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974 (10planetenxin) I added this issue to MediaWiki... [08:24:00] 10VisualEditor, 10VisualEditor-CopyPaste: Pasting content sometimes scrambles it - https://phabricator.wikimedia.org/T200107 (10Mishter_Jingles) Important to note is that in the visual editor everything looks fine, it is only on clicking "save" that the result is garbled. Doesn't that really narrow down the sp... [09:15:45] 10VisualEditor, 10Documentation: Document how to configure the VE extension's Upload feature to use local repository - https://phabricator.wikimedia.org/T202082 (10Deskana) p:05Triage>03Lowest Documenting things for third parties is very low on my list of priorities right now. The annual plan is quite tigh... [09:22:23] 10VisualEditor, 10Documentation, 10User-Ryasmeen: Document the extra features in VE upload wizard functionality for end-users - https://phabricator.wikimedia.org/T202078 (10Deskana) 05Open>03Resolved p:05Triage>03Low a:03Deskana I made [[https://www.mediawiki.org/w/index.php?title=Help:VisualEditor... [09:25:48] 10VisualEditor, 10OOUI: [Regression] Tick box in Upload tab is misaligned in the visual editor - https://phabricator.wikimedia.org/T202124 (10Deskana) [09:26:17] 10VisualEditor, 10OOUI: [Regression] Tick box in Upload tab is misaligned in the visual editor - https://phabricator.wikimedia.org/T202124 (10Deskana) p:05Triage>03High This is broken in production. [09:26:55] 10VisualEditor-MediaWiki, 10Browser-Support-Firefox, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Verified, and 2 others: Switching between old WTE and visual editing doesn't preserve changes - https://phabricator.wikimedia.org/T199655 (10Deskana) 05Open>03Resolved [09:27:10] 10VisualEditor-ContentEditable, 10ContentTranslation, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review, and 3 others: Allow cursoring between active nodes - https://phabricator.wikimedia.org/T200525 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [09:27:45] 10VisualEditor, 10OOUI: [Regression] Tick box in Upload tab is misaligned in the visual editor - https://phabricator.wikimedia.org/T202124 (10Deskana) [09:27:47] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0), 10Regression, 10VisualEditor (Current work): [regression] Layout issues in feedback dialog - https://phabricator.wikimedia.org/T201871 (10Deskana) [09:28:19] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0), 10Regression, 10VisualEditor (Current work): [regression] Layout issues in feedback dialog - https://phabricator.wikimedia.org/T201871 (10Deskana) [09:28:29] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0), 10Regression, 10VisualEditor (Current work): [regression] Layout issues in feedback dialog - https://phabricator.wikimedia.org/T201871 (10Deskana) p:05Triage>03Normal [09:28:32] 10VisualEditor-ContentEditable, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10VisualEditor (Current work): It is possible to get the cursor into a block slug - https://phabricator.wikimedia.org/T201599 (10Deskana) p:05Triage>03Normal [09:28:37] 10VisualEditor-DataModel, 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Technical-Debt, 10VisualEditor (Current work): Generalize logic for inserting a block level element into an empty paragraph (it should replac... - https://phabricator.wikimedia.org/T201573 [09:28:44] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10VisualEditor (Current work): List insertion by typing '#', '*' is broken - https://phabricator.wikimedia.org/T201472 (10Deskana) p:05Triage>03Normal [09:28:50] 10VisualEditor-Links, 10Browser-Support-Internet-Explorer, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10VisualEditor (Current work): VisualEditor linking doesn’t work in IE11 - https://phabricator.wikimedia.org/T200455 (10Deskana) p:05Triage>03Normal [09:28:56] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10VisualEditor (Current work): [Regression pre-wmf.18] Icons for "Page Settings" and "Find and replace" are missing - https://phabricator.wikimedia.org/T202101 (10Deskana) p:05Triage>03Normal [09:30:03] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10Deskana) p:05Triage>03Normal [09:30:06] 10VisualEditor-ContentEditable, 10Patch-For-Review, 10VisualEditor (Current work): Clicking on focusable inside table cell can jump cursor to start of document - https://phabricator.wikimedia.org/T198912 (10Deskana) p:05Triage>03Normal [09:30:08] 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), and 3 others: Give mobile editor a way to edit more than just a single section at once - https://phabricator.wikimedia.org/T196915 (10Deskana) p:... [09:53:02] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (aac36db2c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453292 (https://phabricator.wikimedia.org/T109529) (owner: 10Jforrester) [10:11:08] 10VisualEditor: A URL with a < in it can't be added using VE - https://phabricator.wikimedia.org/T180949 (10Deskana) p:05Normal>03Low [10:13:49] 10VisualEditor, 10wikitech.wikimedia.org, 10User-Ryasmeen: Source to VE editor switching is broken on wikitech - https://phabricator.wikimedia.org/T183309 (10Deskana) 05Open>03Resolved a:03Deskana I can't reproduce this any more, and there's been a lot of changes to the switching behaviour recently, so... [10:15:33] (03Merged) 10jenkins-bot: Update VE core submodule to master (aac36db2c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453292 (https://phabricator.wikimedia.org/T109529) (owner: 10Jforrester) [10:18:18] (03CR) 10jenkins-bot: Update VE core submodule to master (aac36db2c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453292 (https://phabricator.wikimedia.org/T109529) (owner: 10Jforrester) [10:26:50] 10VisualEditor, 10Browser-Tests, 10User-zeljkofilipin: Make language screenshot bot use a bigger window - https://phabricator.wikimedia.org/T193624 (10Deskana) p:05Triage>03Low [10:27:01] 10VisualEditor: Font size of reference lists is inconsistent when {{reflist}} is used - https://phabricator.wikimedia.org/T194462 (10Deskana) p:05Triage>03Low [10:27:45] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Regression, 10VisualEditor (Current work): [Regression pre-wmf.18] Icons for "Page Settings" and "Find and replace" are missing - https://phabricator.wikimedia.org/T202101 (10Peachey88) [10:28:30] 10VisualEditor, 10Regression: [Regression pre-wmf.18] Clicking on a slug positioned after References list or before a map produces error "Uncaught TypeError: Cannot read property 'getModel' of undefined" - https://phabricator.wikimedia.org/T202103 (10Peachey88) [10:31:19] 10VisualEditor: Any change to this paragraph adds two blank lines after it - https://phabricator.wikimedia.org/T190351 (10Deskana) p:05Triage>03Low [10:32:00] 10VisualEditor, 10VisualEditor-Tables: Allow copy/paste of cell formatting in Visual Editor Tables - https://phabricator.wikimedia.org/T189583 (10Deskana) p:05Triage>03Low [10:33:19] 10VisualEditor, 10User-Ryasmeen: Incorrect "Do you want to leave" message after saving - https://phabricator.wikimedia.org/T189393 (10Deskana) 05Open>03Resolved a:03Deskana There were a number of bugs relating to that message appearing erroneously filed between then and now which have now been fixed. I t... [10:33:57] 10VisualEditor: support custom wikilink procedure per-wiki - https://phabricator.wikimedia.org/T188871 (10Deskana) p:05Triage>03Low [10:34:57] 10VisualEditor, 10Patch-For-Review: Rebaser: Separate history stack by user - https://phabricator.wikimedia.org/T185706 (10Deskana) p:05Triage>03Low [10:36:13] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10Collaboration-Team-Triage, 10Growth-Team, and 2 others: Provide an inline discussion feature, "DiscussThis" - https://phabricator.wikimedia.org/T185607 (10Deskana) p:05Triage>03Lowest This seems out of scope of the annual plan, and the relevant teams... [10:40:50] 10VisualEditor: Switch magic word for showing VisualEditor edit button - https://phabricator.wikimedia.org/T182606 (10Deskana) 05Open>03declined Adding an explicit ability to force the visual editor to load on a page in a namespace where the visual editor is intentionally disabled is not a good workflow. [10:42:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: Page with many tables hangs 2017 WTE - https://phabricator.wikimedia.org/T181723 (10Deskana) 05Open>03Resolved p:05Triage>03Normal a:03Deskana The team made a lot of performance improvements to the 2017 wikitext editor af... [11:08:47] (03CR) 10TheDJ: "Anyone care to +2 ?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/447734 (https://phabricator.wikimedia.org/T198781) (owner: 10TheDJ) [11:18:15] 10VisualEditor: Switch magic word for showing VisualEditor edit button - https://phabricator.wikimedia.org/T182606 (10Tacsipacsi) VE is intentionally disabled on discussion pages. Disabling on other project namespace pages seems a side effect. If you really want, make it incompatible with `__NEWSECTIONLINK__`. [12:04:02] 10VisualEditor-Links, 10Browser-Support-Internet-Explorer, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10VisualEditor (Current work): VisualEditor linking doesn’t work in IE11 - https://phabricator.wikimedia.org/T200455 (10Tacsipacsi) 05Open>03Resolved Confirmed to work (on the Win... [12:34:04] 10VisualEditor, 10Product-Analytics: EPIC: Generate one-off metric snapshots for mobile editing documentation - https://phabricator.wikimedia.org/T202132 (10Deskana) [12:34:54] 10VisualEditor, 10Product-Analytics: Snapshot: usage of common editing features - https://phabricator.wikimedia.org/T202133 (10Deskana) [12:41:01] 10VisualEditor, 10Product-Analytics: Snapshot: edit success rate on desktop and mobile with the visual and wikitext editors - https://phabricator.wikimedia.org/T202134 (10Deskana) [12:48:02] 10VisualEditor, 10Product-Analytics: EPIC: Generate one-off metric snapshots for mobile editing documentation - https://phabricator.wikimedia.org/T202132 (10Deskana) Snapshots for some of these subtasks may already exist, for example in the wiki segmentation tables, but I'm filing all these tasks anyway for co... [12:57:55] 10VisualEditor, 10Product-Analytics: Snapshot: median time to save an edit - https://phabricator.wikimedia.org/T202137 (10Deskana) [13:06:50] 10VisualEditor, 10Product-Analytics: Snapshot: how many edits are made using the visual and wikitext editors? - https://phabricator.wikimedia.org/T202138 (10Deskana) [13:07:23] 10VisualEditor, 10Product-Analytics: Snapshot: how many edits are made using the visual and wikitext editors? - https://phabricator.wikimedia.org/T202138 (10Deskana) [13:07:26] 10VisualEditor, 10Product-Analytics: Snapshot: median time to save an edit - https://phabricator.wikimedia.org/T202137 (10Deskana) [13:07:30] 10VisualEditor, 10Product-Analytics: Snapshot: edit success rate on desktop and mobile with the visual and wikitext editors - https://phabricator.wikimedia.org/T202134 (10Deskana) [13:07:34] 10VisualEditor, 10Product-Analytics: Snapshot: usage of common editing features - https://phabricator.wikimedia.org/T202133 (10Deskana) [13:07:36] 10VisualEditor, 10Product-Analytics: EPIC: Generate one-off metric snapshots for mobile editing documentation - https://phabricator.wikimedia.org/T202132 (10Deskana) [13:07:57] 10VisualEditor, 10Product-Analytics: EPIC: Generate one-off metric snapshots for mobile editing documentation - https://phabricator.wikimedia.org/T202132 (10Deskana) p:05Triage>03High [13:08:18] 10VisualEditor, 10Product-Analytics: Snapshot: usage of common editing features - https://phabricator.wikimedia.org/T202133 (10Deskana) p:05Triage>03High [13:08:21] 10VisualEditor, 10Product-Analytics: Snapshot: edit success rate on desktop and mobile with the visual and wikitext editors - https://phabricator.wikimedia.org/T202134 (10Deskana) p:05Triage>03High [13:08:33] 10VisualEditor, 10Product-Analytics: Snapshot: median time to save an edit - https://phabricator.wikimedia.org/T202137 (10Deskana) p:05Triage>03High [13:08:39] 10VisualEditor, 10Product-Analytics: Snapshot: how many edits are made using the visual and wikitext editors? - https://phabricator.wikimedia.org/T202138 (10Deskana) p:05Triage>03High [13:09:08] (03CR) 10Esanders: Show signatures in NWE visual diff (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453264 (https://phabricator.wikimedia.org/T184166) (owner: 10Tchanders) [13:09:58] (03CR) 10Esanders: [C: 032] Show signatures in NWE visual diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453264 (https://phabricator.wikimedia.org/T184166) (owner: 10Tchanders) [13:14:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453391 (owner: 10L10n-bot) [13:14:14] (03CR) 10Tchanders: Show signatures in NWE visual diff (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453264 (https://phabricator.wikimedia.org/T184166) (owner: 10Tchanders) [13:29:45] (03Merged) 10jenkins-bot: Show signatures in NWE visual diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453264 (https://phabricator.wikimedia.org/T184166) (owner: 10Tchanders) [13:32:27] (03CR) 10jenkins-bot: Show signatures in NWE visual diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453264 (https://phabricator.wikimedia.org/T184166) (owner: 10Tchanders) [15:10:50] (03CR) 10Fomafix: "This is a new feature and I6664a7ff2383d83c7d0fa1fd45e2539fad40c1d0 for CodeEditor and I8b7fd41571a48fa4f6560790d94bb966972e740f for CodeM" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/447734 (https://phabricator.wikimedia.org/T198781) (owner: 10TheDJ) [15:16:45] (03CR) 10Bartosz Dziewoński: "-1" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/452725 (https://phabricator.wikimedia.org/T109529) (owner: 10Esanders) [15:18:45] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10matmarex) (Copying from code review comment so it doesn't get lost)... [15:26:54] 10VisualEditor, 10Product-Analytics: Snapshot: breakdown of mobile-only, desktop-only, and mixed platform users - https://phabricator.wikimedia.org/T202135 (10Deskana) [15:27:31] (03CR) 10Bartosz Dziewoński: "> tabIndex:null is an improvement, but it still leaves a blinking cursor to the left of the comment after it is focused." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [15:27:54] (03CR) 10Bartosz Dziewoński: [C: 031] "This patch seems okay to +2 to me. Right?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [15:29:24] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Test failure is real, you need to update ve.dm.example.commentNodePreview for the changed HTML structure (and maybe some other test stuff)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [16:11:59] 10VisualEditor, 10Product-Analytics: Snapshot: monthly retention rates - https://phabricator.wikimedia.org/T202146 (10Deskana) [16:12:08] 10VisualEditor, 10Product-Analytics: Snapshot: monthly retention rates - https://phabricator.wikimedia.org/T202146 (10Deskana) p:05Triage>03High [16:14:30] 10VisualEditor, 10Product-Analytics: Snapshot: which parts of the edit process cause people to abort edits? - https://phabricator.wikimedia.org/T202147 (10Deskana) [16:14:38] 10VisualEditor, 10Product-Analytics: Snapshot: which parts of the edit process cause people to abort edits? - https://phabricator.wikimedia.org/T202147 (10Deskana) p:05Triage>03High [16:15:00] 10VisualEditor, 10Product-Analytics: Snapshot: which parts of the edit process cause people to abort edits? - https://phabricator.wikimedia.org/T202147 (10Deskana) [16:15:02] 10VisualEditor, 10Product-Analytics: Snapshot: monthly retention rates - https://phabricator.wikimedia.org/T202146 (10Deskana) [16:15:05] 10VisualEditor, 10Product-Analytics: EPIC: Generate one-off metric snapshots for mobile editing documentation - https://phabricator.wikimedia.org/T202132 (10Deskana) [16:20:49] 10VisualEditor, 10Product-Analytics: Instrument editing pipeline to be able to figure out which common editing features are used - https://phabricator.wikimedia.org/T202148 (10Deskana) [16:20:54] 10VisualEditor, 10Product-Analytics: Instrument editing pipeline to be able to figure out which common editing features are used - https://phabricator.wikimedia.org/T202148 (10Deskana) p:05Triage>03High [16:21:34] 10VisualEditor, 10Product-Analytics: EPIC: Generate one-off metric snapshots for mobile editing documentation - https://phabricator.wikimedia.org/T202132 (10Deskana) [16:21:45] 10VisualEditor, 10Product-Analytics: Instrument editing pipeline to be able to figure out which common editing features are used - https://phabricator.wikimedia.org/T202148 (10Deskana) [16:21:48] 10VisualEditor, 10Product-Analytics: Snapshot: usage of common editing features - https://phabricator.wikimedia.org/T202133 (10Deskana) [16:27:33] 10VisualEditor: Line number is misplaced for a code block when it is positioned between an image and a map - https://phabricator.wikimedia.org/T172155 (10Deskana) p:05Normal>03Low [16:28:15] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10User-Josve05a: When converting bare link by pressing convert and then back and filling it out manually, it will create a second footnote - https://phabricator.wikimedia.org/T151692 (10Deskana) p:05Normal>03Low [16:29:40] (03PS1) 10Esanders: Reactive surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) [16:30:46] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10Esanders) Thanks @matmarex, I initially though this wasn't necessary... [16:32:13] 10VisualEditor, 10SQLite: VisualEditor fails with "cannot start a transaction within a transaction" - https://phabricator.wikimedia.org/T166113 (10Deskana) 05Open>03declined Sadly, the Wikimedia Foundation Editing team does not have enough capacity to help with debugging third party installations. All I ca... [16:34:08] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10Esanders) Ah, I remembered why I did it that way, it's because on mo... [16:34:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Parser, 10User-Ryasmeen: Table of contents corrupted on read after VE save - https://phabricator.wikimedia.org/T163291 (10Deskana) 05Open>03Resolved a:03Deskana I can't reproduce this any more, so I assume it got fixed at some point. [16:36:26] (03CR) 10jerkins-bot: [V: 04-1] Reactive surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [16:39:20] (03PS2) 10Jforrester: Reactivate surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [16:46:10] (03CR) 10jerkins-bot: [V: 04-1] Reactivate surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [16:55:50] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [16:59:49] 10VisualEditor, 10Product-Analytics: Instrument editing pipeline to be able to figure out which common editing features are used - https://phabricator.wikimedia.org/T202148 (10Esanders) It is like that the implementation of this will hook into things like ve.ui.Action, (where all most toolbar/user commands get... [17:08:58] (03PS5) 10Jforrester: Make invisible icon button unfocusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [17:09:08] (03PS6) 10Jforrester: Make invisible icon button unfocusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [17:09:43] (03CR) 10Jforrester: "PS5: Rebase. PS6: Comment preview outcome adjusted to match new reality." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [17:15:24] (03CR) 10Esanders: [C: 031] Make invisible icon button unfocusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [17:18:05] (03CR) 10Jforrester: Show signatures in NWE visual diff (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453264 (https://phabricator.wikimedia.org/T184166) (owner: 10Tchanders) [17:18:31] 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10VisualEditor (Current work): Visual diff shows signature as tildes - https://phabricator.wikimedia.org/T184166 (10Jdforrester-WMF) [17:24:40] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10VisualEditor (Current work): Cursor appears over the drop down menu for text styling in Mobile VisualEditor - https://phabricator.wikimedia.org/T109529 (10Jdforrester-WMF) [17:24:51] (03CR) 10Jforrester: [C: 032] Reactivate surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [17:30:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs: Provide diffs on mobile VE/2017WTE, including visual diffs - https://phabricator.wikimedia.org/T188554 (10Esanders) They've always been available on mobile, via the "Review your changes" link at the bottom of the dialog (same as desktop),... [17:31:03] (03CR) 10jerkins-bot: [V: 04-1] Reactivate surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [17:49:42] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10Patch-For-Review: On mobile, cursoring off a focusable node fails - https://phabricator.wikimedia.org/T147304 (10Esanders) This bug is probably OS dependent. I also note that we accidentally broke the code path that deactivates the... [18:18:20] (03CR) 10Jforrester: [C: 032] Toolbar: Add a new 'toggle' tool type [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/447734 (https://phabricator.wikimedia.org/T198781) (owner: 10TheDJ) [18:18:39] (03CR) 10Jforrester: [C: 031] "Actually, yeah, let's bump the version for clarity." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/447734 (https://phabricator.wikimedia.org/T198781) (owner: 10TheDJ) [18:19:42] (03PS5) 10Jforrester: Toolbar: Add a new 'toggle' tool type; declare as v0.5.2 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/447734 (https://phabricator.wikimedia.org/T198781) (owner: 10TheDJ) [18:21:14] (03PS1) 10Jforrester: Bump MediaWiki dependency to 1.32+, given we're adjusting based on OOUI changes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/453453 [18:21:59] (03CR) 10Jforrester: [C: 032] Toolbar: Add a new 'toggle' tool type; declare as v0.5.2 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/447734 (https://phabricator.wikimedia.org/T198781) (owner: 10TheDJ) [18:37:40] (03PS1) 10Esanders: Follow-up Ib463485: Get rid of broken ve.ui.Surface#isMobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 [18:43:47] (03CR) 10jerkins-bot: [V: 04-1] Follow-up Ib463485: Get rid of broken ve.ui.Surface#isMobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 (owner: 10Esanders) [18:48:25] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 (owner: 10Esanders) [18:48:40] (03CR) 10Jforrester: [C: 032] Make invisible icon button unfocusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [18:51:41] (03CR) 10jerkins-bot: [V: 04-1] Follow-up Ib463485: Get rid of broken ve.ui.Surface#isMobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 (owner: 10Esanders) [18:55:25] (03CR) 10jerkins-bot: [V: 04-1] Make invisible icon button unfocusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [19:04:20] 10VisualEditor, 10VisualEditor-VisualDiffs: Single line breaks shown a little strangely - https://phabricator.wikimedia.org/T178780 (10Tchanders) This behaviour is caused by the CSS fix to T170114, which preserves whitespace in removed/inserted content, so we can see removed/inserted spaces properly. There's a... [19:08:43] (03Merged) 10jenkins-bot: Toolbar: Add a new 'toggle' tool type; declare as v0.5.2 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/447734 (https://phabricator.wikimedia.org/T198781) (owner: 10TheDJ) [19:15:57] (03PS1) 10Tchanders: Show whitespace HTML chars in converter preview mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453463 (https://phabricator.wikimedia.org/T178780) [19:22:20] (03CR) 10jerkins-bot: [V: 04-1] Show whitespace HTML chars in converter preview mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453463 (https://phabricator.wikimedia.org/T178780) (owner: 10Tchanders) [19:41:18] (03CR) 10Bartosz Dziewoński: [C: 031] Reactivate surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [19:41:32] (03CR) 10Bartosz Dziewoński: [C: 032] Reactivate surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [19:42:25] (03CR) 10Bartosz Dziewoński: [C: 032] Make invisible icon button unfocusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [19:44:12] (03CR) 10Bartosz Dziewoński: [C: 032] Bump MediaWiki dependency to 1.32+, given we're adjusting based on OOUI changes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/453453 (owner: 10Jforrester) [19:49:57] (03Merged) 10jenkins-bot: Reactivate surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [19:49:59] (03Merged) 10jenkins-bot: Make invisible icon button unfocusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [19:56:51] (03CR) 10jenkins-bot: Reactivate surface on toolbar close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453430 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [19:57:33] (03CR) 10Bartosz Dziewoński: [C: 032] Follow-up Ib463485: Get rid of broken ve.ui.Surface#isMobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 (owner: 10Esanders) [20:02:24] (03CR) 10jenkins-bot: Make invisible icon button unfocusable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/444123 (https://phabricator.wikimedia.org/T198912) (owner: 10Esanders) [20:03:40] (03CR) 10jerkins-bot: [V: 04-1] Follow-up Ib463485: Get rid of broken ve.ui.Surface#isMobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 (owner: 10Esanders) [20:19:43] (03Merged) 10jenkins-bot: Bump MediaWiki dependency to 1.32+, given we're adjusting based on OOUI changes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/453453 (owner: 10Jforrester) [20:46:14] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 (owner: 10Esanders) [20:46:53] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453463 (https://phabricator.wikimedia.org/T178780) (owner: 10Tchanders) [20:52:17] (03Merged) 10jenkins-bot: Follow-up Ib463485: Get rid of broken ve.ui.Surface#isMobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 (owner: 10Esanders) [20:55:57] (03CR) 10jerkins-bot: [V: 04-1] Show whitespace HTML chars in converter preview mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453463 (https://phabricator.wikimedia.org/T178780) (owner: 10Tchanders) [20:57:47] (03CR) 10jenkins-bot: Follow-up Ib463485: Get rid of broken ve.ui.Surface#isMobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453455 (owner: 10Esanders) [20:58:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10User-Ryasmeen: Provide diffs on mobile VE/2017WTE, including visual diffs - https://phabricator.wikimedia.org/T188554 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders Huh, yes, they're there now, at least? {F25075094, size=ful... [21:24:13] 10Editing-team, 10VisualEditor, 10MediaWiki-extensions-Quiz, 10Wikimedia-log-errors: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 - https://phabricator.wikimedia.org/T196684 (10Umherirrender) It is possible to extract a project and a wiki page from the request data for this log... [21:41:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453523 (owner: 10L10n-bot) [22:05:28] 10Editing-team, 10MassMessage, 10Patch-For-Review, 10Wikimedia-log-errors: Notice: Undefined index: 0 in /srv/mediawiki/php-1.27.0-wmf.9/extensions/MassMessage/includes/MassMessage.php on line 391 - https://phabricator.wikimedia.org/T123258 (10Umherirrender) 6 wikis may affected, because there are using cu... [22:08:34] (03CR) 10Bartosz Dziewoński: "(fixed in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/453430)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/452725 (https://phabricator.wikimedia.org/T109529) (owner: 10Esanders) [22:09:46] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (a73097d43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453536 (https://phabricator.wikimedia.org/T198912) [22:10:09] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (a73097d43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453536 (https://phabricator.wikimedia.org/T198912) (owner: 10Bartosz Dziewoński) [22:14:17] (03CR) 10Jforrester: "Oops, I hadn't pushed this as git review was asking me to confirm locally. Sorry!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453536 (https://phabricator.wikimedia.org/T198912) (owner: 10Bartosz Dziewoński) [22:14:41] 10VisualEditor-ContentEditable, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10VisualEditor (Current work): Clicking on focusable inside table cell can jump cursor to start of document - https://phabricator.wikimedia.org/T198912 (10Jdforrester-WMF) [22:14:52] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10Jdforrester-WMF) [22:31:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (a73097d43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453536 (https://phabricator.wikimedia.org/T198912) (owner: 10Bartosz Dziewoński) [22:33:36] (03CR) 10jenkins-bot: Update VE core submodule to master (a73097d43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/453536 (https://phabricator.wikimedia.org/T198912) (owner: 10Bartosz Dziewoński)