[03:59:07] 10Editing-team, 10VisualEditor, 10MediaWiki-extensions-Quiz, 10Wikimedia-log-errors: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 - https://phabricator.wikimedia.org/T196684 (10Krinkle) Last 7 days: | Domain | Count |--|-- | en.wikiversity.org | 33 |it.wikibooks.org| 8 |it.wik... [06:21:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453920 (owner: 10L10n-bot) [07:25:19] (03PS6) 10Divec: WIP Cursor into table captions if present, instead of the first cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448580 (https://phabricator.wikimedia.org/T201870) (owner: 10Esanders) [08:02:55] (03PS7) 10Divec: Cursor into table captions if present, instead of the first cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448580 (https://phabricator.wikimedia.org/T201870) (owner: 10Esanders) [08:09:06] (03CR) 10jerkins-bot: [V: 04-1] Cursor into table captions if present, instead of the first cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/448580 (https://phabricator.wikimedia.org/T201870) (owner: 10Esanders) [10:20:54] (03PS2) 10Esanders: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [10:25:24] (03PS3) 10Esanders: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [10:31:06] (03CR) 10jerkins-bot: [V: 04-1] Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [10:40:14] 10Editing-team, 10VisualEditor, 10MediaWiki-extensions-Quiz, 10Patch-For-Review, 10Wikimedia-log-errors: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 - https://phabricator.wikimedia.org/T196684 (10Umherirrender) Thanks for the data. It is the answer '0' in https://en.wikiver... [11:04:08] 10Citoid, 10VisualEditor: Allow restbase url to be set directly in Citoid extension, overwriting the VE url. - https://phabricator.wikimedia.org/T202271 (10Mvolz) [11:06:29] 10Citoid, 10VisualEditor: Allow restbase url to be set directly in Citoid extension, overwriting the VE url. - https://phabricator.wikimedia.org/T202271 (10Mvolz) [12:35:17] (03PS4) 10Esanders: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [12:35:44] (03CR) 10Esanders: [C: 031] "+1 for David's contributions" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [12:36:23] 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10Patch-For-Review, 10VisualEditor (Current work): On mobile, cursoring off a focusable node fails - https://phabricator.wikimedia.org/T147304 (10Esanders) [12:39:21] 10VisualEditor, 10VisualEditor-EditingTools: Remember cell background colour when copying and pasting from external source into wikitable in Visual Editor - https://phabricator.wikimedia.org/T202279 (10Mrjohncummings) [12:42:57] (03CR) 10jerkins-bot: [V: 04-1] Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [12:48:33] (03PS5) 10Divec: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) [12:54:59] (03CR) 10jerkins-bot: [V: 04-1] Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [12:58:50] (03PS6) 10Divec: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) [13:05:11] (03CR) 10jerkins-bot: [V: 04-1] Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [13:06:23] (03PS7) 10Divec: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) [13:11:57] (03PS1) 10Esanders: Blur activateElement when deactivating the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454013 (https://phabricator.wikimedia.org/T201329) [13:12:40] (03CR) 10jerkins-bot: [V: 04-1] Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [13:12:49] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10Esanders) The above patch fixes the issue on iOS (which also require... [13:13:19] (03CR) 10Esanders: [C: 031] "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [13:17:13] 10VisualEditor, 10Continuous-Integration-Infrastructure: Docker headless Chrome running is sometimes silently terminating on start(?), making it impossible to merge code in VE - https://phabricator.wikimedia.org/T200347 (10Esanders) p:05Triage>03High This is happening far too often. Here it is timing out 4... [13:19:07] (03CR) 10jerkins-bot: [V: 04-1] Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [13:45:12] 10VisualEditor, 10VisualEditor-ContentEditable, 10Epic, 10MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)): DM/DOM sync can break if you use an IME - https://phabricator.wikimedia.org/T116275 (10dchan) 05Resolved>03Open It's still possible to trigger this bug, though Change 247800 made things muc... [14:00:13] (03PS2) 10Bartosz Dziewoński: Blur activateElement when deactivating the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454013 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [14:05:37] 10VisualEditor, 10VisualEditor-ContentEditable, 10Epic, 10MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)): DM/DOM sync can break if you use an IME - https://phabricator.wikimedia.org/T116275 (10dchan) [14:06:11] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10Esanders) >>! In T197563#4507393, @DLynch wrote: > This is all still going to leave us with the fun problem that VE's... [14:10:02] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10Anomie) >>! In T197563#4514766, @Esanders wrote: > Aren't the imported style rules scoped in such a way that they onl... [14:13:22] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10Esanders) Ok. I don't think leaving old stylesheets on the page would make the experience //much// worse. Let's get t... [15:24:20] 10VisualEditor, 10ContentTranslation, 10Performance-Team, 10JavaScript: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10Krinkle) [15:25:56] 10VisualEditor, 10Continuous-Integration-Infrastructure: Docker headless Chrome running is sometimes silently terminating on start(?), making it impossible to merge code in VE - https://phabricator.wikimedia.org/T200347 (10mmodell) ```14:57:01 ImportError: No module named compiler.ast 14:57:01 gyp ERR! configu... [15:27:18] 10VisualEditor, 10ContentTranslation, 10Performance-Team, 10JavaScript: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10Krinkle) The issue is not with how the code is registered or delivered, the trace comes from from `ext.visualEditor.t... [15:27:41] 10VisualEditor, 10ContentTranslation, 10Performance-Team, 10JavaScript: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10Krinkle) p:05Low>03Triage [15:47:26] 10VisualEditor, 10Continuous-Integration-Infrastructure: Docker headless Chrome running is sometimes silently terminating on start(?), making it impossible to merge code in VE - https://phabricator.wikimedia.org/T200347 (10mmodell) So I think that the python import error is a red herring. It looks like Firefox... [15:58:48] 10VisualEditor, 10Continuous-Integration-Infrastructure: Docker headless Chrome running is sometimes silently terminating on start(?), making it impossible to merge code in VE - https://phabricator.wikimedia.org/T200347 (10Esanders) Yes, I always assumed this 30s test timeout was the issue, but don't know what... [16:00:05] 10VisualEditor, 10ContentTranslation, 10MediaWiki-General-or-Unknown, 10Performance-Team, 10JavaScript: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10matmarex) Percent-decoding `Apollo%96Soyuz_Test_Project` gives a byte sequence that... [16:05:14] 10VisualEditor, 10ContentTranslation, 10MediaWiki-General-or-Unknown, 10Performance-Team, 10JavaScript: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10Krinkle) Thanks @matmarex. It seems that PHP and/or Varnish do support this invalid... [16:16:02] 10VisualEditor, 10ContentTranslation, 10MediaWiki-General-or-Unknown, 10Performance-Team, 10JavaScript: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10matmarex) >>! In T106244#4515372, @Krinkle wrote: > Thanks @matmarex. It seems that... [16:18:57] 10VisualEditor, 10ContentTranslation, 10Core-Platform-Team, 10MediaWiki-General-or-Unknown, and 2 others: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10Krinkle) [16:24:15] 10VisualEditor, 10ContentTranslation, 10Core-Platform-Team, 10MediaWiki-General-or-Unknown, and 2 others: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10matmarex) I tested and http://localhost/wiki/%96 also loads the page titled `–` on... [16:31:48] 10Citoid, 10VisualEditor, 10Services (later): Don't include requests from automated checks in stats - https://phabricator.wikimedia.org/T202001 (10Pchelolo) [16:36:46] 10VisualEditor, 10ContentTranslation, 10Core-Platform-Team, 10MediaWiki-General-or-Unknown, and 2 others: URL encoded values to the page parameter cause the CX page to not load - https://phabricator.wikimedia.org/T106244 (10matmarex) Never mind, I found where MediaWiki converts the encoding. In WebRequest:... [16:57:44] 10VisualEditor, 10Continuous-Integration-Infrastructure: Docker headless Chrome running is sometimes silently terminating on start(?), making it impossible to merge code in VE - https://phabricator.wikimedia.org/T200347 (10mmodell) That would probably be wise at least for now, since it seems to be only Firefox... [17:31:32] (03PS1) 10DLynch: GeneratedContentNode: make rendered element filtering overridable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454068 (https://phabricator.wikimedia.org/T197563) [17:38:52] (03CR) 10jerkins-bot: [V: 04-1] GeneratedContentNode: make rendered element filtering overridable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454068 (https://phabricator.wikimedia.org/T197563) (owner: 10DLynch) [17:39:32] (03CR) 10DLynch: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454068 (https://phabricator.wikimedia.org/T197563) (owner: 10DLynch) [17:39:45] (03PS1) 10DLynch: TemplateStyles support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454069 (https://phabricator.wikimedia.org/T197563) [17:45:44] (03CR) 10jerkins-bot: [V: 04-1] GeneratedContentNode: make rendered element filtering overridable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454068 (https://phabricator.wikimedia.org/T197563) (owner: 10DLynch) [17:49:10] 10VisualEditor, 10Wikimedia-Site-requests: Deploy CollabPad to officewiki - https://phabricator.wikimedia.org/T196211 (10Whatamidoing-WMF) This kind of multi-person, real-time editing might be useful for edit-a-thons and student groups, too. Education programs could work together on a draft (e.g., in userspac... [17:49:14] (03PS1) 10Jforrester: build: Temporarily disable qunit testing in Firefox due to CI issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454072 (https://phabricator.wikimedia.org/T200347) [17:49:42] 10VisualEditor-MediaWiki-Templates, 10TemplateStyles, 10Patch-For-Review, 10VisualEditor (Current work): Template styles get ignored when switching to Visual Editor - https://phabricator.wikimedia.org/T197563 (10DLynch) The remaining TODO after those patches: if multiple copies of a template with deduplica... [17:53:05] 10VisualEditor, 10Wikimedia-Site-requests: Deploy CollabPad to officewiki - https://phabricator.wikimedia.org/T196211 (10Ragesoss) @Whatamidoing-WMF no, I haven't tried it, but definitely interested! A good shared editing tool would be really useful for most of the kinds of programs on both Wiki Education Dash... [17:56:52] (03PS1) 10Jforrester: build: Bump `grunt-css-url-embed` and `karma` to latest to avoid security issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454073 [17:59:14] (03PS2) 10Jforrester: GeneratedContentNode: make rendered element filtering overridable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454068 (https://phabricator.wikimedia.org/T197563) (owner: 10DLynch) [17:59:20] (03CR) 10jerkins-bot: [V: 04-1] TemplateStyles support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454069 (https://phabricator.wikimedia.org/T197563) (owner: 10DLynch) [17:59:58] (03PS8) 10Jforrester: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [18:00:55] (03PS3) 10Jforrester: Blur activateElement when deactivating the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454013 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [18:01:35] (03CR) 10jerkins-bot: [V: 04-1] build: Bump `grunt-css-url-embed` and `karma` to latest to avoid security issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454073 (owner: 10Jforrester) [18:06:57] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454073 (owner: 10Jforrester) [18:07:21] (03CR) 1020after4: [C: 031] build: Temporarily disable qunit testing in Firefox due to CI issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454072 (https://phabricator.wikimedia.org/T200347) (owner: 10Jforrester) [18:10:53] (03PS2) 10Jforrester: Show whitespace HTML chars in converter preview mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453463 (https://phabricator.wikimedia.org/T178780) (owner: 10Tchanders) [18:12:34] (03CR) 10Divec: [C: 032] build: Temporarily disable qunit testing in Firefox due to CI issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454072 (https://phabricator.wikimedia.org/T200347) (owner: 10Jforrester) [18:14:33] (03CR) 10jerkins-bot: [V: 04-1] Show whitespace HTML chars in converter preview mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453463 (https://phabricator.wikimedia.org/T178780) (owner: 10Tchanders) [18:15:07] (03CR) 10jerkins-bot: [V: 04-1] build: Bump `grunt-css-url-embed` and `karma` to latest to avoid security issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454073 (owner: 10Jforrester) [18:17:50] (03Merged) 10jenkins-bot: build: Temporarily disable qunit testing in Firefox due to CI issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454072 (https://phabricator.wikimedia.org/T200347) (owner: 10Jforrester) [18:21:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Change MediaWiki:Tag-visualeditor-switched-description to be accurate - https://phabricator.wikimedia.org/T202313 (10Whatamidoing-WMF) [18:23:23] (03CR) 10Divec: [C: 032] Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [18:27:37] (03CR) 10jenkins-bot: build: Temporarily disable qunit testing in Firefox due to CI issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454072 (https://phabricator.wikimedia.org/T200347) (owner: 10Jforrester) [18:28:28] (03Merged) 10jenkins-bot: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [18:34:37] (03CR) 10jenkins-bot: Reactivate mobile surface in onModelSelect for native selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [19:10:07] 10VisualEditor-Tables, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Insertion link into an empty table cell causes scroll jump - https://phabricator.wikimedia.org/T191878 (10Ryasmeen) @Esanders: It happens in both Chrome and FF, was using this page for testin... [19:13:49] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Regression, 10VisualEditor (Current work): [Regression pre-wmf.18] Icons for "Page Settings" and "Find and replace" are missing - https://phabricator.wikimedia.org/T202101 (10Ryasmeen) @Esanders: The icons are back... [19:25:37] 10VisualEditor, 10Continuous-Integration-Infrastructure, 10Patch-For-Review: Docker headless Chrome running is sometimes silently terminating on start(?), making it impossible to merge code in VE - https://phabricator.wikimedia.org/T200347 (10Esanders) p:05High>03Normal Lowering priority to reflect this... [19:25:53] (03PS2) 10Esanders: build: Bump `grunt-css-url-embed` and `karma` to latest to avoid security issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454073 (owner: 10Jforrester) [19:27:01] (03PS3) 10Esanders: Show whitespace HTML chars in converter preview mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453463 (https://phabricator.wikimedia.org/T178780) (owner: 10Tchanders) [19:27:35] (03CR) 10Esanders: Show whitespace HTML chars in converter preview mode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/453463 (https://phabricator.wikimedia.org/T178780) (owner: 10Tchanders) [19:30:41] (03CR) 10Jforrester: [C: 031] GeneratedContentNode: make rendered element filtering overridable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454068 (https://phabricator.wikimedia.org/T197563) (owner: 10DLynch) [19:31:05] (03CR) 10Jforrester: [C: 031] Blur activateElement when deactivating the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454013 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [19:43:13] 10VisualEditor, 10VisualEditor-EditingTools: Remember cell background colour when copying and pasting from external source into wikitable in Visual Editor - https://phabricator.wikimedia.org/T202279 (10matmarex) [19:43:18] 10VisualEditor, 10VisualEditor-Tables: Allow copy/paste of cell formatting in Visual Editor Tables - https://phabricator.wikimedia.org/T189583 (10matmarex) [19:53:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10Easy: VisualEditor: Sub-heading 4 font, does not match with the other heading style fonts, in Monobook - https://phabricator.wikimedia.org/T72559 (10matmarex) This is still a problem, the font size in the menu doesn't match the font size in the page content: {F2518... [19:56:51] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Verified, 10VisualEditor (Current work): Cursor appears over the drop down menu for text styling in Mobile VisualEditor - https://phabricator.wikimedia.org/T109529 (10Ryasmeen) [19:57:43] 10Citoid, 10VisualEditor, 10Services (later): Don't include requests from automated checks in stats - https://phabricator.wikimedia.org/T202001 (10Pchelolo) The user-agent is not included in the stat itself for obvious reasons. The `sevice-checker` sets a specific `user-agent` header, and we could programmat... [20:02:26] 10VisualEditor, 10Documentation: Document how to configure the VE extension's Upload feature to use local repository - https://phabricator.wikimedia.org/T202082 (10matmarex) > The Upload modal wizard in VE (as documented at https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide#Uploading_images) sends all... [20:03:05] 10VisualEditor, 10VisualEditor-VisualDiffs, 10JavaScript: Visualdiff stuck on particular diff due to "null is not an object"-error - https://phabricator.wikimedia.org/T202324 (10TheDJ) [20:08:58] visualdiff hang: https://en.wikipedia.org/w/index.php?title=&diff=prev&oldid=855780722&diffmode=visual [20:08:58] [Warning] jQuery.Deferred exception: null is not an object (evaluating 'this.listNode.connect') – "onSetup@https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=diffMatchPatch%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cuni…" – undefined (load.php, line 52) [20:10:05] 10VisualEditor, 10ProofreadPage: Visual Editor set double header in ProofreadPage header - https://phabricator.wikimedia.org/T202200 (10matmarex) Thanks for the report. Link for convenience: https://en.wikisource.org/wiki/Page:Mahabharata_-_the_epic_of_ancient_India.djvu/119 Apparently, it is possible to cop... [20:26:15] 10VisualEditor, 10ProofreadPage: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10matmarex) This took a while to find, because the issue only occurs when switching from wikitext to VE. I couldn't reproduce the problem when going from the view mode directly to... [20:27:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454140 (owner: 10L10n-bot) [20:47:23] 10VisualEditor, 10Parsoid: Parsoid serialises `\w` to a tag (rather than discarding), which then breaks the page - https://phabricator.wikimedia.org/T130224 (10Arlolra) [20:50:46] (03CR) 10Divec: [C: 032] Blur activateElement when deactivating the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454013 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [20:55:59] (03Merged) 10jenkins-bot: Blur activateElement when deactivating the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454013 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [20:57:11] thedj: Lame. Thanks. :-( [20:57:50] (03CR) 10jenkins-bot: Blur activateElement when deactivating the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/454013 (https://phabricator.wikimedia.org/T201329) (owner: 10Esanders) [21:13:10] 10VisualEditor, 10ProofreadPage: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10matmarex) p:05Unbreak!>03Triage a:03matmarex I don't think this needed to be marked as "Unbreak Now!". The issue has existed for a while, and ProofreadPage is able to deal... [21:13:24] 10VisualEditor, 10ProofreadPage: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10matmarex) Wikisource discussion for reference: https://en.wikisource.org/wiki/Wikisource:Scriptorium/Help#Wuthering_Heights [21:16:59] 10VisualEditor, 10ProofreadPage: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10Mpaa) Yes, that it is how I reproduced. To clarify: 1) I went to edit mode, wikitext by default, then w/o saving 2) I switched to VE, 3) I saved. The problem is that when user=... [21:17:44] 10VisualEditor, 10ProofreadPage: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10Mpaa) p:05Triage>03Normal [21:18:01] 10VisualEditor, 10ProofreadPage: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10Mpaa) p:05Normal>03Triage [21:19:07] 10VisualEditor, 10ProofreadPage: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10Framawiki) >>! In T202197#4516595, @matmarex wrote: > existing usernames already saved in existing content can become invalid, e.g. when the user is renamed). Is it a bug that n... [21:22:06] 10VisualEditor, 10ProofreadPage: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10Mpaa) >>! In T202197#4516595, @matmarex wrote: > I don't think this needed to be marked as "Unbreak Now!". The issue has existed for a while, and ProofreadPage is able to deal wi... [21:29:32] 10VisualEditor, 10ProofreadPage: Visual Editor set double header in ProofreadPage header - https://phabricator.wikimedia.org/T202200 (10Mpaa) Hi. Also here I switched from wikitext to VE. And then just save, no other actions. [21:33:13] 10VisualEditor, 10ProofreadPage: Visual Editor set double header in ProofreadPage header - https://phabricator.wikimedia.org/T202200 (10Mpaa) BTW, I could not find a way to edit a page directly in VE. So I need to switch. [21:33:18] 10VisualEditor, 10ProofreadPage, 10Patch-For-Review: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10matmarex) >>! In T202197#4516622, @Framawiki wrote: >>>! In T202197#4516595, @matmarex wrote: >> existing usernames already saved in existing content can be... [21:34:31] 10VisualEditor, 10ProofreadPage, 10Patch-For-Review: Visual Editor removes user from ProofreadPage header - https://phabricator.wikimedia.org/T202197 (10matmarex) The proper solution to that problem would be to not store the page status information in the page text, but rather in some dedicated database tabl... [22:22:03] 10VisualEditor, 10Documentation, 10User-Ryasmeen: Document how to configure the VE extension's Upload feature to use local repository - https://phabricator.wikimedia.org/T202082 (10Quiddity) 05Open>03Resolved Ah! That makes sense, thanks. :) I've added a note pointing to that section, at https://www.medi... [22:27:54] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454165 (https://phabricator.wikimedia.org/T202101) [22:32:08] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): [Regression pre-wmf.18] Icons for "Page Settings" and "Find and replace" are missing - https://phabricator.wikimedia.org/T202101 (10matmarex) For fut... [22:34:25] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (510506739) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454168 (https://phabricator.wikimedia.org/T147304) [22:38:43] (03CR) 10Jforrester: [C: 032] ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454165 (https://phabricator.wikimedia.org/T202101) (owner: 10Bartosz Dziewoński) [22:38:48] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (510506739) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454168 (https://phabricator.wikimedia.org/T147304) (owner: 10Bartosz Dziewoński) [22:40:41] MatmaRex: I need to stop generating pull-throughs and forgetting to push them. That's the third time in the past week. :-) [22:41:48] James_F: :D [22:42:12] MatmaRex: Thank you for being on top of things. :-) [22:51:10] 10VisualEditor: Undo notification is not sent if the editor switches to the visual editor - https://phabricator.wikimedia.org/T185548 (10Catrope) Untagging Notifications; this is almost certainly due to VE failing to pass the undo/undoafter parameter(s) to the edit API. [22:55:13] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Parsoid serialises `\w` to a tag (rather than discarding), which then breaks the page - https://phabricator.wikimedia.org/T130224 (10ssastry) 05Open>03Resolved a:03ssastry [22:55:57] (03Merged) 10jenkins-bot: ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454165 (https://phabricator.wikimedia.org/T202101) (owner: 10Bartosz Dziewoński) [22:56:01] (03Merged) 10jenkins-bot: Update VE core submodule to master (510506739) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454168 (https://phabricator.wikimedia.org/T147304) (owner: 10Bartosz Dziewoński) [22:56:22] 10VisualEditor, 10Regression: [Regression pre-wmf.18] Clicking on a slug positioned after References list or before a map produces error "Uncaught TypeError: Cannot read property 'getModel' of undefined" - https://phabricator.wikimedia.org/T202103 (10matmarex) I can't reproduce this on Beta or locally. [22:58:58] (03CR) 10jenkins-bot: ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454165 (https://phabricator.wikimedia.org/T202101) (owner: 10Bartosz Dziewoński) [23:01:11] (03CR) 10jenkins-bot: Update VE core submodule to master (510506739) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454168 (https://phabricator.wikimedia.org/T147304) (owner: 10Bartosz Dziewoński) [23:05:02] 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10VisualEditor (Current work): On mobile, cursoring off a focusable node fails - https://phabricator.wikimedia.org/T147304 (10Jdforrester-WMF) [23:05:16] 10VisualEditor, 10Continuous-Integration-Infrastructure: Docker headless Chrome running is sometimes silently terminating on start(?), making it impossible to merge code in VE - https://phabricator.wikimedia.org/T200347 (10Jdforrester-WMF) [23:05:42] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10VisualEditor (Current work): Mobile: Hide keyboard while menus are open - https://phabricator.wikimedia.org/T201329 (10Jdforrester-WMF) [23:12:35] 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Parsoid serialises `\w` to a tag (rather than discarding), which then breaks the page - https://phabricator.wikimedia.org/T130224 (10Arlolra) 05Resolved>03Open I don't think this is resolved since it's asking for Parsoid to drop empty unnamed... [23:18:51] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): [Regression pre-wmf.18] Icons for "Page Settings" and "Find and replace" are missing - https://phabricator.wikimedia.org/T202101 (10matmarex) @Ryasme... [23:19:13] 10VisualEditor, 10ProofreadPage, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10User-Ryasmeen: ProofreadPage uses removed 'clip' icon - https://phabricator.wikimedia.org/T202337 (10matmarex) 05Open>03Resolved a:03matmarex