[00:42:44] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457111 (owner: 10Libraryupgrader) [01:04:07] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457111 (owner: 10Libraryupgrader) [06:27:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457323 (owner: 10L10n-bot) [07:04:06] 10VisualEditor, 10VisualEditor-DataModel, 10ContentTranslation, 10Language-2018-July-September, and 2 others: CX2: "Mark as missing" not working with undo - https://phabricator.wikimedia.org/T202440 (10Pginer-WMF) 05Open>03Resolved [10:46:25] (03CR) 10Esanders: [C: 04-1] "Needs unit tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456743 (https://phabricator.wikimedia.org/T108506) (owner: 10Bartosz Dziewoński) [10:50:31] (03CR) 10Esanders: [C: 04-1] ve.ce.Surface: Consistently sanitize external pastes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456743 (https://phabricator.wikimedia.org/T108506) (owner: 10Bartosz Dziewoński) [11:01:35] 10VisualEditor, 10ContentTranslation, 10Design, 10Language-2018-October-December: Tools column responsiveness with VE Context tools minimum width - https://phabricator.wikimedia.org/T192049 (10Pginer-WMF) [12:41:14] 10VisualEditor-MediaWiki-Templates, 10OOUI, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Regression, and 4 others: VisualEditor citation template dialog has unnecessarily large input boxes - https://phabricator.wikimedia.org/T200834 (10Trizek-WMF) [13:29:00] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Mobile native selection context menu can obscure the VE toolbar - https://phabricator.wikimedia.org/T202723 (10Esanders) a:03Esanders [14:22:52] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Fix a test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457465 [14:28:23] (03PS1) 10Bartosz Dziewoński: Add another test case for stripping RESTBase IDs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457467 (https://phabricator.wikimedia.org/T108506) [14:28:59] (03CR) 10Bartosz Dziewoński: "Added a test case in VE-MW in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/457467 (currently failing, passes with " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456743 (https://phabricator.wikimedia.org/T108506) (owner: 10Bartosz Dziewoński) [14:31:38] (03PS3) 10Bartosz Dziewoński: ve.ce.Surface: Consistently sanitize external pastes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456743 (https://phabricator.wikimedia.org/T108506) [14:41:38] (03CR) 10jerkins-bot: [V: 04-1] Add another test case for stripping RESTBase IDs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457467 (https://phabricator.wikimedia.org/T108506) (owner: 10Bartosz Dziewoński) [14:45:40] (03CR) 10Bartosz Dziewoński: [C: 032] Fix: Apply placeholder colour style to first child, not parent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/456655 (owner: 10Esanders) [14:47:31] (03CR) 10Bartosz Dziewoński: [C: 032] Cleanup: Don't assume commands exist when building list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456749 (https://phabricator.wikimedia.org/T203282) (owner: 10Esanders) [14:51:44] (03CR) 10Bartosz Dziewoński: [C: 032] Do not display editor on non-wikitext pages [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/456887 (owner: 10Seb35) [14:51:50] (03Merged) 10jenkins-bot: Cleanup: Don't assume commands exist when building list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456749 (https://phabricator.wikimedia.org/T203282) (owner: 10Esanders) [14:53:39] (03CR) 10Bartosz Dziewoński: [C: 032] "(I was looking to see if there was a bug filed about this, but there isn't one.)" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/456887 (owner: 10Seb35) [14:56:29] (03CR) 10jenkins-bot: Cleanup: Don't assume commands exist when building list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456749 (https://phabricator.wikimedia.org/T203282) (owner: 10Esanders) [15:00:12] 10TemplateData, 10VisualEditor: Parameter suggestion does not work in the TemplateData editor on the documentation pages other than /doc - https://phabricator.wikimedia.org/T203341 (10matmarex) 05Open>03Invalid a:03matmarex You can override the subpage name used by TemplateData using the message 'templat... [15:06:47] (03CR) 10Bartosz Dziewoński: [C: 032] "Okay, whatever" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455163 (https://phabricator.wikimedia.org/T196117) (owner: 10Esanders) [15:06:52] (03Merged) 10jenkins-bot: Fix: Apply placeholder colour style to first child, not parent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/456655 (owner: 10Esanders) [15:06:55] (03Merged) 10jenkins-bot: Do not display editor on non-wikitext pages [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/456887 (owner: 10Seb35) [15:09:25] (03CR) 10jenkins-bot: Fix: Apply placeholder colour style to first child, not parent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/456655 (owner: 10Esanders) [15:10:19] (03CR) 10jenkins-bot: Do not display editor on non-wikitext pages [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/456887 (owner: 10Seb35) [15:14:28] (03PS6) 10Bartosz Dziewoński: Fix problems with MediaWiki messages and non-displaying icons [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/445547 (https://phabricator.wikimedia.org/T160252) (owner: 10Saint Johann) [15:15:27] (03CR) 10Bartosz Dziewoński: "This should fix the test failure. The code was still not working correctly (which was caught by the tests!), because you changed the $form" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/445547 (https://phabricator.wikimedia.org/T160252) (owner: 10Saint Johann) [15:17:00] (03CR) 10Saint Johann: "Ah, rookie mistake. Thanks for helping!" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/445547 (https://phabricator.wikimedia.org/T160252) (owner: 10Saint Johann) [15:17:41] (03CR) 10Bartosz Dziewoński: [C: 031] "Ed, can you review again?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/445547 (https://phabricator.wikimedia.org/T160252) (owner: 10Saint Johann) [15:23:18] (03CR) 10Bartosz Dziewoński: [C: 032] Replace jQuery.grep with Array.prototype.filter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455253 (owner: 10Petar.petkovic) [15:40:53] (03Merged) 10jenkins-bot: Match width of template lookupMenu to input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455163 (https://phabricator.wikimedia.org/T196117) (owner: 10Esanders) [15:40:59] (03Merged) 10jenkins-bot: Replace jQuery.grep with Array.prototype.filter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455253 (owner: 10Petar.petkovic) [15:46:36] (03CR) 10jenkins-bot: Match width of template lookupMenu to input [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455163 (https://phabricator.wikimedia.org/T196117) (owner: 10Esanders) [15:48:14] (03CR) 10Bartosz Dziewoński: [C: 032] "This indeed passes with I38eda4a and fails without it. It's a bit silly that we have to dump the whole example API response into the test " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/456629 (owner: 10Esanders) [15:49:59] (03CR) 10jenkins-bot: Replace jQuery.grep with Array.prototype.filter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455253 (owner: 10Petar.petkovic) [15:50:38] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 10Epic: VE should translate ... into ... - https://phabricator.wikimedia.org/T93081 (10MarkAHershberger) >>! In T93081#4548987, @matmarex wrote: > @MarkAHershberger If you have time to experime... [15:51:28] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 10Epic: VE should translate ... into ... - https://phabricator.wikimedia.org/T93081 (10MarkAHershberger) a:03MarkAHershberger [16:18:48] (03Merged) 10jenkins-bot: Follow-up I38eda4a: Add unit tests for lang/dir in target init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/456629 (owner: 10Esanders) [16:22:06] (03CR) 10jenkins-bot: Follow-up I38eda4a: Add unit tests for lang/dir in target init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/456629 (owner: 10Esanders) [16:39:05] (03Abandoned) 10Iniquity: Add a class to empty TemplateData fields titles (dt) to hide the whole line by CSS [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/445464 (https://phabricator.wikimedia.org/T176956) (owner: 10Iniquity) [16:53:10] (03CR) 10Bartosz Dziewoński: "(Tests added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/456629)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/456610 (https://phabricator.wikimedia.org/T203213) (owner: 10Esanders) [18:00:05] 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Assess VE mobile text input situation for each target wiki - https://phabricator.wikimedia.org/T202647 (10dchan) [18:02:32] 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Assess VE mobile text input situation for each target wiki - https://phabricator.wikimedia.org/T202647 (10dchan) [18:13:46] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?) - https://phabricator.wikimedia.org/T174303 (10Jonesey95) Can someone please fix thi... [18:53:35] 10VisualEditor: ve.ui.MWWikitextStringTransferHandler browser test breaks on unrelated patches - https://phabricator.wikimedia.org/T203411 (10Tgr) [19:05:27] 10VisualEditor, 10Wikimedia-log-errors (Shared Build Failure): QUnit test ve.ui.MWWikitextStringTransferHandler fails with "pending AJAX requests" - https://phabricator.wikimedia.org/T203412 (10Krinkle) [19:05:31] 10VisualEditor, 10Wikimedia-log-errors (Shared Build Failure): QUnit test ve.ui.MWWikitextStringTransferHandler fails with "pending AJAX requests" - https://phabricator.wikimedia.org/T203412 (10Krinkle) p:05Triage>03Unbreak! [19:05:57] 10VisualEditor, 10Wikimedia-log-errors (Shared Build Failure): Jenkins jobs for MediaWiki fail due to ve.ui.MWWikitextStringTransferHandler having "pending AJAX requests" - https://phabricator.wikimedia.org/T203412 (10Krinkle) [19:07:09] 10VisualEditor, 10Wikimedia-log-errors (Shared Build Failure): Jenkins jobs for MediaWiki fail due to ve.ui.MWWikitextStringTransferHandler having "pending AJAX requests" - https://phabricator.wikimedia.org/T203412 (10Krinkle) [19:34:06] (03CR) 10Krinkle: [C: 031] ve.ce.Surface: Make a check for pasted "important elements" faster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456744 (owner: 10Bartosz Dziewoński) [20:00:34] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/457560 (owner: 10Libraryupgrader) [20:19:19] 10VisualEditor: ve.ui.MWWikitextStringTransferHandler browser test breaks on unrelated patches - https://phabricator.wikimedia.org/T203411 (10matmarex) [20:19:21] 10VisualEditor, 10Wikimedia-log-errors (Shared Build Failure): Jenkins jobs for MediaWiki fail due to ve.ui.MWWikitextStringTransferHandler having "pending AJAX requests" - https://phabricator.wikimedia.org/T203412 (10matmarex) [20:21:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457662 (owner: 10L10n-bot) [21:12:15] (03PS1) 10Bartosz Dziewoński: Remove unnecessary "eslint-disable-next-line new-cap" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457686 [21:12:28] (03PS1) 10Bartosz Dziewoński: Remove unnecessary "eslint-disable-next-line new-cap" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457687 [21:33:38] (03CR) 10jerkins-bot: [V: 04-1] Remove unnecessary "eslint-disable-next-line new-cap" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457687 (owner: 10Bartosz Dziewoński) [22:06:32] (03CR) 10Esanders: [C: 032] Remove unnecessary "eslint-disable-next-line new-cap" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457687 (owner: 10Bartosz Dziewoński) [22:06:48] (03CR) 10Esanders: [C: 032] Remove unnecessary "eslint-disable-next-line new-cap" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457686 (owner: 10Bartosz Dziewoński) [22:08:29] (03CR) 10Esanders: [C: 032] ve.ce.Surface: Make a check for pasted "important elements" faster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456744 (owner: 10Bartosz Dziewoński) [22:12:35] (03CR) 10Esanders: [C: 032] ve.ce.Surface: Consistently sanitize external pastes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456743 (https://phabricator.wikimedia.org/T108506) (owner: 10Bartosz Dziewoński) [22:13:11] (03Merged) 10jenkins-bot: Remove unnecessary "eslint-disable-next-line new-cap" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457686 (owner: 10Bartosz Dziewoński) [22:16:08] (03Merged) 10jenkins-bot: ve.ce.Surface: Consistently sanitize external pastes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456743 (https://phabricator.wikimedia.org/T108506) (owner: 10Bartosz Dziewoński) [22:18:32] (03CR) 10jenkins-bot: Remove unnecessary "eslint-disable-next-line new-cap" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457686 (owner: 10Bartosz Dziewoński) [22:24:17] (03CR) 10jenkins-bot: ve.ce.Surface: Consistently sanitize external pastes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456743 (https://phabricator.wikimedia.org/T108506) (owner: 10Bartosz Dziewoński) [22:29:37] (03Merged) 10jenkins-bot: Remove unnecessary "eslint-disable-next-line new-cap" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457687 (owner: 10Bartosz Dziewoński) [22:31:54] (03CR) 10jenkins-bot: Remove unnecessary "eslint-disable-next-line new-cap" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457687 (owner: 10Bartosz Dziewoński) [22:34:38] (03PS3) 10Esanders: ve.ce.Surface: Make a check for pasted "important elements" faster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456744 (owner: 10Bartosz Dziewoński) [22:37:59] 10VisualEditor, 10Wikimedia-log-errors (Shared Build Failure): Jenkins jobs for MediaWiki fail due to ve.ui.MWWikitextStringTransferHandler having "pending AJAX requests" - https://phabricator.wikimedia.org/T203412 (10matmarex) I can reproduce this semi-consistently after setting a custom network throttling pr... [22:38:05] (03CR) 10Bartosz Dziewoński: "Probably causes T203412" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/456629 (owner: 10Esanders) [22:39:22] (03CR) 10Esanders: [C: 032] ve.ce.Surface: Fix a test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457465 (owner: 10Bartosz Dziewoński) [22:39:29] (03PS1) 10Bartosz Dziewoński: Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457699 (https://phabricator.wikimedia.org/T203412) [22:40:13] (03CR) 10Bartosz Dziewoński: [C: 032] "The failures are apparently annoying enough for folks to file two bugs within a couple hours, so let's revert first and try again later." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457699 (https://phabricator.wikimedia.org/T203412) (owner: 10Bartosz Dziewoński) [22:41:17] (03CR) 10Esanders: "Lame" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457699 (https://phabricator.wikimedia.org/T203412) (owner: 10Bartosz Dziewoński) [22:42:14] (03CR) 10Bartosz Dziewoński: [C: 032] "Oh, if you're still online and want to debug instead of reverting, then that'd be fine too :) I assumed everyone is asleep (and US folks h" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457699 (https://phabricator.wikimedia.org/T203412) (owner: 10Bartosz Dziewoński) [22:43:31] (03Merged) 10jenkins-bot: ve.ce.Surface: Fix a test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457465 (owner: 10Bartosz Dziewoński) [22:44:06] (03CR) 10Bartosz Dziewoński: [C: 032] "(Otherwise I'll file a task later to bring this test back)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457699 (https://phabricator.wikimedia.org/T203412) (owner: 10Bartosz Dziewoński) [22:50:44] (03CR) 10jenkins-bot: ve.ce.Surface: Fix a test case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457465 (owner: 10Bartosz Dziewoński) [22:56:53] (03Merged) 10jenkins-bot: Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457699 (https://phabricator.wikimedia.org/T203412) (owner: 10Bartosz Dziewoński) [23:00:17] (03CR) 10jenkins-bot: Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457699 (https://phabricator.wikimedia.org/T203412) (owner: 10Bartosz Dziewoński)