[00:23:20] (03CR) 10Brian Wolff: "<3 Thank you for working on this. This has been one of my pet peeves with WikiEditor for a long time" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (owner: 10Jforrester) [00:25:16] (03PS2) 10Brian Wolff: Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [01:02:07] (03CR) 10Krinkle: [C: 04-1] Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate (039 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [03:18:03] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): 2010 wikitext editor does not emit save events - https://phabricator.wikimedia.org/T203621 (10DLynch) Same reasoning as it not logging an init event, maybe? Ins... [03:36:50] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Implementations of the Edit schema generate session IDs differently - https://phabricator.wikimedia.org/T203620 (10DLynch) I think you might be wrong about Mobi... [05:57:26] 10TemplateData, 10VisualEditor, 10Design, 10Patch-For-Review: Don't show Default, Example and Auto value section of the TemplateData description cell if no information is provided - https://phabricator.wikimedia.org/T125333 (10The_RedBurn) [07:10:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458440 (owner: 10L10n-bot) [07:36:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror: Different widths in NWE+CodeMirror can cause text and color to fall out of sync - https://phabricator.wikimedia.org/T203638 (10Schnark) [10:43:03] (03PS1) 10D3r1ck01: Add recent pattern for ESLinting to repo [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 [10:47:33] (03CR) 10jerkins-bot: [V: 04-1] Add recent pattern for ESLinting to repo [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (owner: 10D3r1ck01) [10:50:19] (03CR) 10D3r1ck01: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (owner: 10D3r1ck01) [10:57:44] (03CR) 10D3r1ck01: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (owner: 10D3r1ck01) [11:12:08] (03PS2) 10D3r1ck01: Add recent pattern for ESLinting to repo [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (https://phabricator.wikimedia.org/T203648) [11:27:19] 10VisualEditor, 10ConfirmEdit (CAPTCHA extension): Support No CAPTCHA reCAPTCHA in VisualEditor - https://phabricator.wikimedia.org/T203478 (10Vishnunuk) ``` if ( editApi && editApi.captcha && ( editApi.captcha.url || editApi.captcha.type === 'simple' || editApi.captcha.type === 'math' || editApi.capt... [11:55:31] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Patch-For-Review, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Esanders) a:03Esanders [12:05:56] (03PS1) 10Esanders: Re-activate surface during event cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458488 (https://phabricator.wikimedia.org/T203517) [12:11:54] (03PS1) 10Esanders: [PULL THROUGH] Use source converter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458489 [12:12:01] (03PS2) 10Esanders: Re-activate surface during event cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458488 (https://phabricator.wikimedia.org/T203517) [12:12:03] (03PS1) 10Esanders: [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203156) [12:12:08] (03CR) 10jerkins-bot: [V: 04-1] [PULL THROUGH] Use source converter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458489 (owner: 10Esanders) [12:12:18] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458054 (owner: 10Esanders) [12:13:47] (03PS2) 10Esanders: [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203156) [12:14:45] (03PS3) 10Esanders: Re-activate surface during event cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458488 (https://phabricator.wikimedia.org/T203517) [12:17:40] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203156) (owner: 10Esanders) [12:18:22] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203156) (owner: 10Esanders) [12:20:04] (03PS2) 10Esanders: Cleanup ve.dm.Converter: Convert absolute references to relative ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458054 [12:20:06] (03PS2) 10Esanders: Add simple test case to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458147 [12:20:08] (03PS2) 10Esanders: Fix typos in ve.dm.SourceSurfaceFragment documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458148 [12:20:10] (03PS2) 10Esanders: Add simple tests for getSourceText [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458154 [12:20:12] (03PS3) 10Esanders: [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203156) [12:24:46] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203156) (owner: 10Esanders) [12:31:51] 10VisualEditor, 10OOUI, 10Design: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Amire80) [12:34:04] 10VisualEditor, 10OOUI, 10Design: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Amire80) [12:38:34] 10VisualEditor, 10MobileFrontend: No toolbar on mobile views using Firefox and Chromium - https://phabricator.wikimedia.org/T191823 (10Trizek-WMF) If it was working as expected, I would get toolbars. :) [12:41:42] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10Performance, 10Technical-Debt, 10VisualEditor (Current work): Refactor source mode conversion - https://phabricator.wikimedia.org/T203156 (10Esanders) a:03Esanders [13:17:02] (03PS1) 10Esanders: Release editWarning unload event when switching from old wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458501 (https://phabricator.wikimedia.org/T202587) [13:23:02] (03CR) 10Esanders: [C: 032] Make columns responsive in visual editor command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458250 (https://phabricator.wikimedia.org/T203474) (owner: 10Tchanders) [13:23:27] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10VisualEditor (Current work): Fix command help dialog in mobile visual editor - https://phabricator.wikimedia.org/T203474 (10Esanders) After: {F... [13:26:40] (03CR) 10Esanders: [C: 04-1] "You need to check in the changes made by `grunt build`" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458324 (https://phabricator.wikimedia.org/T203467) (owner: 10Tchanders) [13:26:49] (03Merged) 10jenkins-bot: Make columns responsive in visual editor command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458250 (https://phabricator.wikimedia.org/T203474) (owner: 10Tchanders) [13:32:54] (03CR) 10Esanders: "PS2 works, but Id1996d9293d1c8059040d2d9c6d93bd6b4f55ee0 is better approach." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/456381 (https://phabricator.wikimedia.org/T203114) (owner: 10Esanders) [13:33:16] (03CR) 10jenkins-bot: Make columns responsive in visual editor command help dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458250 (https://phabricator.wikimedia.org/T203474) (owner: 10Tchanders) [13:33:59] (03PS4) 10Esanders: [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203114) [13:35:36] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Mobile: Provide a way to copy non-native selections (e.g. FocusableNodes or table selections) - https://phabricator.wikimedia.org/T202278 (10Esanders) [13:35:41] 10VisualEditor-MediaWiki-Mobile, 10Design, 10VisualEditor (Current work): Come up with a way to move/remove/duplicate focusable nodes in mobile - https://phabricator.wikimedia.org/T101113 (10Esanders) [13:36:28] 10VisualEditor-MediaWiki-Mobile, 10Design, 10VisualEditor (Current work): Come up with a way to move/remove/duplicate focusable nodes in mobile - https://phabricator.wikimedia.org/T101113 (10Esanders) >>! In T202278#4548191, @Esanders wrote: > It may actually be the case that with the browsers than we want t... [13:37:47] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203114) (owner: 10Esanders) [13:41:35] 10VisualEditor-MediaWiki-Mobile, 10Design, 10VisualEditor (Current work): Come up with a way to move/remove/duplicate focusable nodes in mobile - https://phabricator.wikimedia.org/T101113 (10Esanders) [15:04:14] (03PS5) 10Esanders: [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203114) [15:08:11] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): 2010 wikitext editor does not emit save events - https://phabricator.wikimedia.org/T203621 (10Jdforrester-WMF) >>! In T203621#4561609, @DLynch wrote: > Same rea... [15:08:47] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203114) (owner: 10Esanders) [15:10:59] 10VisualEditor, 10OOUI, 10Design: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Jdforrester-WMF) > If it's possible on mobile devices to detect that a physical keyboard is being used It isn't. [15:15:43] (03PS6) 10Esanders: [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203114) [15:17:58] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10VisualEditor (Current work): Fix command help dialog in mobile visual editor - https://phabricator.wikimedia.org/T203474 (10Jdforrester-WMF) [15:18:37] (03CR) 10Jforrester: [C: 032] Release editWarning unload event when switching from old wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458501 (https://phabricator.wikimedia.org/T202587) (owner: 10Esanders) [15:19:29] 10VisualEditor-MediaWiki, 10Design-Research, 10Design, 10VisualEditor (Current work): "Leave site?" message erroneously shown after user has saved an edit and is back in read mode - https://phabricator.wikimedia.org/T202587 (10Jdforrester-WMF) [15:19:36] (03CR) 10Jforrester: [C: 032] Cleanup ve.dm.Converter: Convert absolute references to relative ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458054 (owner: 10Esanders) [15:20:00] (03CR) 10Jforrester: [C: 032] Add simple test case to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458147 (owner: 10Esanders) [15:20:08] (03CR) 10Jforrester: [C: 032] Fix typos in ve.dm.SourceSurfaceFragment documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458148 (owner: 10Esanders) [15:23:38] (03Merged) 10jenkins-bot: Cleanup ve.dm.Converter: Convert absolute references to relative ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458054 (owner: 10Esanders) [15:23:56] (03Merged) 10jenkins-bot: Add simple test case to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458147 (owner: 10Esanders) [15:24:18] (03Merged) 10jenkins-bot: Fix typos in ve.dm.SourceSurfaceFragment documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458148 (owner: 10Esanders) [15:27:28] (03PS2) 10Jforrester: Update VE core submodule to master (e4ca18ac3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458275 (https://phabricator.wikimedia.org/T203474) [15:27:42] (03CR) 10jenkins-bot: Cleanup ve.dm.Converter: Convert absolute references to relative ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458054 (owner: 10Esanders) [15:31:14] (03CR) 10jenkins-bot: Add simple test case to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458147 (owner: 10Esanders) [15:33:43] (03Merged) 10jenkins-bot: Release editWarning unload event when switching from old wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458501 (https://phabricator.wikimedia.org/T202587) (owner: 10Esanders) [15:34:49] (03CR) 10jenkins-bot: Fix typos in ve.dm.SourceSurfaceFragment documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458148 (owner: 10Esanders) [15:36:04] (03CR) 10jenkins-bot: Release editWarning unload event when switching from old wikitext to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458501 (https://phabricator.wikimedia.org/T202587) (owner: 10Esanders) [15:50:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The dialog now looks silly on desktop with the huge gap between the labels and widgets. https://phabricator.wikimedia.org/F25678609 Maybe " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458324 (https://phabricator.wikimedia.org/T203467) (owner: 10Tchanders) [15:53:27] (03PS2) 10DLynch: DesktopArticleTarget.init: Pass platform to ve.track directly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455850 (https://phabricator.wikimedia.org/T203618) [15:53:43] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (e4ca18ac3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458275 (https://phabricator.wikimedia.org/T203474) (owner: 10Jforrester) [16:00:20] 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 10VisualEditor (Current work): [Epic] Support editing parts of a page in VisualEditor-MediaWiki - https://phabricator.wikimedia.org/T50429 (10ssastry) >>! In T50429#4559824, @Jdforrester-WMF wrote: >>>! In T50429#4559065, @deryckchan wrote: >>>>! In T5042... [16:06:58] 10Editing-team, 10VisualEditor, 10MediaWiki-extensions-Quiz, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 3 others: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 - https://phabricator.wikimedia.org/T196684 (10Umherirrender) 05Open>03Resolved p:05Tria... [16:11:15] (03Merged) 10jenkins-bot: Update VE core submodule to master (e4ca18ac3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458275 (https://phabricator.wikimedia.org/T203474) (owner: 10Jforrester) [16:13:42] (03CR) 10jenkins-bot: Update VE core submodule to master (e4ca18ac3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458275 (https://phabricator.wikimedia.org/T203474) (owner: 10Jforrester) [16:35:19] 10Editing-team, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10MobileFrontend (MobileFrontend.js), 10Technical-Debt: Cleanup Wikitext editor error handling - https://phabricator.wikimedia.org/T202374 (10Jdlrobson) [16:36:42] 10Editing-team, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10MobileFrontend (MobileFrontend.js), 10Technical-Debt: Cleanup Wikitext editor error handling - https://phabricator.wikimedia.org/T202374 (10Jdlrobson) The error handling now works thanks to Piotr, bu... [16:47:11] (03PS1) 10DLynch: dm.MWTableNode: include paragraph in suggestedParentNodeTypes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458534 (https://phabricator.wikimedia.org/T201573) [16:58:30] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10VisualEditor (Current work): Fix command help dialog in mobile visual editor - https://phabricator.wikimedia.org/T203474 (10Jdforrester-WMF) [17:19:22] 10VisualEditor, 10Discovery-Search: The limited list of suggested categories don't ease categories searching - https://phabricator.wikimedia.org/T187342 (10EBjune) Agreed, Deskana, too niche to put a lot of time into, and if we get more use cases we'll take a deeper look. [17:19:35] 10VisualEditor, 10Discovery-Search: The limited list of suggested categories don't ease categories searching - https://phabricator.wikimedia.org/T187342 (10EBjune) 05Open>03declined [17:32:29] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Jdforrester-WMF) [17:32:47] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Jdforrester-WMF) [17:33:02] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Jdforrester-WMF) [17:33:33] 10VisualEditor, 10OOUI, 10Design: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Volker_E) Adding to 'it isn't'. Two further reading resources: 1. CSS media feature only providing device specific feedback via browser on keyboard... [17:33:40] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Jdforrester-WMF) [17:33:46] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Jdforrester-WMF) [17:47:52] 10VisualEditor, 10OOUI, 10Design: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Amire80) Thanks for the replies. As I said, it's not a thing that gets in the way very badly. More like a thing that came up as part of exploratory... [17:56:40] (03PS7) 10Nikerabbit: [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203114) (owner: 10Esanders) [17:57:36] (03CR) 10Jforrester: [C: 031] Add simple tests for getSourceText [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458154 (owner: 10Esanders) [17:58:21] (03CR) 10Jforrester: [C: 031] [BREAKING CHANGE] Implement a SourceConverter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458490 (https://phabricator.wikimedia.org/T203114) (owner: 10Esanders) [18:12:06] (03PS3) 10D3r1ck01: Add recent pattern for ESLinting to repo [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (https://phabricator.wikimedia.org/T203648) [18:23:09] (03CR) 10Jforrester: [C: 04-1] "Per task." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (https://phabricator.wikimedia.org/T203648) (owner: 10D3r1ck01) [19:48:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458567 (owner: 10L10n-bot) [19:52:22] 10VisualEditor-ContentEditable, 10VisualEditor (Current work): [Regression pre-wmf.18] Toolbar does not get activated after pressing return - https://phabricator.wikimedia.org/T202359 (10Esanders) [19:55:01] (03CR) 10Esanders: "While this works it seems very wrong to say that a paragraph is a suggested parent of a table..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458534 (https://phabricator.wikimedia.org/T201573) (owner: 10DLynch) [19:58:40] 10Citoid, 10VisualEditor: Date not when adding a citation automatically in Citoid powered by Zotero - https://phabricator.wikimedia.org/T203710 (10Waddie96) [19:59:44] 10Citoid, 10VisualEditor: Date not when adding a citation automatically in Citoid powered by Zotero - https://phabricator.wikimedia.org/T203710 (10Waddie96) [20:00:20] 10Citoid, 10VisualEditor: Date not when adding a citation automatically in Citoid powered by Zotero - https://phabricator.wikimedia.org/T203710 (10Waddie96) [20:00:53] 10Citoid, 10VisualEditor: Date not when adding a citation automatically in Citoid powered by Zotero - https://phabricator.wikimedia.org/T203710 (10Waddie96) [20:09:36] (03CR) 10DLynch: "That's fair. I'll see if I can do something that's more complicated but also more correct..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458534 (https://phabricator.wikimedia.org/T201573) (owner: 10DLynch) [20:55:54] 10VisualEditor-MediaWiki, 10Design-Research, 10Design, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 2 others: "Leave site?" message erroneously shown after user has saved an edit and is back in read mode - https://phabricator.wikimedia.org/T202587 (10Ryasmeen) [21:04:12] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10VisualEditor (Current work): Fix command help dialog in mobile visual editor - https://phabricator.wikimedia.org/T203474 (10Ryasmeen) @Tchanders: I can't find this d... [21:10:52] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10VisualEditor (Current work): Fix command help dialog in mobile visual editor - https://phabricator.wikimedia.org/T203474 (10Ryasmeen) >>! In T203474#4564375, @Ryasme... [21:11:09] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10VisualEditor (Current work): Fix command help dialog in mobile visual editor on MinervaNeue - https://phabricator.wikimedia.org/T203474 (10Ryasmeen) [21:11:16] (03PS2) 10Tchanders: Fix alignment in visual editor table dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458324 (https://phabricator.wikimedia.org/T203467) [21:13:33] (03PS3) 10Tchanders: Fix alignment in visual editor table dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458324 (https://phabricator.wikimedia.org/T203467) [21:25:18] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, and 3 others: Can't focus block image in mobile visual editor - https://phabricator.wikimedia.org/T202980 (10Ryasmeen) [21:34:37] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10VisualEditor (Current work): Mobile: Page toolbar and edit toolbar shown while editor initialising - https://phabricator.wikimedia.org/T202986 (10Ryasmeen) Verified... [21:34:54] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Verified-in-Phase2, 10VisualEditor (Current work): Mobile: Page toolbar and edit toolbar shown while editor initialising - https://phabricator.wikimedia.org/T202986... [21:43:37] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, and 2 others: Mobile: Deactivated selections have a higher z-index than toolbars - https://phabricator.wikimedia.org/T202990 (10Ryasmeen) [22:05:40] (03CR) 10Bartosz Dziewoński: [C: 031] "I just thought that using 'small' also has a drawback, the dialog title no longer fits in some languages, e.g. German: https://phabricator" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458324 (https://phabricator.wikimedia.org/T203467) (owner: 10Tchanders) [22:19:02] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, and 2 others: 2010 wikitext editor does not emit init events - https://phabricator.wikimedia.org/T203619 (10Neil_P._Quinn_WMF) >>! In T203619#4561356, @DLynch wrote: > I’m not clear on whether... [22:27:08] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): 2010 wikitext editor does not emit save events - https://phabricator.wikimedia.org/T203621 (10Neil_P._Quinn_WMF) >>! In T203621#4563118, @Jdforrester-WMF wrote:... [22:30:03] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, and 3 others: Identify and fix data quality problems in the Edit event log - https://phabricator.wikimedia.org/T202437 (10Neil_P._Quinn_WMF) [22:43:19] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, and 2 others: 2010 wikitext editor does not emit init events - https://phabricator.wikimedia.org/T203619 (10Neil_P._Quinn_WMF) @DLynch, @Jdforrester-WMF are you sure `init` has never been logge... [22:44:16] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, and 2 others: 2010 wikitext editor does not emit init events - https://phabricator.wikimedia.org/T203619 (10Jdforrester-WMF) Nope, hazy memories only. [23:33:18] (03CR) 10Bartosz Dziewoński: [C: 032] Add simple tests for getSourceText [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458154 (owner: 10Esanders) [23:37:01] (03Merged) 10jenkins-bot: Add simple tests for getSourceText [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458154 (owner: 10Esanders) [23:38:37] (03CR) 10Bartosz Dziewoński: [C: 032] Re-activate surface during event cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458488 (https://phabricator.wikimedia.org/T203517) (owner: 10Esanders) [23:40:55] (03CR) 10jenkins-bot: Add simple tests for getSourceText [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458154 (owner: 10Esanders) [23:42:22] (03Merged) 10jenkins-bot: Re-activate surface during event cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458488 (https://phabricator.wikimedia.org/T203517) (owner: 10Esanders) [23:46:12] (03CR) 10jenkins-bot: Re-activate surface during event cycle [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/458488 (https://phabricator.wikimedia.org/T203517) (owner: 10Esanders) [23:57:42] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): 2010 wikitext editor does not emit save events - https://phabricator.wikimedia.org/T203621 (10Neil_P._Quinn_WMF) [23:58:55] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): 2010 wikitext editor does not emit save events - https://phabricator.wikimedia.org/T203621 (10Neil_P._Quinn_WMF) >>! In T203621#4563118, @Jdforrester-WMF wrote:...