[00:06:54] (03PS1) 10Jforrester: Update VE core submodule to master (465ea4618) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/459874 [00:39:06] 10VisualEditor, 10VisualEditor-Tables, 10Epic, 10User-Ryasmeen: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245 (10Timeshifter) Very few people look at Tech News. Even fewer are going to scan it weekly in order to find the very few times it mentions table... [01:13:35] 10TemplateData, 10VisualEditor, 10Community-Tech, 10Community-Tech-Sprint: [BUG] Improve the template parameter guessing - https://phabricator.wikimedia.org/T203605 (10Samwilson) a:03Samwilson [02:06:06] 10TemplateData, 10VisualEditor, 10Community-Tech, 10Community-Tech-Sprint: [BUG] Improve the template parameter guessing - https://phabricator.wikimedia.org/T203605 (10Samwilson) One thing we can do is increase the parameter-finding to avoid `{{{#`, because that's never the start of a valid parameter name.... [02:08:08] (03PS1) 10Samwilson: Prevent leading hash from starting param names when guessing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/459886 (https://phabricator.wikimedia.org/T203605) [07:25:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/459963 (owner: 10L10n-bot) [10:19:54] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design: Mobile Visual Editor fetures different button icon color side-by-side possibly confusing users - https://phabricator.wikimedia.org/T204080 (10Esanders) The blue pencil is progressive as it takes you to the next step, the delete icon is obviously dest... [10:26:10] 10Editing-team, 10VisualEditor, 10MassMessage, 10Wikimedia-production-error: Invalid parameter for message "logentry-massmessage-failure" - https://phabricator.wikimedia.org/T93110 (10Esanders) Editing team is unlikely to get involved with this, even if we are listed as maintainers(?!). [10:26:24] 10Editing-team, 10MassMessage, 10Wikimedia-production-error: Invalid parameter for message "logentry-massmessage-failure" - https://phabricator.wikimedia.org/T93110 (10Esanders) [10:27:39] (03CR) 10Esanders: [C: 032] Prevent leading hash from starting param names when guessing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/459886 (https://phabricator.wikimedia.org/T203605) (owner: 10Samwilson) [10:53:02] 10Editing-team, 10MassMessage, 10Wikimedia-production-error: Invalid parameter for message "logentry-massmessage-failure" - https://phabricator.wikimedia.org/T93110 (10Deskana) >>! In T93110#4576646, @Esanders wrote: > Editing team is unlikely to get involved with this, even if we are listed as maintainers(?... [10:55:04] (03Merged) 10jenkins-bot: Prevent leading hash from starting param names when guessing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/459886 (https://phabricator.wikimedia.org/T203605) (owner: 10Samwilson) [10:56:06] 10VisualEditor, 10OOUI, 10Design: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Deskana) >>! In T203659#4575230, @Volker_E wrote: > @Deskana To repeat once more, in a technically perfect world we would be able to have handles to... [10:58:29] (03CR) 10jenkins-bot: Prevent leading hash from starting param names when guessing [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/459886 (https://phabricator.wikimedia.org/T203605) (owner: 10Samwilson) [11:05:25] 10VisualEditor, 10ConfirmEdit (CAPTCHA extension): Support No CAPTCHA reCAPTCHA in VisualEditor - https://phabricator.wikimedia.org/T203478 (10Esanders) The scripts for recaptcha are all in HTMLReCaptchaNoCaptchaField.php, it's likely no one has tried to do this in the client before, so you can either duplicat... [11:51:01] 10Editing-team, 10MassMessage, 10Wikimedia-production-error: Invalid parameter for message "logentry-massmessage-failure" - https://phabricator.wikimedia.org/T93110 (10Aklapper) (If https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_extensions_deployed_by_WMF is incorrect, feel free to edit it a... [12:18:02] 10VisualEditor, 10VisualEditor-ContentEditable, 10User-Ryasmeen: Highlighting is mis-aligned for inserted template/ inserted media once you open the save dialog and dismiss it - https://phabricator.wikimedia.org/T93660 (10Esanders) 05Open>03Resolved a:03Esanders Yeah - I think this got fixed a while ago. [12:20:16] 10VisualEditor: Highlights not updated when document modified - https://phabricator.wikimedia.org/T203856 (10Esanders) [12:25:12] 10VisualEditor, 10ConfirmEdit (CAPTCHA extension): Support No CAPTCHA reCAPTCHA in VisualEditor - https://phabricator.wikimedia.org/T203478 (10Deskana) p:05Triage>03Lowest [12:35:07] 10VisualEditor: Hover highlights not updated when document modified - https://phabricator.wikimedia.org/T203856 (10Esanders) [12:36:06] (03PS1) 10Esanders: FocusableNode: Start listening to position events even if not focused [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460009 (https://phabricator.wikimedia.org/T203856) [12:55:15] 10Citoid: Citoid extension only offers to convert bare URLs, not other kinds of text - https://phabricator.wikimedia.org/T204121 (10Mvolz) [12:57:00] 10Cite, 10Citoid: Date not when adding a citation automatically in Citoid powered by Zotero - https://phabricator.wikimedia.org/T203710 (10Mvolz) [12:57:08] 10Citoid, 10VisualEditor, 10User-Josve05a: Internationalise citoid dates - https://phabricator.wikimedia.org/T132308 (10Mvolz) [12:57:19] 10Citoid: Date not when adding a citation automatically in Citoid powered by Zotero - https://phabricator.wikimedia.org/T203710 (10Mvolz) [13:00:21] 10Citoid: Date not when adding a citation automatically in Citoid powered by Zotero - https://phabricator.wikimedia.org/T203710 (10Mvolz) I agree this is really annoying. The problem is we never really reached a consensus on how to handle dates that were only the year and the month, which is the task I just merg... [13:03:32] 10Citoid, 10RESTBase-API, 10Services (doing): Remove bibtex from Citoid's public API - https://phabricator.wikimedia.org/T201618 (10Mvolz) >>! In T201618#4534572, @mobrovac wrote: > @Mvolz according to the [export PR](https://github.com/zotero/translation-server-v2/issues/5#issuecomment-414594050), bibtex is... [13:03:44] 10Citoid, 10RESTBase-API, 10Services (doing): Remove bibtex from Citoid's public API - https://phabricator.wikimedia.org/T201618 (10Mvolz) 05Open>03declined [13:03:47] 10Citoid, 10Operations, 10Patch-For-Review, 10Services (watching), 10VisualEditor (Current work): Transition citoid to use Zotero's translation-server-v2 - https://phabricator.wikimedia.org/T197242 (10Mvolz) [13:12:24] 10VisualEditor: When editing an old version of a page, the VisualEditor shows the diff to that old version and not to the most recent version - https://phabricator.wikimedia.org/T203879 (10Esanders) It's probably not that hard, but I think the current behaviour of diffing //latest vs your version// instead of //... [13:20:53] 10VisualEditor: VisualEditor incorrectly removes infobox yet preview does not reflect this - https://phabricator.wikimedia.org/T204007 (10Esanders) a:03Esanders Looks like an about-grouping issue. Templates can consist of adjacent sibling nodes if they have the same about attribute (e.g. On... [13:54:06] (03PS1) 10Esanders: Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) [14:01:23] (03CR) 10Esanders: [C: 032] DesktopArticleTarget.init: Pass platform to ve.track directly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455850 (https://phabricator.wikimedia.org/T203618) (owner: 10DLynch) [14:02:41] (03CR) 10jerkins-bot: [V: 04-1] Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [14:20:45] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: Pass platform to ve.track directly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455850 (https://phabricator.wikimedia.org/T203618) (owner: 10DLynch) [14:23:30] (03CR) 10jenkins-bot: DesktopArticleTarget.init: Pass platform to ve.track directly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/455850 (https://phabricator.wikimedia.org/T203618) (owner: 10DLynch) [14:53:22] 10VisualEditor, 10VisualEditor-Tables, 10Epic, 10User-Ryasmeen: Fully support basic table editing in the visual editor - https://phabricator.wikimedia.org/T108245 (10CKoerner_WMF) Howdy @Timeshifter, Thanks for the feedback. I want to give a little background to echo @Trizek-WMF on why we utilize Tech News... [15:47:11] (03CR) 10Jforrester: [C: 032] Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/458997 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [16:23:49] (03Merged) 10jenkins-bot: Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/458997 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [16:28:40] (03PS1) 10Tchanders: Check new node diff type in visual diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460052 [16:43:00] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Exception thrown in list diff - https://phabricator.wikimedia.org/T201721 (10Tchanders) a:03Tchanders [16:49:06] (03CR) 10Esanders: [C: 032] Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458988 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [16:53:41] (03PS2) 10Tchanders: Check new node diff type in visual diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460052 (https://phabricator.wikimedia.org/T201721) [16:58:17] (03CR) 10jerkins-bot: [V: 04-1] Check new node diff type in visual diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460052 (https://phabricator.wikimedia.org/T201721) (owner: 10Tchanders) [17:06:21] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [17:14:47] (03CR) 10jerkins-bot: [V: 04-1] Use data.cloneElements when converting pasted wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460020 (https://phabricator.wikimedia.org/T204007) (owner: 10Esanders) [17:19:43] (03CR) 10jenkins-bot: Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/458997 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [17:26:11] (03Merged) 10jenkins-bot: Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458988 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [17:28:03] (03PS1) 10DLynch: ui.MWParameterPage: multiline inputs for `line` if newlines already present [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460066 (https://phabricator.wikimedia.org/T190191) [17:29:19] (03CR) 10jenkins-bot: Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/458988 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [19:38:47] 10VisualEditor-Media, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10VisualEditor (Current work): MediaSizeWidget in a FieldLayout always disables the FieldLayout - https://phabricator.wikimedia.org/T203889 (10Ryasmeen) I am not really sure what needs to be tested here just by looking at... [19:47:19] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Verified, 10VisualEditor (Current work): Mobile VE: Show virtual keyboard when a dialog is closed without any edit - https://phabricator.wikimedia.org/T203517 (10Ryasmeen) [19:50:36] (03PS1) 10VolkerE: Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/460087 (https://phabricator.wikimedia.org/T190581) [19:58:21] 10VisualEditor, 10OOUI: Icons for different nodes look misaligned with the other buttons in the mobile context menu - https://phabricator.wikimedia.org/T190595 (10Ryasmeen) [19:58:24] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10VisualEditor (Current work): Context title and description not vertically aligned - https://phabricator.wikimedia.org/T203328 (10Ryasmeen) [19:59:44] (03CR) 10Jforrester: [C: 032] Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/460087 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [20:05:23] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Verified, 10VisualEditor (Current work): Context title and description not vertically aligned - https://phabricator.wikimedia.org/T203328 (10Ryasmeen) [20:05:25] (03Merged) 10jenkins-bot: Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/460087 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [20:07:11] (03CR) 10jenkins-bot: Replace deprecated 'advanced' by renamed to 'settings' icon [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/460087 (https://phabricator.wikimedia.org/T190581) (owner: 10VolkerE) [20:07:19] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, and 2 others: Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Ryasmeen) [20:08:10] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Verified, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Jdforrester-WMF) [20:56:46] 10VisualEditor, 10VisualEditor-MediaWiki: Users are requesting a "Cancel and exit without saving" option - https://phabricator.wikimedia.org/T85470 (10matmarex) While there is no explicit button to reliably discard your changes, you can still do it by pressing Escape on your keyboard, or by clicking on the "Re... [21:18:11] 10VisualEditor, 10OOUI: Icons for different nodes look misaligned with the other buttons in the mobile context menu - https://phabricator.wikimedia.org/T190595 (10Volker_E) Not convinced if this is the same issue as the one you merged into? The linked task is talking about context title and description? Or did... [21:27:46] (03CR) 10Bartosz Dziewoński: "Parsoid dependency has been merged: https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/451001 Is this ready for review?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/454860 (https://phabricator.wikimedia.org/T198511) (owner: 10DLynch) [21:32:46] (03CR) 10Bartosz Dziewoński: [C: 032] "Sure, should be good, let's just remember this in case something similar to T203412 starts happening. I haven't thoroughly checked that th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457884 (owner: 10Esanders) [21:37:54] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Re-evaluate mobile editing for images - https://phabricator.wikimedia.org/T190885 (10matmarex) [21:47:29] 10VisualEditor, 10MediaWiki-extensions-InputBox: Visualeditor-welcomedialogue interferes with Inputbox's comment feature - https://phabricator.wikimedia.org/T204167 (10Quiddity) [21:48:59] 10VisualEditor, 10MediaWiki-extensions-InputBox: Visualeditor-welcomedialogue interferes with Inputbox's comment feature - https://phabricator.wikimedia.org/T204167 (10Quiddity) [21:51:03] 10VisualEditor, 10MediaWiki-extensions-InputBox: Visualeditor-welcomedialogue interferes with Inputbox's comment feature - https://phabricator.wikimedia.org/T204167 (10Quiddity) [21:51:45] 10VisualEditor, 10MediaWiki-extensions-InputBox: Visual Editor Option not working - https://phabricator.wikimedia.org/T182526 (10Quiddity) [22:05:48] (03Merged) 10jenkins-bot: Revert "Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457884 (owner: 10Esanders) [22:11:42] (03CR) 10jenkins-bot: Revert "Revert "Follow-up I38eda4a: Add unit tests for lang/dir in target init"" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/457884 (owner: 10Esanders) [22:40:33] (03PS1) 10Reedy: Remove php entry point [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/460136 (https://phabricator.wikimedia.org/T140007) [23:05:15] 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Hover highlights not updated when document modified - https://phabricator.wikimedia.org/T203856 (10Jdforrester-WMF) [23:12:46] (03CR) 10Jforrester: [C: 032] Remove php entry point [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/460136 (https://phabricator.wikimedia.org/T140007) (owner: 10Reedy) [23:17:54] 10Cite: mwext-php70-phan-seccheck-docker failing on cite - https://phabricator.wikimedia.org/T204175 (10Reedy) [23:25:44] (03Merged) 10jenkins-bot: Remove php entry point [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/460136 (https://phabricator.wikimedia.org/T140007) (owner: 10Reedy) [23:50:05] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): 2010 wikitext editor does not emit save events - https://phabricator.wikimedia.org/T203621 (10Neil_P._Quinn_WMF) >>! In T203621#4574372, @Milimetric wrote: > So...