[02:20:38] 10VisualEditor-DataModel, 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Technical-Debt, and 2 others: Generalize logic for inserting a block level element into an empty paragraph (it should replace that paragraph, n... - https://phabricator.wikimedia.org/T201573 [02:51:37] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Parsoid, 10Services (watching): Can't load VE on Beta cluster - https://phabricator.wikimedia.org/T204624 (10Ryasmeen) Thanks @Pchelolo for looking into this! [07:57:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/461074 (owner: 10L10n-bot) [10:29:17] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Parsoid, 10Services (watching): Parsoid is misbehaving in Beta cluster - https://phabricator.wikimedia.org/T204624 (10Krenair) [10:42:46] (03CR) 10Esanders: [C: 032] ve.init.mw.MobileArticleTarget: Simplify margin/padding for debug bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460975 (owner: 10Bartosz Dziewoński) [10:58:10] (03Merged) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Simplify margin/padding for debug bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460975 (owner: 10Bartosz Dziewoński) [11:00:31] (03CR) 10jenkins-bot: ve.init.mw.MobileArticleTarget: Simplify margin/padding for debug bar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460975 (owner: 10Bartosz Dziewoński) [11:15:20] (03CR) 10Divec: [C: 032] Allow applyTo to guess a selection for undo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460328 (https://phabricator.wikimedia.org/T204197) (owner: 10Esanders) [11:24:03] (03Merged) 10jenkins-bot: Allow applyTo to guess a selection for undo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460328 (https://phabricator.wikimedia.org/T204197) (owner: 10Esanders) [11:27:53] (03CR) 10jenkins-bot: Allow applyTo to guess a selection for undo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460328 (https://phabricator.wikimedia.org/T204197) (owner: 10Esanders) [11:31:36] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VE mobile toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Esanders) [12:19:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VE mobile toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Esanders) This should probably be fixed upstream in MobileFrontend, as it applies to any overlay toolbar. cc @Jdlrobson [12:20:22] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: VE mobile toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Esanders) [12:20:49] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend: MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Esanders) [13:08:11] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Esanders) [14:12:22] (03PS1) 10Esanders: Scroll cursor into view after resize on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461135 (https://phabricator.wikimedia.org/T204388) [14:14:02] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Mobile: Selection handles obscured after scrollCursorIntoView - https://phabricator.wikimedia.org/T204718 (10Esanders) [14:17:22] (03PS1) 10Esanders: Collase this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 [14:21:15] (03PS3) 10Esanders: Scroll 60px past toolbar on mobile to avoid context menu clash on Android [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/457883 (https://phabricator.wikimedia.org/T202723) [14:21:17] (03PS2) 10Esanders: Scroll 60px past toolbar on mobile to avoid context menu clash on iOS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460331 (https://phabricator.wikimedia.org/T202723) [14:28:30] (03PS3) 10Esanders: Scroll 60px past toolbar on mobile to avoid context menu clash on iOS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460331 (https://phabricator.wikimedia.org/T202723) [14:28:32] (03PS1) 10Esanders: Scroll 30px above bottom of viewport on Android to keep selection handles visible [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461139 (https://phabricator.wikimedia.org/T204718) [14:28:57] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Selection handles obscured after scrollCursorIntoView - https://phabricator.wikimedia.org/T204718 (10Esanders) [14:31:16] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Focusing the document in the bottom half of the screen doesn't always scroll the cursor into view - https://phabricator.wikimedia.org/T204388 (10Esanders) [14:32:08] (03CR) 10jerkins-bot: [V: 04-1] Scroll 60px past toolbar on mobile to avoid context menu clash on iOS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460331 (https://phabricator.wikimedia.org/T202723) (owner: 10Esanders) [14:43:56] (03CR) 10jerkins-bot: [V: 04-1] Scroll 60px past toolbar on mobile to avoid context menu clash on iOS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/460331 (https://phabricator.wikimedia.org/T202723) (owner: 10Esanders) [15:01:01] (03Merged) 10jenkins-bot: Use mw.Title.isTalkNamespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460415 (owner: 10Esanders) [15:04:32] (03CR) 10jenkins-bot: Use mw.Title.isTalkNamespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460415 (owner: 10Esanders) [15:22:59] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Parsoid, 10Services (watching): Parsoid is misbehaving in Beta cluster - https://phabricator.wikimedia.org/T204624 (10cscott) The last Parsoid deploy to beta was Wed or Thursday of last week. Assuming this problem started recently it's probably not a code o... [15:32:33] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Parsoid, 10Services (watching): Parsoid is misbehaving in Beta cluster - https://phabricator.wikimedia.org/T204624 (10Arlolra) Probably the same thing that caused T198421 cropping up again [15:40:52] (03CR) 10Jforrester: [C: 032] Collase this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 (owner: 10Esanders) [15:41:41] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Focusing the document in the bottom half of the screen doesn't always scroll the cursor into view - https://phabricator.wikimedia.org/T204388 (10Jdforrester-WMF) [15:41:42] (03CR) 10Jforrester: [C: 032] Scroll cursor into view after resize on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461135 (https://phabricator.wikimedia.org/T204388) (owner: 10Esanders) [15:45:58] (03PS2) 10Bartosz Dziewoński: Collapse this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 (owner: 10Esanders) [15:46:04] (03CR) 10Bartosz Dziewoński: [C: 032] Collapse this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 (owner: 10Esanders) [15:50:26] (03Merged) 10jenkins-bot: Scroll cursor into view after resize on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461135 (https://phabricator.wikimedia.org/T204388) (owner: 10Esanders) [15:52:05] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Patch-For-Review, 10VisualEditor (Current work): MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Volker_E) [15:54:01] 10VisualEditor, 10Maps-Sprint, 10Maps (Kartographer), 10User-Ryasmeen: [Regression pre-wmf.29] Can't add map using VE/NWE, throwing uncaught error in the console - https://phabricator.wikimedia.org/T191476 (10MSantos) [15:54:27] (03CR) 10jenkins-bot: Scroll cursor into view after resize on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461135 (https://phabricator.wikimedia.org/T204388) (owner: 10Esanders) [16:14:28] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Design: Re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10Esanders) [16:43:12] (03CR) 10Jforrester: "> Patch Set 7: Code-Review-1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [16:45:46] (03PS1) 10Jforrester: Update VE core submodule to master (2093bd6f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/461161 (https://phabricator.wikimedia.org/T204197) [16:57:49] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (2093bd6f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/461161 (https://phabricator.wikimedia.org/T204197) (owner: 10Jforrester) [17:03:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] "There aren't patches for them, they would need to be written." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/418591 (https://phabricator.wikimedia.org/T153306) (owner: 10Esanders) [17:06:42] 10Editing-team, 10SpamBlacklist, 10Wikimedia-production-error: SpamBlacklist is escaping/validating patterns incorrectly - "Compilation failed: nothing to repeat at offset 13" - https://phabricator.wikimedia.org/T148639 (10Krinkle) [17:10:50] 10VisualEditor-DataModel, 10MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 10VisualEditor (Current work): On a page with recovered autosaved changes, using Ctrl+Z to undo clears the DM selection (and CE selection is desync'd) - https://phabricator.wikimedia.org/T204197 (10Jdforrester-WMF) [17:11:15] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 10VisualEditor (Current work): Mobile: Focusing the document in the bottom half of the screen doesn't always scroll the curso... - https://phabricator.wikimedia.org/T204388 [17:15:09] (03Merged) 10jenkins-bot: Update VE core submodule to master (2093bd6f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/461161 (https://phabricator.wikimedia.org/T204197) (owner: 10Jforrester) [17:19:29] (03CR) 10jenkins-bot: Update VE core submodule to master (2093bd6f0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/461161 (https://phabricator.wikimedia.org/T204197) (owner: 10Jforrester) [17:29:01] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Patch-For-Review, and 2 others: MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Jdlrobson) [17:31:32] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Patch-For-Review, and 2 others: MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Jdlrobson) >>! In T204691#4593330, @Esanders wrote: > This should probably be fixed upst... [17:42:08] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Parsoid, 10Services (watching): Parsoid is misbehaving in Beta cluster - https://phabricator.wikimedia.org/T204624 (10Arlolra) > The last Parsoid deploy to beta was Wed or Thursday of last week. According to the logs, it was on Wednesday. > After restartin... [17:44:05] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Patch-For-Review, and 2 others: MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10alexhollender) @Esanders can you provide more details & screenshots in the task descript... [19:00:33] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Patch-For-Review, and 2 others: MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Esanders) Any overlay that uses a header will have it blend into the status bar, so the... [19:19:01] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Patch-For-Review, and 2 others: MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Jdlrobson) What if we used the existing manifest file to change the background color of... [19:26:32] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Patch-For-Review, and 2 others: MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Jdlrobson) Another approach to this would be to use a slighty-off white background color... [19:44:21] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Parsoid, 10Services (done), 10User-Ryasmeen: Parsoid is misbehaving in Beta cluster - https://phabricator.wikimedia.org/T204624 (10Pchelolo) 05Open>03Resolved a:03Pchelolo VE works properly in Beta now. After decreasing change-prop concurrency level... [20:15:43] 10Editing-team, 10MassMessage, 10Wikimedia-production-error: Unable to view certain mobile diffs "Exception: Cannot diff content types other than MassMessageListContent" - https://phabricator.wikimedia.org/T156293 (10Krinkle) [20:21:24] 10VisualEditor: [Regression pre-wmf.21] Tab border disappeared between Edit and Edit Source tab? - https://phabricator.wikimedia.org/T204766 (10Ryasmeen) [21:30:12] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Verified, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Etonkovidova) [21:57:44] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, and 3 others: No Edit events recorded from mobile editors - https://phabricator.wikimedia.org/T203615 (10Neil_P._Quinn_WMF) >>! In T203615#4591459, @Krinkle wrote: > Reminder to revert the abov... [21:58:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-User-preferences, 10Design: Re-design the Editing preferences to make it easier to pick the editing environment that you want to use - https://phabricator.wikimedia.org/T202921 (10Izno) >>! In T202921#4537253, @Schnark wrote: >>>! In... [22:03:16] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Patch-For-Review, and 2 others: MobileFrontend overlay toolbar can have no top border on Android - https://phabricator.wikimedia.org/T204691 (10Jdlrobson) The easiest thing to do here is a config change: converting ``` "wgMFManifes... [22:11:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Epic: Mobile editors do not log inits on direct URL initiation - https://phabricator.wikimedia.org/T204779 (10Neil_P._Quinn_WMF) p:05Triage>03Lowest [22:21:47] (03PS3) 10Esanders: Collapse this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 [22:22:07] (03CR) 10Esanders: [C: 032] "Per James/Bartosz" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 (owner: 10Esanders) [22:38:30] 10VisualEditor, 10Vector, 10Browser-Support-Google-Chrome: [Regression pre-wmf.21] Tab border disappeared between Edit and Edit Source tab? - https://phabricator.wikimedia.org/T204766 (10matmarex) This seems to be a Chromium rendering bug. We didn't do anything to these tabs that would cause this. I can't re... [22:42:03] 10VisualEditor, 10Vector, 10Browser-Support-Google-Chrome: [Regression pre-wmf.21] Tab border disappeared between Edit and Edit Source tab? - https://phabricator.wikimedia.org/T204766 (10matmarex) Here's a fairly minimal test case if anyone fancies reporting this bug upstream: http://jsfiddle.net/146bnjgu/16... [22:47:26] (03CR) 10jerkins-bot: [V: 04-1] Collapse this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 (owner: 10Esanders) [22:54:49] (03CR) 10Bartosz Dziewoński: [C: 032] Collapse this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 (owner: 10Esanders) [22:58:30] (03Merged) 10jenkins-bot: Collapse this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 (owner: 10Esanders) [23:08:55] (03CR) 10jenkins-bot: Collapse this.getSurface().getView() to this in ve.ce.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/461137 (owner: 10Esanders) [23:11:54] 10VisualEditor, 10Vector, 10Browser-Support-Google-Chrome: [Regression pre-wmf.21] Tab border disappeared between Edit and Edit Source tab? - https://phabricator.wikimedia.org/T204766 (10Krinkle) Yep, I've actually been seeing this for about a month or so in Chrome canary. Didn't think it was worth reporting... [23:14:51] 10VisualEditor, 10Vector, 10Browser-Support-Google-Chrome, 10Performance-Team (Radar): [Regression pre-wmf.21] Tab border disappeared between Edit and Edit Source tab? - https://phabricator.wikimedia.org/T204766 (10Krinkle)