[05:37:10] (03Restored) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) (owner: 10Divec) [05:38:07] (03PS35) 10Divec: WIP: Change#squash: Compact multiple transactions into one [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/413428 (https://phabricator.wikimedia.org/T188026) [08:52:04] 10Citoid, 10User-notice: Allow arbitrary search strings in citoid - https://phabricator.wikimedia.org/T198567 (10Mvolz) 05Open>03stalled [08:52:30] 10Citoid, 10VisualEditor, 10User-notice: Allow arbitrary search strings in citoid - https://phabricator.wikimedia.org/T198567 (10Mvolz) [08:54:34] 10Citoid, 10VisualEditor, 10User-notice: Allow arbitrary search strings in citoid - https://phabricator.wikimedia.org/T198567 (10Mvolz) 05stalled>03Open [10:10:02] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Browser-Support-Android-Google-Chrome, and 4 others: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android - https://phabricator.wikimedia.org/T204691 (10phuedx) [10:12:13] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Browser-Support-Android-Google-Chrome, and 4 others: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android - https://phabricator.wikimedia.org/T204691 (10phuedx) ☝️ I moved this task onto the board because it... [10:52:40] 10VisualEditor, 10WikiProject-tools, 10Wikimedia-Site-requests, 10Spanish-Sites: Enable the visual editor on the wikiproject namespace on Spanish Wikipedia - https://phabricator.wikimedia.org/T158763 (10Deskana) Can you give more detail about what "enable the visual editor" means for you? Do you mean have... [11:07:02] (03PS1) 10Esanders: Remove deprecated domNodeArray branch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463233 [11:08:46] (03PS2) 10Esanders: Remove deprecated domNodeArray branch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463233 [11:32:47] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Verified, 10VisualEditor (Current work): Mobile VE: Show virtual keyboard when a dialog is closed without any edit - https://phabricator.wikimedia.org/T203517 (10Esanders) @Deskana tag with Q1 mobile improve... [11:33:27] 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Verified, 10VisualEditor (Current work): On mobile, cursoring off a focusable node fails - https://phabricator.wikimedia.org/T147304 (10Esanders) @Deskana tag with Q1 mobile improv... [11:35:30] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Images wrap in mobile VE, leading to very narrow paragraphs - https://phabricator.wikimedia.org/T205474 (10Esanders) a:03Esanders [11:35:49] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Selection handles obscured after scrollCursorIntoView - https://phabricator.wikimedia.org/T204718 (10Esanders) a:03Esanders [11:36:43] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): Image resize handle is useless on mobile - https://phabricator.wikimedia.org/T205480 (10Esanders) a:03Esanders [11:37:00] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 10VisualEditor (Current work): 2017 wikitext editor emits many ready events with platform "other" - https://phabricator.wikimedia.org/T205241 (10Esanders) a:03Esanders [11:41:24] (03PS4) 10Tchanders: Improve the media dialog appearance on mobile visual editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460926 (https://phabricator.wikimedia.org/T190885) [11:42:59] (03PS1) 10Esanders: Avoid jQuery in ve.dm.Model.static.describeChange(s) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463235 (https://phabricator.wikimedia.org/T195111) [11:44:11] (03PS1) 10Esanders: Turn off browser/jquery env's in Node code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463236 [11:45:22] (03CR) 10jerkins-bot: [V: 04-1] Avoid jQuery in ve.dm.Model.static.describeChange(s) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463235 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [11:46:41] (03PS1) 10Esanders: WIP deepfreeze [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 [11:46:53] (03CR) 10jerkins-bot: [V: 04-1] WIP deepfreeze [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (owner: 10Esanders) [11:47:42] (03PS2) 10Esanders: WIP deepfreeze [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 [11:49:46] (03CR) 10jerkins-bot: [V: 04-1] WIP deepfreeze [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (owner: 10Esanders) [11:53:02] 10VisualEditor: OOUI fieldset layouts sometimes contain widgets in visual editor components - https://phabricator.wikimedia.org/T205615 (10Tchanders) [11:58:40] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design: I want a way in wikitext mode to identify that a selection shouldn't be treated as wikitext - https://phabricator.wikimedia.org/T157625 (10Izno) >>! In T157625#3715406, @Deskana wrote: > If the user has intentionally chosen to use the wik... [12:04:41] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Verified, 10VisualEditor (Current work): Mobile VE: Show virtual keyboard when a dialog is closed without any edit - https://phabricator.wikimedia.org/T203517 (10De... [12:04:53] 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), and 2 others: On mobile, cursoring off a focusable node fails - https://phabricator.wikimedia.org/T147304 (10Deskana) [12:05:26] 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Apple-Safari, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), and 2 others: Unable to scroll OOUI dialogs on iOS - https://phabricator.wikimedia.org/T126240 (10Deskana) 05Open>03Resolved [12:10:02] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10User-Ryasmeen, 10VisualEditor (Current work): jquery.textSelection methods work incorrectly with 2017 wikitext editor - https://phabricator.wikimedia.org/T198010 (10Deskana) 05Open>03Resolved [12:18:10] (03CR) 10Esanders: [C: 032] Make media size widget alignment configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462490 (https://phabricator.wikimedia.org/T190885) (owner: 10Tchanders) [12:20:23] (03Merged) 10jenkins-bot: Make media size widget alignment configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462490 (https://phabricator.wikimedia.org/T190885) (owner: 10Tchanders) [12:20:56] 10VisualEditor-Tables, 10Accessibility, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Verified, 10VisualEditor (Current work): Cursor into and out of table captions correctly with up/down arrow - https://phabricator.wikimedia.org/T201870 (10Deskana) 05Open>03Resolved [12:22:51] (03CR) 10jenkins-bot: Make media size widget alignment configurable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462490 (https://phabricator.wikimedia.org/T190885) (owner: 10Tchanders) [12:24:10] (03PS5) 10Tchanders: Enable the media dialog on mobile visual editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460926 (https://phabricator.wikimedia.org/T190885) [12:24:35] (03PS3) 10Esanders: WIP deepfreeze linear data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 [12:24:37] (03PS1) 10Esanders: Add ve.deepFreeze to ve.debug.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463241 [12:26:57] (03CR) 10jerkins-bot: [V: 04-1] WIP deepfreeze linear data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (owner: 10Esanders) [12:27:06] (03CR) 10jerkins-bot: [V: 04-1] Add ve.deepFreeze to ve.debug.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463241 (owner: 10Esanders) [12:29:19] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Technical-Debt, 10VisualEditor (Current work): Don't assume commands exist when building CommandHelpDialog - https://phabricator.wikimedia.org/T203282 (10Deskana) 05Open>03Resolved p:05Triage>03Low [12:30:10] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10User-Ryasmeen, and 2 others: Mobile VE: Show virtual keyboard when a dialog is closed without any edit - https://phabricator.wikimedia.org/T203517 (10Deskana) 05Ope... [12:30:37] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Verified, 10VisualEditor (Current work): Mobile notification toast appears under surface text - https://phabricator.wikimedia.org/T202620 (10Deskana) 05Open>03R... [13:01:57] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10User-Ryasmeen, and 2 others: Context title and description not vertically aligned - https://phabricator.wikimedia.org/T203328 (10Deskana) 05Open>03Resolved p:05... [13:03:56] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10User-Ryasmeen, and 3 others: Can't focus block image in mobile visual editor - https://phabricator.wikimedia.org/T202980 (10Deskana) 05Open>03Resolved [13:13:03] (03PS2) 10Esanders: Add ve.deepFreeze to ve.debug.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463241 [13:13:05] (03PS4) 10Esanders: WIP deepfreeze linear data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 [13:15:29] (03CR) 10jerkins-bot: [V: 04-1] WIP deepfreeze linear data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463238 (owner: 10Esanders) [13:20:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: External text with CRLF line endings breaks text processing in NWE - https://phabricator.wikimedia.org/T205564 (10matmarex) Thank you, excellent bug report :) I can reproduce the problem. Most of the issues disappear when I disable syntax highlighti... [13:29:30] (03CR) 10Esanders: [C: 032] Enable the media dialog on mobile visual editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460926 (https://phabricator.wikimedia.org/T190885) (owner: 10Tchanders) [13:30:21] 10Editing-team, 10MinervaNeue, 10MobileFrontend, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), and 3 others: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10Deskana) [13:30:23] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Epic, 10Technical-Debt: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186 (10Deskana) [13:32:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: External text with CRLF line endings breaks text processing in NWE - https://phabricator.wikimedia.org/T205564 (10matmarex) As a side note, CR newlines cause even more hilarious issues. [13:43:07] (03PS1) 10Bartosz Dziewoński: ve.dm.SourceConverter: Handle CRLF and CR newlines [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463261 (https://phabricator.wikimedia.org/T205564) [13:43:20] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): External text with CRLF line endings breaks text processing in NWE - https://phabricator.wikimedia.org/T205564 (10matmarex) a:03matmarex [13:45:16] (03CR) 10jerkins-bot: [V: 04-1] ve.dm.SourceConverter: Handle CRLF and CR newlines [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463261 (https://phabricator.wikimedia.org/T205564) (owner: 10Bartosz Dziewoński) [13:45:44] (03Merged) 10jenkins-bot: Enable the media dialog on mobile visual editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460926 (https://phabricator.wikimedia.org/T190885) (owner: 10Tchanders) [13:48:21] (03CR) 10jenkins-bot: Enable the media dialog on mobile visual editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/460926 (https://phabricator.wikimedia.org/T190885) (owner: 10Tchanders) [13:49:08] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Verified, 10VisualEditor (Current work): VisualEditor (NWE) doesn't exit cleanly when clicking the namespace tab on a discussion page - https://phabricator.wikimedia.org/T204194 (10Deskana) 05Open>03Resolved p:... [13:49:39] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Verified, 10VisualEditor (Current work): View content and edit content overlaid on top of each other (?) on mobile visual... - https://phabricator.wikimedia.org/T202517 [14:23:05] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (4888f7664) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463274 (https://phabricator.wikimedia.org/T190885) [14:34:48] 10VisualEditor: OOUI fieldset layouts sometimes contain widgets in visual editor components - https://phabricator.wikimedia.org/T205615 (10matmarex) > Should we (i) make sure the visual editor components all follow this rule (…)? I agree that ve.ui.MWMediaDialog should use FieldLayouts to wrap and labels its wi... [14:35:35] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (4888f7664) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463274 (https://phabricator.wikimedia.org/T190885) (owner: 10Bartosz Dziewoński) [14:48:06] (03Merged) 10jenkins-bot: Update VE core submodule to master (4888f7664) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463274 (https://phabricator.wikimedia.org/T190885) (owner: 10Bartosz Dziewoński) [14:50:26] (03CR) 10jenkins-bot: Update VE core submodule to master (4888f7664) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463274 (https://phabricator.wikimedia.org/T190885) (owner: 10Bartosz Dziewoński) [15:21:51] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements: Certain dialogues in the mobile visual editor are larger than necessary on certain screen sizes - https://phabricator.wikimedia.org/T203237 (10Esanders) Here's another example, the Citation dialog. While it would look... [15:25:50] 10Citoid, 10Operations, 10Services, 10Patch-For-Review, and 3 others: Deploy translation-server-v2 - https://phabricator.wikimedia.org/T201611 (10akosiaris) https://gerrit.wikimedia.org/g/mediawiki/services/zotero/+/refs/heads/master would be the repository @Mvolz I just created it and gave it the same per... [15:33:25] 10VisualEditor: OOUI fieldset layouts sometimes contain widgets in visual editor components - https://phabricator.wikimedia.org/T205615 (10Tchanders) > I agree that ve.ui.MWMediaDialog should use FieldLayouts to wrap and labels its widgets, rather than FieldsetLayouts. Ok, I can go through and correct those. Fo... [15:40:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Epic, 10Technical-Debt: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor - https://phabricator.wikimedia.org/T96186 (10JTannerWMF) a:03marcella [15:45:36] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10VisualEditor (Current work): Image resize handle is useless on mobile - https://phabricator.wikimedia.org/T205480 (10Jdforrester-WMF) [15:46:21] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-release-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10VisualEditor (Current work): Re-evaluate mobile editing for images - https://phabricator.wikimedia.org/T190885 (10Jdforrester-WMF) [15:52:54] (03CR) 10Jforrester: [C: 032] Remove deprecated domNodeArray branch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463233 (owner: 10Esanders) [15:54:57] (03PS2) 10Jforrester: Avoid jQuery in ve.dm.Model.static.describeChange(s) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463235 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [15:55:16] (03Merged) 10jenkins-bot: Remove deprecated domNodeArray branch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463233 (owner: 10Esanders) [15:55:22] (03CR) 10Jforrester: [C: 032] Avoid jQuery in ve.dm.Model.static.describeChange(s) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463235 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [15:56:14] (03PS2) 10Jforrester: eslint: Disable browser/jquery environment expectations in Node code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463236 (owner: 10Esanders) [15:56:19] (03CR) 10Jforrester: [C: 032] eslint: Disable browser/jquery environment expectations in Node code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463236 (owner: 10Esanders) [15:58:41] (03CR) 10jenkins-bot: Remove deprecated domNodeArray branch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463233 (owner: 10Esanders) [15:58:44] (03Merged) 10jenkins-bot: Avoid jQuery in ve.dm.Model.static.describeChange(s) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463235 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [15:58:50] (03PS1) 10Jforrester: eslint: Disable jquery environment expectation in DM code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 [16:00:52] (03CR) 10jerkins-bot: [V: 04-1] eslint: Disable jquery environment expectation in DM code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 (owner: 10Jforrester) [16:01:03] (03CR) 10jenkins-bot: Avoid jQuery in ve.dm.Model.static.describeChange(s) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463235 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [16:12:32] 10VisualEditor: OOUI fieldset layouts sometimes contain widgets in visual editor components - https://phabricator.wikimedia.org/T205615 (10matmarex) >>! In T205615#4622423, @Tchanders wrote: > While I'm doing this, do you think we //should// be using `addItems()` and the config option instead? No need, I think... [16:14:49] (03Merged) 10jenkins-bot: eslint: Disable browser/jquery environment expectations in Node code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463236 (owner: 10Esanders) [16:15:38] 10VisualEditor: OOUI fieldset layouts sometimes contain widgets in visual editor components - https://phabricator.wikimedia.org/T205615 (10matmarex) Also, I've just seen your media dialog changes, they're great :D [16:17:27] (03CR) 10jenkins-bot: eslint: Disable browser/jquery environment expectations in Node code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463236 (owner: 10Esanders) [16:19:42] (03PS1) 10Bartosz Dziewoński: ve.ui.MWMediaDialog: Remove unused widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463303 [16:19:44] (03PS1) 10Bartosz Dziewoński: [WIP] ve.ui.MWMediaDialog: Replace FieldsetLayout with FieldLayout (make labels smaller) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463304 (https://phabricator.wikimedia.org/T205615) [16:21:03] 10VisualEditor-MediaWiki-Media, 10Design, 10MW-1.32-release-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10VisualEditor (Current work): Media settings dialog: Replace icons with something useful - https://phabricator.wikimedia.org/T118710 (10matmarex) [16:21:25] 10VisualEditor-MediaWiki-Media, 10Design, 10MW-1.32-release-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10VisualEditor (Current work): Media settings dialog: Replace icons with something useful - https://phabricator.wikimedia.org/T118710 (10matmarex) a:03Tchanders They're gone :o [16:23:07] (03CR) 10jerkins-bot: [V: 04-1] [WIP] ve.ui.MWMediaDialog: Replace FieldsetLayout with FieldLayout (make labels smaller) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463304 (https://phabricator.wikimedia.org/T205615) (owner: 10Bartosz Dziewoński) [16:24:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Hold on, there is more unused stuff related to this…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463303 (owner: 10Bartosz Dziewoński) [16:31:33] (03PS2) 10Bartosz Dziewoński: ve.ui.MWMediaDialog: Remove unused widget and messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463303 [16:38:33] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Browser-Support-Android-Google-Chrome, and 4 others: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android - https://phabricator.wikimedia.org/T204691 (10Jdlrobson) Two patches remain open. I'm happy to get h... [16:45:51] 10VisualEditor, 10VisualEditor-MediaWiki: Remove useless "Make full size" button in media dialog - https://phabricator.wikimedia.org/T205645 (10matmarex) [16:46:11] (03PS1) 10Bartosz Dziewoński: ve.ui.MediaSizeWidget: Remove "Make full size" button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463310 (https://phabricator.wikimedia.org/T205645) [16:50:39] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Remove useless "Make full size" button in media dialog - https://phabricator.wikimedia.org/T205645 (10matmarex) I wrote the patch first, but then decided to file this task and ask if we should actually do this, just in case there is... [16:52:38] (03CR) 10Tchanders: "I like the position-wrap swap." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463304 (https://phabricator.wikimedia.org/T205615) (owner: 10Bartosz Dziewoński) [16:54:38] 10VisualEditor, 10Patch-For-Review: OOUI fieldset layouts sometimes contain widgets in visual editor components - https://phabricator.wikimedia.org/T205615 (10Tchanders) Thanks! I've commented on the patch - I think the fieldsets work semantically (unless I've misunderstood something) - particularly on the adv... [17:05:14] (03PS2) 10Jforrester: eslint: Disable jquery environment expectation in DM code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 (https://phabricator.wikimedia.org/T195111) [17:05:32] (03PS2) 10Bartosz Dziewoński: ve.dm.SourceConverter: Handle CRLF and CR newlines [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463261 (https://phabricator.wikimedia.org/T205564) [17:06:02] 10VisualEditor, 10VisualEditor-DataModel, 10MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 10Patch-For-Review, and 2 others: Avoid jQuery & CE code in ve.dm. - https://phabricator.wikimedia.org/T195111 (10Jdforrester-WMF) 05Resolved>03Open [17:09:07] (03CR) 10jerkins-bot: [V: 04-1] eslint: Disable jquery environment expectation in DM code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 (https://phabricator.wikimedia.org/T195111) (owner: 10Jforrester) [17:25:34] (03CR) 10Jforrester: "Remaining uses are for jQuery.Promise and one of parseHTML…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 (https://phabricator.wikimedia.org/T195111) (owner: 10Jforrester) [17:33:53] (03CR) 10Jforrester: [C: 031] ve.dm.SourceConverter: Handle CRLF and CR newlines [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463261 (https://phabricator.wikimedia.org/T205564) (owner: 10Bartosz Dziewoński) [18:50:21] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10Patch-For-Review, 10VisualEditor (Current work): Mobile: Range not in document error shown when recovering from auto-save - https://phabricator.wikimedia.org/T205527 (10Esanders) [18:50:52] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements: Investigate ways to improve the copy-pasting workflow on mobile - https://phabricator.wikimedia.org/T204239 (10Esanders) [18:51:31] 10VisualEditor-MediaWiki-Mobile, 10OOUI, 10Design, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 2 others: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Esanders) [18:51:34] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Improve gallery dialog for mobile visual editor - https://phabricator.wikimedia.org/T203477 (10Esanders) [18:51:43] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Improve diff dialog for mobile visual editor - https://phabricator.wikimedia.org/T203476 (10Esanders) [18:52:00] 10VisualEditor-MediaWiki-Mobile, 10Maps, 10Editing Q1 2018-19 mobile improvements, 10Patch-For-Review, 10VisualEditor (Current work): Fix maps dialog in mobile visual editor - https://phabricator.wikimedia.org/T203473 (10Esanders) [18:52:09] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, and 2 others: Fix graph dialog in mobile visual editor - https://phabricator.wikimedia.org/T203470 (10Esanders) [18:53:09] 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Assess VE mobile text input situation for each target wiki - https://phabricator.wikimedia.org/T202647 (10Esanders) [18:53:28] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Be more consistent about dialog availability in mobile visual editor - https://phabricator.wikimedia.org/T202575 (10Esanders) [18:54:21] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10WikiEditor, 10MediaWiki-Page-editing, and 3 others: Reword post edit notification to reflect save->publish change on mobile - https://phabricator.wikimedia.org/T191104 (10Esanders) [18:57:35] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Readers-Web-Backlog (Design): Abort dialog in mobile editing should feature primary destructive button - https://phabricator.wikimedia.org/T192333 (10Esanders) [19:00:13] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Readers-Web-Backlog (Design): Abort dialog in mobile editing should feature primary destructive button - https://phabricator.wikimedia.org/T192333 (10Esanders) Is this still an issue, I see this locally: {F26221761} [19:01:53] 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, and 3 others: On mobile, cursoring off a focusable node fails - https://phabricator.wikimedia.org/T147304 (10Esanders) [19:10:12] (03PS2) 10Bartosz Dziewoński: ve.ui.MediaSizeWidget: Remove "Make full size" button [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463310 (https://phabricator.wikimedia.org/T205645) [19:10:14] (03PS1) 10Bartosz Dziewoński: ve.ui.MediaSizeWidget: Change the button select to a dropdown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463347 [19:12:41] (03CR) 10Bartosz Dziewoński: "> I don't think the labels look noticeable enough on the advanced tab (e.g. "Custom" no longer looks like it's part of "Image size")... My" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463304 (https://phabricator.wikimedia.org/T205615) (owner: 10Bartosz Dziewoński) [19:21:24] 10VisualEditor-Media, 10Parsoid, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor losing Media: links - https://phabricator.wikimedia.org/T198511 (10Arlolra) {nav icon=file, name=Mentioned in SAL (#wikimedia-operations), href=https://tools.wmflabs.org/sal/log/AWYcOzfg9KCHCtNUJKoF} [2018-09-2... [19:21:32] (03CR) 10Esanders: eslint: Disable jquery environment expectation in DM code (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 (https://phabricator.wikimedia.org/T195111) (owner: 10Jforrester) [19:23:31] (03CR) 10Esanders: eslint: Disable jquery environment expectation in DM code (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 (https://phabricator.wikimedia.org/T195111) (owner: 10Jforrester) [19:25:59] (03PS1) 10Esanders: Update VE core submodule to master (5742a48a3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463355 (https://phabricator.wikimedia.org/T195111) [19:27:15] (03PS1) 10Esanders: Avoid jQuery in ve.dm.Model.static.describeChange(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463356 [19:38:47] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (5742a48a3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463355 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [19:39:21] (03CR) 10Jforrester: [C: 032] Avoid jQuery in ve.dm.Model.static.describeChange(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463356 (owner: 10Esanders) [19:39:36] 10VisualEditor, 10MinervaNeue: Editing caret is off by several pixels in VisualEditor wikitext editor. - https://phabricator.wikimedia.org/T205658 (10Jdlrobson) [19:51:16] (03PS3) 10Jforrester: eslint: Disable jquery environment expectation in DM code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 [19:51:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (5742a48a3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463355 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [19:51:33] (03CR) 10Jforrester: eslint: Disable jquery environment expectation in DM code (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 (owner: 10Jforrester) [19:51:58] (03Merged) 10jenkins-bot: Avoid jQuery in ve.dm.Model.static.describeChange(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463356 (owner: 10Esanders) [19:53:27] (03CR) 10jerkins-bot: [V: 04-1] eslint: Disable jquery environment expectation in DM code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463299 (owner: 10Jforrester) [19:53:34] (03CR) 10jenkins-bot: Update VE core submodule to master (5742a48a3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463355 (https://phabricator.wikimedia.org/T195111) (owner: 10Esanders) [19:55:31] (03CR) 10jenkins-bot: Avoid jQuery in ve.dm.Model.static.describeChange(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463356 (owner: 10Esanders) [19:59:32] 10VisualEditor, 10MinervaNeue: Editing caret is off by several pixels in VisualEditor wikitext editor. - https://phabricator.wikimedia.org/T205658 (10matmarex) I tested on https://www.mediawiki.org/wiki/Project:Sandbox?useskin=minerva and the most confounding this is that NWE actually loads. Isn't Minerva supp... [20:00:01] 10VisualEditor, 10MinervaNeue: Editing caret is off by several pixels in VisualEditor wikitext editor. - https://phabricator.wikimedia.org/T205658 (10matmarex) a:03matmarex [20:00:04] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10Timeless: The text displays one line above the cursor when syntax highlighting in while using the 2017 wikitext editor - https://phabricator.wikimedia.org/T205154 (10matmarex) a:03matmarex [20:09:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Timeless: The first letter is cut off when using the 2017 wikitext editor with the timeless skin - https://phabricator.wikimedia.org/T205149 (10matmarex) I can't reproduce using Opera 56 (Chromium 69) on Windows 10. [20:25:37] (03CR) 10Tchanders: [C: 032] ve.ui.MWMediaDialog: Remove unused widget and messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463303 (owner: 10Bartosz Dziewoński) [20:27:35] (03PS1) 10Esanders: [BREAKING CHANGE] Have ve.htmlMsg return a node array instead of jQuery collection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463368 [20:37:44] (03Merged) 10jenkins-bot: ve.ui.MWMediaDialog: Remove unused widget and messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463303 (owner: 10Bartosz Dziewoński) [20:40:06] (03CR) 10jenkins-bot: ve.ui.MWMediaDialog: Remove unused widget and messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463303 (owner: 10Bartosz Dziewoński) [21:40:43] 10VisualEditor, 10MinervaNeue, 10Patch-For-Review: Editing caret is off by several pixels in VisualEditor wikitext editor. - https://phabricator.wikimedia.org/T205658 (10Jdlrobson) > Isn't Minerva supposed to always load the mobile wikitext editor? (T198765) Fascinating. Only when it operates in mobile mode... [21:50:51] 10VisualEditor, 10MinervaNeue, 10Patch-For-Review: Editing caret is off by several pixels in VisualEditor wikitext editor. - https://phabricator.wikimedia.org/T205658 (10matmarex) >>! In T205658#4623746, @Jdlrobson wrote: >> Isn't Minerva supposed to always load the mobile wikitext editor? (T198765) Fascinat... [21:52:04] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: The text displays one line above the cursor when syntax highlighting in while using the 2017 wikitext editor - https://phabricator.wikimedia.org/T205154 (10matmarex) 05Open>03R... [21:52:32] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: Editing caret is off by several pixels in VisualEditor wikitext editor. - https://phabricator.wikimedia.org/T205658 (10matmarex) 05Open>03Resolved