[07:36:56] (03PS1) 10Divec: Logger class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463638 [07:37:09] (03PS1) 10Divec: Separate file for ProtocolServer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463639 [07:39:24] (03CR) 10jerkins-bot: [V: 04-1] Separate file for ProtocolServer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463639 (owner: 10Divec) [11:25:14] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10MediaWiki-extensions-FlaggedRevs: NWE+CodeMirror: Notice about unflagged revision can cause different line breaks - https://phabricator.wikimedia.org/T205689 (10Esanders) Non-content data s... [13:25:23] (03PS2) 10Divec: Separate file for ProtocolServer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463639 [15:05:00] (03CR) 10Esanders: [C: 032] Separate file for ProtocolServer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463639 (owner: 10Divec) [15:56:52] 10WikiEditor, 10Patch-For-Review, 10goodfirstbug: Several of the wikieditor-toolbar-* messages are used as raw html - https://phabricator.wikimedia.org/T154891 (10D3r1ck01) [18:16:35] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Remove useless "Make full size" button in media dialog - https://phabricator.wikimedia.org/T205645 (10Esanders) a:03matmarex [18:18:51] (03CR) 10Esanders: [C: 032] Logger class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463638 (owner: 10Divec) [18:21:13] (03Merged) 10jenkins-bot: Logger class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463638 (owner: 10Divec) [18:21:16] (03Merged) 10jenkins-bot: Separate file for ProtocolServer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463639 (owner: 10Divec) [18:23:36] (03CR) 10jenkins-bot: Logger class [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463638 (owner: 10Divec) [18:25:42] (03CR) 10jenkins-bot: Separate file for ProtocolServer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463639 (owner: 10Divec) [18:45:48] (03PS1) 10Esanders: Revert "Separate file for ProtocolServer" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463687 [18:46:05] (03CR) 10Esanders: [C: 032] Revert "Separate file for ProtocolServer" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463687 (owner: 10Esanders) [18:48:16] (03Merged) 10jenkins-bot: Revert "Separate file for ProtocolServer" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463687 (owner: 10Esanders) [18:50:32] (03CR) 10jenkins-bot: Revert "Separate file for ProtocolServer" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463687 (owner: 10Esanders) [20:23:20] (03PS1) 10Tchanders: Make table dialog done action message match other dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463688 (https://phabricator.wikimedia.org/T205807) [20:23:44] (03PS1) 10Tchanders: Make extension dialog done action messages match other dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463689 (https://phabricator.wikimedia.org/T205807) [20:34:24] (03CR) 10Esanders: [C: 032] Make table dialog done action message match other dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463688 (https://phabricator.wikimedia.org/T205807) (owner: 10Tchanders) [20:34:52] (03CR) 10Esanders: [C: 032] Make extension dialog done action messages match other dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463689 (https://phabricator.wikimedia.org/T205807) (owner: 10Tchanders) [20:36:38] (03Merged) 10jenkins-bot: Make table dialog done action message match other dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463688 (https://phabricator.wikimedia.org/T205807) (owner: 10Tchanders) [20:38:56] (03CR) 10jenkins-bot: Make table dialog done action message match other dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463688 (https://phabricator.wikimedia.org/T205807) (owner: 10Tchanders) [20:46:52] (03Merged) 10jenkins-bot: Make extension dialog done action messages match other dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463689 (https://phabricator.wikimedia.org/T205807) (owner: 10Tchanders) [20:49:22] (03CR) 10jenkins-bot: Make extension dialog done action messages match other dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/463689 (https://phabricator.wikimedia.org/T205807) (owner: 10Tchanders) [21:09:16] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Improve diff dialog for mobile visual editor - https://phabricator.wikimedia.org/T203476 (10Tchanders) A simple fix would be to make the sidebar narrower for smaller screen sizes. Desktop: {F26259489}... [21:11:54] (03PS1) 10Tchanders: Make visual diff dialog sidebar narrower on narrow screens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463690 (https://phabricator.wikimedia.org/T203476) [21:24:49] (03PS1) 10Esanders: ve.ce.getOffsetOfSlug: Only match leaf/branch nodes when traversing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463691 [21:26:45] (03PS2) 10Esanders: ve.ce.getOffsetOfSlug: Only match leaf/branch nodes when traversing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463691 (https://phabricator.wikimedia.org/T202103) [21:29:17] (03CR) 10Esanders: "I'm a little uncomfortable with `.ve-ce-leafNode,.ve-ce-branchNode` being our selector for "all CE nodes", but we already use it a few pla" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463691 (https://phabricator.wikimedia.org/T202103) (owner: 10Esanders) [21:29:49] 10VisualEditor: Visual editing cache should refresh after connecting to Wikidata item - https://phabricator.wikimedia.org/T205056 (10eranroz) alternatively should be handled as part of T178249 - e.g link to wikidata on the first edit [23:24:46] (03CR) 10Divec: [C: 04-1] ve.ce.getOffsetOfSlug: Only match leaf/branch nodes when traversing (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463691 (https://phabricator.wikimedia.org/T202103) (owner: 10Esanders) [23:58:27] (03PS1) 10Divec: Separate file for protocol server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695