[02:02:32] 10VisualEditor, 10Parsoid, 10Wikipedia-Android-App-Backlog, 10Parsoid-Rendering: {{Row indexer}} completely fails on the Android app / VisualEditor - https://phabricator.wikimedia.org/T203293 (10Pppery) >>! In T203293#4566886, @Arlolra wrote: > ... the comment in the module expects the contents to have bee... [03:11:34] (03Abandoned) 10Legoktm: [DNM] jenkins testing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462608 (owner: 10Legoktm) [07:09:16] 10VisualEditor, 10SVG Translate Tool: SVG Translate should highlight the translatable images in VE - https://phabricator.wikimedia.org/T206434 (10Liuxinyu970226) [09:45:05] 10Citoid, 10VisualEditor, 10Operations, 10Services (watching), and 2 others: Some requests for DOIs are failing or very slow; if we have a DOI and the request is taking too long, just use CrossRef data instead. - https://phabricator.wikimedia.org/T165105 (10Mvolz) I'm getting reports of some DOIs still bei... [11:13:12] 10WikiEditor, 10Browser-Support-Internet-Explorer, 10Browser-Support-Opera: Search&replace disabled in Internet Explorer 8–10, Opera - https://phabricator.wikimedia.org/T25992 (10PlavorSeol) Rolled back all actions by @Liuxinyu970226 [12:11:34] (03CR) 10Esanders: [C: 04-1] "You can remove the eslint-env comments now" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465019 (owner: 10Divec) [12:13:04] (03CR) 10Esanders: [C: 032] Remove ES6 support for async/await [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465020 (owner: 10Divec) [12:14:56] (03CR) 10Esanders: [C: 04-1] "You can remove the eslint-env comment" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 (owner: 10Divec) [12:15:09] 10WikiEditor, 10Browser-Support-Internet-Explorer, 10Browser-Support-Opera: Search&replace disabled in Internet Explorer 8–10, Opera - https://phabricator.wikimedia.org/T25992 (10Liuxinyu970226) @PlavorSeol for what reason? You believe that this only happens on IE8? Works for you on IE9+ and Edge? [13:41:58] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Epic, 10VisualEditor (Current work): Epic: Be more consistent about dialog availability in mobile visual editor - https://phabricator.wikimedia.org/T202575 (10iamjessklein) I am going to attempt to edit the Epic task here to inclu... [13:53:54] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Epic, 10VisualEditor (Current work): Epic: Be more consistent about dialog availability in mobile visual editor - https://phabricator.wikimedia.org/T202575 (10iamjessklein) [14:05:23] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Epic, 10VisualEditor (Current work): Epic: Be more consistent about dialog availability in mobile visual editor - https://phabricator.wikimedia.org/T202575 (10iamjessklein) [14:34:00] (03PS2) 10Divec: Move node-specific code into rebaser/ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465019 [14:34:40] (03CR) 10Divec: "Done" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465019 (owner: 10Divec) [14:37:28] (03PS3) 10Divec: Remove ES6 support for async/await [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465020 [14:38:25] (03PS5) 10Divec: Separate file for protocol server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 [14:43:26] 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Can't drag a collapsed selection across a reference on mobile - https://phabricator.wikimedia.org/T204387 (10Esanders) So... it looks like there are no touch events when using the native selection handles. Thanks mobile web! The best solution I c... [14:51:51] (03PS6) 10Divec: Separate file for protocol server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 [14:52:36] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Epic, 10VisualEditor (Current work): Epic: Be more consistent about dialog availability in mobile visual editor - https://phabricator.wikimedia.org/T202575 (10iamjessklein) [15:04:57] 10VisualEditor-Media, 10Parsoid, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor losing Media: links - https://phabricator.wikimedia.org/T198511 (10rakekniven) @ssastry Any update regarding release of Parsoid? Our wiki is still losing working links. In the meantime I upgrade our MW instance... [15:07:52] (03PS7) 10Divec: Separate files for protocol and transport server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 [15:11:15] 10VisualEditor, 10OOUI: Holistically review OOUI components used in Visual Editor dialogs - https://phabricator.wikimedia.org/T206463 (10iamjessklein) [15:20:07] (03PS5) 10Divec: WIP: Asynchronous document store [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/459273 [15:42:57] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10UI-Standardization, 10Browser-Support-Android-Google-Chrome, and 5 others: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android - https://phabricator.wikimedia.org/T204691 (10ovasileva) 05Open>03Resolved looks good - resolving. [15:53:46] (03CR) 10Tchanders: [C: 032] Wrap editPanel & searchPanel in a StackLayout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/464848 (owner: 10Esanders) [16:14:51] (03CR) 10Esanders: [C: 032] Move node-specific code into rebaser/ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465019 (owner: 10Divec) [16:15:16] (03CR) 10Esanders: [C: 032] Separate files for protocol and transport server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 (owner: 10Divec) [16:16:58] 10VisualEditor-Media, 10Parsoid, 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor losing Media: links - https://phabricator.wikimedia.org/T198511 (10ssastry) >>! In T198511#4649642, @rakekniven wrote: > @ssastry Any update regarding release of Parsoid? Our wiki is still losing working links.... [16:17:55] (03Merged) 10jenkins-bot: Wrap editPanel & searchPanel in a StackLayout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/464848 (owner: 10Esanders) [16:18:17] 10VisualEditor-MediaWiki-Mobile, 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10VisualEditor (Current work): Re-evaluate mobile editing for images - https://phabricator.wikimedia.org/T190885 (10iamjessklein) Considering that the high level issues around the OOUI mobile patterns will be dealt with... [16:19:38] (03Merged) 10jenkins-bot: Move node-specific code into rebaser/ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465019 (owner: 10Divec) [16:19:40] (03Merged) 10jenkins-bot: Remove ES6 support for async/await [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465020 (owner: 10Divec) [16:19:54] (03CR) 10jerkins-bot: [V: 04-1] Separate files for protocol and transport server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 (owner: 10Divec) [16:20:58] (03CR) 10Esanders: [C: 04-1] WIP: Asynchronous document store (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/459273 (owner: 10Divec) [16:22:18] (03CR) 10jenkins-bot: Wrap editPanel & searchPanel in a StackLayout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/464848 (owner: 10Esanders) [16:24:40] (03CR) 10jenkins-bot: Move node-specific code into rebaser/ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465019 (owner: 10Divec) [16:29:14] 10VisualEditor-MediaWiki-Mobile, 10Maps, 10Editing Q1 2018-19 mobile improvements, 10Patch-For-Review, 10VisualEditor (Current work): Fix maps dialog in mobile visual editor - https://phabricator.wikimedia.org/T203473 (10iamjessklein) >>! In T203473#4577348, @Esanders wrote: > I think we might have to fi... [16:29:23] (03CR) 10jenkins-bot: Remove ES6 support for async/await [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465020 (owner: 10Divec) [16:35:49] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Patch-For-Review, 10VisualEditor (Current work): Improve diff dialog for mobile visual editor - https://phabricator.wikimedia.org/T203476 (10iamjessklein) >>! In T203476#4... [16:39:50] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Improve gallery dialog for mobile visual editor - https://phabricator.wikimedia.org/T203477 (10iamjessklein) My main question here is if the current experience is completely impossible to do. If the answ... [16:41:37] (03PS1) 10Tchanders: Don't add body attribute to an extension node with an empty body [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465193 (https://phabricator.wikimedia.org/T206473) [16:42:00] 10VisualEditor, 10OOUI: Holistically review OOUI components used in Visual Editor dialogs - https://phabricator.wikimedia.org/T206463 (10iamjessklein) To get this work started, I'm going to make a visual map of the screens of the experience. This will help us to: - look for patterns - look for inconsistencies [16:45:00] (03CR) 10Tchanders: "I think the selfCloseEmptyBody check means this should only affect maps." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465193 (https://phabricator.wikimedia.org/T206473) (owner: 10Tchanders) [17:09:04] (03CR) 10Esanders: [C: 032] "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 (owner: 10Divec) [17:13:36] (03Merged) 10jenkins-bot: Separate files for protocol and transport server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 (owner: 10Divec) [17:17:16] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Improve gallery dialog for mobile visual editor - https://phabricator.wikimedia.org/T203477 (10Esanders) The current experience requires an image carousel and a main edit panel. We might be able to make... [17:18:44] (03CR) 10jenkins-bot: Separate files for protocol and transport server [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/463695 (owner: 10Divec) [17:19:54] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Improve gallery dialog for mobile visual editor - https://phabricator.wikimedia.org/T203477 (10iamjessklein) Agreed, those are the fixes that I would take a look at. I like the thought of responsive butt... [20:41:03] 10VisualEditor, 10AbuseFilter, 10Patch-For-Review: VisualEditor: Allow AbuseFilter rules to identify VE edits - https://phabricator.wikimedia.org/T53421 (10Whatamidoing-WMF) [21:28:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465272 (owner: 10L10n-bot) [22:53:50] (03CR) 10Bartosz Dziewoński: [C: 032] Don't add body attribute to an extension node with an empty body [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465193 (https://phabricator.wikimedia.org/T206473) (owner: 10Tchanders) [22:56:09] (03PS1) 10VolkerE: Update OOUI to v0.29.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465292 [22:57:42] MatmaRex: ^ [22:59:01] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOUI to v0.29.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465292 (owner: 10VolkerE) [22:59:07] (ping me when the other ones are up) [23:02:04] (03CR) 10Bartosz Dziewoński: [C: 032] Minor cleanup of ve.ui.MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/464597 (https://phabricator.wikimedia.org/T206236) (owner: 10Tchanders) [23:03:36] (03Merged) 10jenkins-bot: Update OOUI to v0.29.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465292 (owner: 10VolkerE) [23:06:47] (03Merged) 10jenkins-bot: Minor cleanup of ve.ui.MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/464597 (https://phabricator.wikimedia.org/T206236) (owner: 10Tchanders) [23:08:27] (03CR) 10jenkins-bot: Update OOUI to v0.29.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/465292 (owner: 10VolkerE) [23:12:31] (03CR) 10jenkins-bot: Minor cleanup of ve.ui.MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/464597 (https://phabricator.wikimedia.org/T206236) (owner: 10Tchanders) [23:16:18] (03Merged) 10jenkins-bot: Don't add body attribute to an extension node with an empty body [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465193 (https://phabricator.wikimedia.org/T206473) (owner: 10Tchanders) [23:19:53] (03CR) 10jenkins-bot: Don't add body attribute to an extension node with an empty body [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465193 (https://phabricator.wikimedia.org/T206473) (owner: 10Tchanders) [23:24:16] (03PS1) 10Bartosz Dziewoński: Update VE core submodule to master (f9afaa3e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465294 (https://phabricator.wikimedia.org/T206236) [23:25:25] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (f9afaa3e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465294 (https://phabricator.wikimedia.org/T206236) (owner: 10Bartosz Dziewoński) [23:30:19] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (f9afaa3e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465294 (https://phabricator.wikimedia.org/T206236) (owner: 10Bartosz Dziewoński) [23:31:24] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (f9afaa3e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465294 (https://phabricator.wikimedia.org/T206236) (owner: 10Bartosz Dziewoński) [23:33:08] (03PS2) 10Bartosz Dziewoński: Update VE core submodule to master (f9afaa3e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465294 (https://phabricator.wikimedia.org/T206236) [23:43:51] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (f9afaa3e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465294 (https://phabricator.wikimedia.org/T206236) (owner: 10Bartosz Dziewoński)