[01:15:02] 10VisualEditor, 10MobileFrontend, 10Wikipedia-iOS-App-Backlog, 10Mobile: Lack of next steps for new users on mobile devices when attempting to edit a protected page - https://phabricator.wikimedia.org/T206829 (10JTannerWMF) [04:03:45] 10VisualEditor, 10MediaWiki-Page-protection, 10MobileFrontend, 10Wikipedia-iOS-App-Backlog, and 2 others: Lack of next steps for new users on mobile devices when attempting to edit a protected page - https://phabricator.wikimedia.org/T206829 (10Jdlrobson) There's not much help on desktop either. :( [05:14:05] (03CR) 10Legoktm: "I don't think npm audit should be part of the Grunt task. If you do want it to be part of CI and fail tests, then we already have a separa" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462739 (owner: 10Jforrester) [05:14:27] (03CR) 10Legoktm: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462739 (owner: 10Jforrester) [05:17:22] (03CR) 10Legoktm: "Also this repo is now using npm6 for CI, so committing package-lock.json can happen whenever." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/462739 (owner: 10Jforrester) [05:50:40] 10TemplateData, 10VisualEditor: Changes to TemplateData not applied when using the TemplateData GUI, unless in safe mode - https://phabricator.wikimedia.org/T206795 (10DePiep) Notes: - Visual Editor not involved (edits are tried in classic WP edit box) - When *not* logged in: test success (no bug). - Issue als... [08:28:00] (03PS4) 10Gergő Tisza: Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [08:28:11] (03CR) 10Gergő Tisza: "> escaping of not-actually-raw-HTML messages can be fixed in another patch." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/456030 (https://phabricator.wikimedia.org/T200997) (owner: 10Jforrester) [08:28:35] (03CR) 10Robert Vogel: "recheck" [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/466665 (owner: 10Nasty) [08:29:19] (03CR) 10Gergő Tisza: [C: 031] "Removed the double-escapes indicated by Krinkle. Other than that looks good and gets all *-tool-* messages as far as I can tell." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [08:46:57] 10VisualEditor: WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10Osnard) [08:48:20] (03PS3) 10Robert Vogel: Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/466665 (https://phabricator.wikimedia.org/T206838) (owner: 10Nasty) [14:07:46] 10VisualEditor, 10MediaWiki-Page-protection, 10MobileFrontend, 10Wikipedia-iOS-App-Backlog, and 2 others: Lack of next steps for new users on mobile devices when attempting to edit a protected page - https://phabricator.wikimedia.org/T206829 (10Jdlrobson) [14:55:43] (03CR) 10Esanders: "Can you rebaser over/under I4a48f0c14f49859c50ce7be913314bb66786698d ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/466695 (https://phabricator.wikimedia.org/T202148) (owner: 10DLynch) [15:03:52] 10VisualEditor-MediaWiki, 10Contributors-Analysis, 10Product-Analytics, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Mobile editors do not log loaded events - https://phabricator.wikimedia.org/T206014 (10Esanders) 'ready' means the editor is ready to receive user input, but ma... [15:14:27] (03CR) 10Esanders: [C: 032] trackSubscriber: log activity events for VisualEditorFeatureUse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/466695 (https://phabricator.wikimedia.org/T202148) (owner: 10DLynch) [15:14:49] (03PS2) 10Esanders: Always run event logging code in debug mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465023 (https://phabricator.wikimedia.org/T205934) [15:19:00] (03PS3) 10Esanders: Always run event logging code in debug mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465023 (https://phabricator.wikimedia.org/T205934) [15:31:36] (03PS4) 10Esanders: Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/466665 (https://phabricator.wikimedia.org/T206838) (owner: 10Nasty) [15:33:16] 10VisualEditor, 10Patch-For-Review: WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10Esanders) [15:34:36] (03CR) 10Esanders: "Can you submit this as a patch to master, then we will backport as required?" [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/466665 (https://phabricator.wikimedia.org/T206838) (owner: 10Nasty) [15:36:55] (03CR) 10Esanders: [C: 031] Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/466665 (https://phabricator.wikimedia.org/T206838) (owner: 10Nasty) [15:37:35] 10Editing-team, 10MinervaNeue, 10MobileFrontend, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 3 others: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10matmarex) [15:56:21] (03CR) 10Jforrester: [C: 031] Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [15:59:00] (03PS3) 10Esanders: Improve the gallery dialog layout for mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465622 (https://phabricator.wikimedia.org/T203477) (owner: 10Tchanders) [15:59:37] (03CR) 10Esanders: [C: 032] Improve the gallery dialog layout for mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465622 (https://phabricator.wikimedia.org/T203477) (owner: 10Tchanders) [16:02:22] (03CR) 10Esanders: [C: 031] Let users know they can search by title or citation [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/466192 (https://phabricator.wikimedia.org/T198567) (owner: 10Mvolz) [16:06:04] 10Editing-team, 10MinervaNeue, 10MobileFrontend, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 3 others: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10Esanders) All the patches... [16:13:40] 10VisualEditor, 10MediaWiki-Page-protection, 10MobileFrontend, 10Wikipedia-iOS-App-Backlog, and 2 others: Lack of next steps for new users on mobile devices when attempting to edit a protected page - https://phabricator.wikimedia.org/T206829 (10Esanders) In general we don't show any edit notices in either... [16:31:28] (03CR) 10jerkins-bot: [V: 04-1] trackSubscriber: log activity events for VisualEditorFeatureUse [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/466695 (https://phabricator.wikimedia.org/T202148) (owner: 10DLynch) [17:01:49] (03CR) 10jerkins-bot: [V: 04-1] Improve the gallery dialog layout for mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465622 (https://phabricator.wikimedia.org/T203477) (owner: 10Tchanders) [17:04:44] 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Backspace across paragraphs is broken on mobile VE - https://phabricator.wikimedia.org/T202719 (10Esanders) [17:04:46] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Google-Chrome: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - https://phabricator.wikimedia.org/T69262 (10Esanders) [17:06:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Google-Chrome: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - https://phabricator.wikimedia.org/T69262 (10Esanders) Looks like on latest Chrobile/iOSafari we get input+beforeinput events with an... [17:54:35] (03CR) 10Gergő Tisza: [C: 032] Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [18:16:49] 10Editing-team, 10MinervaNeue, 10MobileFrontend, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 2 others: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop) - https://phabricator.wikimedia.org/T198765 (10matmarex) [18:24:59] 10TemplateData, 10VisualEditor: Changes to TemplateData not applied when using the TemplateData GUI, unless in safe mode - https://phabricator.wikimedia.org/T206795 (10matmarex) > Running with debug=true, webconsole message in Chrome: "Uncaught TypeError: Cannot read property 'accessKey' jquery.js[...]" (in Fi... [18:27:37] (03Merged) 10jenkins-bot: Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [18:31:45] 10WikiEditor, 10Patch-For-Review, 10goodfirstbug: Several of the wikieditor-toolbar-* messages are used as raw html - https://phabricator.wikimedia.org/T154891 (10Tgr) 05Open>03Resolved a:03Jdforrester-WMF [19:17:31] (03PS1) 10Bartosz Dziewoński: Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/466949 (https://phabricator.wikimedia.org/T206838) [19:19:12] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10Jdforrester-WMF) [19:19:19] 10Editing-team, 10MinervaNeue, 10MobileFrontend, 10Anti-Harassment (AHT Sprint 31), 10Readers-Web-Backlog (Tracking): Update the block notices on mobile web to be page specific - https://phabricator.wikimedia.org/T197122 (10TBolliger) [19:19:36] (03CR) 10Bartosz Dziewoński: [C: 032] Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/466949 (https://phabricator.wikimedia.org/T206838) (owner: 10Bartosz Dziewoński) [19:24:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10matmarex) There is no REL1_32 branch yet, as far as I can see. I don't think it has been c... [19:24:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10Jdforrester-WMF) >>! In T206838#4662266, @matmarex wrote: > There is no REL1_32 branch yet... [19:30:54] (03PS5) 10Bartosz Dziewoński: Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/466665 (https://phabricator.wikimedia.org/T206838) (owner: 10Nasty) [19:31:01] (03CR) 10Bartosz Dziewoński: [C: 032] Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/466665 (https://phabricator.wikimedia.org/T206838) (owner: 10Nasty) [19:38:32] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10matmarex) [19:47:12] (03Merged) 10jenkins-bot: Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/466949 (https://phabricator.wikimedia.org/T206838) (owner: 10Bartosz Dziewoński) [19:47:18] (03Merged) 10jenkins-bot: Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] (REL1_31) - 10https://gerrit.wikimedia.org/r/466665 (https://phabricator.wikimedia.org/T206838) (owner: 10Nasty) [19:49:53] 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): WikiText content provided by hook `EditFormPreloadText` gets converted to HTML even if VE is in WikiText mode - https://phabricator.wikimedia.org/T206838 (10matmarex) I've looked at extensions using the EditFormPreloadText hook and... [19:50:08] (03CR) 10jenkins-bot: Fix parse wikitext fragment in `paction` wikitext. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/466949 (https://phabricator.wikimedia.org/T206838) (owner: 10Bartosz Dziewoński) [21:23:34] 10VisualEditor: Inconsistent "Edit" button label - https://phabricator.wikimedia.org/T206554 (10alexhollender) @matmarex > Can you load the page with ?uselang=qqx (see https://mediawiki.org/wiki/qqx) to reveal which localisation message generates this text? | | before clicking "Edit" | after clicking "Edit" | n... [23:16:12] 10TemplateData, 10VisualEditor, 10Community-Tech, 10Community-Tech-Sprint, and 3 others: [BUG] Improve the template parameter guessing - https://phabricator.wikimedia.org/T203605 (10Niharika) 05Open>03Resolved Seems like the problems with Infobox officeholder (what is that??) are resolved. We can tack... [23:24:17] 10TemplateData, 10VisualEditor, 10Community-Tech, 10Community-Tech-Sprint, and 3 others: Ignore multiple same-name fields when guessing template params - https://phabricator.wikimedia.org/T193265 (10Niharika) 05Open>03Resolved [23:28:06] 10VisualEditor, 10I18n, 10User-Ryasmeen: [[MediaWiki:Visualeditor-debugbar-testsquasher/nb]]: "test the transaction squasher"? - https://phabricator.wikimedia.org/T202465 (10matmarex) 05Open>03Resolved a:03matmarex I hope that helps. I added a link to this comment in