[04:04:40] 10Cite, 10TemplateStyles, 10Patch-For-Review: Duplicate reference name errors in English Wikipedia caused by MediaWiki templatestyle handling? - https://phabricator.wikimedia.org/T205803 (10Jonesey95) >>! In T205803#4664752, @Hawkeye7 wrote: > If there was no change to the MediaWiki software that caused a pr... [04:06:49] 10VisualEditor: Hitting Shift+Enter within a bulleted or numbered list leads to incorrect wikitext - https://phabricator.wikimedia.org/T206969 (10Yaron_Koren) [07:35:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/467266 (owner: 10L10n-bot) [09:48:44] 10Cite, 10TemplateStyles, 10Patch-For-Review: Duplicate reference name errors in English Wikipedia caused by MediaWiki templatestyle handling? - https://phabricator.wikimedia.org/T205803 (10Mikeblas) Over the last 12 hours (or so) there has been a significant drop in the number of topics in [[ https://en.wik... [10:05:03] (03CR) 10Esanders: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465622 (https://phabricator.wikimedia.org/T203477) (owner: 10Tchanders) [10:11:08] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Target widget toolbar wraps awkwardly on narrow screens - https://phabricator.wikimedia.org/T205999 (10Esanders) [10:19:42] (03Merged) 10jenkins-bot: Improve the gallery dialog layout for mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465622 (https://phabricator.wikimedia.org/T203477) (owner: 10Tchanders) [10:22:11] (03CR) 10jenkins-bot: Improve the gallery dialog layout for mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/465622 (https://phabricator.wikimedia.org/T203477) (owner: 10Tchanders) [10:48:53] 10Cite, 10TemplateStyles, 10Patch-For-Review: Duplicate reference name errors in English Wikipedia caused by MediaWiki templatestyle handling? - https://phabricator.wikimedia.org/T205803 (10Jonesey95) >>! In T205803#4665823, @Mikeblas wrote: > Over the last 12 hours (or so) there has been a significant drop... [11:12:50] 10Cite, 10TemplateStyles, 10Patch-For-Review: Duplicate reference name errors in English Wikipedia caused by MediaWiki templatestyle handling? - https://phabricator.wikimedia.org/T205803 (10Mikeblas) I'm sure there's a lot that I don't know about the developmnet process used by this project. For example, I d... [13:02:37] 10VisualEditor, 10Parsoid: Media "alt" text wrongly interpreted as caption - https://phabricator.wikimedia.org/T206940 (10cscott) There's a misfeature in the PHP parser where "anything which doesn't properly parse as an option" is assumed to be a caption. Parsoid mimics this behavior, for better or for worse.... [13:07:06] 10VisualEditor, 10Parsoid: Media "alt" text wrongly interpreted as caption - https://phabricator.wikimedia.org/T206940 (10cscott) And in particular it seems to be the newline between the double-quotes in the caption which is causing the `alt` attribute to fail. [13:11:14] 10VisualEditor, 10Parsoid: Newlines in "alt" text between double-quotes breaks media attribute parsing - https://phabricator.wikimedia.org/T206940 (10cscott) [13:16:02] (03CR) 10Esanders: [C: 032] Asynchronous document store (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/459273 (owner: 10Divec) [13:18:34] (03Merged) 10jenkins-bot: Asynchronous document store [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/459273 (owner: 10Divec) [13:19:16] 10VisualEditor, 10Parsoid: Newlines in "alt" text between double-quotes breaks media attribute parsing - https://phabricator.wikimedia.org/T206940 (10cscott) Hey, look at this: ``` $ (echo "[[File:Foo.jpg|caption|alt=''"; echo "alt'']]") | php maintenance/parse.php

10Citoid, 10VisualEditor, 10Operations, 10Services (watching), and 2 others: Some requests for DOIs are failing or very slow; if we have a DOI and the request is taking too long, just use CrossRef data instead. - https://phabricator.wikimedia.org/T165105 (10mobrovac) It takes 75 secs for Citoid in producti... [13:59:07] 10VisualEditor, 10Parsoid: Newlines in "alt" text between double-quotes breaks media attribute parsing - https://phabricator.wikimedia.org/T206940 (10cscott) i'm working on a patch [15:06:54] 10VisualEditor-MediaWiki-Mobile, 10Editing Q1 2018-19 mobile improvements, 10Epic, 10VisualEditor (Current work): Epic: Be more consistent about dialog availability in mobile visual editor - https://phabricator.wikimedia.org/T202575 (10Tchanders) [15:19:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Performance: Analyse load time performance of FA-length pages on mobile - https://phabricator.wikimedia.org/T206228 (10marcella) [16:01:02] 10Cite, 10TemplateStyles, 10Patch-For-Review: Duplicate reference name errors in English Wikipedia caused by MediaWiki templatestyle handling? - https://phabricator.wikimedia.org/T205803 (10Aklapper) Please feel free to ask general "how does/should development work" questions in a forum or mailing list, as t... [16:35:14] 10Cite, 10TemplateStyles, 10Patch-For-Review: Duplicate reference name errors in English Wikipedia caused by MediaWiki templatestyle handling? - https://phabricator.wikimedia.org/T205803 (10Anomie) >>! In T205803#4663276, @Hawkeye7 wrote: > Can we please revert the offending change? The "offending change" w... [16:37:11] 10Cite, 10TemplateStyles, 10Patch-For-Review: Duplicate reference name errors in English Wikipedia caused by MediaWiki templatestyle handling? - https://phabricator.wikimedia.org/T205803 (10Anomie) 05Open>03Resolved a:03Anomie As noted above, we typically close Phabricator tasks when the fix is applied... [16:37:22] 10Cite, 10TemplateStyles, 10Patch-For-Review: Duplicate reference name errors in English Wikipedia caused by MediaWiki templatestyle handling? - https://phabricator.wikimedia.org/T205803 (10Anomie) a:05Anomie>03Tgr [17:03:33] (03CR) 10Jforrester: [C: 032] ApiTemplateData: Remove needless count() call [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467105 (owner: 10Krinkle) [17:03:51] (03CR) 10Jforrester: [C: 032] ApiTemplateData: Use strict check for $langCode [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467106 (owner: 10Krinkle) [17:04:31] (03CR) 10Jforrester: [C: 032] ApiTemplateData: Address non-array count() warning on PHP 7.2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467107 (https://phabricator.wikimedia.org/T202087) (owner: 10Krinkle) [17:04:44] (03CR) 10Jforrester: [C: 032] "check experimental" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467107 (https://phabricator.wikimedia.org/T202087) (owner: 10Krinkle) [17:06:42] (03Abandoned) 10Jforrester: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/444380 (owner: 10Paladox) [17:08:37] (03Merged) 10jenkins-bot: ApiTemplateData: Remove needless count() call [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467105 (owner: 10Krinkle) [17:09:18] (03Merged) 10jenkins-bot: ApiTemplateData: Use strict check for $langCode [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467106 (owner: 10Krinkle) [17:10:57] (03CR) 10jenkins-bot: ApiTemplateData: Remove needless count() call [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467105 (owner: 10Krinkle) [17:11:16] (03Merged) 10jenkins-bot: ApiTemplateData: Address non-array count() warning on PHP 7.2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467107 (https://phabricator.wikimedia.org/T202087) (owner: 10Krinkle) [17:12:33] (03CR) 10jenkins-bot: ApiTemplateData: Use strict check for $langCode [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467106 (owner: 10Krinkle) [17:14:14] (03CR) 10jenkins-bot: ApiTemplateData: Address non-array count() warning on PHP 7.2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/467107 (https://phabricator.wikimedia.org/T202087) (owner: 10Krinkle) [17:19:46] 10TemplateData, 10VisualEditor, 10Performance-Team, 10PHP 7.2 support, 10Patch-For-Review: TemplateData emits count() parameter warning on PHP7.2 - https://phabricator.wikimedia.org/T202087 (10Jdforrester-WMF) [17:20:10] 10TemplateData, 10VisualEditor, 10Performance-Team, 10PHP 7.2 support, 10User-Ryasmeen: TemplateData emits count() parameter warning on PHP7.2 - https://phabricator.wikimedia.org/T202087 (10Jdforrester-WMF) 05Open>03Resolved [17:23:04] 10VisualEditor, 10Parsoid: Quote marks in "alt" text break media attribute parsing - https://phabricator.wikimedia.org/T206940 (10Krinkle) [17:23:42] 10VisualEditor, 10Parsoid: Quote marks in "alt" text break media attribute parsing - https://phabricator.wikimedia.org/T206940 (10Krinkle) @cscott Hm.. so it's not the new lines. I assume that means its the quote marks that trigger it? [17:26:05] 10VisualEditor, 10Parsoid: Quote marks in "alt" text break media attribute parsing - https://phabricator.wikimedia.org/T206940 (10cscott) Well, a combination of things. It's triggered by the quote marks, but then we're not handling the `` in the serialized version either. `[[File:Foo.jpg|alt=... [17:42:11] 10VisualEditor: Hitting Shift+Enter within a bulleted or numbered list leads to incorrect wikitext - https://phabricator.wikimedia.org/T206969 (10matmarex) [17:51:03] 10VisualEditor, 10Parsoid: Quote marks in "alt" text break media attribute parsing - https://phabricator.wikimedia.org/T206940 (10cscott) Turns out there's a bug in how core PHP parses `[[File:Foo.jpg|link=Foo''s bar''s]]` (which is a valid title) or `[[File:Foo.jpg|link=''Main Page'']]` (where the italics app... [18:05:14] (03PS1) 10Paladox: ApiTemplateData: Remove needless count() call [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467431 [18:05:29] (03PS1) 10Paladox: ApiTemplateData: Use strict check for $langCode [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467432 [18:05:38] (03PS1) 10Paladox: ApiTemplateData: Address non-array count() warning on PHP 7.2 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467433 (https://phabricator.wikimedia.org/T202087) [18:11:18] (03CR) 10Jforrester: [C: 032] ApiTemplateData: Use strict check for $langCode [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467432 (owner: 10Paladox) [18:11:31] (03CR) 10Jforrester: [C: 032] ApiTemplateData: Address non-array count() warning on PHP 7.2 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467433 (https://phabricator.wikimedia.org/T202087) (owner: 10Paladox) [18:11:33] (03CR) 10Jforrester: [C: 032] ApiTemplateData: Remove needless count() call [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467431 (owner: 10Paladox) [18:15:52] (03CR) 10jerkins-bot: [V: 04-1] ApiTemplateData: Use strict check for $langCode [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467432 (owner: 10Paladox) [18:20:21] (03CR) 10jerkins-bot: [V: 04-1] ApiTemplateData: Remove needless count() call [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467431 (owner: 10Paladox) [18:20:51] (03CR) 10jerkins-bot: [V: 04-1] ApiTemplateData: Address non-array count() warning on PHP 7.2 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467433 (https://phabricator.wikimedia.org/T202087) (owner: 10Paladox) [18:24:45] (03PS1) 10Jforrester: TemplateDataBlobTest: Ensure identical results on PHP 7.1 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467438 (https://phabricator.wikimedia.org/T206287) [18:24:51] (03CR) 10Jforrester: [C: 032] TemplateDataBlobTest: Ensure identical results on PHP 7.1 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467438 (https://phabricator.wikimedia.org/T206287) (owner: 10Jforrester) [18:27:58] (03CR) 10jerkins-bot: [V: 04-1] TemplateDataBlobTest: Ensure identical results on PHP 7.1 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467438 (https://phabricator.wikimedia.org/T206287) (owner: 10Jforrester) [18:28:35] (03Merged) 10jenkins-bot: TemplateDataBlobTest: Ensure identical results on PHP 7.1 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467438 (https://phabricator.wikimedia.org/T206287) (owner: 10Jforrester) [18:30:27] (03CR) 10jenkins-bot: TemplateDataBlobTest: Ensure identical results on PHP 7.1 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467438 (https://phabricator.wikimedia.org/T206287) (owner: 10Jforrester) [18:32:32] (03CR) 10Jforrester: [C: 032] "…" [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467432 (owner: 10Paladox) [18:32:56] (03CR) 10Jforrester: [C: 032] "…" [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467431 (owner: 10Paladox) [18:33:07] (03CR) 10Jforrester: [C: 032] "…" [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467433 (https://phabricator.wikimedia.org/T202087) (owner: 10Paladox) [18:36:03] (03Merged) 10jenkins-bot: ApiTemplateData: Use strict check for $langCode [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467432 (owner: 10Paladox) [18:36:22] (03Merged) 10jenkins-bot: ApiTemplateData: Remove needless count() call [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467431 (owner: 10Paladox) [18:36:32] (03Merged) 10jenkins-bot: ApiTemplateData: Address non-array count() warning on PHP 7.2 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467433 (https://phabricator.wikimedia.org/T202087) (owner: 10Paladox) [18:37:47] (03CR) 10jenkins-bot: ApiTemplateData: Use strict check for $langCode [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467432 (owner: 10Paladox) [18:39:26] (03CR) 10jenkins-bot: ApiTemplateData: Remove needless count() call [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467431 (owner: 10Paladox) [18:41:07] (03CR) 10jenkins-bot: ApiTemplateData: Address non-array count() warning on PHP 7.2 [extensions/TemplateData] (REL1_31) - 10https://gerrit.wikimedia.org/r/467433 (https://phabricator.wikimedia.org/T202087) (owner: 10Paladox) [19:58:33] 10VisualEditor, 10MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)), 10Technical-Debt: ve.ce.LinearArrowKeyDownHandler.js is largely untested - https://phabricator.wikimedia.org/T130389 (10marcella) [20:21:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467504 (owner: 10L10n-bot) [20:57:24] (03CR) 10Bartosz Dziewoński: [C: 031] "Seems good to go after the OOUI patch is pulled through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/464641 (https://phabricator.wikimedia.org/T205948) (owner: 10Esanders) [22:06:07] (03PS1) 10Catrope: trackSubscriber: Use early return for 6.25% sampling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467535 [22:09:46] (03CR) 10Jforrester: [C: 032] trackSubscriber: Use early return for 6.25% sampling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467535 (owner: 10Catrope) [22:32:29] (03Merged) 10jenkins-bot: trackSubscriber: Use early return for 6.25% sampling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467535 (owner: 10Catrope) [22:35:01] (03CR) 10jenkins-bot: trackSubscriber: Use early return for 6.25% sampling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467535 (owner: 10Catrope) [22:55:09] (03PS1) 10Catrope: Use Schema:Edit sampling rate config from WikimediaEvents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/467543 (https://phabricator.wikimedia.org/T206543) [22:55:36] (03PS1) 10Catrope: Use Schema:Edit sampling rate config from WikimediaEvents [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/467544 (https://phabricator.wikimedia.org/T206543) [22:55:55] 10VisualEditor, 10Product-Analytics, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add configuration variable for sampling rate on Edit schema - https://phabricator.wikimedia.org/T206543 (10Neil_P._Quinn_WMF) [23:27:50] 10TemplateData, 10VisualEditor: Changes to TemplateData not applied when using the TemplateData GUI, unless in safe mode - https://phabricator.wikimedia.org/T206795 (10matmarex) 05Open>03Invalid a:03matmarex I spent a few hours investigating this today. The problem with TemplateData editor and the except...