[00:01:12] (03CR) 10Divec: [C: 032] Add more tests to LinearArrowKeyDownHandler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468005 (https://phabricator.wikimedia.org/T207077) (owner: 10Esanders) [00:04:05] (03Merged) 10jenkins-bot: Add more tests to LinearArrowKeyDownHandler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468005 (https://phabricator.wikimedia.org/T207077) (owner: 10Esanders) [00:06:46] (03CR) 10jenkins-bot: Add more tests to LinearArrowKeyDownHandler [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468005 (https://phabricator.wikimedia.org/T207077) (owner: 10Esanders) [00:17:47] (03CR) 10Divec: [C: 032] LinearArrowKeyDownHandler: Test Selection#extend fallback [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468302 (https://phabricator.wikimedia.org/T207077) (owner: 10Esanders) [00:18:27] (03PS1) 10Divec: LinearArrowKeyDownHandler tests: use try-finally so teardown always runs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [00:20:35] (03Merged) 10jenkins-bot: LinearArrowKeyDownHandler: Test Selection#extend fallback [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468302 (https://phabricator.wikimedia.org/T207077) (owner: 10Esanders) [00:25:14] (03CR) 10jenkins-bot: LinearArrowKeyDownHandler: Test Selection#extend fallback [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468302 (https://phabricator.wikimedia.org/T207077) (owner: 10Esanders) [01:32:38] (03PS2) 10Divec: LinearArrowKeyDownHandler tests: use try-finally so teardown always runs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [01:34:51] (03PS3) 10Divec: LinearArrowKeyDownHandler tests: use try-finally so teardown always runs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [02:09:50] (03PS4) 10Divec: LinearArrowKeyDownHandler tests: handle test errors more gracefully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [02:40:37] (03PS5) 10Divec: LinearArrowKeyDownHandler tests: handle test errors more gracefully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [02:42:25] (03PS6) 10Divec: LinearArrowKeyDownHandler tests: handle test errors more gracefully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [03:21:40] (03CR) 10Divec: [C: 04-1] "Good plan, we just have to find a Heisenbug :(" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [03:28:31] (03PS7) 10Divec: Keydown tests: handle test errors more gracefully [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [04:37:46] (03CR) 10Divec: [C: 04-1] Keydown test refactor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [08:03:12] (03CR) 10Divec: [C: 04-1] Keydown test refactor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [08:11:25] (03PS3) 10Divec: Keydown test refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [08:16:42] (03CR) 10Divec: "Patch set 3 keeps the promise code structure but executes the code synchronously, so we can build on this code structure without triggerin" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [08:19:40] (03PS3) 10Divec: Assert defaultPrevented state in KeyDown tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468711 (owner: 10Esanders) [08:19:42] (03PS4) 10Divec: LinearDeleteKeyDownHandler: Test shift+delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468712 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [08:19:44] (03PS6) 10Divec: LinearDeleteKeyDownHandler: Test delete next to link [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468303 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [08:19:46] (03PS2) 10Divec: LinearEnterKeyDownHandler: Add more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468715 (https://phabricator.wikimedia.org/T207079) (owner: 10Esanders) [08:19:48] (03PS2) 10Divec: KeyDownTests: Remove unused constructor calls for all static classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468719 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [08:19:50] (03PS4) 10Divec: KeyDown tests: Add tests for missing cases to cover tab/escape/enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468720 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [08:19:52] (03PS3) 10Divec: Add tests for ve.ce.AnnotationFactory/NodeFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468727 (owner: 10Esanders) [08:19:54] (03PS3) 10Divec: Delete unused ve.ce.modelChangeFromContentChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468735 (owner: 10Esanders) [09:08:25] (03PS4) 10Divec: Keydown test refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [09:10:54] (03CR) 10jerkins-bot: [V: 04-1] Keydown test refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [09:13:18] (03PS5) 10Divec: Keydown test refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [09:14:42] (03PS4) 10Divec: Assert defaultPrevented state in KeyDown tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468711 (owner: 10Esanders) [09:14:44] (03PS5) 10Divec: LinearDeleteKeyDownHandler: Test shift+delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468712 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [09:14:46] (03PS7) 10Divec: LinearDeleteKeyDownHandler: Test delete next to link [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468303 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [09:14:49] (03PS3) 10Divec: LinearEnterKeyDownHandler: Add more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468715 (https://phabricator.wikimedia.org/T207079) (owner: 10Esanders) [09:14:50] (03PS3) 10Divec: KeyDownTests: Remove unused constructor calls for all static classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468719 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [09:14:52] (03PS5) 10Divec: KeyDown tests: Add tests for missing cases to cover tab/escape/enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468720 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [09:14:54] (03PS4) 10Divec: Add tests for ve.ce.AnnotationFactory/NodeFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468727 (owner: 10Esanders) [09:14:57] (03PS4) 10Divec: Delete unused ve.ce.modelChangeFromContentChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468735 (owner: 10Esanders) [09:25:33] (03PS8) 10Divec: WIP: Keydown tests: run asynchronously [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [09:39:28] (03PS9) 10Divec: WIP: Keydown tests: run asynchronously [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [11:15:10] (03CR) 10Divec: [C: 031] "+2 to the parts I didn't write" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [11:16:50] (03CR) 10Divec: [C: 032] Assert defaultPrevented state in KeyDown tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468711 (owner: 10Esanders) [12:12:25] (03PS1) 10Divec: Use native promises instead of jQuery promises [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468820 [12:15:01] (03CR) 10Divec: "I guess an argument for not doing this is we need jQuery promises in non-test code, and it increases the cognitive burden to have two type" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468820 (owner: 10Divec) [12:35:16] (03CR) 10Esanders: [C: 032] Use native promises instead of jQuery promises [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468820 (owner: 10Divec) [12:35:22] (03CR) 10Esanders: [C: 032] Keydown test refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [12:39:47] (03Merged) 10jenkins-bot: Keydown test refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [12:39:49] (03Merged) 10jenkins-bot: Assert defaultPrevented state in KeyDown tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468711 (owner: 10Esanders) [12:41:17] (03CR) 10Divec: [C: 032] LinearDeleteKeyDownHandler: Test shift+delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468712 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [12:43:07] (03Merged) 10jenkins-bot: LinearDeleteKeyDownHandler: Test shift+delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468712 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [12:43:36] (03CR) 10Divec: [C: 032] LinearDeleteKeyDownHandler: Test delete next to link [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468303 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [12:44:19] (03CR) 10jenkins-bot: Keydown test refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468710 (owner: 10Esanders) [12:45:39] (03CR) 10Divec: [C: 032] LinearEnterKeyDownHandler: Add more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468715 (https://phabricator.wikimedia.org/T207079) (owner: 10Esanders) [12:46:52] (03CR) 10jenkins-bot: Assert defaultPrevented state in KeyDown tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468711 (owner: 10Esanders) [12:47:43] (03Merged) 10jenkins-bot: LinearDeleteKeyDownHandler: Test delete next to link [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468303 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [12:47:53] (03Merged) 10jenkins-bot: LinearEnterKeyDownHandler: Add more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468715 (https://phabricator.wikimedia.org/T207079) (owner: 10Esanders) [12:47:58] (03CR) 10Divec: [C: 032] KeyDownTests: Remove unused constructor calls for all static classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468719 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [12:48:55] (03CR) 10jenkins-bot: LinearDeleteKeyDownHandler: Test shift+delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468712 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [12:50:26] (03CR) 10Divec: [C: 032] KeyDown tests: Add tests for missing cases to cover tab/escape/enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468720 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [12:50:37] (03Merged) 10jenkins-bot: KeyDownTests: Remove unused constructor calls for all static classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468719 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [12:51:25] (03CR) 10jenkins-bot: LinearDeleteKeyDownHandler: Test delete next to link [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468303 (https://phabricator.wikimedia.org/T207078) (owner: 10Esanders) [12:53:09] (03CR) 10jenkins-bot: LinearEnterKeyDownHandler: Add more tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468715 (https://phabricator.wikimedia.org/T207079) (owner: 10Esanders) [12:53:34] (03CR) 10Divec: [C: 032] Add tests for ve.ce.AnnotationFactory/NodeFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468727 (owner: 10Esanders) [12:54:28] (03CR) 10Divec: [C: 032] Delete unused ve.ce.modelChangeFromContentChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468735 (owner: 10Esanders) [12:54:51] (03CR) 10jenkins-bot: KeyDownTests: Remove unused constructor calls for all static classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468719 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [12:55:37] (03Merged) 10jenkins-bot: KeyDown tests: Add tests for missing cases to cover tab/escape/enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468720 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [12:55:39] (03PS10) 10Divec: Keydown tests: run asynchronously [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 [12:55:41] (03Merged) 10jenkins-bot: Add tests for ve.ce.AnnotationFactory/NodeFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468727 (owner: 10Esanders) [12:57:18] (03Merged) 10jenkins-bot: Delete unused ve.ce.modelChangeFromContentChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468735 (owner: 10Esanders) [12:58:21] (03CR) 10jenkins-bot: KeyDown tests: Add tests for missing cases to cover tab/escape/enter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468720 (https://phabricator.wikimedia.org/T207080) (owner: 10Esanders) [13:03:21] (03CR) 10jenkins-bot: Add tests for ve.ce.AnnotationFactory/NodeFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468727 (owner: 10Esanders) [13:05:57] (03CR) 10jenkins-bot: Delete unused ve.ce.modelChangeFromContentChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468735 (owner: 10Esanders) [13:16:51] (03CR) 10Esanders: [C: 032] Keydown tests: run asynchronously [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 (owner: 10Divec) [13:19:08] (03Merged) 10jenkins-bot: Keydown tests: run asynchronously [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 (owner: 10Divec) [13:21:57] (03CR) 10jenkins-bot: Keydown tests: run asynchronously [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468796 (owner: 10Divec) [13:22:00] (03PS2) 10Divec: Use native promises instead of jQuery promises [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468820 [13:23:21] (03CR) 10Esanders: [C: 032] Use native promises instead of jQuery promises [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468820 (owner: 10Divec) [13:25:58] (03Merged) 10jenkins-bot: Use native promises instead of jQuery promises [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468820 (owner: 10Divec) [13:28:43] (03CR) 10jenkins-bot: Use native promises instead of jQuery promises [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468820 (owner: 10Divec) [13:31:46] (03PS1) 10Esanders: KeyDown tests: Remove unnecessary setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468827 [13:34:50] (03PS1) 10Esanders: KeyDown tests: Un-nest functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468828 [13:37:53] (03PS1) 10Esanders: KeyDown tests: rename defer -> then [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468829 [13:55:24] (03PS1) 10Esanders: Allow ES6 in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468834 [13:58:47] 10Citoid, 10Community-Tech: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156 (10martin.monperrus) RefToolbar queries Citoid only for ISBN and URL queries, see https://github.com/alexz-enwp/reftoolbar/blob/master/lookup.php#L328 This pull-request proposes that RefToolbar also... [14:06:15] 10Citoid, 10Community-Tech: Add Citoid support to RefToolbar gadget - https://phabricator.wikimedia.org/T114156 (10Mvolz) Yes, you have to put the DOI in the URL field if you want a response from citoid - a bit confusing. Plausibly we should enable citoid for the DOI field as well. [17:14:01] (03CR) 10Jforrester: [C: 032] KeyDown tests: Un-nest functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468828 (owner: 10Esanders) [17:14:14] (03CR) 10Jforrester: [C: 032] KeyDown tests: rename defer -> then [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468829 (owner: 10Esanders) [17:14:22] (03CR) 10Jforrester: [C: 032] Allow ES6 in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468834 (owner: 10Esanders) [17:56:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: refToolBar causes error with wikitext 2017 editor - https://phabricator.wikimedia.org/T207604 (10Mvolz) [17:56:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: refToolBar gadget on en wiki causes error with wikitext 2017 editor - https://phabricator.wikimedia.org/T207604 (10Mvolz) [17:59:34] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: refToolBar gadget on en wiki causes error with wikitext 2017 editor - https://phabricator.wikimedia.org/T207604 (10Mvolz) [17:59:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: refToolBar gadget on en wiki possibly interfering with wikitext 2017 editor - https://phabricator.wikimedia.org/T207604 (10Mvolz) [18:13:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: refToolBar gadget on en wiki possibly interfering with wikitext 2017 editor - https://phabricator.wikimedia.org/T207604 (10Mvolz) On second check it's actually the GoogleTrans gadget (https://en.wikipedia.org/wiki/User:Endo999/GoogleTrans) that seems... [18:13:46] (03PS1) 10Esanders: LinearEnterKeyDownHandler: Add test for edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468854 [18:21:51] (03CR) 10jerkins-bot: [V: 04-1] LinearEnterKeyDownHandler: Add test for edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468854 (owner: 10Esanders) [20:43:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/468895 (owner: 10L10n-bot) [22:31:47] (03PS1) 10Putnik: Lua method for TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) [22:40:11] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Israel-Hackers, 10Patch-For-Review: Provide a Lua method mw.loadTemplateData() - https://phabricator.wikimedia.org/T107119 (10putnik) I made a patch that adds a method to get TemplateData in Lua. The method is currently named `mw.ext.T... [22:46:13] (03CR) 10Saint Johann: "recheck" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [23:07:56] 10Cite: Line breaks between punctuation and footnote - https://phabricator.wikimedia.org/T132266 (10Josve05a) WFM now at least... [23:28:25] 10Cite, 10Mobile: Raw CSS source from Cite getting shown in reference preview on mobile (android chrome) - https://phabricator.wikimedia.org/T207619 (10Mvolz)