[00:15:15] Is VE/Parsoid supposed to normalise a gallery's attributes when changing contents of it? E.g. I removed an image from a gallery using VE and it reordered the attributes, removed the 'px' from widths/heights, and IIRC the visual diff showed up strange for widths/heights [00:17:19] okay so visual diff reflects the change of widths/heights from having 'px' to not having 'px'. [00:17:42] it also shows 'altText changed from null to ' for each of the remaining images in the gallery - I assume that means they changed from null to empty string behind the scenes? [00:18:06] eh I'll just throw this into a phabricator ticket [00:19:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Slightly strange behaviour around removing image from gallery using VE - https://phabricator.wikimedia.org/T207620 (10Krenair) [00:30:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Slightly strange behaviour around removing image from gallery using VE - https://phabricator.wikimedia.org/T207620 (10Krenair) (probably lowest priority given how minor this is but I thought I'd file it anyway) [03:28:58] 10VisualEditor, 10TemplateStyles: Footnote weirdness after editing the title parameter - https://phabricator.wikimedia.org/T207325 (10Nirmos) [06:11:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468916 (owner: 10L10n-bot) [08:23:55] 10VisualEditor, 10CommRel-Documentation: Create project page for mobile editing improvements - https://phabricator.wikimedia.org/T207302 (10Elitre) [08:24:21] 10VisualEditor, 10CommRel-Documentation: Write Editing newsletter - https://phabricator.wikimedia.org/T207301 (10Elitre) [12:14:21] (03PS1) 10Esanders: Fix test in Chrome 70 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468960 (https://phabricator.wikimedia.org/T207654) [12:32:53] (03PS1) 10Esanders: Basic tests for getClientRects in ve.ce.Selection and FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468962 (https://phabricator.wikimedia.org/T207083) [12:50:48] (03PS2) 10Esanders: Basic tests for getClientRects in ve.ce.Selection and FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468962 (https://phabricator.wikimedia.org/T207083) [12:50:50] (03PS1) 10Esanders: Remove false coverage of TableNode/TableSelection code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468967 [13:03:37] 10VisualEditor: EPIC: Synthesize + Share VE Brainstorms and Plan Next Steps - https://phabricator.wikimedia.org/T207519 (10iamjessklein) [13:08:00] 10VisualEditor: EPIC: Synthesize + Share VE Brainstorms and Plan Next Steps - https://phabricator.wikimedia.org/T207519 (10iamjessklein) [13:11:49] 10VisualEditor: EPIC: Synthesize + Share VE Brainstorms and Plan Next Steps - https://phabricator.wikimedia.org/T207519 (10iamjessklein) [13:33:48] (03PS1) 10Esanders: Remove broken checks for DM code coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468974 [14:08:44] (03PS3) 10Esanders: Basic tests for getClientRects in ve.ce.Selection and FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468962 (https://phabricator.wikimedia.org/T207083) [14:08:46] (03PS1) 10Esanders: Remove setupToolbar from DummyTarget to avoid false code coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468984 [14:08:48] (03PS1) 10Esanders: ve.ce.Selection: Add getDirection tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468985 [14:12:21] (03CR) 10Anomie: Lua method for TemplateData (0310 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [14:13:53] (03CR) 10Anomie: "Thanks for taking this on. It looks like a good start, just a few small issues." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [14:38:04] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Israel-Hackers, 10Patch-For-Review: Provide a Lua method mw.loadTemplateData() - https://phabricator.wikimedia.org/T107119 (10stjn) >>! In T107119#4684407, @putnik wrote: > I made a patch that adds a method to get TemplateData in Lua.... [15:22:25] (03CR) 10Jforrester: [C: 032] Fix test in Chrome 70 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468960 (https://phabricator.wikimedia.org/T207654) (owner: 10Esanders) [15:26:24] (03Merged) 10jenkins-bot: Fix test in Chrome 70 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468960 (https://phabricator.wikimedia.org/T207654) (owner: 10Esanders) [15:32:23] (03CR) 10jenkins-bot: Fix test in Chrome 70 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468960 (https://phabricator.wikimedia.org/T207654) (owner: 10Esanders) [15:54:03] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468854 (owner: 10Esanders) [15:56:33] (03CR) 10Jforrester: [C: 032] Remove broken checks for DM code coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468974 (owner: 10Esanders) [15:58:31] (03Merged) 10jenkins-bot: Remove broken checks for DM code coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468974 (owner: 10Esanders) [16:02:56] (03CR) 10jenkins-bot: Remove broken checks for DM code coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468974 (owner: 10Esanders) [16:13:25] (03PS2) 10Esanders: KeyDown tests: Remove unnecessary setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468827 [16:13:31] (03PS2) 10Esanders: KeyDown tests: Un-nest functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468828 [16:13:37] (03PS2) 10Esanders: KeyDown tests: rename defer -> then [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468829 [16:13:43] (03PS2) 10Esanders: Allow ES6 in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468834 [16:16:27] (03CR) 10Kosta Harlan: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/467885 (https://phabricator.wikimedia.org/T206543) (owner: 10Catrope) [16:30:50] (03CR) 10Jforrester: [C: 032] LinearEnterKeyDownHandler: Add test for edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468854 (owner: 10Esanders) [16:32:45] (03CR) 10jerkins-bot: [V: 04-1] Oversample Schema:Edit events when configured to do so [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/467885 (https://phabricator.wikimedia.org/T206543) (owner: 10Catrope) [16:34:17] (03Merged) 10jenkins-bot: LinearEnterKeyDownHandler: Add test for edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468854 (owner: 10Esanders) [16:36:34] (03CR) 10jenkins-bot: LinearEnterKeyDownHandler: Add test for edge case [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468854 (owner: 10Esanders) [16:59:55] (03CR) 10Divec: [C: 04-1] "I agree it works, but I'm unclear as to whether it works by robust principle or on sleight of promise." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468827 (owner: 10Esanders) [17:26:20] (03PS1) 10Jforrester: Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) [17:26:51] (03CR) 10Jforrester: [C: 032] Remove false coverage of TableNode/TableSelection code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468967 (owner: 10Esanders) [17:26:56] (03CR) 10Jforrester: [C: 032] Remove setupToolbar from DummyTarget to avoid false code coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468984 (owner: 10Esanders) [17:27:20] (03CR) 10Jforrester: [C: 032] Basic tests for getClientRects in ve.ce.Selection and FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468962 (https://phabricator.wikimedia.org/T207083) (owner: 10Esanders) [17:28:08] (03CR) 10Jforrester: [C: 032] ve.ce.Selection: Add getDirection tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468985 (owner: 10Esanders) [17:29:11] (03Merged) 10jenkins-bot: Remove false coverage of TableNode/TableSelection code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468967 (owner: 10Esanders) [17:29:25] (03Merged) 10jenkins-bot: Remove setupToolbar from DummyTarget to avoid false code coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468984 (owner: 10Esanders) [17:29:37] (03Merged) 10jenkins-bot: Basic tests for getClientRects in ve.ce.Selection and FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468962 (https://phabricator.wikimedia.org/T207083) (owner: 10Esanders) [17:30:23] (03Merged) 10jenkins-bot: ve.ce.Selection: Add getDirection tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468985 (owner: 10Esanders) [17:31:43] (03CR) 10jenkins-bot: Remove false coverage of TableNode/TableSelection code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468967 (owner: 10Esanders) [17:35:21] (03CR) 10jenkins-bot: Remove setupToolbar from DummyTarget to avoid false code coverage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468984 (owner: 10Esanders) [17:37:32] (03CR) 10jenkins-bot: Basic tests for getClientRects in ve.ce.Selection and FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468962 (https://phabricator.wikimedia.org/T207083) (owner: 10Esanders) [17:38:51] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [17:44:46] (03PS3) 10Divec: KeyDown tests: Remove unnecessary setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468827 (owner: 10Esanders) [17:47:15] (03CR) 10Divec: [C: 032] KeyDown tests: Remove unnecessary setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468827 (owner: 10Esanders) [17:49:14] (03Merged) 10jenkins-bot: KeyDown tests: Remove unnecessary setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468827 (owner: 10Esanders) [17:51:58] (03CR) 10jenkins-bot: KeyDown tests: Remove unnecessary setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468827 (owner: 10Esanders) [17:57:57] (03PS3) 10Divec: KeyDown tests: Un-nest functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468828 (owner: 10Esanders) [17:57:59] (03PS3) 10Divec: KeyDown tests: rename defer -> then [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468829 (owner: 10Esanders) [17:58:01] (03PS3) 10Divec: Allow ES6 in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468834 (owner: 10Esanders) [17:59:53] (03PS2) 10Esanders: Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [18:06:10] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [18:13:08] (03PS3) 10Esanders: Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [18:25:14] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [18:30:51] (03CR) 10Divec: [C: 032] KeyDown tests: Un-nest functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468828 (owner: 10Esanders) [18:31:07] (03CR) 10Divec: [C: 032] KeyDown tests: rename defer -> then [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468829 (owner: 10Esanders) [18:33:37] (03Merged) 10jenkins-bot: KeyDown tests: Un-nest functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468828 (owner: 10Esanders) [18:33:39] (03Merged) 10jenkins-bot: KeyDown tests: rename defer -> then [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468829 (owner: 10Esanders) [18:33:41] (03Merged) 10jenkins-bot: Allow ES6 in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468834 (owner: 10Esanders) [18:35:46] (03CR) 10jenkins-bot: KeyDown tests: Un-nest functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468828 (owner: 10Esanders) [18:37:32] (03CR) 10jenkins-bot: KeyDown tests: rename defer -> then [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468829 (owner: 10Esanders) [18:38:00] (03PS1) 10Divec: ES6 eslint follow-up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469052 [18:39:18] (03CR) 10jenkins-bot: Allow ES6 in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/468834 (owner: 10Esanders) [19:07:14] (03CR) 10Jforrester: [C: 032] ES6 eslint follow-up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469052 (owner: 10Divec) [19:09:09] (03Merged) 10jenkins-bot: ES6 eslint follow-up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469052 (owner: 10Divec) [19:11:09] (03CR) 10jenkins-bot: ES6 eslint follow-up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/469052 (owner: 10Divec) [19:18:48] 10VisualEditor, 10Reading-Infrastructure-Team-Backlog, 10Maps (Kartographer), 10User-Ryasmeen: [Regression pre-wmf.29] Can't add map using VE/NWE, throwing uncaught error in the console - https://phabricator.wikimedia.org/T191476 (10MSantos) 05Open>03Resolved a:03MSantos This seems to be not reproduc... [19:26:08] (03PS4) 10Esanders: Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [19:26:54] 10VisualEditor, 10Reading-Infrastructure-Team-Backlog, 10Maps (Kartographer), 10User-Ryasmeen: [Regression pre-wmf.29] Can't add map using VE/NWE, throwing uncaught error in the console - https://phabricator.wikimedia.org/T191476 (10matmarex) Looks like the issue was fixed in {40d2e6ef}. [19:36:46] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [20:24:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469109 (owner: 10L10n-bot) [21:47:34] 10VisualEditor: The Hebrew Wikipedia "rambi" template is rendered correctly, but is displayed incorrectly when edited in Visual Editor - https://phabricator.wikimedia.org/T207710 (10Amire80) [21:52:25] 10VisualEditor: The Hebrew Wikipedia "rambi" template is rendered correctly, but is displayed incorrectly when edited in Visual Editor - https://phabricator.wikimedia.org/T207710 (10Amire80) [21:59:40] (03PS2) 10Putnik: Lua method for TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) [22:09:34] (03PS3) 10Putnik: Lua method for TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) [22:13:50] (03CR) 10Putnik: "Anomie, thank you very much for the code review. I fixed some of the problems and commented the remaining ones. Please see if everything i" (0310 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) (owner: 10Putnik) [22:15:54] 10VisualEditor, 10VisualEditor-MediaWiki: Make editing sortkeys easier in the Categories dialog by pasting in the article title - https://phabricator.wikimedia.org/T145339 (10matmarex) Rathar than insert a fake name of the article (a "placeholder") into those text fields, we could just use the name of the arti... [22:19:51] 10VisualEditor, 10Need-volunteer, 10goodfirstbug: Buttons don't fit in math formula editing popup - https://phabricator.wikimedia.org/T205830 (10matmarex) You can see the issue on (although depending on your font, the text might actually fit). The label... [22:20:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10Google-Code-in-2018: Make editing sortkeys easier in the Categories dialog by pasting in the article title - https://phabricator.wikimedia.org/T145339 (10matmarex) I would like to mentor this task in #Google-Code-in-2018. [22:20:45] 10VisualEditor, 10Google-Code-in-2018, 10Need-volunteer, 10goodfirstbug: Buttons don't fit in math formula editing popup - https://phabricator.wikimedia.org/T205830 (10matmarex) I would like to mentor this task in #Google-Code-in-2018. [22:21:05] 10VisualEditor, 10Math, 10Google-Code-in-2018, 10Need-volunteer, 10goodfirstbug: Buttons don't fit in math formula editing popup - https://phabricator.wikimedia.org/T205830 (10matmarex) [22:29:27] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [22:37:26] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (b2ece1abc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/469038 (https://phabricator.wikimedia.org/T207077) (owner: 10Jforrester) [22:41:31] (03PS4) 10Putnik: Lua method for TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/468901 (https://phabricator.wikimedia.org/T107119) [22:48:37] 10VisualEditor: In Visual Editor, caption appears vertically to the left of the image in the infobox - https://phabricator.wikimedia.org/T207426 (10matmarex) [22:49:24] 10VisualEditor, 10Browser-Support-Google-Chrome: In Visual Editor, caption appears vertically to the left of the image in the infobox - https://phabricator.wikimedia.org/T207426 (10matmarex) I only see this issue on Chrome.